mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2024-12-08 14:36:32 +01:00
a8254a40e7
* FURTHER paging shenanigans 🥲
* remove cursor logic from ToLinkURL()
* fix up paging tests
---------
Co-authored-by: tobi <tobi.smethurst@protonmail.com>
506 lines
16 KiB
Go
506 lines
16 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package accounts_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/client/accounts"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/oauth"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
"github.com/tomnomnom/linkheader"
|
|
)
|
|
|
|
type FollowTestSuite struct {
|
|
AccountStandardTestSuite
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestFollowSelf() {
|
|
testAcct := suite.testAccounts["local_account_1"]
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := testrig.CreateGinTestContext(recorder, nil)
|
|
ctx.Set(oauth.SessionAuthorizedAccount, testAcct)
|
|
ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(suite.testTokens["local_account_1"]))
|
|
ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"])
|
|
ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"])
|
|
ctx.Request = httptest.NewRequest(http.MethodPost, fmt.Sprintf("http://localhost:8080%s", strings.Replace(accounts.FollowPath, ":id", testAcct.ID, 1)), nil)
|
|
|
|
ctx.Params = gin.Params{
|
|
gin.Param{
|
|
Key: accounts.IDKey,
|
|
Value: testAcct.ID,
|
|
},
|
|
}
|
|
|
|
// call the handler
|
|
suite.accountsModule.AccountFollowPOSTHandler(ctx)
|
|
|
|
// 1. status should be Not Acceptable due to self-follow attempt
|
|
suite.Equal(http.StatusNotAcceptable, recorder.Code)
|
|
|
|
result := recorder.Result()
|
|
defer result.Body.Close()
|
|
|
|
// check the response
|
|
b, err := io.ReadAll(result.Body)
|
|
_ = b
|
|
assert.NoError(suite.T(), err)
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageNewestToOldestLimit2() {
|
|
suite.testGetFollowersPage(2, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageNewestToOldestLimit4() {
|
|
suite.testGetFollowersPage(4, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageNewestToOldestLimit6() {
|
|
suite.testGetFollowersPage(6, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageOldestToNewestLimit2() {
|
|
suite.testGetFollowersPage(2, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageOldestToNewestLimit4() {
|
|
suite.testGetFollowersPage(4, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowersPageOldestToNewestLimit6() {
|
|
suite.testGetFollowersPage(6, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) testGetFollowersPage(limit int, direction string) {
|
|
ctx := context.Background()
|
|
|
|
// The authed local account we are going to use for HTTP requests
|
|
requestingAccount := suite.testAccounts["local_account_1"]
|
|
suite.clearAccountRelations(requestingAccount.ID)
|
|
|
|
// Get current time.
|
|
now := time.Now()
|
|
|
|
var i int
|
|
|
|
// Have each account in the testrig follow the account
|
|
// that is requesting their followers from the API.
|
|
for _, account := range suite.testAccounts {
|
|
targetAccount := requestingAccount
|
|
if account.ID == targetAccount.ID {
|
|
// we cannot be our own target...
|
|
continue
|
|
}
|
|
|
|
// Get next simple ID.
|
|
id := strconv.Itoa(i)
|
|
i++
|
|
|
|
// put a follow in the database
|
|
err := suite.db.PutFollow(ctx, >smodel.Follow{
|
|
ID: id,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
URI: fmt.Sprintf("%s/follow/%s", account.URI, id),
|
|
AccountID: account.ID,
|
|
TargetAccountID: targetAccount.ID,
|
|
})
|
|
suite.NoError(err)
|
|
|
|
// Bump now by 1 second.
|
|
now = now.Add(time.Second)
|
|
}
|
|
|
|
// Get _ALL_ follows we expect to see without any paging (this filters invisible).
|
|
apiRsp, err := suite.processor.Account().FollowersGet(ctx, requestingAccount, requestingAccount.ID, nil)
|
|
suite.NoError(err)
|
|
expectAccounts := apiRsp.Items // interfaced{} account slice
|
|
|
|
// Iteratively set
|
|
// link query string.
|
|
var query string
|
|
|
|
switch direction {
|
|
case "newestToOldest":
|
|
// Set the starting query to page from
|
|
// newest (ie., first entry in slice).
|
|
acc := expectAccounts[0].(*model.Account)
|
|
newest, _ := suite.db.GetFollow(ctx, acc.ID, requestingAccount.ID)
|
|
expectAccounts = expectAccounts[1:]
|
|
query = fmt.Sprintf("limit=%d&max_id=%s", limit, newest.ID)
|
|
|
|
case "oldestToNewest":
|
|
// Set the starting query to page from
|
|
// oldest (ie., last entry in slice).
|
|
acc := expectAccounts[len(expectAccounts)-1].(*model.Account)
|
|
oldest, _ := suite.db.GetFollow(ctx, acc.ID, requestingAccount.ID)
|
|
expectAccounts = expectAccounts[:len(expectAccounts)-1]
|
|
query = fmt.Sprintf("limit=%d&min_id=%s", limit, oldest.ID)
|
|
}
|
|
|
|
for p := 0; ; p++ {
|
|
// Prepare new request for endpoint
|
|
recorder := httptest.NewRecorder()
|
|
endpoint := fmt.Sprintf("/api/v1/accounts/%s/followers", requestingAccount.ID)
|
|
ctx := suite.newContext(recorder, http.MethodGet, []byte{}, endpoint, "")
|
|
ctx.Params = gin.Params{{Key: "id", Value: requestingAccount.ID}}
|
|
ctx.Request.URL.RawQuery = query // setting provided next query value
|
|
|
|
// call the handler and check for valid response code.
|
|
suite.T().Logf("direction=%q page=%d query=%q", direction, p, query)
|
|
suite.accountsModule.AccountFollowersGETHandler(ctx)
|
|
suite.Equal(http.StatusOK, recorder.Code)
|
|
|
|
var accounts []*model.Account
|
|
|
|
// Decode response body into API account models
|
|
result := recorder.Result()
|
|
dec := json.NewDecoder(result.Body)
|
|
err := dec.Decode(&accounts)
|
|
suite.NoError(err)
|
|
_ = result.Body.Close()
|
|
|
|
var (
|
|
|
|
// start provides the starting index for loop in accounts.
|
|
start func([]*model.Account) int
|
|
|
|
// iter performs the loop iter step with index.
|
|
iter func(int) int
|
|
|
|
// check performs the loop conditional check against index and accounts.
|
|
check func(int, []*model.Account) bool
|
|
|
|
// expect pulls the next account to check against from expectAccounts.
|
|
expect func([]interface{}) interface{}
|
|
|
|
// trunc drops the last checked account from expectAccounts.
|
|
trunc func([]interface{}) []interface{}
|
|
)
|
|
|
|
switch direction {
|
|
case "newestToOldest":
|
|
// When paging newest to oldest (ie., first page to last page):
|
|
// - iter from start of received accounts
|
|
// - iterate backward through received accounts
|
|
// - stop when we reach last index of received accounts
|
|
// - compare each received with the first index of expected accounts
|
|
// - after each compare, drop the first index of expected accounts
|
|
start = func([]*model.Account) int { return 0 }
|
|
iter = func(i int) int { return i + 1 }
|
|
check = func(idx int, i []*model.Account) bool { return idx < len(i) }
|
|
expect = func(i []interface{}) interface{} { return i[0] }
|
|
trunc = func(i []interface{}) []interface{} { return i[1:] }
|
|
|
|
case "oldestToNewest":
|
|
// When paging oldest to newest (ie., last page to first page):
|
|
// - iter from end of received accounts
|
|
// - iterate backward through received accounts
|
|
// - stop when we reach first index of received accounts
|
|
// - compare each received with the last index of expected accounts
|
|
// - after each compare, drop the last index of expected accounts
|
|
start = func(i []*model.Account) int { return len(i) - 1 }
|
|
iter = func(i int) int { return i - 1 }
|
|
check = func(idx int, _ []*model.Account) bool { return idx >= 0 }
|
|
expect = func(i []interface{}) interface{} { return i[len(i)-1] }
|
|
trunc = func(i []interface{}) []interface{} { return i[:len(i)-1] }
|
|
}
|
|
|
|
for i := start(accounts); check(i, accounts); i = iter(i) {
|
|
// Get next expected account.
|
|
iface := expect(expectAccounts)
|
|
|
|
// Check that expected account matches received.
|
|
expectAccID := iface.(*model.Account).ID
|
|
receivdAccID := accounts[i].ID
|
|
suite.Equal(expectAccID, receivdAccID, "unexpected account at position in response on page=%d", p)
|
|
|
|
// Drop checked from expected accounts.
|
|
expectAccounts = trunc(expectAccounts)
|
|
}
|
|
|
|
if len(expectAccounts) == 0 {
|
|
// Reached end.
|
|
break
|
|
}
|
|
|
|
// Parse response link header values.
|
|
values := result.Header.Values("Link")
|
|
links := linkheader.ParseMultiple(values)
|
|
|
|
var filteredLinks linkheader.Links
|
|
if direction == "newestToOldest" {
|
|
filteredLinks = links.FilterByRel("next")
|
|
} else {
|
|
filteredLinks = links.FilterByRel("prev")
|
|
}
|
|
|
|
suite.NotEmpty(filteredLinks, "no next link provided with more remaining accounts on page=%d", p)
|
|
|
|
// A ref link header was set.
|
|
link := filteredLinks[0]
|
|
|
|
// Parse URI from URI string.
|
|
uri, err := url.Parse(link.URL)
|
|
suite.NoError(err)
|
|
|
|
// Set next raw query value.
|
|
query = uri.RawQuery
|
|
}
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageNewestToOldestLimit2() {
|
|
suite.testGetFollowingPage(2, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageNewestToOldestLimit4() {
|
|
suite.testGetFollowingPage(4, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageNewestToOldestLimit6() {
|
|
suite.testGetFollowingPage(6, "newestToOldest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageOldestToNewestLimit2() {
|
|
suite.testGetFollowingPage(2, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageOldestToNewestLimit4() {
|
|
suite.testGetFollowingPage(4, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) TestGetFollowingPageOldestToNewestLimit6() {
|
|
suite.testGetFollowingPage(6, "oldestToNewest")
|
|
}
|
|
|
|
func (suite *FollowTestSuite) testGetFollowingPage(limit int, direction string) {
|
|
ctx := context.Background()
|
|
|
|
// The authed local account we are going to use for HTTP requests
|
|
requestingAccount := suite.testAccounts["local_account_1"]
|
|
suite.clearAccountRelations(requestingAccount.ID)
|
|
|
|
// Get current time.
|
|
now := time.Now()
|
|
|
|
var i int
|
|
|
|
// Have the account that is requesting their following
|
|
// list from the API follow each account in the testrig.
|
|
for _, targetAccount := range suite.testAccounts {
|
|
account := requestingAccount
|
|
if targetAccount.ID == account.ID {
|
|
// we cannot be our own target...
|
|
continue
|
|
}
|
|
|
|
// Get next simple ID.
|
|
id := strconv.Itoa(i)
|
|
i++
|
|
|
|
// put a follow in the database
|
|
err := suite.db.PutFollow(ctx, >smodel.Follow{
|
|
ID: id,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
URI: fmt.Sprintf("%s/follow/%s", account.URI, id),
|
|
AccountID: account.ID,
|
|
TargetAccountID: targetAccount.ID,
|
|
})
|
|
suite.NoError(err)
|
|
|
|
// Bump now by 1 second.
|
|
now = now.Add(time.Second)
|
|
}
|
|
|
|
// Get _ALL_ follows we expect to see without any paging (this filters invisible).
|
|
apiRsp, err := suite.processor.Account().FollowingGet(ctx, requestingAccount, requestingAccount.ID, nil)
|
|
suite.NoError(err)
|
|
expectAccounts := apiRsp.Items // interfaced{} account slice
|
|
|
|
// Iteratively set
|
|
// link query string.
|
|
var query string
|
|
|
|
switch direction {
|
|
case "newestToOldest":
|
|
// Set the starting query to page from
|
|
// newest (ie., first entry in slice).
|
|
acc := expectAccounts[0].(*model.Account)
|
|
newest, _ := suite.db.GetFollow(ctx, requestingAccount.ID, acc.ID)
|
|
expectAccounts = expectAccounts[1:]
|
|
query = fmt.Sprintf("limit=%d&max_id=%s", limit, newest.ID)
|
|
|
|
case "oldestToNewest":
|
|
// Set the starting query to page from
|
|
// oldest (ie., last entry in slice).
|
|
acc := expectAccounts[len(expectAccounts)-1].(*model.Account)
|
|
oldest, _ := suite.db.GetFollow(ctx, requestingAccount.ID, acc.ID)
|
|
expectAccounts = expectAccounts[:len(expectAccounts)-1]
|
|
query = fmt.Sprintf("limit=%d&min_id=%s", limit, oldest.ID)
|
|
}
|
|
|
|
for p := 0; ; p++ {
|
|
// Prepare new request for endpoint
|
|
recorder := httptest.NewRecorder()
|
|
endpoint := fmt.Sprintf("/api/v1/accounts/%s/following", requestingAccount.ID)
|
|
ctx := suite.newContext(recorder, http.MethodGet, []byte{}, endpoint, "")
|
|
ctx.Params = gin.Params{{Key: "id", Value: requestingAccount.ID}}
|
|
ctx.Request.URL.RawQuery = query // setting provided next query value
|
|
|
|
// call the handler and check for valid response code.
|
|
suite.T().Logf("direction=%q page=%d query=%q", direction, p, query)
|
|
suite.accountsModule.AccountFollowingGETHandler(ctx)
|
|
suite.Equal(http.StatusOK, recorder.Code)
|
|
|
|
var accounts []*model.Account
|
|
|
|
// Decode response body into API account models
|
|
result := recorder.Result()
|
|
dec := json.NewDecoder(result.Body)
|
|
err := dec.Decode(&accounts)
|
|
suite.NoError(err)
|
|
_ = result.Body.Close()
|
|
|
|
var (
|
|
// start provides the starting index for loop in accounts.
|
|
start func([]*model.Account) int
|
|
|
|
// iter performs the loop iter step with index.
|
|
iter func(int) int
|
|
|
|
// check performs the loop conditional check against index and accounts.
|
|
check func(int, []*model.Account) bool
|
|
|
|
// expect pulls the next account to check against from expectAccounts.
|
|
expect func([]interface{}) interface{}
|
|
|
|
// trunc drops the last checked account from expectAccounts.
|
|
trunc func([]interface{}) []interface{}
|
|
)
|
|
|
|
switch direction {
|
|
case "newestToOldest":
|
|
// When paging newest to oldest (ie., first page to last page):
|
|
// - iter from start of received accounts
|
|
// - iterate backward through received accounts
|
|
// - stop when we reach last index of received accounts
|
|
// - compare each received with the first index of expected accounts
|
|
// - after each compare, drop the first index of expected accounts
|
|
start = func([]*model.Account) int { return 0 }
|
|
iter = func(i int) int { return i + 1 }
|
|
check = func(idx int, i []*model.Account) bool { return idx < len(i) }
|
|
expect = func(i []interface{}) interface{} { return i[0] }
|
|
trunc = func(i []interface{}) []interface{} { return i[1:] }
|
|
|
|
case "oldestToNewest":
|
|
// When paging oldest to newest (ie., last page to first page):
|
|
// - iter from end of received accounts
|
|
// - iterate backward through received accounts
|
|
// - stop when we reach first index of received accounts
|
|
// - compare each received with the last index of expected accounts
|
|
// - after each compare, drop the last index of expected accounts
|
|
start = func(i []*model.Account) int { return len(i) - 1 }
|
|
iter = func(i int) int { return i - 1 }
|
|
check = func(idx int, _ []*model.Account) bool { return idx >= 0 }
|
|
expect = func(i []interface{}) interface{} { return i[len(i)-1] }
|
|
trunc = func(i []interface{}) []interface{} { return i[:len(i)-1] }
|
|
}
|
|
|
|
for i := start(accounts); check(i, accounts); i = iter(i) {
|
|
// Get next expected account.
|
|
iface := expect(expectAccounts)
|
|
|
|
// Check that expected account matches received.
|
|
expectAccID := iface.(*model.Account).ID
|
|
receivdAccID := accounts[i].ID
|
|
suite.Equal(expectAccID, receivdAccID, "unexpected account at position in response on page=%d", p)
|
|
|
|
// Drop checked from expected accounts.
|
|
expectAccounts = trunc(expectAccounts)
|
|
}
|
|
|
|
if len(expectAccounts) == 0 {
|
|
// Reached end.
|
|
break
|
|
}
|
|
|
|
// Parse response link header values.
|
|
values := result.Header.Values("Link")
|
|
links := linkheader.ParseMultiple(values)
|
|
|
|
var filteredLinks linkheader.Links
|
|
if direction == "newestToOldest" {
|
|
filteredLinks = links.FilterByRel("next")
|
|
} else {
|
|
filteredLinks = links.FilterByRel("prev")
|
|
}
|
|
|
|
suite.NotEmpty(filteredLinks, "no next link provided with more remaining accounts on page=%d", p)
|
|
|
|
// A ref link header was set.
|
|
link := filteredLinks[0]
|
|
|
|
// Parse URI from URI string.
|
|
uri, err := url.Parse(link.URL)
|
|
suite.NoError(err)
|
|
|
|
// Set next raw query value.
|
|
query = uri.RawQuery
|
|
}
|
|
}
|
|
|
|
func (suite *FollowTestSuite) clearAccountRelations(id string) {
|
|
// Esnure no account blocks exist between accounts.
|
|
_ = suite.db.DeleteAccountBlocks(
|
|
context.Background(),
|
|
id,
|
|
)
|
|
|
|
// Ensure no account follows exist between accounts.
|
|
_ = suite.db.DeleteAccountFollows(
|
|
context.Background(),
|
|
id,
|
|
)
|
|
|
|
// Ensure no account follow_requests exist between accounts.
|
|
_ = suite.db.DeleteAccountFollowRequests(
|
|
context.Background(),
|
|
id,
|
|
)
|
|
}
|
|
|
|
func TestFollowTestSuite(t *testing.T) {
|
|
suite.Run(t, new(FollowTestSuite))
|
|
}
|