mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2024-12-11 16:20:16 +01:00
33aee1b1e9
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove now unused error type
* return nil when wrapping nil error
* update expected error messages
* return correct url for foss satan webfinger
* add AP model for Some_User
* normalize local domain
* return notretrievable where appropriate
* expose NewErrNotRetrievable
* ensure webfinger for new accounts searched by uri
* update local account short circuit
* allow enrich to fail for already-known accounts
* remove unused LastWebfingeredAt
* expose test maps on mock http client
* update Update test
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove nil error checks (we shouldn't be passing nil errors to newError() initializers)
* remove mutex unlock on transport init fail (it hasn't yet been locked!)
* woops add back the error wrapping to use ErrNotRetrievable
* caches were never being started... 🙈
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
226 lines
7.1 KiB
Go
226 lines
7.1 KiB
Go
/*
|
|
GoToSocial
|
|
Copyright (C) 2021-2023 GoToSocial Authors admin@gotosocial.org
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU Affero General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Affero General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Affero General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
package dereferencing_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/gotosocial/internal/ap"
|
|
"github.com/superseriousbusiness/gotosocial/internal/config"
|
|
"github.com/superseriousbusiness/gotosocial/internal/federation/dereferencing"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
type AccountTestSuite struct {
|
|
DereferencerStandardTestSuite
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceGroup() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
|
|
groupURL := testrig.URLMustParse("https://unknown-instance.com/groups/some_group")
|
|
group, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
groupURL,
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(group)
|
|
|
|
// group values should be set
|
|
suite.Equal("https://unknown-instance.com/groups/some_group", group.URI)
|
|
suite.Equal("https://unknown-instance.com/@some_group", group.URL)
|
|
suite.WithinDuration(time.Now(), group.FetchedAt, 5*time.Second)
|
|
|
|
// group should be in the database
|
|
dbGroup, err := suite.db.GetAccountByURI(context.Background(), group.URI)
|
|
suite.NoError(err)
|
|
suite.Equal(group.ID, dbGroup.ID)
|
|
suite.Equal(ap.ActorGroup, dbGroup.ActorType)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceService() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
|
|
serviceURL := testrig.URLMustParse("https://owncast.example.org/federation/user/rgh")
|
|
service, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
serviceURL,
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(service)
|
|
|
|
// service values should be set
|
|
suite.Equal("https://owncast.example.org/federation/user/rgh", service.URI)
|
|
suite.Equal("https://owncast.example.org/federation/user/rgh", service.URL)
|
|
suite.WithinDuration(time.Now(), service.FetchedAt, 5*time.Second)
|
|
|
|
// service should be in the database
|
|
dbService, err := suite.db.GetAccountByURI(context.Background(), service.URI)
|
|
suite.NoError(err)
|
|
suite.Equal(service.ID, dbService.ID)
|
|
suite.Equal(ap.ActorService, dbService.ActorType)
|
|
suite.Equal("example.org", dbService.Domain)
|
|
}
|
|
|
|
/*
|
|
We shouldn't try webfingering or making http calls to dereference local accounts
|
|
that might be passed into GetRemoteAccount for whatever reason, so these tests are
|
|
here to make sure that such cases are (basically) short-circuit evaluated and given
|
|
back as-is without trying to make any calls to one's own instance.
|
|
*/
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountAsRemoteURL() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
targetAccount := suite.testAccounts["local_account_2"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
testrig.URLMustParse(targetAccount.URI),
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(fetchedAccount)
|
|
suite.Empty(fetchedAccount.Domain)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountAsRemoteURLNoSharedInboxYet() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
targetAccount := suite.testAccounts["local_account_2"]
|
|
|
|
targetAccount.SharedInboxURI = nil
|
|
if err := suite.db.UpdateAccount(context.Background(), targetAccount); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
testrig.URLMustParse(targetAccount.URI),
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(fetchedAccount)
|
|
suite.Empty(fetchedAccount.Domain)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountAsUsername() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
targetAccount := suite.testAccounts["local_account_2"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
testrig.URLMustParse(targetAccount.URI),
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(fetchedAccount)
|
|
suite.Empty(fetchedAccount.Domain)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountAsUsernameDomain() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
targetAccount := suite.testAccounts["local_account_2"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
testrig.URLMustParse(targetAccount.URI),
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(fetchedAccount)
|
|
suite.Empty(fetchedAccount.Domain)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountAsUsernameDomainAndURL() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
targetAccount := suite.testAccounts["local_account_2"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByUsernameDomain(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
targetAccount.Username,
|
|
config.GetHost(),
|
|
false,
|
|
)
|
|
suite.NoError(err)
|
|
suite.NotNil(fetchedAccount)
|
|
suite.Empty(fetchedAccount.Domain)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountWithUnknownUsername() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByUsernameDomain(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
"thisaccountdoesnotexist",
|
|
config.GetHost(),
|
|
false,
|
|
)
|
|
var errNotRetrievable *dereferencing.ErrNotRetrievable
|
|
suite.ErrorAs(err, &errNotRetrievable)
|
|
suite.EqualError(err, "item could not be retrieved: no entries")
|
|
suite.Nil(fetchedAccount)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountWithUnknownUsernameDomain() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByUsernameDomain(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
"thisaccountdoesnotexist",
|
|
"localhost:8080",
|
|
false,
|
|
)
|
|
var errNotRetrievable *dereferencing.ErrNotRetrievable
|
|
suite.ErrorAs(err, &errNotRetrievable)
|
|
suite.EqualError(err, "item could not be retrieved: no entries")
|
|
suite.Nil(fetchedAccount)
|
|
}
|
|
|
|
func (suite *AccountTestSuite) TestDereferenceLocalAccountWithUnknownUserURI() {
|
|
fetchingAccount := suite.testAccounts["local_account_1"]
|
|
|
|
fetchedAccount, err := suite.dereferencer.GetAccountByURI(
|
|
context.Background(),
|
|
fetchingAccount.Username,
|
|
testrig.URLMustParse("http://localhost:8080/users/thisaccountdoesnotexist"),
|
|
false,
|
|
)
|
|
var errNotRetrievable *dereferencing.ErrNotRetrievable
|
|
suite.ErrorAs(err, &errNotRetrievable)
|
|
suite.EqualError(err, "item could not be retrieved: no entries")
|
|
suite.Nil(fetchedAccount)
|
|
}
|
|
|
|
func TestAccountTestSuite(t *testing.T) {
|
|
suite.Run(t, new(AccountTestSuite))
|
|
}
|