mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
89df9f3b21
# Description > If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements. > > If this is a documentation change, please briefly describe what you've changed and why. This pull request fixes an issue where multiple mentions were being created for one statuses, when delivered to multiple inboxes on an instance, but only the final mention ended up actually being used. Also adds tests to make sure that a notification is received when a status is edited to include a mention. ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4127 Co-authored-by: tobi <tobi.smethurst@protonmail.com> Co-committed-by: tobi <tobi.smethurst@protonmail.com>
77 lines
2.2 KiB
Go
77 lines
2.2 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package federatingdb_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/ap"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtscontext"
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type UpdateTestSuite struct {
|
|
FederatingDBTestSuite
|
|
}
|
|
|
|
func (suite *UpdateTestSuite) TestUpdateNewMention() {
|
|
var (
|
|
ctx = context.Background()
|
|
update = suite.testActivities["remote_account_2_status_1_update"]
|
|
receivingAcct = suite.testAccounts["local_account_1"]
|
|
requestingAcct = suite.testAccounts["remote_account_2"]
|
|
)
|
|
|
|
ctx = gtscontext.SetReceivingAccount(ctx, receivingAcct)
|
|
ctx = gtscontext.SetRequestingAccount(ctx, requestingAcct)
|
|
|
|
m, err := ap.Serialize(update.Activity)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
b, err := json.MarshalIndent(&m, "", " ")
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.T().Logf("Update:\n%s\n", string(b))
|
|
|
|
note := update.Activity.GetActivityStreamsObject().At(0).GetActivityStreamsNote()
|
|
if err := suite.federatingDB.Update(ctx, note); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Should be a message heading to the processor.
|
|
msg, ok := suite.getFederatorMsg(5 * time.Second)
|
|
if !ok {
|
|
suite.FailNow("no federator message after 5s")
|
|
}
|
|
|
|
suite.Equal(ap.ObjectNote, msg.APObjectType)
|
|
suite.Equal(ap.ActivityUpdate, msg.APActivityType)
|
|
suite.NotNil(msg.APObject)
|
|
}
|
|
|
|
func TestUpdateTestSuite(t *testing.T) {
|
|
suite.Run(t, new(UpdateTestSuite))
|
|
}
|