Files
GoToSocial/internal/federation/federatingdb/get.go
tobi 1bad36b637 [bugfix] Fix wrong URI used in dereferenceLocal (#4097)
# Description

> If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.
>
> If this is a documentation change, please briefly describe what you've changed and why.

Previously we were passing a *followers* URI into the federatingDB `Followers` function, which expects an *account* URI. This led to a nil body when doing internal dereferences (ie., while sending out messages). I think I probably wrote this bug when I refactored stuff a while ago.

This PR fixes that up by making the dereferenceLocal function more consistent, and falling back to an http dereference if nothing found. Clarifies behavior of the federatingdb.Get function as well, by commenting the shit out of it.

Also adds tests, precious tests.

Closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4066

## Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]`

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

- [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md).
- [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
- [x] I/we have not leveraged AI to create the proposed changes.
- [x] I/we have performed a self-review of added code.
- [x] I/we have written code that is legible and maintainable by others.
- [x] I/we have commented the added code, particularly in hard-to-understand areas.
- [x] I/we have made any necessary changes to documentation.
- [x] I/we have added tests that cover new code.
- [x] I/we have run tests and they pass locally with the changes.
- [x] I/we have run `go fmt ./...` and `golangci-lint run`.

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4097
Co-authored-by: tobi <tobi.smethurst@protonmail.com>
Co-committed-by: tobi <tobi.smethurst@protonmail.com>
2025-04-30 18:19:01 +00:00

110 lines
3.7 KiB
Go

// GoToSocial
// Copyright (C) GoToSocial Authors admin@gotosocial.org
// SPDX-License-Identifier: AGPL-3.0-or-later
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package federatingdb
import (
"context"
"net/url"
"code.superseriousbusiness.org/activity/streams/vocab"
"code.superseriousbusiness.org/gotosocial/internal/config"
"code.superseriousbusiness.org/gotosocial/internal/db"
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
"code.superseriousbusiness.org/gotosocial/internal/log"
"code.superseriousbusiness.org/gotosocial/internal/uris"
)
// Get returns the database entry for the specified id.
//
// The library makes this call only after acquiring a lock first.
//
// Implementation notes: in GoToSocial this function should *only*
// be used for internal dereference calls. Everything coming from the
// outside goes via the handlers defined in internal/api/activitypub.
//
// Normally with go-fed this function would get used in lots of
// places for the side effect callback handlers, but since we override
// everything and handle side effects ourselves, the only two places
// this function actually ends up getting called are:
//
// - vendor/code.superseriousbusiness.org/activity/pub/side_effect_actor.go
// to get outbox actor inside the prepare function.
// - internal/transport/controller.go to try to shortcut deref a local item.
//
// It may be useful in future to add more matching here so that more
// stuff can be shortcutted by the dereferencer, saving HTTP calls.
func (f *federatingDB) Get(ctx context.Context, id *url.URL) (value vocab.Type, err error) {
log.DebugKV(ctx, "id", id)
// Ensure our host, for safety.
if id.Host != config.GetHost() {
return nil, gtserror.Newf("%s was not for our host", id.String())
}
if username, err := uris.ParseUserPath(id); err == nil && username != "" {
acct, err := f.state.DB.GetAccountByUsernameDomain(ctx, username, "")
if err != nil {
return nil, err
}
return f.converter.AccountToAS(ctx, acct)
} else if _, statusID, err := uris.ParseStatusesPath(id); err == nil && statusID != "" {
status, err := f.state.DB.GetStatusByID(ctx, statusID)
if err != nil {
return nil, err
}
return f.converter.StatusToAS(ctx, status)
} else if username, err := uris.ParseFollowersPath(id); err == nil && username != "" {
acct, err := f.state.DB.GetAccountByUsernameDomain(ctx, username, "")
if err != nil {
return nil, err
}
acctURI, err := url.Parse(acct.URI)
if err != nil {
return nil, err
}
return f.Followers(ctx, acctURI)
} else if username, err := uris.ParseFollowingPath(id); err == nil && username != "" {
acct, err := f.state.DB.GetAccountByUsernameDomain(ctx, username, "")
if err != nil {
return nil, err
}
acctURI, err := url.Parse(acct.URI)
if err != nil {
return nil, err
}
return f.Following(ctx, acctURI)
} else if uris.IsAcceptsPath(id) {
return f.GetAccept(ctx, id)
}
// Nothing found, the caller
// will have to deal with this.
return nil, gtserror.Newf(
"not implemented for %s: %w",
id.String(), db.ErrNoEntries,
)
}