mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
* start work rewriting timeline cache type
* further work rewriting timeline caching
* more work integration new timeline code
* remove old code
* add local timeline, fix up merge conflicts
* remove old use of go-bytes
* implement new timeline code into more areas of codebase, pull in latest go-mangler, go-mutexes, go-structr
* remove old timeline package, add local timeline cache
* remove references to old timeline types that needed starting up in tests
* start adding page validation
* fix test-identified timeline cache package issues
* fix up more tests, fix missing required changes, etc
* add exclusion for test.out in gitignore
* clarify some things better in code comments
* tweak cache size limits
* fix list timeline cache fetching
* further list timeline fixes
* linter, ssssssssshhhhhhhhhhhh please
* fix linter hints
* reslice the output if it's beyond length of 'lim'
* remove old timeline initialization code, bump go-structr to v0.9.4
* continued from previous commit
* improved code comments
* don't allow multiple entries for BoostOfID values to prevent repeated boosts of same boosts
* finish writing more code comments
* some variable renaming, for ease of following
* change the way we update lo,hi paging values during timeline load
* improved code comments for updated / returned lo , hi paging values
* finish writing code comments for the StatusTimeline{} type itself
* fill in more code comments
* update go-structr version to latest with changed timeline unique indexing logic
* have a local and public timeline *per user*
* rewrite calls to public / local timeline calls
* remove the zero length check, as lo, hi values might still be set
* simplify timeline cache loading, fix lo/hi returns, fix timeline invalidation side-effects missing for some federated actions
* swap the lo, hi values 🤦
* add (now) missing slice reverse of tag timeline statuses when paging ASC
* remove local / public caches (is out of scope for this work), share more timeline code
* remove unnecessary change
* again, remove more unused code
* remove unused function to appease the linter
* move boost checking to prepare function
* fix use of timeline.lastOrder, fix incorrect range functions used
* remove comments for repeat code
* remove the boost logic from prepare function
* do a maximum of 5 loads, not 10
* add repeat boost filtering logic, update go-structr, general improvements
* more code comments
* add important note
* fix timeline tests now that timelines are returned in page order
* remove unused field
* add StatusTimeline{} tests
* add more status timeline tests
* start adding preloading support
* ensure repeat boosts are marked in preloaded entries
* share a bunch of the database load code in timeline cache, don't clear timelines on relationship change
* add logic to allow dynamic clear / preloading of timelines
* comment-out unused functions, but leave in place as we might end-up using them
* fix timeline preload state check
* much improved status timeline code comments
* more code comments, don't bother inserting statuses if timeline not preloaded
* shift around some logic to make sure things aren't accidentally left set
* finish writing code comments
* remove trim-after-insert behaviour
* fix-up some comments referring to old logic
* remove unsetting of lo, hi
* fix preload repeatBoost checking logic
* don't return on status filter errors, these are usually transient
* better concurrency safety in Clear() and Done()
* fix test broken due to addition of preloader
* fix repeatBoost logic that doesn't account for already-hidden repeatBoosts
* ensure edit submodels are dropped on cache insertion
* update code-comment to expand CAS accronym
* use a plus1hULID() instead of 24h
* remove unused functions
* add note that public / local timeline requester can be nil
* fix incorrect visibility filtering of tag timeline statuses
* ensure we filter home timeline statuses on local only
* some small re-orderings to confirm query params in correct places
* fix the local only home timeline filter func
317 lines
9.1 KiB
Go
317 lines
9.1 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package common
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/federation/dereferencing"
|
|
statusfilter "github.com/superseriousbusiness/gotosocial/internal/filter/status"
|
|
"github.com/superseriousbusiness/gotosocial/internal/filter/usermute"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
)
|
|
|
|
// GetOwnStatus fetches the given status with ID,
|
|
// and ensures that it belongs to given requester.
|
|
func (p *Processor) GetOwnStatus(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
targetID string,
|
|
) (
|
|
*gtsmodel.Status,
|
|
gtserror.WithCode,
|
|
) {
|
|
target, err := p.state.DB.GetStatusByID(ctx, targetID)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
err := gtserror.Newf("error getting from db: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
switch {
|
|
case target == nil:
|
|
const text = "target status not found"
|
|
return nil, gtserror.NewErrorNotFound(
|
|
errors.New(text),
|
|
text,
|
|
)
|
|
|
|
case target.AccountID != requester.ID:
|
|
return nil, gtserror.NewErrorNotFound(
|
|
errors.New("status does not belong to requester"),
|
|
"target status not found",
|
|
)
|
|
}
|
|
|
|
return target, nil
|
|
}
|
|
|
|
// GetTargetStatusBy fetches the target status with db load
|
|
// function, given the authorized (or, nil) requester's
|
|
// account. This returns an approprate gtserror.WithCode
|
|
// accounting for not found and visibility to requester.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetTargetStatusBy(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
getTargetFromDB func() (*gtsmodel.Status, error),
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
visible bool,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
// Fetch the target status from db.
|
|
target, err := getTargetFromDB()
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
err := gtserror.Newf("error getting from db: %w", err)
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
if target == nil {
|
|
// DB loader could not find status in database.
|
|
const text = "target status not found"
|
|
return nil, false, gtserror.NewErrorNotFound(
|
|
errors.New(text),
|
|
text,
|
|
)
|
|
}
|
|
|
|
// Check whether target status is visible to requesting account.
|
|
visible, err = p.visFilter.StatusVisible(ctx, requester, target)
|
|
if err != nil {
|
|
err := gtserror.Newf("error checking visibility: %w", err)
|
|
return nil, false, gtserror.NewErrorInternalError(err)
|
|
}
|
|
|
|
if requester != nil && visible {
|
|
// Only refresh status if visible to requester,
|
|
// and there is *authorized* requester to prevent
|
|
// a possible DOS vector for unauthorized clients.
|
|
latest, _, err := p.federator.RefreshStatus(ctx,
|
|
requester.Username,
|
|
target,
|
|
nil,
|
|
window,
|
|
)
|
|
if err != nil {
|
|
log.Errorf(ctx, "error refreshing target %s: %v", target.URI, err)
|
|
return target, visible, nil
|
|
}
|
|
|
|
// Set latest.
|
|
target = latest
|
|
}
|
|
|
|
return target, visible, nil
|
|
}
|
|
|
|
// GetVisibleTargetStatus calls GetTargetStatusBy(),
|
|
// but converts a non-visible result to not-found error.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetVisibleTargetStatusBy(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
getTargetFromDB func() (*gtsmodel.Status, error),
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
// Fetch the target status by ID from the database.
|
|
target, visible, errWithCode := p.GetTargetStatusBy(ctx,
|
|
requester,
|
|
getTargetFromDB,
|
|
window,
|
|
)
|
|
if errWithCode != nil {
|
|
return nil, errWithCode
|
|
}
|
|
|
|
if !visible {
|
|
// Target should not be seen by requester.
|
|
const text = "target status not found"
|
|
return nil, gtserror.NewErrorNotFound(
|
|
errors.New(text),
|
|
text,
|
|
)
|
|
}
|
|
|
|
return target, nil
|
|
}
|
|
|
|
// GetVisibleTargetStatus calls GetVisibleTargetStatusBy(),
|
|
// passing in a database function that fetches by status ID.
|
|
//
|
|
// window can be used to force refresh of the target if it's
|
|
// deemed to be stale. Falls back to default window if nil.
|
|
func (p *Processor) GetVisibleTargetStatus(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
targetID string,
|
|
window *dereferencing.FreshnessWindow,
|
|
) (
|
|
status *gtsmodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
return p.GetVisibleTargetStatusBy(ctx, requester, func() (*gtsmodel.Status, error) {
|
|
return p.state.DB.GetStatusByID(ctx, targetID)
|
|
}, window)
|
|
}
|
|
|
|
// UnwrapIfBoost "unwraps" the given status if
|
|
// it's a boost wrapper, by returning the boosted
|
|
// status it targets (pending visibility checks).
|
|
//
|
|
// Just returns the input status if it's not a boost.
|
|
func (p *Processor) UnwrapIfBoost(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
status *gtsmodel.Status,
|
|
) (*gtsmodel.Status, gtserror.WithCode) {
|
|
if status.BoostOfID == "" {
|
|
return status, nil
|
|
}
|
|
return p.GetVisibleTargetStatus(ctx,
|
|
requester,
|
|
status.BoostOfID,
|
|
nil,
|
|
)
|
|
}
|
|
|
|
// GetAPIStatus fetches the appropriate API status model for target.
|
|
func (p *Processor) GetAPIStatus(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
target *gtsmodel.Status,
|
|
) (
|
|
apiStatus *apimodel.Status,
|
|
errWithCode gtserror.WithCode,
|
|
) {
|
|
apiStatus, err := p.converter.StatusToAPIStatus(ctx,
|
|
target,
|
|
requester,
|
|
statusfilter.FilterContextNone,
|
|
nil,
|
|
nil,
|
|
)
|
|
if err != nil {
|
|
err := gtserror.Newf("error converting: %w", err)
|
|
return nil, gtserror.NewErrorInternalError(err)
|
|
}
|
|
return apiStatus, nil
|
|
}
|
|
|
|
// GetVisibleAPIStatuses converts a slice of statuses to API
|
|
// model statuses, filtering according to visibility to requester
|
|
// along with given filter context, filters and user mutes.
|
|
//
|
|
// Please note that all errors will be logged at ERROR level,
|
|
// but will not be returned. Callers are likely to run into
|
|
// show-stopping errors in the lead-up to this function.
|
|
func (p *Processor) GetVisibleAPIStatuses(
|
|
ctx context.Context,
|
|
requester *gtsmodel.Account,
|
|
statuses []*gtsmodel.Status,
|
|
filterContext statusfilter.FilterContext,
|
|
filters []*gtsmodel.Filter,
|
|
userMutes []*gtsmodel.UserMute,
|
|
) []apimodel.Status {
|
|
|
|
// Start new log entry with
|
|
// the calling function name
|
|
// as a field in each entry.
|
|
l := log.WithContext(ctx).
|
|
WithField("caller", log.Caller(3))
|
|
|
|
// Compile mutes to useable user mutes for type converter.
|
|
compUserMutes := usermute.NewCompiledUserMuteList(userMutes)
|
|
|
|
// Iterate filtered statuses for conversion to API model.
|
|
apiStatuses := make([]apimodel.Status, 0, len(statuses))
|
|
for _, status := range statuses {
|
|
|
|
// Check whether status is visible to requester.
|
|
visible, err := p.visFilter.StatusVisible(ctx,
|
|
requester,
|
|
status,
|
|
)
|
|
if err != nil {
|
|
l.Errorf("error checking visibility: %v", err)
|
|
continue
|
|
}
|
|
|
|
if !visible {
|
|
continue
|
|
}
|
|
|
|
// Convert to API status, taking mute / filter into account.
|
|
apiStatus, err := p.converter.StatusToAPIStatus(ctx,
|
|
status,
|
|
requester,
|
|
filterContext,
|
|
filters,
|
|
compUserMutes,
|
|
)
|
|
if err != nil && !errors.Is(err, statusfilter.ErrHideStatus) {
|
|
l.Errorf("error converting: %v", err)
|
|
continue
|
|
}
|
|
|
|
if apiStatus == nil {
|
|
// Status was
|
|
// filtered out.
|
|
continue
|
|
}
|
|
|
|
// Append converted status to return slice.
|
|
apiStatuses = append(apiStatuses, *apiStatus)
|
|
}
|
|
|
|
return apiStatuses
|
|
}
|
|
|
|
// InvalidateTimelinedStatus is a shortcut function for invalidating the cached
|
|
// representation one status in the home timeline and all list timelines of the
|
|
// given accountID. It should only be called in cases where a status update
|
|
// does *not* need to be passed into the processor via the worker queue, since
|
|
// such invalidation will, in that case, be handled by the processor instead.
|
|
func (p *Processor) InvalidateTimelinedStatus(ctx context.Context, accountID string, statusID string) error {
|
|
// Get lists first + bail if this fails.
|
|
lists, err := p.state.DB.GetListsByAccountID(ctx, accountID)
|
|
if err != nil {
|
|
return gtserror.Newf("db error getting lists for account %s: %w", accountID, err)
|
|
}
|
|
|
|
// Unprepare item from home + list timelines.
|
|
p.state.Caches.Timelines.Home.MustGet(accountID).UnprepareByStatusIDs(statusID)
|
|
for _, list := range lists {
|
|
p.state.Caches.Timelines.List.MustGet(list.ID).UnprepareByStatusIDs(statusID)
|
|
}
|
|
|
|
return nil
|
|
}
|