mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
3cff4b2d7d
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
91 lines
2.8 KiB
Go
91 lines
2.8 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package transport
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
apiutil "code.superseriousbusiness.org/gotosocial/internal/api/util"
|
|
"code.superseriousbusiness.org/gotosocial/internal/config"
|
|
"code.superseriousbusiness.org/gotosocial/internal/federation/federatingdb"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
|
|
"code.superseriousbusiness.org/gotosocial/internal/log"
|
|
)
|
|
|
|
func (t *transport) Dereference(ctx context.Context, iri *url.URL) (*http.Response, error) {
|
|
// If the request is to us, we can try to shortcut
|
|
// rather than going through the normal request flow.
|
|
//
|
|
// Only bail on a real error, otherwise continue
|
|
// to just make a normal http request to ourself.
|
|
if iri.Host == config.GetHost() {
|
|
rsp, err := t.controller.dereferenceLocal(ctx, iri)
|
|
if err != nil && !errors.Is(err, federatingdb.ErrNotImplemented) {
|
|
return nil, gtserror.Newf("error dereferencing local: %w", err)
|
|
}
|
|
|
|
if rsp != nil {
|
|
// Got something!
|
|
//
|
|
// No need for
|
|
// further business.
|
|
return rsp, nil
|
|
}
|
|
|
|
// Blast out a cheeky warning so we can keep track of this.
|
|
log.Warnf(ctx, "about to perform request to self: GET %s", iri)
|
|
}
|
|
|
|
// Build IRI just once
|
|
iriStr := iri.String()
|
|
|
|
// Prepare new HTTP request to endpoint
|
|
req, err := http.NewRequestWithContext(ctx, "GET", iriStr, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
req.Header.Add("Accept", string(apiutil.AppActivityLDJSON)+","+string(apiutil.AppActivityJSON))
|
|
req.Header.Add("Accept-Charset", "utf-8")
|
|
|
|
// Perform the HTTP request
|
|
rsp, err := t.GET(req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Ensure a non-error status response.
|
|
if rsp.StatusCode != http.StatusOK {
|
|
err := gtserror.NewFromResponse(rsp)
|
|
_ = rsp.Body.Close() // done with body
|
|
return nil, err
|
|
}
|
|
|
|
// Ensure that the incoming request content-type is expected.
|
|
if ct := rsp.Header.Get("Content-Type"); !apiutil.ASContentType(ct) {
|
|
err := gtserror.Newf("non activity streams response: %s", ct)
|
|
_ = rsp.Body.Close() // done with body
|
|
return nil, gtserror.SetMalformed(err)
|
|
}
|
|
|
|
return rsp, nil
|
|
}
|