mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
3cff4b2d7d
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
60 lines
2.3 KiB
Go
60 lines
2.3 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package federatingdb
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
|
|
"code.superseriousbusiness.org/activity/streams"
|
|
"code.superseriousbusiness.org/activity/streams/vocab"
|
|
)
|
|
|
|
// GetOutbox returns the first ordered collection page of the outbox
|
|
// at the specified IRI, for prepending new items.
|
|
//
|
|
// The library makes this call only after acquiring a lock first.
|
|
//
|
|
// Implementation note: we don't (yet) serve outboxes, so just return empty and nil here.
|
|
func (f *DB) GetOutbox(ctx context.Context, outboxIRI *url.URL) (inbox vocab.ActivityStreamsOrderedCollectionPage, err error) {
|
|
return streams.NewActivityStreamsOrderedCollectionPage(), nil
|
|
}
|
|
|
|
// SetOutbox saves the outbox value given from GetOutbox, with new items
|
|
// prepended. Note that the new items must not be added as independent
|
|
// database entries. Separate calls to Create will do that.
|
|
//
|
|
// The library makes this call only after acquiring a lock first.
|
|
//
|
|
// Implementation note: we don't allow outbox setting so just return nil here.
|
|
func (f *DB) SetOutbox(ctx context.Context, outbox vocab.ActivityStreamsOrderedCollectionPage) error {
|
|
return nil
|
|
}
|
|
|
|
// OutboxForInbox fetches the corresponding local actor's outbox IRI for the
|
|
// actor's inbox IRI.
|
|
//
|
|
// The library makes this call only after acquiring a lock first.
|
|
func (f *DB) OutboxForInbox(ctx context.Context, inboxIRI *url.URL) (outboxIRI *url.URL, err error) {
|
|
acct, err := f.state.DB.GetOneAccountByInboxURI(ctx, inboxIRI.String())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return url.Parse(acct.OutboxURI)
|
|
}
|