mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
3cff4b2d7d
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
92 lines
3.0 KiB
Go
92 lines
3.0 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package federatingdb
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
|
|
"code.superseriousbusiness.org/activity/streams/vocab"
|
|
"code.superseriousbusiness.org/gotosocial/internal/ap"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
|
|
"code.superseriousbusiness.org/gotosocial/internal/id"
|
|
"code.superseriousbusiness.org/gotosocial/internal/log"
|
|
"code.superseriousbusiness.org/gotosocial/internal/messages"
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func (f *DB) Flag(ctx context.Context, flaggable vocab.ActivityStreamsFlag) error {
|
|
log.DebugKV(ctx, "flag", serialize{flaggable})
|
|
|
|
// Mark activity as handled.
|
|
f.storeActivityID(flaggable)
|
|
|
|
// Extract relevant values from passed ctx.
|
|
activityContext := getActivityContext(ctx)
|
|
if activityContext.internal {
|
|
return nil // Already processed.
|
|
}
|
|
|
|
requesting := activityContext.requestingAcct
|
|
receiving := activityContext.receivingAcct
|
|
|
|
// Convert received AS flag type to internal report model.
|
|
report, err := f.converter.ASFlagToReport(ctx, flaggable)
|
|
if err != nil {
|
|
err := gtserror.Newf("error converting from AS type: %w", err)
|
|
return gtserror.WrapWithCode(http.StatusBadRequest, err)
|
|
}
|
|
|
|
// Requesting acc's domain must be at
|
|
// least a subdomain of the reporting
|
|
// account. i.e. if they're using a
|
|
// different account domain to host.
|
|
if dns.CompareDomainName(
|
|
requesting.Domain,
|
|
report.Account.Domain,
|
|
) < 2 {
|
|
return gtserror.NewfWithCode(http.StatusForbidden, "requester %s does not share a domain with Flag Actor account %s",
|
|
requesting.URI, report.Account.URI)
|
|
}
|
|
|
|
// Ensure report received by correct account.
|
|
if report.TargetAccountID != receiving.ID {
|
|
return gtserror.NewfWithCode(http.StatusForbidden, "receiver %s is not expected object %s",
|
|
receiving.URI, report.TargetAccount.URI)
|
|
}
|
|
|
|
// Generate new ID for report.
|
|
report.ID = id.NewULID()
|
|
|
|
// Insert the new validated reported into the database.
|
|
if err := f.state.DB.PutReport(ctx, report); err != nil {
|
|
return gtserror.Newf("error inserting %s into db: %w", report.URI, err)
|
|
}
|
|
|
|
// Push message to worker queue to handle report side-effects.
|
|
f.state.Workers.Federator.Queue.Push(&messages.FromFediAPI{
|
|
APObjectType: ap.ActivityFlag,
|
|
APActivityType: ap.ActivityCreate,
|
|
GTSModel: report,
|
|
Receiving: receiving,
|
|
Requesting: requesting,
|
|
})
|
|
|
|
return nil
|
|
}
|