mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2025-06-05 21:59:39 +02:00
3cff4b2d7d
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
100 lines
3.5 KiB
Go
100 lines
3.5 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package federatingdb_test
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/admin"
|
|
"code.superseriousbusiness.org/gotosocial/internal/db"
|
|
"code.superseriousbusiness.org/gotosocial/internal/federation/federatingdb"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtscontext"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
|
|
"code.superseriousbusiness.org/gotosocial/internal/messages"
|
|
"code.superseriousbusiness.org/gotosocial/internal/state"
|
|
"code.superseriousbusiness.org/gotosocial/internal/typeutils"
|
|
"code.superseriousbusiness.org/gotosocial/testrig"
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type FederatingDBTestSuite struct {
|
|
suite.Suite
|
|
db db.DB
|
|
tc *typeutils.Converter
|
|
federatingDB *federatingdb.DB
|
|
state state.State
|
|
|
|
testTokens map[string]*gtsmodel.Token
|
|
testApplications map[string]*gtsmodel.Application
|
|
testUsers map[string]*gtsmodel.User
|
|
testAccounts map[string]*gtsmodel.Account
|
|
testAttachments map[string]*gtsmodel.MediaAttachment
|
|
testStatuses map[string]*gtsmodel.Status
|
|
testBlocks map[string]*gtsmodel.Block
|
|
testActivities map[string]testrig.ActivityWithSignature
|
|
}
|
|
|
|
func (suite *FederatingDBTestSuite) getFederatorMsg(timeout time.Duration) (*messages.FromFediAPI, bool) {
|
|
ctx := context.Background()
|
|
ctx, cncl := context.WithTimeout(ctx, timeout)
|
|
defer cncl()
|
|
return suite.state.Workers.Federator.Queue.PopCtx(ctx)
|
|
}
|
|
|
|
func (suite *FederatingDBTestSuite) SetupSuite() {
|
|
suite.testTokens = testrig.NewTestTokens()
|
|
suite.testApplications = testrig.NewTestApplications()
|
|
suite.testUsers = testrig.NewTestUsers()
|
|
suite.testAccounts = testrig.NewTestAccounts()
|
|
suite.testAttachments = testrig.NewTestAttachments()
|
|
suite.testStatuses = testrig.NewTestStatuses()
|
|
suite.testBlocks = testrig.NewTestBlocks()
|
|
}
|
|
|
|
func (suite *FederatingDBTestSuite) SetupTest() {
|
|
testrig.InitTestConfig()
|
|
testrig.InitTestLog()
|
|
|
|
suite.state.Caches.Init()
|
|
testrig.StartNoopWorkers(&suite.state)
|
|
|
|
suite.db = testrig.NewTestDB(&suite.state)
|
|
|
|
suite.testActivities = testrig.NewTestActivities(suite.testAccounts)
|
|
suite.tc = typeutils.NewConverter(&suite.state)
|
|
|
|
suite.federatingDB = testrig.NewTestFederatingDB(&suite.state)
|
|
testrig.StandardDBSetup(suite.db, suite.testAccounts)
|
|
|
|
suite.state.DB = suite.db
|
|
suite.state.AdminActions = admin.New(suite.state.DB, &suite.state.Workers)
|
|
}
|
|
|
|
func (suite *FederatingDBTestSuite) TearDownTest() {
|
|
testrig.StandardDBTeardown(suite.db)
|
|
testrig.StopWorkers(&suite.state)
|
|
}
|
|
|
|
func createTestContext(receivingAccount *gtsmodel.Account, requestingAccount *gtsmodel.Account) context.Context {
|
|
ctx := context.Background()
|
|
ctx = gtscontext.SetReceivingAccount(ctx, receivingAccount)
|
|
ctx = gtscontext.SetRequestingAccount(ctx, requestingAccount)
|
|
return ctx
|
|
}
|