SuperSeriousBusiness
/
GoToSocial
mirror of https://github.com/superseriousbusiness/gotosocial
1
1
Fork 0
Code Issues Projects Releases Wiki Activity

[chore] Change time comparison in webfinger test (#1798) 

Every now and then the TestFingerWithHostMetaCacheStrategy would fail on
a time related error. I suspect suite.Equal doesn't quite work as
expected when given two time.Time's, so instead explicitly check with
the time.Equal.
This commit is contained in:
Daenney 2023-05-16 15:09:29 +02:00 committed by GitHub
parent e91cabb704
commit c7702c47bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/transport/finger_test.go
View File

@ -87,9 +87,12 @@ func (suite *FingerTestSuite) TestFingerWithHostMetaCacheStrategy() {
// the TTL of the entry should have extended because we did a second // the TTL of the entry should have extended because we did a second
// successful finger // successful finger
suite.NotEqual(initialTime, repeatTime, "expected webfinger cache entry to have different expiry times") if repeatTime.Equal(initialTime) {
suite.FailNowf("expected webfinger cache entry to have different expiry times", "initial: '%s', repeat: '%s'", initialTime, repeatTime)
}
if repeatTime.Before(initialTime) { if repeatTime.Before(initialTime) {
suite.FailNow("expected webfinger cache entry to not be a time traveller") suite.FailNowf("expected webfinger cache entry to not be a time traveller", "initial: '%s', repeat: '%s'", initialTime, repeatTime)
} }
// finger a non-existing user on that same instance which will return an error // finger a non-existing user on that same instance which will return an error