SuperSeriousBusiness/GoToSocial
1
1
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial synced 2025-06-05 21:59:39 +02:00
Code Issues Projects Releases Wiki Activity

[chore] Admin CLI + new account creation refactoring (#2008)

Browse Source 
* set maxPasswordLength to 72 bytes, rename validate function

* refactor NewSignup

* refactor admin account CLI commands

* refactor oidc create user

* refactor processor create

* tweak password change, check old != new password
This commit is contained in:
tobi
2023-07-23 12:33:17 +02:00
committed by GitHub
parent f8f0312042
commit 5a29a031ad
11 changed files with 373 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/validate/formvalidation.go
View File

@@ -46,9 +46,9 @@ const (
maximumListTitleLength = 200
)
// NewPassword returns a helpful error if the given password
// Password returns a helpful error if the given password
// is too short, too long, or not sufficiently strong.
func NewPassword(password string) error {
func Password(password string) error {
// Ensure length is OK first.
if pwLen := len(password); pwLen == 0 {
return errors.New("no password provided / provided password was 0 bytes")

16
internal/validate/formvalidation_test.go
View File

@@ -43,42 +43,42 @@ func (suite *ValidationTestSuite) TestCheckPasswordStrength() {
strongPassword := "3dX5@Zc%mV*W2MBNEy$@"
var err error
err = validate.NewPassword(empty)
err = validate.Password(empty)
if suite.Error(err) {
suite.Equal(errors.New("no password provided / provided password was 0 bytes"), err)
}
err = validate.NewPassword(terriblePassword)
err = validate.Password(terriblePassword)
if suite.Error(err) {
suite.Equal(errors.New("password is only 62% strength, try including more special characters, using uppercase letters, using numbers or using a longer password"), err)
}
err = validate.NewPassword(weakPassword)
err = validate.Password(weakPassword)
if suite.Error(err) {
suite.Equal(errors.New("password is only 95% strength, try including more special characters, using numbers or using a longer password"), err)
}
err = validate.NewPassword(shortPassword)
err = validate.Password(shortPassword)
if suite.Error(err) {
suite.Equal(errors.New("password is only 39% strength, try including more special characters or using a longer password"), err)
}
err = validate.NewPassword(specialPassword)
err = validate.Password(specialPassword)
if suite.Error(err) {
suite.Equal(errors.New("password is only 53% strength, try including more special characters or using a longer password"), err)
}
err = validate.NewPassword(longPassword)
err = validate.Password(longPassword)
if suite.NoError(err) {
suite.Equal(nil, err)
}
err = validate.NewPassword(tooLong)
err = validate.Password(tooLong)
if suite.Error(err) {
suite.Equal(errors.New("password should be no more than 72 bytes, provided password was 571 bytes"), err)
}
err = validate.NewPassword(strongPassword)
err = validate.Password(strongPassword)
if suite.NoError(err) {
suite.Equal(nil, err)
}