SuperSeriousBusiness/GoToSocial
1
1
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial synced 2025-06-05 21:59:39 +02:00
Code Issues Projects Releases Wiki Activity

[bugfix] process account delete side effects in serial, not in parallel (#2360)

Browse Source 
* [bugfix] process account delete side effects in serial, not in parallel

* StartWorkers / StartNoopWorkers for tests

* undo testrig trace logging

* log errors instead of immediately returning
This commit is contained in:
tobi
2023-11-14 15:57:25 +01:00
committed by GitHub
parent 0b99f14d64
commit 4ee436e98a
41 changed files with 181 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/api/activitypub/emoji/emojiget_test.go
View File

@@ -66,7 +66,7 @@ func (suite *EmojiGetTestSuite) SetupSuite() {
func (suite *EmojiGetTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

4
internal/api/activitypub/users/user_test.go
View File

@@ -78,7 +78,6 @@ func (suite *UserStandardTestSuite) SetupSuite() {
func (suite *UserStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()
@@ -98,7 +97,10 @@ func (suite *UserStandardTestSuite) SetupTest() {
suite.mediaManager = testrig.NewTestMediaManager(&suite.state)
suite.federator = testrig.NewTestFederator(&suite.state, testrig.NewTestTransportController(&suite.state, testrig.NewMockHTTPClient(nil, "../../../../testrig/media")), suite.mediaManager)
suite.emailSender = testrig.NewEmailSender("../../../../web/template/", nil)
suite.processor = testrig.NewTestProcessor(&suite.state, suite.federator, suite.emailSender, suite.mediaManager)
testrig.StartWorkers(&suite.state, suite.processor.Workers())
suite.userModule = users.New(suite.processor)
testrig.StandardDBSetup(suite.db, suite.testAccounts)
testrig.StandardStorageSetup(suite.storage, "../../../../testrig/media")

2
internal/api/auth/auth_test.go
View File

@@ -93,7 +93,7 @@ func (suite *AuthStandardTestSuite) SetupTest() {
suite.authModule = auth.New(suite.db, suite.processor, suite.idp)
testrig.StandardDBSetup(suite.db, suite.testAccounts)
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
}
func (suite *AuthStandardTestSuite) TearDownTest() {

2
internal/api/client/accounts/account_test.go
View File

@@ -78,7 +78,7 @@ func (suite *AccountStandardTestSuite) SetupSuite() {
func (suite *AccountStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/admin/admin_test.go
View File

@@ -84,7 +84,7 @@ func (suite *AdminStandardTestSuite) SetupSuite() {
func (suite *AdminStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/bookmarks/bookmarks_test.go
View File

@@ -88,7 +88,7 @@ func (suite *BookmarkTestSuite) SetupSuite() {
func (suite *BookmarkTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/favourites/favourites_test.go
View File

@@ -72,7 +72,7 @@ func (suite *FavouritesStandardTestSuite) SetupSuite() {
func (suite *FavouritesStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/followrequests/followrequest_test.go
View File

@@ -75,7 +75,7 @@ func (suite *FollowRequestStandardTestSuite) SetupSuite() {
func (suite *FollowRequestStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/instance/instance_test.go
View File

@@ -77,7 +77,7 @@ func (suite *InstanceStandardTestSuite) SetupSuite() {
func (suite *InstanceStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/lists/lists_test.go
View File

@@ -76,7 +76,7 @@ func (suite *ListsStandardTestSuite) SetupSuite() {
func (suite *ListsStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
suite.state.Caches.Start()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/media/mediacreate_test.go
View File

@@ -80,7 +80,7 @@ type MediaCreateTestSuite struct {
func (suite *MediaCreateTestSuite) SetupSuite() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
// setup standard items
testrig.InitTestConfig()

2
internal/api/client/media/mediaupdate_test.go
View File

@@ -76,7 +76,7 @@ type MediaUpdateTestSuite struct {
*/
func (suite *MediaUpdateTestSuite) SetupSuite() {
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
// setup standard items
testrig.InitTestConfig()

2
internal/api/client/polls/polls_test.go
View File

@@ -69,7 +69,7 @@ func (suite *PollsStandardTestSuite) SetupSuite() {
func (suite *PollsStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/reports/reports_test.go
View File

@@ -69,7 +69,7 @@ func (suite *ReportsStandardTestSuite) SetupSuite() {
func (suite *ReportsStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/search/search_test.go
View File

@@ -73,7 +73,7 @@ func (suite *SearchStandardTestSuite) SetupSuite() {
func (suite *SearchStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/statuses/status_test.go
View File

@@ -72,7 +72,7 @@ func (suite *StatusStandardTestSuite) SetupSuite() {
func (suite *StatusStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/streaming/streaming_test.go
View File

@@ -84,7 +84,7 @@ func (suite *StreamingTestSuite) SetupSuite() {
func (suite *StreamingTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

2
internal/api/client/user/user_test.go
View File

@@ -57,7 +57,7 @@ type UserStandardTestSuite struct {
func (suite *UserStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()

4
internal/api/fileserver/fileserver_test.go
View File

@@ -65,7 +65,7 @@ type FileserverTestSuite struct {
*/
func (suite *FileserverTestSuite) SetupSuite() {
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestConfig()
testrig.InitTestLog()
@@ -96,7 +96,7 @@ func (suite *FileserverTestSuite) SetupSuite() {
func (suite *FileserverTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.StandardDBSetup(suite.db, nil)
testrig.StandardStorageSetup(suite.storage, "../../../testrig/media")

2
internal/api/wellknown/webfinger/webfinger_test.go
View File

@@ -72,7 +72,7 @@ func (suite *WebfingerStandardTestSuite) SetupSuite() {
func (suite *WebfingerStandardTestSuite) SetupTest() {
suite.state.Caches.Init()
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
testrig.InitTestLog()
testrig.InitTestConfig()

4
internal/api/wellknown/webfinger/webfingerget_test.go
View File

@@ -84,10 +84,10 @@ func (suite *WebfingerGetTestSuite) funkifyAccountDomain(host string, accountDom
config.SetHost(host)
config.SetAccountDomain(accountDomain)
testrig.StopWorkers(&suite.state)
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
suite.processor = processing.NewProcessor(cleaner.New(&suite.state), suite.tc, suite.federator, testrig.NewTestOauthServer(suite.db), testrig.NewTestMediaManager(&suite.state), &suite.state, suite.emailSender)
suite.webfingerModule = webfinger.New(suite.processor)
testrig.StartWorkers(&suite.state)
testrig.StartNoopWorkers(&suite.state)
// Generate a new account for the
// tester, which uses the new host.