[chore] Global server configuration overhaul (#575)

* move config flag names and usage to config package, rewrite config package to use global Configuration{} struct

Signed-off-by: kim <grufwub@gmail.com>

* improved code comment

Signed-off-by: kim <grufwub@gmail.com>

* linter

Signed-off-by: kim <grufwub@gmail.com>

* fix unmarshaling

Signed-off-by: kim <grufwub@gmail.com>

* remove kim's custom go compiler changes

Signed-off-by: kim <grufwub@gmail.com>

* generate setter and flag-name functions, implement these in codebase

Signed-off-by: kim <grufwub@gmail.com>

* update deps

Signed-off-by: kim <grufwub@gmail.com>

* small change

Signed-off-by: kim <grufwub@gmail.com>

* appease the linter...

Signed-off-by: kim <grufwub@gmail.com>

* move configuration into ConfigState structure, ensure reloading to/from viper settings to keep in sync

Signed-off-by: kim <grufwub@gmail.com>

* lint

Signed-off-by: kim <grufwub@gmail.com>

* update code comments

Signed-off-by: kim <grufwub@gmail.com>

* fix merge issue

Signed-off-by: kim <grufwub@gmail.com>

* fix merge issue

Signed-off-by: kim <grufwub@gmail.com>

* improved version string (removes time + go version)

Signed-off-by: kim <grufwub@gmail.com>

* fix version string build to pass test script + consolidate logic in func

Signed-off-by: kim <grufwub@gmail.com>

* add license text, update config.Defaults comment

Signed-off-by: kim <grufwub@gmail.com>

* add license text to generated config helpers file

Signed-off-by: kim <grufwub@gmail.com>

* defer unlock on config.Set___(), to ensure unlocked on panic

Signed-off-by: kim <grufwub@gmail.com>

* make it more obvious which cmd flags are being attached

Signed-off-by: kim <grufwub@gmail.com>

internal/api/client/account/account_test.go

@@ -8,7 +8,6 @@ import (
 
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/api/client/account"
 	"github.com/superseriousbusiness/gotosocial/internal/concurrency"
@@ -90,8 +89,8 @@ func (suite *AccountStandardTestSuite) newContext(recorder *httptest.ResponseRec
 	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"])
 	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"])
 
-	protocol := viper.GetString(config.Keys.Protocol)
-	host := viper.GetString(config.Keys.Host)
+	protocol := config.GetProtocol()
+	host := config.GetHost()
 
 	baseURI := fmt.Sprintf("%s://%s", protocol, host)
 	requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath)

internal/api/client/account/accountcreate.go

@@ -24,7 +24,6 @@ import (
 	"net/http"
 
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 
 	"github.com/gin-gonic/gin"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
@@ -123,9 +122,7 @@ func (m *Module) AccountCreatePOSTHandler(c *gin.Context) {
 // validateCreateAccount checks through all the necessary prerequisites for creating a new account,
 // according to the provided account create request. If the account isn't eligible, an error will be returned.
 func validateCreateAccount(form *model.AccountCreateRequest) error {
-	keys := config.Keys
-
-	if !viper.GetBool(keys.AccountsRegistrationOpen) {
+	if !config.GetAccountsRegistrationOpen() {
 		return errors.New("registration is not open for this server")
 	}
 
@@ -149,7 +146,7 @@ func validateCreateAccount(form *model.AccountCreateRequest) error {
 		return err
 	}
 
-	if err := validate.SignUpReason(form.Reason, viper.GetBool(keys.AccountsReasonRequired)); err != nil {
+	if err := validate.SignUpReason(form.Reason, config.GetAccountsReasonRequired()); err != nil {
 		return err
 	}
 

internal/api/client/admin/admin_test.go

@@ -26,7 +26,6 @@ import (
 
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/api/client/admin"
 	"github.com/superseriousbusiness/gotosocial/internal/concurrency"
@@ -108,8 +107,8 @@ func (suite *AdminStandardTestSuite) newContext(recorder *httptest.ResponseRecor
 	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["admin_account"])
 	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["admin_account"])
 
-	protocol := viper.GetString(config.Keys.Protocol)
-	host := viper.GetString(config.Keys.Host)
+	protocol := config.GetProtocol()
+	host := config.GetHost()
 
 	baseURI := fmt.Sprintf("%s://%s", protocol, host)
 	requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath)

internal/api/client/admin/mediacleanup.go

@@ -24,7 +24,6 @@ import (
 
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 	"github.com/superseriousbusiness/gotosocial/internal/api/model"
 	"github.com/superseriousbusiness/gotosocial/internal/config"
 	"github.com/superseriousbusiness/gotosocial/internal/oauth"
@@ -93,7 +92,7 @@ func (m *Module) MediaCleanupPOSTHandler(c *gin.Context) {
 
 	var remoteCacheDays int
 	if form.RemoteCacheDays == nil {
-		remoteCacheDays = viper.GetInt(config.Keys.MediaRemoteCacheDays)
+		remoteCacheDays = config.GetMediaRemoteCacheDays()
 	} else {
 		remoteCacheDays = *form.RemoteCacheDays
 	}

internal/api/client/auth/auth_test.go

@@ -26,7 +26,6 @@ import (
 	"github.com/gin-contrib/sessions"
 	"github.com/gin-contrib/sessions/memstore"
 	"github.com/gin-gonic/gin"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/api/client/auth"
 	"github.com/superseriousbusiness/gotosocial/internal/config"
@@ -96,8 +95,8 @@ func (suite *AuthStandardTestSuite) newContext(requestMethod string, requestPath
 	testrig.ConfigureTemplatesWithGin(engine)
 
 	// create the request
-	protocol := viper.GetString(config.Keys.Protocol)
-	host := viper.GetString(config.Keys.Host)
+	protocol := config.GetProtocol()
+	host := config.GetHost()
 	baseURI := fmt.Sprintf("%s://%s", protocol, host)
 	requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath)
 	ctx.Request = httptest.NewRequest(requestMethod, requestURI, nil) // the endpoint we're hitting

internal/api/client/followrequest/followrequest_test.go

@@ -25,7 +25,6 @@ import (
 
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/api/client/followrequest"
 	"github.com/superseriousbusiness/gotosocial/internal/concurrency"
@@ -104,8 +103,8 @@ func (suite *FollowRequestStandardTestSuite) newContext(recorder *httptest.Respo
 	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"])
 	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["local_account_1"])
 
-	protocol := viper.GetString(config.Keys.Protocol)
-	host := viper.GetString(config.Keys.Host)
+	protocol := config.GetProtocol()
+	host := config.GetHost()
 
 	baseURI := fmt.Sprintf("%s://%s", protocol, host)
 	requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath)

internal/api/client/instance/instance_test.go

@@ -26,7 +26,6 @@ import (
 
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	"github.com/superseriousbusiness/gotosocial/internal/api/client/instance"
 	"github.com/superseriousbusiness/gotosocial/internal/concurrency"
@@ -108,8 +107,8 @@ func (suite *InstanceStandardTestSuite) newContext(recorder *httptest.ResponseRe
 	ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["admin_account"])
 	ctx.Set(oauth.SessionAuthorizedUser, suite.testUsers["admin_account"])
 
-	protocol := viper.GetString(config.Keys.Protocol)
-	host := viper.GetString(config.Keys.Host)
+	protocol := config.GetProtocol()
+	host := config.GetHost()
 
 	baseURI := fmt.Sprintf("%s://%s", protocol, host)
 	requestURI := fmt.Sprintf("%s/%s", baseURI, requestPath)

internal/api/client/instance/instanceget.go

@@ -4,7 +4,6 @@ import (
 	"net/http"
 
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
 	"github.com/superseriousbusiness/gotosocial/internal/config"
 
@@ -41,7 +40,7 @@ func (m *Module) InstanceInformationGETHandler(c *gin.Context) {
 		return
 	}
 
-	host := viper.GetString(config.Keys.Host)
+	host := config.GetHost()
 
 	instance, err := m.processor.InstanceGet(c.Request.Context(), host)
 	if err != nil {

internal/api/client/media/mediacreate.go

@@ -24,7 +24,6 @@ import (
 	"net/http"
 
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 
 	"github.com/gin-gonic/gin"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
@@ -133,11 +132,10 @@ func validateCreateMedia(form *model.AttachmentRequest) error {
 		return errors.New("no attachment given")
 	}
 
-	keys := config.Keys
-	maxVideoSize := viper.GetInt(keys.MediaVideoMaxSize)
-	maxImageSize := viper.GetInt(keys.MediaImageMaxSize)
-	minDescriptionChars := viper.GetInt(keys.MediaDescriptionMinChars)
-	maxDescriptionChars := viper.GetInt(keys.MediaDescriptionMaxChars)
+	maxVideoSize := config.GetMediaVideoMaxSize()
+	maxImageSize := config.GetMediaImageMaxSize()
+	minDescriptionChars := config.GetMediaDescriptionMinChars()
+	maxDescriptionChars := config.GetMediaDescriptionMaxChars()
 
 	// a very superficial check to see if no size limits are exceeded
 	// we still don't actually know which media types we're dealing with but the other handlers will go into more detail there

internal/api/client/media/mediacreate_test.go

@@ -33,7 +33,6 @@ import (
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	mediamodule "github.com/superseriousbusiness/gotosocial/internal/api/client/media"
 	"github.com/superseriousbusiness/gotosocial/internal/api/model"
@@ -261,7 +260,7 @@ func (suite *MediaCreateTestSuite) TestMediaCreateLongDescription() {
 
 func (suite *MediaCreateTestSuite) TestMediaCreateTooShortDescription() {
 	// set the min description length
-	viper.Set(config.Keys.MediaDescriptionMinChars, 500)
+	config.SetMediaDescriptionMinChars(500)
 
 	// set up the context for the request
 	t := suite.testTokens["local_account_1"]

internal/api/client/media/mediaupdate.go

@@ -24,7 +24,6 @@ import (
 	"net/http"
 
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 
 	"github.com/gin-gonic/gin"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
@@ -141,9 +140,8 @@ func (m *Module) MediaPUTHandler(c *gin.Context) {
 }
 
 func validateUpdateMedia(form *model.AttachmentUpdateRequest) error {
-	keys := config.Keys
-	minDescriptionChars := viper.GetInt(keys.MediaDescriptionMinChars)
-	maxDescriptionChars := viper.GetInt(keys.MediaDescriptionMaxChars)
+	minDescriptionChars := config.GetMediaDescriptionMinChars()
+	maxDescriptionChars := config.GetMediaDescriptionMaxChars()
 
 	if form.Description != nil {
 		if len(*form.Description) < minDescriptionChars || len(*form.Description) > maxDescriptionChars {

internal/api/client/media/mediaupdate_test.go

@@ -31,7 +31,6 @@ import (
 	"codeberg.org/gruf/go-store/kv"
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 	"github.com/stretchr/testify/suite"
 	mediamodule "github.com/superseriousbusiness/gotosocial/internal/api/client/media"
 	"github.com/superseriousbusiness/gotosocial/internal/api/model"
@@ -188,7 +187,7 @@ func (suite *MediaUpdateTestSuite) TestUpdateImage() {
 
 func (suite *MediaUpdateTestSuite) TestUpdateImageShortDescription() {
 	// set the min description length
-	viper.Set(config.Keys.MediaDescriptionMinChars, 50)
+	config.SetMediaDescriptionMinChars(50)
 
 	toUpdate := suite.testAttachments["local_account_1_unattached_1"]
 

internal/api/client/status/statuscreate.go

@@ -24,7 +24,6 @@ import (
 	"net/http"
 
 	"github.com/sirupsen/logrus"
-	"github.com/spf13/viper"
 
 	"github.com/gin-gonic/gin"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
@@ -130,12 +129,11 @@ func validateCreateStatus(form *model.AdvancedStatusCreateForm) error {
 		return errors.New("can't post media + poll in same status")
 	}
 
-	keys := config.Keys
-	maxChars := viper.GetInt(keys.StatusesMaxChars)
-	maxMediaFiles := viper.GetInt(keys.StatusesMediaMaxFiles)
-	maxPollOptions := viper.GetInt(keys.StatusesPollMaxOptions)
-	maxPollChars := viper.GetInt(keys.StatusesPollOptionMaxChars)
-	maxCwChars := viper.GetInt(keys.StatusesCWMaxChars)
+	maxChars := config.GetStatusesMaxChars()
+	maxMediaFiles := config.GetStatusesMediaMaxFiles()
+	maxPollOptions := config.GetStatusesPollMaxOptions()
+	maxPollChars := config.GetStatusesPollOptionMaxChars()
+	maxCwChars := config.GetStatusesCWMaxChars()
 
 	// validate status
 	if form.Status != "" {