SuperSeriousBusiness
/
GoToSocial
mirror of https://github.com/superseriousbusiness/gotosocial
1
1
Fork 0
Code Issues Projects Releases Wiki Activity

[bugfix] Use background context instead of request context for async processing (#888) 

Fixes an issue where async processing was not completing correctly.

In particular this applies to side effects of domain blocks: while the domain block was being entered and enforced correctly, side effects like deleting accounts and updating the instance entry for the blocked instance were not. This fixes that :)
This commit is contained in:
tobi 2022-10-04 17:50:29 +02:00 committed by GitHub
parent 1a56352568
commit 359ed1bcb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/processing/admin/createdomainblock.go
View File

@ -75,7 +75,9 @@ func (p *processor) DomainBlockCreate(ctx context.Context, account *gtsmodel.Acc
block = &newBlock block = &newBlock
// Process the side effects of the domain block asynchronously since it might take a while // Process the side effects of the domain block asynchronously since it might take a while
go p.initiateDomainBlockSideEffects(ctx, account, block) go func() {
p.initiateDomainBlockSideEffects(context.Background(), account, block)
}()
} }
// Convert our gts model domain block into an API model // Convert our gts model domain block into an API model

6
internal/processing/admin/mediaprune.go
View File

@ -33,7 +33,7 @@ func (p *processor) MediaPrune(ctx context.Context, mediaRemoteCacheDays int) gt
} }
go func() { go func() {
pruned, err := p.mediaManager.PruneAllRemote(ctx, mediaRemoteCacheDays) pruned, err := p.mediaManager.PruneAllRemote(context.Background(), mediaRemoteCacheDays)
if err != nil { if err != nil {
log.Errorf("MediaPrune: error pruning remote cache: %s", err) log.Errorf("MediaPrune: error pruning remote cache: %s", err)
} else { } else {
@ -42,7 +42,7 @@ func (p *processor) MediaPrune(ctx context.Context, mediaRemoteCacheDays int) gt
}() }()
go func() { go func() {
pruned, err := p.mediaManager.PruneUnusedLocalAttachments(ctx) pruned, err := p.mediaManager.PruneUnusedLocalAttachments(context.Background())
if err != nil { if err != nil {
log.Errorf("MediaPrune: error pruning unused local cache: %s", err) log.Errorf("MediaPrune: error pruning unused local cache: %s", err)
} else { } else {
@ -51,7 +51,7 @@ func (p *processor) MediaPrune(ctx context.Context, mediaRemoteCacheDays int) gt
}() }()
go func() { go func() {
pruned, err := p.mediaManager.PruneAllMeta(ctx) pruned, err := p.mediaManager.PruneAllMeta(context.Background())
if err != nil { if err != nil {
log.Errorf("MediaPrune: error pruning meta: %s", err) log.Errorf("MediaPrune: error pruning meta: %s", err)
} else { } else {