make if else clauses easier to parse

2024-04-26 12:14:50 +01:00 · 2024-04-26 12:14:50 +01:00 · 2e5c93fdba
parent 1ec1af9e22
commit 2e5c93fdba
1 changed files with 8 additions and 2 deletions
--- a/internal/federation/federatingdb/delete.go
+++ b/internal/federation/federatingdb/delete.go
@ -60,8 +60,11 @@ func (f *federatingDB) Delete(ctx context.Context, id *url.URL) error {
 		receiving,
 		uriStr,
 	)
-	if err != nil || ok { // handles success
+	if err != nil {
 		return err
+	} else if ok {
+		// success!
+		return nil
 	}

 	// Attempt to delete status.
@ -70,8 +73,11 @@ func (f *federatingDB) Delete(ctx context.Context, id *url.URL) error {
 		receiving,
 		uriStr,
 	)
-	if err != nil || ok { // handles success
+	if err != nil {
 		return err
+	} else if ok {
+		// success!
+		return nil
 	}

 	// Log at debug level, as lots of these could indicate federation