reference global logrus (#274)

* reference logrus' global logger instead of passing and storing a logger reference everywhere

* always directly use global logrus logger instead of referencing an instance

* test suites should also directly use the global logrus logger

* rename gin logging function to clarify that it's middleware

* correct comments which erroneously referenced removed logger parameter

* setting log level for tests now uses logrus' exported type instead of the string value, to guarantee error isn't possible

internal/api/s2s/nodeinfo/nodeinfo.go

@@ -21,7 +21,6 @@ package nodeinfo
 import (
 	"net/http"
 
-	"github.com/sirupsen/logrus"
 	"github.com/superseriousbusiness/gotosocial/internal/api"
 	"github.com/superseriousbusiness/gotosocial/internal/config"
 	"github.com/superseriousbusiness/gotosocial/internal/processing"
@@ -39,15 +38,13 @@ const (
 type Module struct {
 	config    *config.Config
 	processor processing.Processor
-	log       *logrus.Logger
 }
 
 // New returns a new nodeinfo module
-func New(config *config.Config, processor processing.Processor, log *logrus.Logger) api.FederationModule {
+func New(config *config.Config, processor processing.Processor) api.FederationModule {
 	return &Module{
 		config:    config,
 		processor: processor,
-		log:       log,
 	}
 }
 

internal/api/s2s/nodeinfo/nodeinfoget.go

@@ -28,7 +28,7 @@ import (
 // NodeInfoGETHandler returns a compliant nodeinfo response to node info queries.
 // See: https://nodeinfo.diaspora.software/
 func (m *Module) NodeInfoGETHandler(c *gin.Context) {
-	l := m.log.WithFields(logrus.Fields{
+	l := logrus.WithFields(logrus.Fields{
 		"func":       "NodeInfoGETHandler",
 		"user-agent": c.Request.UserAgent(),
 	})

internal/api/s2s/nodeinfo/wellknownget.go

@@ -28,7 +28,7 @@ import (
 // NodeInfoWellKnownGETHandler returns a well known response to a query to /.well-known/nodeinfo,
 // directing (but not redirecting...) callers to the NodeInfoGETHandler.
 func (m *Module) NodeInfoWellKnownGETHandler(c *gin.Context) {
-	l := m.log.WithFields(logrus.Fields{
+	l := logrus.WithFields(logrus.Fields{
 		"func":       "NodeInfoWellKnownGETHandler",
 		"user-agent": c.Request.UserAgent(),
 	})