[bugfix] small editing tweaks (#3631)

* ensure edited_at isn't set on boost wrapper statuses

* improve handling of remote status updated_at to fix previous cases

* formatting

* add remote status published / updated field validation checks, handle appropriately in handleStatusEdit()

* specifically allowed updated to be equal to published

* only check creation date change when an existing status
This commit is contained in:
kim
2024-12-24 21:16:49 +00:00
committed by GitHub
parent fe8d5f2307
commit 0784aa3218
3 changed files with 33 additions and 12 deletions

View File

@@ -22,6 +22,7 @@ import (
"context"
"errors"
"net/url"
"time"
"github.com/miekg/dns"
"github.com/superseriousbusiness/gotosocial/internal/ap"
@@ -357,15 +358,21 @@ func (c *Converter) ASStatusToStatus(ctx context.Context, statusable ap.Statusab
status.CreatedAt = pub
} else {
log.Warnf(ctx, "unusable published property on %s", uri)
status.CreatedAt = time.Now()
}
// status.Updated
//
// Extract updated time for status, defaults to Published.
if upd := ap.GetUpdated(statusable); !upd.IsZero() {
// Extract and validate update time for status. Defaults to published.
if upd := ap.GetUpdated(statusable); !upd.Before(status.CreatedAt) {
status.UpdatedAt = upd
} else {
} else if upd.IsZero() {
status.UpdatedAt = status.CreatedAt
} else {
// This is a malformed status that will likely break our systems.
err := gtserror.Newf("status %s 'updated' predates 'published'", uri)
return nil, gtserror.SetMalformed(err)
}
// status.AccountURI