2023-03-12 16:00:57 +01:00
|
|
|
// GoToSocial
|
|
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
//
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Affero General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2021-07-06 13:29:11 +02:00
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
package bundb
|
2021-07-06 13:29:11 +02:00
|
|
|
|
|
|
|
import (
|
2021-08-20 12:26:56 +02:00
|
|
|
"context"
|
2023-05-12 11:15:54 +02:00
|
|
|
"errors"
|
2022-03-07 11:08:26 +01:00
|
|
|
"time"
|
2021-07-06 13:29:11 +02:00
|
|
|
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
2023-05-12 11:15:54 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
|
2023-06-22 21:46:36 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
2021-08-20 12:26:56 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
2023-02-13 21:19:51 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/state"
|
2021-08-25 15:34:33 +02:00
|
|
|
"github.com/uptrace/bun"
|
2021-07-06 13:29:11 +02:00
|
|
|
)
|
|
|
|
|
2021-08-20 12:26:56 +02:00
|
|
|
type mediaDB struct {
|
2023-02-13 21:19:51 +01:00
|
|
|
conn *DBConn
|
|
|
|
state *state.State
|
2021-08-20 12:26:56 +02:00
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
func (m *mediaDB) GetAttachmentByID(ctx context.Context, id string) (*gtsmodel.MediaAttachment, db.Error) {
|
2023-02-13 21:19:51 +01:00
|
|
|
return m.getAttachment(
|
|
|
|
ctx,
|
|
|
|
"ID",
|
|
|
|
func(attachment *gtsmodel.MediaAttachment) error {
|
2023-03-04 00:02:23 +01:00
|
|
|
return m.conn.NewSelect().
|
|
|
|
Model(attachment).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), id).
|
|
|
|
Scan(ctx)
|
2023-02-13 21:19:51 +01:00
|
|
|
},
|
|
|
|
id,
|
|
|
|
)
|
|
|
|
}
|
2021-08-20 12:26:56 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
func (m *mediaDB) GetAttachmentsByIDs(ctx context.Context, ids []string) ([]*gtsmodel.MediaAttachment, error) {
|
|
|
|
attachments := make([]*gtsmodel.MediaAttachment, 0, len(ids))
|
|
|
|
|
|
|
|
for _, id := range ids {
|
|
|
|
// Attempt fetch from DB
|
|
|
|
attachment, err := m.GetAttachmentByID(ctx, id)
|
|
|
|
if err != nil {
|
|
|
|
log.Errorf(ctx, "error getting attachment %q: %v", id, err)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// Append attachment
|
|
|
|
attachments = append(attachments, attachment)
|
|
|
|
}
|
|
|
|
|
|
|
|
return attachments, nil
|
|
|
|
}
|
|
|
|
|
2023-03-04 00:02:23 +01:00
|
|
|
func (m *mediaDB) getAttachment(ctx context.Context, lookup string, dbQuery func(*gtsmodel.MediaAttachment) error, keyParts ...any) (*gtsmodel.MediaAttachment, db.Error) {
|
|
|
|
return m.state.Caches.GTS.Media().Load(lookup, func() (*gtsmodel.MediaAttachment, error) {
|
|
|
|
var attachment gtsmodel.MediaAttachment
|
2021-08-20 12:26:56 +02:00
|
|
|
|
2023-03-04 00:02:23 +01:00
|
|
|
// Not cached! Perform database query
|
|
|
|
if err := dbQuery(&attachment); err != nil {
|
|
|
|
return nil, m.conn.ProcessError(err)
|
2023-02-13 21:19:51 +01:00
|
|
|
}
|
|
|
|
|
2023-03-04 00:02:23 +01:00
|
|
|
return &attachment, nil
|
|
|
|
}, keyParts...)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (m *mediaDB) PutAttachment(ctx context.Context, media *gtsmodel.MediaAttachment) error {
|
|
|
|
return m.state.Caches.GTS.Media().Store(media, func() error {
|
|
|
|
_, err := m.conn.NewInsert().Model(media).Exec(ctx)
|
|
|
|
return m.conn.ProcessError(err)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func (m *mediaDB) UpdateAttachment(ctx context.Context, media *gtsmodel.MediaAttachment, columns ...string) error {
|
|
|
|
media.UpdatedAt = time.Now()
|
|
|
|
if len(columns) > 0 {
|
|
|
|
// If we're updating by column, ensure "updated_at" is included.
|
|
|
|
columns = append(columns, "updated_at")
|
2021-08-29 16:41:41 +02:00
|
|
|
}
|
2023-02-13 21:19:51 +01:00
|
|
|
|
2023-03-04 00:02:23 +01:00
|
|
|
return m.state.Caches.GTS.Media().Store(media, func() error {
|
|
|
|
_, err := m.conn.NewUpdate().
|
|
|
|
Model(media).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), media.ID).
|
|
|
|
Column(columns...).
|
|
|
|
Exec(ctx)
|
|
|
|
return m.conn.ProcessError(err)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func (m *mediaDB) DeleteAttachment(ctx context.Context, id string) error {
|
2023-05-12 11:15:54 +02:00
|
|
|
defer m.state.Caches.GTS.Media().Invalidate("ID", id)
|
|
|
|
|
|
|
|
// Load media into cache before attempting a delete,
|
|
|
|
// as we need it cached in order to trigger the invalidate
|
|
|
|
// callback. This in turn invalidates others.
|
2023-06-22 21:46:36 +02:00
|
|
|
media, err := m.GetAttachmentByID(gtscontext.SetBarebones(ctx), id)
|
2023-05-12 11:15:54 +02:00
|
|
|
if err != nil {
|
|
|
|
if errors.Is(err, db.ErrNoEntries) {
|
|
|
|
// not an issue.
|
|
|
|
err = nil
|
|
|
|
}
|
|
|
|
return err
|
2023-03-04 00:02:23 +01:00
|
|
|
}
|
|
|
|
|
2023-06-22 21:46:36 +02:00
|
|
|
var (
|
|
|
|
invalidateAccount bool
|
|
|
|
invalidateStatus bool
|
|
|
|
)
|
|
|
|
|
|
|
|
// Delete media attachment in new transaction.
|
|
|
|
err = m.conn.RunInTx(ctx, func(tx bun.Tx) error {
|
|
|
|
if media.AccountID != "" {
|
|
|
|
var account gtsmodel.Account
|
|
|
|
|
|
|
|
// Get related account model.
|
|
|
|
if _, err := tx.NewSelect().
|
|
|
|
Model(&account).
|
|
|
|
Where("? = ?", bun.Ident("id"), media.AccountID).
|
|
|
|
Exec(ctx); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
return gtserror.Newf("error selecting account: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
var set func(*bun.UpdateQuery) *bun.UpdateQuery
|
|
|
|
|
|
|
|
switch {
|
|
|
|
case *media.Avatar && account.AvatarMediaAttachmentID == id:
|
|
|
|
set = func(q *bun.UpdateQuery) *bun.UpdateQuery {
|
|
|
|
return q.Set("? = NULL", bun.Ident("avatar_media_attachment_id"))
|
|
|
|
}
|
|
|
|
case *media.Header && account.HeaderMediaAttachmentID == id:
|
|
|
|
set = func(q *bun.UpdateQuery) *bun.UpdateQuery {
|
|
|
|
return q.Set("? = NULL", bun.Ident("header_media_attachment_id"))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if set != nil {
|
|
|
|
// Note: this handles not found.
|
|
|
|
//
|
|
|
|
// Update the account model.
|
|
|
|
q := tx.NewUpdate().
|
|
|
|
Table("accounts").
|
|
|
|
Where("? = ?", bun.Ident("id"), account.ID)
|
|
|
|
if _, err := set(q).Exec(ctx); err != nil {
|
|
|
|
return gtserror.Newf("error updating account: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Mark as needing invalidate.
|
|
|
|
invalidateAccount = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if media.StatusID != "" {
|
|
|
|
var status gtsmodel.Status
|
|
|
|
|
|
|
|
// Get related status model.
|
|
|
|
if _, err := tx.NewSelect().
|
|
|
|
Model(&status).
|
|
|
|
Where("? = ?", bun.Ident("id"), media.StatusID).
|
|
|
|
Exec(ctx); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
return gtserror.Newf("error selecting status: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Get length of attachments beforehand.
|
|
|
|
before := len(status.AttachmentIDs)
|
|
|
|
|
|
|
|
for i := 0; i < len(status.AttachmentIDs); {
|
|
|
|
if status.AttachmentIDs[i] == id {
|
|
|
|
// Remove this reference to deleted attachment ID.
|
|
|
|
copy(status.AttachmentIDs[i:], status.AttachmentIDs[i+1:])
|
|
|
|
status.AttachmentIDs = status.AttachmentIDs[:len(status.AttachmentIDs)-1]
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
i++
|
|
|
|
}
|
|
|
|
|
|
|
|
if before != len(status.AttachmentIDs) {
|
|
|
|
// Note: this accounts for status not found.
|
|
|
|
//
|
|
|
|
// Attachments changed, update the status.
|
|
|
|
if _, err := tx.NewUpdate().
|
|
|
|
Table("statuses").
|
|
|
|
Where("? = ?", bun.Ident("id"), status.ID).
|
|
|
|
Set("? = ?", bun.Ident("attachment_ids"), status.AttachmentIDs).
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
return gtserror.Newf("error updating status: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Mark as needing invalidate.
|
|
|
|
invalidateStatus = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Finally delete this media.
|
|
|
|
if _, err := tx.NewDelete().
|
|
|
|
Table("media_attachments").
|
|
|
|
Where("? = ?", bun.Ident("id"), id).
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
return gtserror.Newf("error deleting media: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
|
|
|
|
if invalidateAccount {
|
|
|
|
// The account for given ID will have been updated in transaction.
|
|
|
|
m.state.Caches.GTS.Account().Invalidate("ID", media.AccountID)
|
|
|
|
}
|
|
|
|
|
|
|
|
if invalidateStatus {
|
|
|
|
// The status for given ID will have been updated in transaction.
|
|
|
|
m.state.Caches.GTS.Status().Invalidate("ID", media.StatusID)
|
|
|
|
}
|
|
|
|
|
2023-05-12 11:15:54 +02:00
|
|
|
return m.conn.ProcessError(err)
|
2021-07-06 13:29:11 +02:00
|
|
|
}
|
2022-03-07 11:08:26 +01:00
|
|
|
|
|
|
|
func (m *mediaDB) GetRemoteOlderThan(ctx context.Context, olderThan time.Time, limit int) ([]*gtsmodel.MediaAttachment, db.Error) {
|
2023-02-13 21:19:51 +01:00
|
|
|
attachmentIDs := []string{}
|
2022-03-07 11:08:26 +01:00
|
|
|
|
|
|
|
q := m.conn.
|
|
|
|
NewSelect().
|
2023-02-13 21:19:51 +01:00
|
|
|
TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
|
|
|
|
Column("media_attachment.id").
|
2022-10-08 13:50:48 +02:00
|
|
|
Where("? = ?", bun.Ident("media_attachment.cached"), true).
|
|
|
|
Where("? < ?", bun.Ident("media_attachment.created_at"), olderThan).
|
2023-07-05 12:34:37 +02:00
|
|
|
Where("? IS NOT NULL", bun.Ident("media_attachment.remote_url")).
|
2022-03-07 11:08:26 +01:00
|
|
|
Order("media_attachment.created_at DESC")
|
|
|
|
|
|
|
|
if limit != 0 {
|
|
|
|
q = q.Limit(limit)
|
|
|
|
}
|
|
|
|
|
2023-02-13 21:19:51 +01:00
|
|
|
if err := q.Scan(ctx, &attachmentIDs); err != nil {
|
2022-03-07 11:08:26 +01:00
|
|
|
return nil, m.conn.ProcessError(err)
|
|
|
|
}
|
2022-12-12 12:22:19 +01:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return m.GetAttachmentsByIDs(ctx, attachmentIDs)
|
2022-03-07 11:08:26 +01:00
|
|
|
}
|
2022-05-15 16:45:04 +02:00
|
|
|
|
2023-02-11 12:48:38 +01:00
|
|
|
func (m *mediaDB) CountRemoteOlderThan(ctx context.Context, olderThan time.Time) (int, db.Error) {
|
|
|
|
q := m.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
|
|
|
|
Column("media_attachment.id").
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.cached"), true).
|
2023-07-05 12:34:37 +02:00
|
|
|
Where("? IS NOT NULL", bun.Ident("media_attachment.remote_url")).
|
|
|
|
Where("? < ?", bun.Ident("media_attachment.created_at"), olderThan)
|
2023-02-11 12:48:38 +01:00
|
|
|
|
|
|
|
count, err := q.Count(ctx)
|
|
|
|
if err != nil {
|
|
|
|
return 0, m.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return count, nil
|
|
|
|
}
|
|
|
|
|
2023-06-22 21:46:36 +02:00
|
|
|
func (m *mediaDB) GetAttachments(ctx context.Context, maxID string, limit int) ([]*gtsmodel.MediaAttachment, error) {
|
|
|
|
attachmentIDs := []string{}
|
|
|
|
|
|
|
|
q := m.conn.NewSelect().
|
|
|
|
Table("media_attachments").
|
|
|
|
Column("id").
|
|
|
|
Order("id DESC")
|
|
|
|
|
|
|
|
if maxID != "" {
|
|
|
|
q = q.Where("? < ?", bun.Ident("id"), maxID)
|
|
|
|
}
|
|
|
|
|
|
|
|
if limit != 0 {
|
|
|
|
q = q.Limit(limit)
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := q.Scan(ctx, &attachmentIDs); err != nil {
|
|
|
|
return nil, m.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return m.GetAttachmentsByIDs(ctx, attachmentIDs)
|
|
|
|
}
|
|
|
|
|
2022-05-15 16:45:04 +02:00
|
|
|
func (m *mediaDB) GetAvatarsAndHeaders(ctx context.Context, maxID string, limit int) ([]*gtsmodel.MediaAttachment, db.Error) {
|
2023-02-13 21:19:51 +01:00
|
|
|
attachmentIDs := []string{}
|
2022-05-15 16:45:04 +02:00
|
|
|
|
2023-02-13 21:19:51 +01:00
|
|
|
q := m.conn.NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
|
|
|
|
Column("media_attachment.id").
|
2022-05-15 16:45:04 +02:00
|
|
|
WhereGroup(" AND ", func(innerQ *bun.SelectQuery) *bun.SelectQuery {
|
|
|
|
return innerQ.
|
2022-10-08 13:50:48 +02:00
|
|
|
WhereOr("? = ?", bun.Ident("media_attachment.avatar"), true).
|
|
|
|
WhereOr("? = ?", bun.Ident("media_attachment.header"), true)
|
2022-05-15 16:45:04 +02:00
|
|
|
}).
|
|
|
|
Order("media_attachment.id DESC")
|
|
|
|
|
|
|
|
if maxID != "" {
|
2022-10-08 13:50:48 +02:00
|
|
|
q = q.Where("? < ?", bun.Ident("media_attachment.id"), maxID)
|
2022-05-15 16:45:04 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if limit != 0 {
|
|
|
|
q = q.Limit(limit)
|
|
|
|
}
|
|
|
|
|
2023-02-13 21:19:51 +01:00
|
|
|
if err := q.Scan(ctx, &attachmentIDs); err != nil {
|
2022-05-15 16:45:04 +02:00
|
|
|
return nil, m.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return m.GetAttachmentsByIDs(ctx, attachmentIDs)
|
2022-05-15 16:45:04 +02:00
|
|
|
}
|
2022-06-30 12:22:10 +02:00
|
|
|
|
2023-02-11 12:48:38 +01:00
|
|
|
func (m *mediaDB) GetLocalUnattachedOlderThan(ctx context.Context, olderThan time.Time, limit int) ([]*gtsmodel.MediaAttachment, db.Error) {
|
2023-02-13 21:19:51 +01:00
|
|
|
attachmentIDs := []string{}
|
2022-06-30 12:22:10 +02:00
|
|
|
|
2023-02-13 21:19:51 +01:00
|
|
|
q := m.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
|
|
|
|
Column("media_attachment.id").
|
2022-10-08 13:50:48 +02:00
|
|
|
Where("? = ?", bun.Ident("media_attachment.cached"), true).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.avatar"), false).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.header"), false).
|
|
|
|
Where("? < ?", bun.Ident("media_attachment.created_at"), olderThan).
|
|
|
|
Where("? IS NULL", bun.Ident("media_attachment.remote_url")).
|
2023-02-11 12:48:38 +01:00
|
|
|
Where("? IS NULL", bun.Ident("media_attachment.status_id")).
|
|
|
|
Order("media_attachment.created_at DESC")
|
2022-06-30 12:22:10 +02:00
|
|
|
|
|
|
|
if limit != 0 {
|
|
|
|
q = q.Limit(limit)
|
|
|
|
}
|
|
|
|
|
2023-02-13 21:19:51 +01:00
|
|
|
if err := q.Scan(ctx, &attachmentIDs); err != nil {
|
2022-06-30 12:22:10 +02:00
|
|
|
return nil, m.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return m.GetAttachmentsByIDs(ctx, attachmentIDs)
|
2022-06-30 12:22:10 +02:00
|
|
|
}
|
2023-02-11 12:48:38 +01:00
|
|
|
|
|
|
|
func (m *mediaDB) CountLocalUnattachedOlderThan(ctx context.Context, olderThan time.Time) (int, db.Error) {
|
|
|
|
q := m.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
|
|
|
|
Column("media_attachment.id").
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.cached"), true).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.avatar"), false).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.header"), false).
|
|
|
|
Where("? < ?", bun.Ident("media_attachment.created_at"), olderThan).
|
|
|
|
Where("? IS NULL", bun.Ident("media_attachment.remote_url")).
|
|
|
|
Where("? IS NULL", bun.Ident("media_attachment.status_id"))
|
|
|
|
|
|
|
|
count, err := q.Count(ctx)
|
|
|
|
if err != nil {
|
|
|
|
return 0, m.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return count, nil
|
|
|
|
}
|