2023-03-12 16:00:57 +01:00
|
|
|
// GoToSocial
|
|
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
//
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Affero General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2021-08-25 15:34:33 +02:00
|
|
|
|
|
|
|
package bundb
|
|
|
|
|
|
|
|
import (
|
|
|
|
"container/list"
|
|
|
|
"context"
|
2022-07-10 17:18:21 +02:00
|
|
|
"database/sql"
|
2022-09-12 13:03:23 +02:00
|
|
|
"errors"
|
2022-11-20 17:38:58 +01:00
|
|
|
"fmt"
|
2021-08-25 15:34:33 +02:00
|
|
|
"time"
|
|
|
|
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
|
2021-08-25 15:34:33 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
2022-07-19 10:47:55 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
2022-12-08 18:35:14 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/state"
|
2021-08-25 15:34:33 +02:00
|
|
|
"github.com/uptrace/bun"
|
|
|
|
)
|
|
|
|
|
|
|
|
type statusDB struct {
|
2022-12-08 18:35:14 +01:00
|
|
|
conn *DBConn
|
|
|
|
state *state.State
|
2022-11-15 19:45:15 +01:00
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
func (s *statusDB) newStatusQ(status interface{}) *bun.SelectQuery {
|
|
|
|
return s.conn.
|
|
|
|
NewSelect().
|
|
|
|
Model(status).
|
|
|
|
Relation("Tags").
|
|
|
|
Relation("CreatedWithApplication")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) GetStatusByID(ctx context.Context, id string) (*gtsmodel.Status, db.Error) {
|
2021-09-01 11:08:21 +02:00
|
|
|
return s.getStatus(
|
|
|
|
ctx,
|
2022-11-15 19:45:15 +01:00
|
|
|
"ID",
|
2021-09-01 11:08:21 +02:00
|
|
|
func(status *gtsmodel.Status) error {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.newStatusQ(status).Where("? = ?", bun.Ident("status.id"), id).Scan(ctx)
|
2021-09-01 11:08:21 +02:00
|
|
|
},
|
2022-11-15 19:45:15 +01:00
|
|
|
id,
|
2021-09-01 11:08:21 +02:00
|
|
|
)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2023-01-10 15:19:05 +01:00
|
|
|
func (s *statusDB) GetStatuses(ctx context.Context, ids []string) ([]*gtsmodel.Status, db.Error) {
|
|
|
|
statuses := make([]*gtsmodel.Status, 0, len(ids))
|
|
|
|
|
|
|
|
for _, id := range ids {
|
|
|
|
// Attempt fetch from DB
|
|
|
|
status, err := s.GetStatusByID(ctx, id)
|
|
|
|
if err != nil {
|
2023-02-17 12:02:29 +01:00
|
|
|
log.Errorf(ctx, "error getting status %q: %v", id, err)
|
2023-01-10 15:19:05 +01:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// Append status
|
|
|
|
statuses = append(statuses, status)
|
|
|
|
}
|
|
|
|
|
|
|
|
return statuses, nil
|
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
func (s *statusDB) GetStatusByURI(ctx context.Context, uri string) (*gtsmodel.Status, db.Error) {
|
2021-09-01 11:08:21 +02:00
|
|
|
return s.getStatus(
|
|
|
|
ctx,
|
2022-11-15 19:45:15 +01:00
|
|
|
"URI",
|
2021-09-01 11:08:21 +02:00
|
|
|
func(status *gtsmodel.Status) error {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.newStatusQ(status).Where("? = ?", bun.Ident("status.uri"), uri).Scan(ctx)
|
2021-09-01 11:08:21 +02:00
|
|
|
},
|
2022-11-15 19:45:15 +01:00
|
|
|
uri,
|
2021-09-01 11:08:21 +02:00
|
|
|
)
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-09-01 11:08:21 +02:00
|
|
|
func (s *statusDB) GetStatusByURL(ctx context.Context, url string) (*gtsmodel.Status, db.Error) {
|
|
|
|
return s.getStatus(
|
|
|
|
ctx,
|
2022-11-15 19:45:15 +01:00
|
|
|
"URL",
|
2021-09-01 11:08:21 +02:00
|
|
|
func(status *gtsmodel.Status) error {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.newStatusQ(status).Where("? = ?", bun.Ident("status.url"), url).Scan(ctx)
|
2021-09-01 11:08:21 +02:00
|
|
|
},
|
2022-11-15 19:45:15 +01:00
|
|
|
url,
|
2021-09-01 11:08:21 +02:00
|
|
|
)
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
func (s *statusDB) getStatus(ctx context.Context, lookup string, dbQuery func(*gtsmodel.Status) error, keyParts ...any) (*gtsmodel.Status, db.Error) {
|
|
|
|
// Fetch status from database cache with loader callback
|
2022-12-08 18:35:14 +01:00
|
|
|
status, err := s.state.Caches.GTS.Status().Load(lookup, func() (*gtsmodel.Status, error) {
|
2022-11-15 19:45:15 +01:00
|
|
|
var status gtsmodel.Status
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// Not cached! Perform database query.
|
2022-11-15 19:45:15 +01:00
|
|
|
if err := dbQuery(&status); err != nil {
|
2021-09-01 11:08:21 +02:00
|
|
|
return nil, s.conn.ProcessError(err)
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return &status, nil
|
|
|
|
}, keyParts...)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if gtscontext.Barebones(ctx) {
|
|
|
|
// no need to fully populate.
|
|
|
|
return status, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Further populate the status fields where applicable.
|
|
|
|
if err := s.PopulateStatus(ctx, status); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
return status, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) PopulateStatus(ctx context.Context, status *gtsmodel.Status) error {
|
|
|
|
var err error
|
|
|
|
|
|
|
|
if status.Account == nil {
|
|
|
|
// Status author is not set, fetch from database.
|
|
|
|
status.Account, err = s.state.DB.GetAccountByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.AccountID,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("error populating status author: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if status.InReplyToID != "" && status.InReplyTo == nil {
|
|
|
|
// Status parent is not set, fetch from database.
|
|
|
|
status.InReplyTo, err = s.GetStatusByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.InReplyToID,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("error populating status parent: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if status.InReplyToID != "" {
|
|
|
|
if status.InReplyTo == nil {
|
|
|
|
// Status parent is not set, fetch from database.
|
|
|
|
status.InReplyTo, err = s.GetStatusByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.InReplyToID,
|
|
|
|
)
|
2022-11-18 18:28:33 +01:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("error populating status parent: %w", err)
|
2022-11-18 18:28:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if status.InReplyToAccount == nil {
|
|
|
|
// Status parent author is not set, fetch from database.
|
|
|
|
status.InReplyToAccount, err = s.state.DB.GetAccountByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.InReplyToAccountID,
|
|
|
|
)
|
2022-11-15 19:45:15 +01:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("error populating status parent author: %w", err)
|
2021-09-01 11:08:21 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if status.BoostOfID != "" {
|
|
|
|
if status.BoostOf == nil {
|
|
|
|
// Status boost is not set, fetch from database.
|
|
|
|
status.BoostOf, err = s.GetStatusByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.BoostOfID,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("error populating status boost: %w", err)
|
|
|
|
}
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if status.BoostOfAccount == nil {
|
|
|
|
// Status boost author is not set, fetch from database.
|
|
|
|
status.BoostOfAccount, err = s.state.DB.GetAccountByID(
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
status.BoostOfAccountID,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("error populating status boost author: %w", err)
|
|
|
|
}
|
2022-11-18 18:28:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if !status.AttachmentsPopulated() {
|
|
|
|
// Status attachments are out-of-date with IDs, repopulate.
|
|
|
|
status.Attachments, err = s.state.DB.GetAttachmentsByIDs(
|
|
|
|
ctx, // these are already barebones
|
|
|
|
status.AttachmentIDs,
|
|
|
|
)
|
2022-11-18 18:28:33 +01:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("error populating status attachments: %w", err)
|
2022-11-18 18:28:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// TODO: once we don't fetch using relations.
|
|
|
|
// if !status.TagsPopulated() {
|
|
|
|
// }
|
|
|
|
|
|
|
|
if !status.MentionsPopulated() {
|
|
|
|
// Status mentions are out-of-date with IDs, repopulate.
|
|
|
|
status.Mentions, err = s.state.DB.GetMentions(
|
|
|
|
ctx, // leave fully populated for now
|
|
|
|
status.MentionIDs,
|
|
|
|
)
|
2022-11-18 18:28:33 +01:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("error populating status mentions: %w", err)
|
2022-11-18 18:28:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if !status.EmojisPopulated() {
|
|
|
|
// Status emojis are out-of-date with IDs, repopulate.
|
|
|
|
status.Emojis, err = s.state.DB.GetEmojisByIDs(
|
|
|
|
ctx, // these are already barebones
|
|
|
|
status.EmojiIDs,
|
|
|
|
)
|
2022-11-18 18:28:33 +01:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("error populating status emojis: %w", err)
|
2022-11-18 18:28:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) PutStatus(ctx context.Context, status *gtsmodel.Status) db.Error {
|
2023-03-04 00:02:23 +01:00
|
|
|
err := s.state.Caches.GTS.Status().Store(status, func() error {
|
2022-11-15 19:45:15 +01:00
|
|
|
// It is safe to run this database transaction within cache.Store
|
|
|
|
// as the cache does not attempt a mutex lock until AFTER hook.
|
|
|
|
//
|
|
|
|
return s.conn.RunInTx(ctx, func(tx bun.Tx) error {
|
|
|
|
// create links between this status and any emojis it uses
|
|
|
|
for _, i := range status.EmojiIDs {
|
|
|
|
if _, err := tx.
|
|
|
|
NewInsert().
|
|
|
|
Model(>smodel.StatusToEmoji{
|
|
|
|
StatusID: status.ID,
|
|
|
|
EmojiID: i,
|
2023-03-02 16:58:23 +01:00
|
|
|
}).
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("emoji_id")).
|
|
|
|
Exec(ctx); err != nil {
|
2022-11-15 19:45:15 +01:00
|
|
|
err = s.conn.ProcessError(err)
|
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
// create links between this status and any tags it uses
|
|
|
|
for _, i := range status.TagIDs {
|
|
|
|
if _, err := tx.
|
|
|
|
NewInsert().
|
|
|
|
Model(>smodel.StatusToTag{
|
|
|
|
StatusID: status.ID,
|
|
|
|
TagID: i,
|
2023-03-02 16:58:23 +01:00
|
|
|
}).
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("tag_id")).
|
|
|
|
Exec(ctx); err != nil {
|
2022-11-15 19:45:15 +01:00
|
|
|
err = s.conn.ProcessError(err)
|
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
// change the status ID of the media attachments to the new status
|
|
|
|
for _, a := range status.Attachments {
|
|
|
|
a.StatusID = status.ID
|
|
|
|
a.UpdatedAt = time.Now()
|
|
|
|
if _, err := tx.
|
|
|
|
NewUpdate().
|
|
|
|
Model(a).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), a.ID).
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
err = s.conn.ProcessError(err)
|
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
// Finally, insert the status
|
|
|
|
_, err := tx.NewInsert().Model(status).Exec(ctx)
|
2022-10-08 13:50:48 +02:00
|
|
|
return err
|
2022-11-15 19:45:15 +01:00
|
|
|
})
|
2021-09-01 11:08:21 +02:00
|
|
|
})
|
2023-03-04 00:02:23 +01:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, id := range status.AttachmentIDs {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// Invalidate media attachments from cache.
|
|
|
|
//
|
|
|
|
// NOTE: this is needed due to the way in which
|
|
|
|
// we upload status attachments, and only after
|
|
|
|
// update them with a known status ID. This is
|
|
|
|
// not the case for header/avatar attachments.
|
2023-03-04 00:02:23 +01:00
|
|
|
s.state.Caches.GTS.Media().Invalidate("ID", id)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2023-03-01 18:52:44 +01:00
|
|
|
func (s *statusDB) UpdateStatus(ctx context.Context, status *gtsmodel.Status, columns ...string) db.Error {
|
|
|
|
status.UpdatedAt = time.Now()
|
|
|
|
if len(columns) > 0 {
|
|
|
|
// If we're updating by column, ensure "updated_at" is included.
|
|
|
|
columns = append(columns, "updated_at")
|
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
if err := s.conn.RunInTx(ctx, func(tx bun.Tx) error {
|
2022-09-12 13:03:23 +02:00
|
|
|
// create links between this status and any emojis it uses
|
|
|
|
for _, i := range status.EmojiIDs {
|
2022-10-08 13:50:48 +02:00
|
|
|
if _, err := tx.
|
|
|
|
NewInsert().
|
|
|
|
Model(>smodel.StatusToEmoji{
|
|
|
|
StatusID: status.ID,
|
|
|
|
EmojiID: i,
|
2023-03-02 16:58:23 +01:00
|
|
|
}).
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("emoji_id")).
|
|
|
|
Exec(ctx); err != nil {
|
2022-11-15 19:45:15 +01:00
|
|
|
err = s.conn.ProcessError(err)
|
2022-09-12 13:03:23 +02:00
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// create links between this status and any tags it uses
|
|
|
|
for _, i := range status.TagIDs {
|
2022-10-08 13:50:48 +02:00
|
|
|
if _, err := tx.
|
|
|
|
NewInsert().
|
|
|
|
Model(>smodel.StatusToTag{
|
|
|
|
StatusID: status.ID,
|
|
|
|
TagID: i,
|
2023-03-02 16:58:23 +01:00
|
|
|
}).
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("tag_id")).
|
|
|
|
Exec(ctx); err != nil {
|
2022-11-15 19:45:15 +01:00
|
|
|
err = s.conn.ProcessError(err)
|
2022-09-12 13:03:23 +02:00
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
// change the status ID of the media attachments to the new status
|
2022-09-12 13:03:23 +02:00
|
|
|
for _, a := range status.Attachments {
|
|
|
|
a.StatusID = status.ID
|
|
|
|
a.UpdatedAt = time.Now()
|
2022-10-08 13:50:48 +02:00
|
|
|
if _, err := tx.
|
|
|
|
NewUpdate().
|
|
|
|
Model(a).
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), a.ID).
|
2022-09-12 13:03:23 +02:00
|
|
|
Exec(ctx); err != nil {
|
2022-11-15 19:45:15 +01:00
|
|
|
err = s.conn.ProcessError(err)
|
|
|
|
if !errors.Is(err, db.ErrAlreadyExists) {
|
|
|
|
return err
|
|
|
|
}
|
2022-09-12 13:03:23 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-03-02 16:58:23 +01:00
|
|
|
// Finally, update the status
|
2022-11-15 19:45:15 +01:00
|
|
|
_, err := tx.
|
2022-10-08 13:50:48 +02:00
|
|
|
NewUpdate().
|
|
|
|
Model(status).
|
2023-03-01 18:52:44 +01:00
|
|
|
Column(columns...).
|
2022-10-08 13:50:48 +02:00
|
|
|
Where("? = ?", bun.Ident("status.id"), status.ID).
|
2022-11-15 19:45:15 +01:00
|
|
|
Exec(ctx)
|
|
|
|
return err
|
|
|
|
}); err != nil {
|
2023-03-04 00:02:23 +01:00
|
|
|
// already processed
|
2022-11-15 19:45:15 +01:00
|
|
|
return err
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2022-09-12 13:03:23 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// Invalidate status from database lookups.
|
|
|
|
s.state.Caches.GTS.Status().Invalidate("ID", status.ID)
|
|
|
|
|
2023-03-04 00:02:23 +01:00
|
|
|
for _, id := range status.AttachmentIDs {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// Invalidate media attachments from cache.
|
|
|
|
//
|
|
|
|
// NOTE: this is needed due to the way in which
|
|
|
|
// we upload status attachments, and only after
|
|
|
|
// update them with a known status ID. This is
|
|
|
|
// not the case for header/avatar attachments.
|
2023-03-04 00:02:23 +01:00
|
|
|
s.state.Caches.GTS.Media().Invalidate("ID", id)
|
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
return nil
|
2022-09-12 13:03:23 +02:00
|
|
|
}
|
|
|
|
|
2022-09-21 19:55:52 +02:00
|
|
|
func (s *statusDB) DeleteStatusByID(ctx context.Context, id string) db.Error {
|
2022-11-15 19:45:15 +01:00
|
|
|
if err := s.conn.RunInTx(ctx, func(tx bun.Tx) error {
|
2022-09-21 19:55:52 +02:00
|
|
|
// delete links between this status and any emojis it uses
|
|
|
|
if _, err := tx.
|
|
|
|
NewDelete().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_to_emojis"), bun.Ident("status_to_emoji")).
|
|
|
|
Where("? = ?", bun.Ident("status_to_emoji.status_id"), id).
|
2022-09-21 19:55:52 +02:00
|
|
|
Exec(ctx); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete links between this status and any tags it uses
|
|
|
|
if _, err := tx.
|
|
|
|
NewDelete().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_to_tags"), bun.Ident("status_to_tag")).
|
|
|
|
Where("? = ?", bun.Ident("status_to_tag.status_id"), id).
|
2022-09-21 19:55:52 +02:00
|
|
|
Exec(ctx); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete the status itself
|
|
|
|
if _, err := tx.
|
|
|
|
NewDelete().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
|
|
Where("? = ?", bun.Ident("status.id"), id).
|
2022-09-21 19:55:52 +02:00
|
|
|
Exec(ctx); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
2022-11-15 19:45:15 +01:00
|
|
|
}); err != nil {
|
|
|
|
return err
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2022-09-21 19:55:52 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// Invalidate status from database lookups.
|
2022-12-08 18:35:14 +01:00
|
|
|
s.state.Caches.GTS.Status().Invalidate("ID", id)
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
|
|
|
|
// Invalidate status from all visibility lookups.
|
|
|
|
s.state.Caches.Visibility.Invalidate("ItemID", id)
|
|
|
|
|
2022-10-08 13:50:48 +02:00
|
|
|
return nil
|
2022-09-21 19:55:52 +02:00
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
func (s *statusDB) GetStatusParents(ctx context.Context, status *gtsmodel.Status, onlyDirect bool) ([]*gtsmodel.Status, db.Error) {
|
2022-11-15 19:45:15 +01:00
|
|
|
if onlyDirect {
|
|
|
|
// Only want the direct parent, no further than first level
|
|
|
|
parent, err := s.GetStatusByID(ctx, status.InReplyToID)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
return []*gtsmodel.Status{parent}, nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
var parents []*gtsmodel.Status
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
for id := status.InReplyToID; id != ""; {
|
|
|
|
parent, err := s.GetStatusByID(ctx, id)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Append parent to slice
|
|
|
|
parents = append(parents, parent)
|
|
|
|
|
|
|
|
// Set the next parent ID
|
|
|
|
id = parent.InReplyToID
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-11-15 19:45:15 +01:00
|
|
|
return parents, nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) GetStatusChildren(ctx context.Context, status *gtsmodel.Status, onlyDirect bool, minID string) ([]*gtsmodel.Status, db.Error) {
|
|
|
|
foundStatuses := &list.List{}
|
|
|
|
foundStatuses.PushFront(status)
|
|
|
|
s.statusChildren(ctx, status, foundStatuses, onlyDirect, minID)
|
|
|
|
|
|
|
|
children := []*gtsmodel.Status{}
|
|
|
|
for e := foundStatuses.Front(); e != nil; e = e.Next() {
|
|
|
|
// only append children, not the overall parent status
|
2021-11-22 08:46:19 +01:00
|
|
|
entry, ok := e.Value.(*gtsmodel.Status)
|
|
|
|
if !ok {
|
2023-02-17 12:02:29 +01:00
|
|
|
log.Panic(ctx, "found status could not be asserted to *gtsmodel.Status")
|
2021-11-22 08:46:19 +01:00
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
if entry.ID != status.ID {
|
|
|
|
children = append(children, entry)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return children, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) statusChildren(ctx context.Context, status *gtsmodel.Status, foundStatuses *list.List, onlyDirect bool, minID string) {
|
2022-11-15 19:45:15 +01:00
|
|
|
var childIDs []string
|
2021-08-25 15:34:33 +02:00
|
|
|
|
|
|
|
q := s.conn.
|
|
|
|
NewSelect().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
|
|
Column("status.id").
|
|
|
|
Where("? = ?", bun.Ident("status.in_reply_to_id"), status.ID)
|
2021-08-25 15:34:33 +02:00
|
|
|
if minID != "" {
|
2022-10-08 13:50:48 +02:00
|
|
|
q = q.Where("? > ?", bun.Ident("status.id"), minID)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
2022-07-10 17:18:21 +02:00
|
|
|
if err := q.Scan(ctx, &childIDs); err != nil {
|
|
|
|
if err != sql.ErrNoRows {
|
2023-02-17 12:02:29 +01:00
|
|
|
log.Errorf(ctx, "error getting children for %q: %v", status.ID, err)
|
2022-07-10 17:18:21 +02:00
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2022-07-10 17:18:21 +02:00
|
|
|
for _, id := range childIDs {
|
|
|
|
// Fetch child with ID from database
|
|
|
|
child, err := s.GetStatusByID(ctx, id)
|
|
|
|
if err != nil {
|
2023-02-17 12:02:29 +01:00
|
|
|
log.Errorf(ctx, "error getting child status %q: %v", id, err)
|
2022-07-10 17:18:21 +02:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
insertLoop:
|
|
|
|
for e := foundStatuses.Front(); e != nil; e = e.Next() {
|
2021-11-22 08:46:19 +01:00
|
|
|
entry, ok := e.Value.(*gtsmodel.Status)
|
|
|
|
if !ok {
|
2023-02-17 12:02:29 +01:00
|
|
|
log.Panic(ctx, "found status could not be asserted to *gtsmodel.Status")
|
2021-11-22 08:46:19 +01:00
|
|
|
}
|
|
|
|
|
2021-08-25 15:34:33 +02:00
|
|
|
if child.InReplyToAccountID != "" && entry.ID == child.InReplyToID {
|
|
|
|
foundStatuses.InsertAfter(child, e)
|
|
|
|
break insertLoop
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-09 16:15:25 +02:00
|
|
|
// if we're not only looking for direct children of status, then do the same children-finding
|
|
|
|
// operation for the found child status too.
|
|
|
|
if !onlyDirect {
|
|
|
|
s.statusChildren(ctx, child, foundStatuses, false, minID)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) CountStatusReplies(ctx context.Context, status *gtsmodel.Status) (int, db.Error) {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
|
|
Where("? = ?", bun.Ident("status.in_reply_to_id"), status.ID).
|
|
|
|
Count(ctx)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) CountStatusReblogs(ctx context.Context, status *gtsmodel.Status) (int, db.Error) {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
|
|
Where("? = ?", bun.Ident("status.boost_of_id"), status.ID).
|
|
|
|
Count(ctx)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) CountStatusFaves(ctx context.Context, status *gtsmodel.Status) (int, db.Error) {
|
2022-10-08 13:50:48 +02:00
|
|
|
return s.conn.
|
|
|
|
NewSelect().
|
|
|
|
TableExpr("? AS ?", bun.Ident("status_faves"), bun.Ident("status_fave")).
|
|
|
|
Where("? = ?", bun.Ident("status_fave.status_id"), status.ID).
|
|
|
|
Count(ctx)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) IsStatusFavedBy(ctx context.Context, status *gtsmodel.Status, accountID string) (bool, db.Error) {
|
|
|
|
q := s.conn.
|
|
|
|
NewSelect().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_faves"), bun.Ident("status_fave")).
|
|
|
|
Where("? = ?", bun.Ident("status_fave.status_id"), status.ID).
|
|
|
|
Where("? = ?", bun.Ident("status_fave.account_id"), accountID)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-08-29 16:41:41 +02:00
|
|
|
return s.conn.Exists(ctx, q)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) IsStatusRebloggedBy(ctx context.Context, status *gtsmodel.Status, accountID string) (bool, db.Error) {
|
|
|
|
q := s.conn.
|
|
|
|
NewSelect().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
|
|
Where("? = ?", bun.Ident("status.boost_of_id"), status.ID).
|
|
|
|
Where("? = ?", bun.Ident("status.account_id"), accountID)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-08-29 16:41:41 +02:00
|
|
|
return s.conn.Exists(ctx, q)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) IsStatusMutedBy(ctx context.Context, status *gtsmodel.Status, accountID string) (bool, db.Error) {
|
|
|
|
q := s.conn.
|
|
|
|
NewSelect().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_mutes"), bun.Ident("status_mute")).
|
|
|
|
Where("? = ?", bun.Ident("status_mute.status_id"), status.ID).
|
|
|
|
Where("? = ?", bun.Ident("status_mute.account_id"), accountID)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-08-29 16:41:41 +02:00
|
|
|
return s.conn.Exists(ctx, q)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) IsStatusBookmarkedBy(ctx context.Context, status *gtsmodel.Status, accountID string) (bool, db.Error) {
|
|
|
|
q := s.conn.
|
|
|
|
NewSelect().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_bookmarks"), bun.Ident("status_bookmark")).
|
|
|
|
Where("? = ?", bun.Ident("status_bookmark.status_id"), status.ID).
|
|
|
|
Where("? = ?", bun.Ident("status_bookmark.account_id"), accountID)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-08-29 16:41:41 +02:00
|
|
|
return s.conn.Exists(ctx, q)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (s *statusDB) GetStatusReblogs(ctx context.Context, status *gtsmodel.Status) ([]*gtsmodel.Status, db.Error) {
|
|
|
|
reblogs := []*gtsmodel.Status{}
|
|
|
|
|
2022-10-08 13:50:48 +02:00
|
|
|
q := s.
|
|
|
|
newStatusQ(&reblogs).
|
|
|
|
Where("? = ?", bun.Ident("status.boost_of_id"), status.ID)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2021-11-22 08:46:19 +01:00
|
|
|
if err := q.Scan(ctx); err != nil {
|
2021-08-29 16:41:41 +02:00
|
|
|
return nil, s.conn.ProcessError(err)
|
|
|
|
}
|
|
|
|
return reblogs, nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|