be676ad93c
Merge pull request #3371 from mauriciocolli/feed-hide-played-items
...
Add ability to hide played items in a feed
2021-06-18 09:18:48 +02:00
d6decc05d7
Move some classes to a new subpackage and adress requested changes
...
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
2021-06-11 12:12:02 +02:00
d85afd6435
Initial work to add the image of the content in the share sheet
...
Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
2021-06-11 12:12:00 +02:00
0113ad5e14
Correctly save stream progress at the end of a video
2021-06-09 15:53:51 +02:00
360f5ac6f7
Save playback state even if stream is finished and add isFinished()
2021-06-09 15:53:51 +02:00
56cd84c1fe
Merge pull request #6444 from TeamNewPipe/increasebufferafterdepletion
...
Increase buffer for playback after rebuffer
2021-06-08 17:02:18 +02:00
bede758507
Use url at current time for long click on player share button
2021-06-08 14:34:51 +02:00
5532666ad5
Long press on player share button to copy url to clipboard
2021-06-08 14:23:33 +02:00
3b0045917c
Increase buffer for playback after rebuffer
2021-06-07 09:25:49 +02:00
a102fc9cad
Use constraint layout for play queue item
...
Also remove invalid ic_selected attribute
2021-06-07 08:07:27 +02:00
d921e2e61b
Hide queue duration when displaying segment panel
...
Fixes #6441
2021-06-07 02:10:44 +01:00
98fdbec442
Fix playback speed not being updated in PlayQueuAcitvity
...
Fixes #6419
2021-06-05 12:24:59 +02:00
2e161a1f45
Change shuffle() guard to check for size <= 2
...
After testing the app, I realized that shuffling a queue with size 2
does nothing
2021-05-24 12:20:19 -04:00
5ab6e84044
Remove redundant clearing of list
2021-05-24 12:20:19 -04:00
e1a6347c4e
Refactor shuffle and update documentation
...
- Add early return for invalid sizes to shuffle
- Rename variables to be more descriptive
- Refactor moving list element, removing unnecessary operations
- Unwrap if clause for adding to history because the condition is
guaranteed by the guard clause
- Inline the value 0 for the ReorderEvent
- Update documentation to reflect new changes
2021-05-24 12:20:19 -04:00
92a67bb8cb
Rearrange fields
...
Final fields should be arranged first
2021-05-24 12:20:19 -04:00
e8eeac6735
Resolve TODO in indexOf(...)
...
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
2021-05-24 12:20:19 -04:00
775fbc9a75
Rewrite setIndex(int) to pass unit tests
...
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.
There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
2021-05-24 12:20:19 -04:00
8efe2859b8
Refactor assignments to field declaration
...
Assignments that don't require the constructor can be moved out.
2021-05-24 12:20:19 -04:00
441c68ead2
Add hashCode() to match equals(other)
2021-05-24 12:20:19 -04:00
4cd1f201f5
Refactor streams to initialize with values
2021-05-24 12:20:19 -04:00
013c59f904
Refactor ArrayList fields to List
2021-05-24 12:20:19 -04:00
57474e2dab
Refactor and optimize equals
...
- Remove multiple casts of obj
- Simply use object equals on the streams because PlayQueueItem’s
equals already compares urls
2021-05-24 12:20:19 -04:00
87d2f33e55
Add support for PeerTube HLS streams
2021-05-23 11:53:35 +02:00
95f61542b5
TEST: Downgrade ExoPlayer to 2.12
2021-05-14 14:47:53 +02:00
98ccd577d6
Fixed checkstyle
2021-05-14 12:15:48 +02:00
1d43a2362c
Add debug option to disable media tunneling
2021-05-14 12:05:52 +02:00
31ea44ccf1
Fixed player not automatically playing ( #6266 )
...
* Fixed player not automatically playing
Should also fix https://github.com/TeamNewPipe/NewPipe/issues/6179
* Added comment
2021-05-12 10:20:39 +02:00
c85b97a484
Fix: fragmentSize is below the minimum ( #6238 )
...
noticed logs " CacheDataSink: fragmentSize is below the minimum recommended value of 2097152. This may cause poor cache performance.
this fixes the issue by using ExoPlayers MIN_RECOMMENDED_FRAGMENT_SIZE. Unfortunately that field is private:
aeb306a164/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSink.java (L123)
2021-05-04 19:08:25 +02:00
b54c2b7f57
Fix invisible buffering / loading indicator in player
2021-04-25 11:36:00 +02:00
3fcd580491
Add queue time ( #6023 )
...
* Add queue time
2021-04-08 10:41:41 +02:00
e484339cca
Merge branch 'dev' into daynight
2021-04-03 00:08:26 +03:00
c9766d25ef
Rename related streams to related items
2021-03-31 22:33:22 +02:00
4a9d21062a
Disabled tunneling on Hi3798MV200
2021-03-31 16:38:50 +02:00
5739caaa5a
Merge pull request #5856 from Redirion/exo213
...
Update to ExoPlayer 2.13.2
2021-03-31 14:29:16 +02:00
73cfa5499d
Fix overlapping fonts and crash on tapping anywhere on video after long-pressing 'Popup' button ( #5813 )
...
* Overlapping fonts #5096
issue : #5096
* Overlapping fonts #5096
issue : #5096
changed :
- If additional textView is overlapped, only title view shows.
* Overlapping fonts #5096
issue : #5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.
* Overlapping fonts #5096
issue : #5096
changed :
- remove unusable variable
* Crash on tapping anywhere on video after long-pressing 'Popup' button #5804
issue : #5804
changed :
- checked null
- fixed NullPointerException.
2021-03-31 10:10:14 +02:00
83d16932a4
Update to ExoPlayer 2.13.2
2021-03-31 10:05:44 +02:00
84de865daf
Allow the user to pause while a video is buffering ( #5929 )
...
Fix pause while buffering
Use getPlayWhenReady wrapper everywhere playWhenReady is checked
Remove duplicate `playPause()` code
2021-03-29 18:00:00 +02:00
80d1c5b9f5
Fix Repeat Button color in Player
2021-03-28 22:04:54 +03:00
0afdac5683
Fix Light Player Popups in Dark Theme, make Player Controls Overlay always Dark
2021-03-28 18:48:51 +03:00
fd14c8cdce
Fix Dark elements in Light Theme
2021-03-27 17:46:05 +03:00
86381696f4
Merge pull request #5457 from Redirion/exo123
...
Update to ExoPlayer 2.12.3
2021-03-18 18:59:56 +01:00
feb65cf8f3
Merge pull request #5792 from TeamNewPipe/resize_mode
...
Fix last resize mode not being restored correctly
2021-03-17 09:07:44 +01:00
71d3227791
Fix bottom controls being out of the screen
...
This was caused by too large end screen thumbnails enlarging the whole palyer. Fixed by scaling the thumbnail.
Ensure that the player does not use the whole screen height in detail fragment to keep the additional content like title, comments, etc. available.
2021-03-14 17:52:15 +01:00
86fa629591
Fix last resize mode not being restored correctly
...
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone thought while working on the resize mode switcher, that the old (to be replaced) resize mode should be stored.
Fixes #5613
2021-03-08 09:46:33 +01:00
8978187c64
Improve code style and fix some warnings
...
Removed a textTrack null check on a now- NonNull method
Added a error type switch case (TIMEOUT)
2021-02-16 16:54:44 +01:00
eba0b07782
Update to ExoPlayer 2.12.3
2021-02-16 16:42:51 +01:00
156d7139fa
removed resizig text from popup player, as requested in #5514
2021-02-11 11:20:27 +01:00
fdb0f01b38
Add Objects.requireNotNull to warning which is surely not null
2021-01-28 14:35:47 +01:00
376cba696e
Remove useless getString for default setting value
2021-01-28 14:35:00 +01:00
cade272501
Use PlayerHelper.retrieveResizeModeFromPrefs in Player
2021-01-28 14:33:50 +01:00
4f828fbe00
Fix always minimizing to popup player
2021-01-28 14:33:12 +01:00
e327f7ba2c
Fix popup closing x button animation
2021-01-19 09:34:21 +01:00
23b5cd5b72
Merge pull request #5442 from Stypox/fix-close-popup
...
Prevent IllegalArgumentException when closing popup
2021-01-18 09:39:02 +01:00
d4a33603ab
Prevent IllegalArgumentException when closing popup
2021-01-18 08:27:49 +01:00
4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility
2021-01-17 15:34:24 +01:00
fe92abde0e
Use view binding in VideoDetailFragment.
2021-01-17 09:57:40 +05:30
79e98db3bd
Apply the requested changes and little improvements
...
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
920e560b4b
Convert AnimationUtils functions to extension functions.
2021-01-16 14:49:37 +05:30
37aa41afae
Add stream segments to player
2021-01-14 21:58:19 +01:00
059bb7622d
Merge and rename into PlayQueueActivity
2021-01-14 10:25:48 +01:00
cece83328a
Fix wrong speed indicator in queue activity
2021-01-14 10:25:48 +01:00
f6e2dd1480
Merge player classes into a single one
2021-01-14 10:25:44 +01:00
fa75c79d34
Use view binding (PlayerPopupCloseOverlayBinding) in VideoPlayerImpl.
2021-01-13 20:44:00 +01:00
0c86a4e608
Use view binding (PlayerBinding) in VideoPlayer.
2021-01-13 20:43:56 +01:00
92a87a5ed2
Merge pull request #5310 from khimaros/list-play-kodi
...
add list item to play video on kodi
2021-01-13 17:02:56 +01:00
907106156f
When in Fullscreen playback mode, toggle play/pause with the hardware Space button.
2021-01-07 17:32:16 +02:00
ac59382b84
pass serviceId instead of item, reduce duplication
2021-01-02 11:24:33 -08:00
1b4bde4e78
Merge pull request #5221 from B0pol/notifications
...
Dynamically get package name
2021-01-01 18:05:43 +01:00
ce2719d77e
Merge pull request #5317 from XiangRongLin/timestamp
...
Fix urls with timestamps not being played
2020-12-31 12:46:40 +01:00
8193a0df63
Merge pull request #5065 from TacoTheDank/androidx-media-audioreactor
...
Use AndroidX Media compat in AudioReactor
2020-12-31 10:55:11 +01:00
ebd589c9cb
Use AndroidX Media compat in AudioReactor
2020-12-30 17:10:57 -05:00
1f15368b7b
Fix urls with timestamps not being played
...
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
2020-12-30 21:07:30 +01:00
0a05534c84
Fix null pointer exception in play button method
...
When the play queue was null, and this method was called a null pointer
exception would be thrown. This change adds an additional check to see
if the play queue is not null before making additional changes.
2020-12-29 14:51:24 -05:00
b2e9981313
Fix queue display in ServicePlayerActivity.
2020-12-23 20:06:02 +05:30
2b8837609b
dynamically get package name
...
it fixes issues with forks or debug builds, e.g. when you open two newpipe apps (with debug or fork apps), close one notification, it closes all newpipe notifications
fixes https://github.com/TeamNewPipe/NewPipe/issues/4653
2020-12-20 13:52:20 +01:00
7a7a90bf79
remove timestamp from share url for all services except youtube
...
It produces not found error for PeerTube, media.ccc.de, SoundCloud
2020-12-20 10:53:22 +01:00
0fe3fe7594
Use ServiceCompat.stopForeground().
2020-12-19 16:52:17 +05:30
e6021465f6
Use view binding in ServicePlayerActivity.
2020-12-19 04:21:59 +05:30
807e4d4af9
Use ActivityCompat.recreate().
2020-12-15 13:55:05 +05:30
db9f20a22f
Merge pull request #4961 from TeamNewPipe/lint
...
Fix some Lint errors
2020-12-07 11:19:01 +01:00
b66047e084
Fix ktlint errors
2020-11-22 14:03:10 +01:00
f0ca916432
Update most dependencies
2020-11-22 14:03:10 +01:00
7a8dab2d58
Fix typos
2020-11-22 10:39:00 +01:00
b5321152fd
Player gestures: Fix respecting brightness-volume-gesture settings
2020-11-20 21:08:02 +01:00
06b7072240
Merge pull request #4642 from XiangRongLin/hide_thumbnail
...
Add option to hide thumbnail on lock screen
2020-11-20 16:35:10 +01:00
2669ba944d
Correct some other small lints
2020-11-19 18:54:27 -05:00
0274cd6beb
Lint: Inner class may be static
2020-11-18 18:02:33 -05:00
39e5d8ccc2
Lint: Make a bunch of stuff final
2020-11-18 17:50:00 -05:00
ea5939c1b7
Kotlin lint fixing
2020-11-18 17:45:19 -05:00
7476498823
[Regression] Revert "Removed remember popup properties setting"
...
This reverts commit 314615bfef
2020-11-15 22:24:27 +01:00
7805f8a9b1
Add option to hide thumbnail on lock screen and inside notification
2020-11-14 10:01:07 +01:00
617ee0afc0
Fix brightness and volume scroll swapped
2020-11-08 10:00:28 +01:00
1b47a1a994
Fix switching to main player when MainActivity is closed
2020-11-08 10:00:28 +01:00
5a87cfc25d
Open mini player if player running on app open
2020-11-08 10:00:28 +01:00
2a2c82e73b
More fixes with opening VideoDetailFragment
2020-11-08 10:00:28 +01:00
1d42e45d78
Unify all ways of opening VideoDetailFragment
2020-11-08 10:00:27 +01:00
f4435f9031
Merge pull request #4555 from Stypox/playqueue-crash
...
Fix NullPointerException in queue handling
2020-11-08 01:19:38 +01:00
f1583b6e0c
Merge pull request #4587 from vkay94/separate-player-gesture-logic-ui
...
Separate player gesture logic and UI
2020-11-02 16:36:50 +01:00
347566c311
Player gestures: Add multi-double-tap logic
2020-11-02 15:50:34 +01:00
974f8f692c
Add option to not colorize notification
2020-11-01 22:13:00 +01:00
31cffa68c5
Push conditionals inside branch expressions
2020-10-31 15:57:26 -04:00
2683043762
Player gestures: separate logic and UI
2020-10-29 12:46:34 +01:00
e406b6f780
Fix NullPointerException in queue handling
2020-10-26 18:15:59 +01:00
32a142bf79
Fix PlaylistAppendDialog: Renamed method and replaced with Runnable
2020-10-23 09:44:26 +02:00
2680d41a3d
Fix PlaylistAppendDialog showing when no local playlists exist
2020-10-23 09:44:26 +02:00
941028ba6f
Don't rearrange lists by dragging the thumbnails
2020-10-17 16:25:06 +02:00
ae33c6cf18
Merge pull request #4476 from vkay94/two-finger-to-close-player
...
Two finger to close player gesture
2020-10-11 14:51:45 +02:00
f8cd6afbf8
Two finger gesture: Less code lines
2020-10-11 13:56:30 +02:00
f6925fc5b8
Added two finger to close player gesture
2020-10-10 15:00:39 +02:00
58b720b004
Use ContextCompat.getSystemService() and the Context.getSystemService() extension function.
2020-10-09 08:52:05 +05:30
314615bfef
Removed remember popup properties setting
2020-10-06 18:32:20 -04:00
44e82217c1
Merge pull request #4425 from vkay94/enqueue-stream
...
Replace specific enqueue options with one
2020-10-06 22:37:19 +02:00
12f615c6da
Enqueue: Removed unneeded dialog-entries and strings + adjustments
2020-10-06 17:22:12 +02:00
ed6fc4d848
Enqueue: Replaced specific StreamDialogEntry items with one
...
The enqueue options won't be shown in the dialogs if the Player service is not running. When it's running one item (enqueue stream) will be shown and enqueues the item into the Player type which is currently selected.
2020-10-06 14:38:48 +02:00
cd515993f5
Enqueue: Add auto-select StreamDialogEntry for current PlayerType
2020-10-06 13:33:44 +02:00
9f63e2d39a
Merge pull request #4410 from Stypox/notification-fixes
...
Notification fixes
2020-10-05 19:08:26 +02:00
a88f5113e0
Hide player notification "when" time
...
It is useless to see how much time ago a player notification was created
2020-10-05 15:57:14 +02:00
06fb89fae2
Fix crash on fast forward
2020-10-05 15:55:10 +02:00
63d54e6570
Use DisplayCutoutCompat in VideoPlayerImpl.
2020-10-04 05:44:13 +05:30
83ea91586b
Merge pull request #4362 from Stypox/fix-queue
...
Random fixes and improvements
2020-10-02 16:48:04 +02:00
794c74e514
Merge pull request #4360 from avently/player-overlays
...
Player overlays now centered
2020-10-02 15:37:28 +02:00
fbcdaa77e3
Initialize player notification asap
...
Otherwise Android's foreground services implementation would complain
2020-10-02 15:17:04 +02:00
4e7632949d
Merge pull request #4347 from avently/player-rebind
...
Player rebind
2020-10-01 15:03:43 +02:00
26a8bd147b
Now player's overlays are aware of insets
2020-10-01 03:10:51 +03:00
dd726fac02
Skipped interception of buttons in the player in some cases and made image view from playQueue visible
2020-10-01 03:10:42 +03:00
f4bd20361a
Fix auto-queue with no next videos
2020-09-29 10:43:17 +02:00
c1d5a5cd98
Player will be rebound when needed, prev/next/queue buttons, preserving paused state
...
- each time something starts to play in any player VideoDetailFragment will be started (if not yet started) and mini player will show up. It makes possible to see a playing stream in mini player even if the stream was started without using fragment or after player service was closed somehow
- play/next/queue buttons will be updated in realtime when stream was added/removed from queue instead of waiting for a onPlay/onPause action to happen
- when popup or background players start the stream will start playing only if paused state wasn't requested. Which means, for example, if a user opens popup it will be started when START_PAUSED is false. If, for example, the stream was played in main player and then popup was started the stream will still be playing, but if it was paused it still be paused in popup (or background) in APPEND_ONLY mode (but will be playing on new queue initialization)
2020-09-29 06:22:53 +03:00
0370fa6c00
Merged 'dev' branch
2020-09-27 18:02:31 +03:00
e53e5ca20e
Disabled nested scrolling of queue
2020-09-27 15:50:21 +03:00
609bf64856
Merged 'dev' branch
2020-09-27 15:04:20 +03:00
d5f603303d
Merge pull request #4259 from TeamNewPipe/pref_migration
...
Add settings migration, remove "Detail page" option from share dialog and minimize to background by default
2020-09-27 11:20:39 +02:00
fc9c073a60
Merge pull request #3178 from cool-student/notificationImprovements
...
Notification Improvements
2020-09-27 10:43:11 +02:00
9a0c2c40bd
Refactoring and made the player returning from landscape & fullscreen on vertical video to portrait after clicking on fullscreen button
2020-09-27 06:39:42 +03:00
df9823988e
Changes for tablets and device's orientation behavior
...
- the app will not rotate the screen to portrait after video completes, it will just exit from fullscreen mode
- ability to rotate the orientation via fullscreen button from landscape to portrait when device has locked orientation in landscape
- ability to enter/exit to/from fullscreen on tablets with unlocked global orientation in portrait mode
2020-09-27 04:11:38 +03:00
0e5f85db95
Remove "Detail Page" open action from share dialog under certain circumstances
...
With the new application workflow and unified player, video detail page and video player are the same activity. So show only one of these options based on whether autoplay is enabled or not, and show both if using external player
2020-09-26 21:58:34 +02:00
3add24b8aa
Merged 'dev' branch
2020-09-26 02:42:26 +03:00
e0f02d4080
Merge pull request #4246 from avently/preloading
...
Disabled preloading when switching streams
2020-09-25 21:22:31 +02:00
c843e77183
Made notification thumbnail smaller
2020-09-23 15:20:25 +03:00
b4e073cde7
Show replay icon in notification when player state is completed
2020-09-22 18:17:16 +02:00
814efbf8df
Remove ACTION_BUFFERING, update buffering only if needed
...
- ACTION_BUFFERING was just wrong: why should the user be able to trigger the internal onBuffering() state by pressing on the buffering button? So that was replaced by a null intent, doing nothing.
- Now updating notification in onBuffering() only when buffering actions are not already buffering, to prevent useless updates
2020-09-22 18:17:16 +02:00
11e048abb1
Remove hardcoded and duplicate strings, use exoplayer ones
2020-09-22 18:17:09 +02:00
518eb97e3a
Variable width for caption button and hiding system UI after popup close
2020-09-19 22:52:59 +03:00
f41549ccf1
Added a comment and excluded automatic switch of orientation on tablets and Android TVs
2020-09-19 17:21:01 +03:00
5b8eda4805
Increased performance of the UI. main thread is not as busy as before
2020-09-17 23:42:35 +03:00
886a949a00
Enable/disable video after screen on/off regardless of background playback setting
2020-09-17 22:30:03 +03:00
92e13dafe5
Correct exit from fullscreen in case of error or close from notification,
2020-09-17 19:01:20 +03:00
c9be812330
Fix for untouchable area
2020-09-16 23:41:49 +03:00
59e7ebabfa
Random adjustements to notification
2020-09-16 14:00:22 +02:00
5ada0ae2c7
Hiding controls when orientation changes to landscape
2020-09-15 22:10:38 +03:00
Tobi
TiA4f8R
Stypox
Abanoub Sameh
Robin
Douile
Zhiheng Xu
Robin
litetex
krlvm
Fynn Godau
wangear
karol
XiangRongLin
Isira Seneviratne
vkay94
Mikhail Barashkov
khimaros
TacoTheDank
Eric Lemieux
bopol
Panorea
Avently
wb9688