70354eb73e
Add play next to long press menu & refactor enqueue methods ( #6872 )
...
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings
* changed line length for checkstyle pass
* cleaned comments, moved strings
* Update app/src/main/res/values/strings.xml
to make long press entry more descriptive
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Update app/src/main/res/values/strings.xml
Co-authored-by: Stypox <stypox@pm.me>
* replace redundant nextOnVideoPlayer methods
Co-authored-by: Stypox <stypox@pm.me>
* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments
* removed deprecated methods
removed redundant methods
* removed deprecated methods
removed redundant methods
* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods
* now works with playlists
* renamed dialog entry
* checking for >1 items in the queue using the PlayerHolder
* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)
* corrected strings
* improve getQueueSize in PlayerHolder
* long press to enqueue only if queue isnt empty
* add Whitespace
Co-authored-by: Stypox <stypox@pm.me>
* clarify comments / add spaces
* PlayerType as parameter of the enqueueOnPlayer method
add Helper method
* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle
* assimilated the enqueue*OnPlayer methods
* removed redundant comment, variable
* simplify code line
Co-authored-by: Stypox <stypox@pm.me>
* move if
* replace workaround for isPlayerOpen()
Co-authored-by: Stypox <stypox@pm.me>
* replaced workarounds (getType), corrected static access with getInstance
* remove unused imports
* changed method call to original, new method doesnt exist yet.
* Use getter method instead of property access syntax.
* improve conditional for play next entry
Co-authored-by: Stypox <stypox@pm.me>
* show play next btn in feed fragment
Co-authored-by: Stypox <stypox@pm.me>
* add play next to local playlist and statistics fragment
Co-authored-by: Stypox <stypox@pm.me>
* formating
Co-authored-by: Stypox <stypox@pm.me>
* correcting logic
Co-authored-by: Stypox <stypox@pm.me>
* remove 2 year old unused string, formating
Co-authored-by: Stypox <stypox@pm.me>
* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.
* remove player open checks from button long press enqueue actions
* improve log msg
* Rename next to enqueue_next
* Refactor kotlin
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
a2887034a6
Merge pull request #7068 from litetex/fix-restart
...
Fixed restarting not working properly
2021-09-11 12:51:38 +02:00
7eb5aa1bc5
Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
...
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
892b4a15f6
Change player progress bar update from 500 ms to 1 s
...
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062 , this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00
fda0a550fd
Fixed the app restarting not working properly
...
* Using [``process-phoenix``](https://github.com/JakeWharton/ProcessPhoenix )
2021-09-06 20:47:44 +02:00
4d51ebc37a
Fix a few SonarLint warnings
2021-09-05 19:54:28 +02:00
433c6dc33b
Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
...
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
ed4fdadd4d
Fix OnErrorNotImplementedException in playOnPopup
2021-09-05 19:54:28 +02:00
298e96b821
Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
...
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
8dd617fc6b
Merge pull request #7043 from Stypox/optimize-resources
...
Remove unused resources
2021-09-04 20:57:07 +02:00
3a09039b93
Remove unused resources
2021-09-02 21:13:54 +02:00
669a35bc78
check immediately for updates if user enables 'check for updates setting'
...
- Convert CheckForNewAppVersion to IntentService
- reset expire date to 0 after user enables check for updates setting
2021-09-02 07:20:35 +02:00
ed408b2094
Move fullscreen-related comments to javadocs
2021-09-01 20:13:27 +02:00
3bc661f583
Fix null pointer exception in player initialization
2021-09-01 20:13:27 +02:00
cf9b482be2
Completely close player when changing stream w/o autoplay
2021-09-01 20:13:27 +02:00
1d935b46f9
Open fullscreen when switching from popup to main player
2021-09-01 20:13:24 +02:00
520ac2e935
Fix bottom sheet state after automatic fullscreen
2021-09-01 20:12:14 +02:00
c6316abbce
Fix opening directly fullscreen on tablets
2021-09-01 20:12:09 +02:00
2dfe837c35
Extract isLandscape and isInMultiWindow to DeviceUtils
2021-09-01 20:09:08 +02:00
3c2ea7697c
Add option to directly open fullscreen when the main player starts
2021-09-01 20:08:37 +02:00
faa7a91764
Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
...
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
f629a4d206
Merge pull request #6993 from Redirion/closeaudioeffectsession
...
Close audio effect control session properly
2021-08-31 12:37:20 +02:00
4b7c37e919
Merge pull request #6955 from ktprograms/queue-long-press-menu
...
Show popup menu when long pressing in play queue (Full screen player)
2021-08-31 12:22:59 +02:00
f8f2dfce4b
Merge pull request #6882 from talanc/dev
...
Add support for CSV+ZIP subscriptions (Google Takeout)
2021-08-31 12:10:12 +02:00
5284072b8d
Improve mime type deduction on subscription import
2021-08-31 12:07:34 +02:00
e603dddc54
Added support for CSV+ZIP subscriptions
...
Updated import instructions string
2021-08-31 12:07:34 +02:00
a555aab3e7
Merge pull request #7024 from Stypox/string-fixes
...
Never use ``android.R.string``s; remove unused ``add`` string
2021-08-31 12:00:07 +02:00
88f1c3a808
Merge pull request #6985 from litetex/set-seekbarjump-when-using-dpad-to-seek-duration-from-preferences
...
Set ``KeyProgressIncrement`` manually / Fix long seekbar jumps when using a DPad
2021-08-30 23:36:29 +02:00
0e6668636d
Merge pull request #6986 from litetex/fix-build-problems-update-kotlin
...
Fix build problems and updated kotlin
2021-08-30 21:20:45 +02:00
cfdcb92fa3
Always use our strings, not android ones
2021-08-30 16:37:01 +02:00
039bd5d413
Rename string finish to ok, as its content was "OK"
2021-08-30 16:36:57 +02:00
57ca281c80
Merge pull request #6634 from Isira-Seneviratne/Use_PackageInfoCompat
...
Use PackageInfoCompat.getSignatures().
2021-08-29 23:13:12 +02:00
703f1550d8
Fixed double tapping the replay button
2021-08-29 17:53:09 +02:00
8bfd380b89
Merge pull request #6515 from Redirion/buffersharmonization
...
Use ExoPlayer default values for buffers
2021-08-29 17:44:43 +02:00
43e91ae4ae
Added plural forms for download related strings ( #6930 )
...
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-08-29 13:28:01 +02:00
d931d058d9
Reworked the ErrorPanel
...
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown
* Added a method to ensure the above
* This deduplicates a lot of code
* Fixed format of some LoC
* Added new method: ``showAndSetErrorButtonAction``
* Fixed ``showTextError``
* Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
2021-08-28 17:05:12 +02:00
d9086300f3
Re-add sharing of the content name with the "Share" command ( #6957 )
...
The title of the content is re-added as the EXTRA_SUBJECT of the share intent.
2021-08-27 19:26:32 +02:00
f18a7c91ca
Suppressed warning
...
There seems to be a bug in the kotlin plugin as it tells you when building that this can't be null:
"Condition 'throwable != null' is always 'true'"
However it can indeed be null as seen in https://github.com/TeamNewPipe/NewPipe/pull/6986#issuecomment-906822218
2021-08-27 16:32:59 +02:00
43d0543b9f
close audio effect control session properly
2021-08-27 10:53:44 +02:00
0787d62254
Merge pull request #6820 from Stypox/picker-mime-type
...
Provide mime type to file picker to gray out unselectable files
2021-08-26 21:39:35 +02:00
b061423847
Changed package as the old one is deprecated
2021-08-26 18:09:27 +02:00
c6ead351c0
Set ``KeyProgressIncrement`` manually
...
* Set ``KeyProgressIncrement`` manually to the value of the seek duration in the settings so that it works when using the DPad
* consolidated code inside a new method to avoid duplication
2021-08-26 17:16:51 +02:00
a4503eb609
Remove TAG parameter, refactor method calls
2021-08-25 17:04:15 +08:00
a1cb3e59d6
Move opening popup menu to utility class
2021-08-25 09:30:40 +08:00
1b05c404d5
Remove Details option in Main Player Queue menu
2021-08-25 08:56:26 +08:00
5de455bb86
Change type of themeWrapper to ContextThemeWrapper
2021-08-25 08:56:26 +08:00
acdfee5c25
Show popup menu when long pressing in play queue (Full screen player)
2021-08-25 08:56:26 +08:00
87e7d95966
Do not show suggestions error snackbar for interrupted I/O
...
Fix formatting
2021-08-24 18:16:17 +02:00
d37ee1e0dc
First run migrations, then setDefaultValues, since the latter requires the correct types
2021-08-24 18:16:17 +02:00
1d33e7ab49
Allow choosing which types of search suggestions to show
...
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00
2027b743b4
Merge pull request #6919 from ktprograms/channel-details-all-places
...
Add Show Channel Details where it's missing
2021-08-24 16:43:21 +02:00
2928df0cc9
Fix checkstyle ParenPad error
2021-08-24 21:17:08 +08:00
44128f9145
Remove placeholder image while loading thumbnails
2021-08-24 10:56:25 +02:00
6eaff5ca6a
Apply review: move thumbnail loading out of Player
2021-08-24 10:56:25 +02:00
c0664c1cb6
Add Picasso to licences and remove Universal Image Loader
2021-08-24 10:56:25 +02:00
e229e5355d
Always create new bitmap when resizing thumbnail
...
This prevents strange crashes on some devices, fixes #4638
2021-08-24 10:56:25 +02:00
52189fc5df
Add debug setting to enable Picasso indicators
2021-08-24 10:56:25 +02:00
314964c5f9
Recycle Bitmap in transformation
2021-08-24 10:56:25 +02:00
fcef783bbb
Replace UniversalImageLoader with Picasso
2021-08-24 10:56:25 +02:00
bdbb9bead2
Merge pull request #6848 from Stypox/somali-cancel
...
Use custom cancel string everywhere
2021-08-22 22:36:14 +02:00
6fbb601802
Merge branch 'master' into dev
2021-08-22 22:22:37 +02:00
8715e7dd98
Only show "mark as watched" context menu entry when watch history is enabled
2021-08-22 22:15:05 +02:00
a209e87c69
Add Loading Channel Details Toast
2021-08-21 09:30:40 +08:00
967bdf8f08
Remove migration test, add manual testing reminder to Migrations.java
2021-08-17 08:57:03 +08:00
712985ced1
Save uploader url when adding from PlayQueueItem
2021-08-16 08:08:50 +08:00
0683dafa55
Merge pull request #6851 from litetex/make-parsing-of-timestamp-links-more-robust
...
Catch errors while processing timestamp-links
2021-08-14 21:10:20 +02:00
6f1958d398
Remove setting uploaderUrl to empty string if null
2021-08-14 20:59:38 +08:00
21bcadeecb
Make uploader_url column nullable
2021-08-14 17:48:35 +08:00
bd0427c79f
Refactor duplicated code into method
2021-08-14 17:32:38 +08:00
241054fd26
Remove hardcoded string
2021-08-14 15:38:57 +08:00
d8888e3495
Catch error from ExtractorHelper.getStreamInfo, remove blockingGet
2021-08-14 09:07:27 +08:00
76803bfcb1
Save channelUrl to Database if it doesn't exist
2021-08-13 18:02:53 +08:00
c248741c00
Add Show Channel Details to Subscription Feed & History
2021-08-13 17:04:10 +08:00
759a078ce0
Add uploader_url column to StreamEntity
2021-08-13 16:44:50 +08:00
a536311d56
name the regions according to the comments ( #6854 )
...
if a region is named android studio will show its name in the structure view.
2021-08-10 22:38:23 +00:00
5f3b8bea52
Fixed format
2021-08-06 22:12:49 +02:00
f9ab23bb4a
Removed useless fiedl
2021-08-06 22:08:42 +02:00
9f8b2264a2
Use better pattern for matching timestamp in text and some reworks
...
Also extracted overhead code into ``TimestampExtractor``
2021-08-06 22:08:29 +02:00
1d61bb58f5
Set loglevel to error
...
Co-authored-by: Stypox <stypox@pm.me>
2021-08-05 20:26:17 +02:00
a3440cc8ef
Merge pull request #6814 from Stypox/channel-grid-span-count
...
Fix channel item span count for SubscriptionFragment
2021-08-05 14:25:39 +02:00
51c60e5261
Catch errors while processing timestamp-links
...
Otherwise the complete app crashes, which is bad
2021-08-04 22:35:41 +02:00
f8caed139a
Use custom cancel string everywhere
...
to fix missing somali translation for android.R.string.cancel
2021-08-04 18:58:35 +02:00
a2297fb5b8
Fix play queue theme
2021-08-04 18:41:23 +02:00
32dffb577c
Provide mime type to file picker to gray out unselectable files
2021-08-01 13:52:32 +02:00
a9623f8e6a
Merge pull request #6550 from Douile/fix/clickthrough-feed-refresh
...
Disable feed click events while refresh overlay is shown
2021-08-01 13:11:24 +02:00
d32450255c
Use NotificationChannelCompat.
2021-08-01 14:59:30 +05:30
896aec5295
Merge pull request #6719 from TacoTheDank/core-lifecycle-bump
...
Update some AndroidX libraries
2021-08-01 11:24:33 +02:00
d42a534fc3
Merge pull request #6741 from KalleStruik/comment-hearts
...
Show hearts in comments
2021-08-01 11:12:58 +02:00
551e8df8b8
Merge pull request #6773 from nschulzke/mark-as-played
...
Add ability to mark an item as played
2021-08-01 10:30:36 +02:00
dc0a28b93d
Upsert the complete info if we fetch it for marking as watched
2021-07-31 09:50:41 -06:00
644396149b
Fix channel item span count for SubscriptionFragment
2021-07-31 11:02:57 +02:00
0e12cdea7c
Save the fetched duration to the database so that it can render the view correctly.
2021-07-29 20:59:23 -06:00
cd713db029
Merge pull request #6778 from Stypox/invalid-storage-npe
...
Fix NullPointerException when checking if storage exists
2021-07-28 16:54:57 +02:00
bdd16e06e0
Add comments describing the purpose of the markAsWatched method
2021-07-28 08:25:39 -06:00
4c632810ec
Fetch the stream info via a network request if no duration is found when attempting to mark as watched.
2021-07-27 15:21:56 -06:00
f451bdbfa4
Do not add Mark as Watched to a live stream.
2021-07-27 15:21:56 -06:00
bfac73b992
Make heart visible in android studio and move logic to the right file.
2021-07-27 22:34:59 +02:00
2b41f710a8
Change played to watched
2021-07-27 13:26:51 -06:00
5ceec31adf
Merge pull request #6720 from TacoTheDank/alertdialog-edittext
...
Consolidate edittext alert dialogs into one common layout
2021-07-27 19:42:51 +02:00
50f3b08c59
Consolidate edittext alert dialogs into one layout
2021-07-27 13:31:58 -04:00
z3r0r4
Tobi
thefalsedev
litetex
Stypox
evermind
Robin
talanc
Agnieszka C
acti0
Robin
ktprograms
Isira Seneviratne
Nathan Schulzke
Kalle Struik
TacoTheDank