973a966011
Review suggestions
2022-08-25 17:02:53 +02:00
510efaae97
Keep strong reference to Picasso thumbnail loading target
...
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
2022-08-25 17:02:52 +02:00
11bd2369e5
Merge MediaSessionManager into MediaSessionPlayerUi
2022-08-25 17:02:52 +02:00
f80d1dc48d
Let exoplayer decide when to update metadata
...
Though still make sure metadata is updated after the thumbnail is loaded.
This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
2022-08-25 17:02:52 +02:00
8bff445ec3
Remove useless checks before updating metadata
...
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
2022-08-25 17:02:51 +02:00
d73ca41cfe
Even when thumbnails should not be shown, set it to null in notification
...
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
2022-08-25 17:02:51 +02:00
f3a9b81b67
Fix sometimes seeing outdated thumbnail in notification
...
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
2022-08-25 17:02:51 +02:00
3cc43e9fb9
Fix thumbnail sometimes not set to media session metadata
...
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
2022-08-25 17:00:41 +02:00
bc33322d4b
Remove useless MediaSessionCallback
...
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
2022-08-25 17:00:41 +02:00
c054ea0737
Create MediaSessionPlayerUi
2022-08-25 17:00:41 +02:00
52dbfdee00
Keep strong references to Picasso notification icon loading targets
...
Before the Target would sometimes be garbage collected before being called with the loaded channel icon, since Picasso holds weak references to targets. This meant that sometimes a new streams notification would not be shown, because the lambda that should have shown it had already been garbage collected.
2022-08-25 16:41:51 +02:00
208dde631f
Merge branch 'master' into dev
2022-08-25 10:45:24 +02:00
e1b8a3fbdf
Hotfix release v0.23.3 (989)
2022-08-25 10:16:56 +02:00
1a432f2ee3
Update jsoup to 1.15.3
...
This fixes a vulnerability issue related to Cross Site Scripting
2022-08-25 10:15:30 +02:00
db45042a56
Update NewPipeExtractor
...
This removes the usage of the SourceVersion class, which was not available on Android and caused issues such as #8876
2022-08-25 10:14:46 +02:00
5e0788b99c
Use ListAdapter in PreferenceSearchAdapter.
2022-08-18 19:52:51 +05:30
67669c286b
Use ListAdapter in SuggestionListAdapter.
2022-08-18 19:52:51 +05:30
4f6b5b3b89
Use ListAdapter in PeertubeInstanceListFragment.
2022-08-15 07:26:02 +05:30
b9b09d325a
Merge branch 'master' into dev
2022-08-14 17:23:30 +02:00
fcaebc838e
Release v0.23.2 (988)
2022-08-12 23:50:41 +02:00
ec3efea05a
Update NewPipe Extractor to fix YouTube playback issues
2022-08-12 23:41:12 +02:00
571bf397c5
Merge pull request #8666 from TacoTheDank/filepicker
...
Update FilePicker to our custom fork and disable Jetifier
2022-08-12 09:15:34 +02:00
74921d3afa
Merge pull request #8740 from Isira-Seneviratne/Cleanup_methods
...
Remove some unused methods.
2022-08-06 22:45:40 +02:00
edd2b110b0
Merge pull request #8738 from Isira-Seneviratne/Collectors_joining
...
Use Collectors.joining().
2022-08-06 22:31:31 +02:00
80fb21e031
Merge pull request #8728 from Isira-Seneviratne/Comparator_factory
...
Use Comparator factory methods.
2022-08-06 11:56:44 +02:00
ebd06bdd24
Improve comment
2022-08-06 11:56:00 +02:00
6f86e21605
Merge pull request #8724 from Isira-Seneviratne/toArray_improvements
...
Use toArray() with zero-length arrays.
2022-08-06 11:33:05 +02:00
816154c7cb
Merge pull request #8737 from Isira-Seneviratne/Fix_coerceIn
...
Replace coerceIn() with MathUtils.clamp().
2022-08-06 11:16:06 +02:00
d9230c0103
Merge pull request #8708 from Isira-Seneviratne/Reduce_View.kt_size
...
Reduce View.kt size.
2022-08-06 10:59:10 +02:00
5c7dfd1d69
Remove unused method.
2022-08-06 06:54:21 +05:30
7aacaf8c38
Use Collectors.joining().
2022-08-06 06:54:21 +05:30
ee6a279596
Remove unused methods in HistoryRecordManager.
2022-08-06 05:09:54 +05:30
a9af1dfdd2
Applied code review changes.
2022-08-05 06:54:03 +05:30
fc46233baf
Use toArray() with zero-length arrays.
2022-08-05 06:50:55 +05:30
2eec2e9128
Replace coerceIn() with MathUtils.clamp().
2022-08-05 06:19:06 +05:30
8024b437e9
Add reusable classes extending AnimatorListenerAdapter.
2022-08-05 06:08:13 +05:30
d1f3f15478
Use Comparator.comparingDouble().
2022-08-05 05:36:39 +05:30
059cfcbad2
Use Comparator factory methods in ListHelper.
2022-08-05 05:36:21 +05:30
1a8f396e77
Merge pull request #8721 from Isira-Seneviratne/OnClickGesture_interface
...
Make OnClickGesture an interface.
2022-08-04 16:15:54 +02:00
5640365fbd
Merge pull request #8682 from Isira-Seneviratne/Refactor_LicenseFragmentHelper
...
Refactor LicenseFragmentHelper.
2022-08-04 11:18:40 +02:00
4b7de86a92
Clean up getLicenseStylesheet().
2022-08-04 11:17:30 +02:00
24ec642181
Merge pull request #8669 from Isira-Seneviratne/Remove_setBottomSheetCallback
...
Remove uses of setBottomSheetCallback().
2022-08-04 11:03:57 +02:00
8dce66d76f
Improve FeedGroupDialogViewModel factory
2022-08-04 10:49:33 +02:00
7972678fe6
Merge branch 'dev' into bumpRoom
2022-08-04 10:40:09 +02:00
ffc1d9a212
Merge pull request #8656 from Isira-Seneviratne/Use_WindowMetrics
...
Use WindowMetrics API.
2022-08-04 10:12:32 +02:00
7f018b90db
Merge branch 'dev' into OnClickGesture_interface
2022-08-04 06:10:39 +05:30
8a774dc90d
Merge pull request #8667 from Isira-Seneviratne/Update_AppCompat
...
Update AppCompat to 1.4.2.
2022-08-03 22:59:45 +02:00
368c6c0ccb
Merge pull request #8709 from Isira-Seneviratne/Tags_case_insensitive
...
Sort tags case-insensitively.
2022-08-03 22:43:50 +02:00
5c4874b90f
Merge pull request #8701 from Isira-Seneviratne/Use_stackTraceToString
...
Use Throwable.stackTraceToString().
2022-08-03 21:04:22 +02:00
3420faab08
Merge pull request #8661 from Stypox/player-refactor-npe
...
Fix random NullPointerException when adding video player view
2022-08-02 11:09:50 +02:00
a548b34811
Merge pull request #8692 from TacoTheDank/bumpMaterial
...
Update Google Material to 1.6.1
2022-08-02 11:05:24 +02:00
ad30eb809c
Merge branch 'dev' into bumpFragment
2022-08-02 10:54:39 +02:00
ee368452ae
Merge pull request #8687 from TacoTheDank/bumpExoPlayer
...
Update ExoPlayer to 2.18.1
2022-08-02 10:34:58 +02:00
a9095ca2ad
Make block parameter an extension lambda.
2022-08-01 08:29:59 +05:30
013522c376
Convert LicenseFragmentHelper methods to top-level declarations.
2022-08-01 08:27:09 +05:30
947242d913
Update AppCompat to 1.4.2.
2022-08-01 08:26:07 +05:30
8a896114c1
Apply code review change.
2022-08-01 08:25:24 +05:30
47f58040d1
Make OnClickGesture an interface.
2022-08-01 06:47:00 +05:30
582032f372
Update AndroidX Room to 2.4.3
2022-07-31 00:14:23 -04:00
311d392386
Use Application instead of Context in FeedViewModel.
2022-07-31 08:37:16 +05:30
404c13d4c1
Improve FeedViewModel factory
2022-07-31 08:30:17 +05:30
5c68c8ece8
Update Lifecycle to 2.5.1.
2022-07-31 08:30:17 +05:30
4d7a6fb6de
Use WindowMetrics API in VideoDetailFragment and PopupPlayerUi.
2022-07-30 19:22:39 +05:30
630558ed4f
Use nested functions.
2022-07-30 07:59:36 +05:30
69942003f7
Sort tags case-insensitively.
2022-07-29 09:21:48 +05:30
af9c2bd59d
Use stackTraceToString().
2022-07-27 07:54:49 +05:30
81fb44c45c
Remove uses of setBottomSheetCallback().
2022-07-25 18:44:30 +05:30
d66997c2ed
Update Google Material to 1.6.1
2022-07-24 16:51:26 -04:00
d7a654fc27
Update AndroidX Fragment to 1.4.1
2022-07-24 15:35:33 -04:00
229422bfa9
Update ExoPlayer to 2.18.1
2022-07-24 14:11:31 -04:00
8f5d564f84
Migrate NoNonsense-FilePicker to our updated fork
2022-07-24 15:07:31 +02:00
dcb332e08d
Merge pull request #8624 from TacoTheDank/bumpOkhttp
...
Update OkHttp to 4.10.0
2022-07-24 15:02:08 +02:00
51e72d1a05
Removed the "(beta)"-tag from services ( #8637 )
2022-07-24 15:57:23 +03:00
8f37015dbb
Merge pull request #8621 from Stypox/deduplicate-feed
...
Deduplicate SQL queries to get feed streams
2022-07-24 14:52:35 +02:00
74df7fcd66
Merge pull request #8670 from Isira-Seneviratne/Update_FocusAwareCoordinator
...
Remove deprecated method calls in FocusAwareCoordinator.
2022-07-23 17:12:29 +02:00
bfaf074f4e
Merge pull request #8663 from Isira-Seneviratne/Remove_unnecessary_methods
...
Remove unnecessary methods.
2022-07-23 16:31:28 +02:00
3281ed2ef1
Merge pull request #8648 from Isira-Seneviratne/Use_IO_extensions
...
Use IO extensions.
2022-07-22 18:30:51 +02:00
b2c2570a85
Merge pull request #8676 from Stypox/fix-channel-placeholders
...
Fix wrong thumbnail used as placeholder for channel
2022-07-22 18:16:42 +02:00
f4fe5fcb16
Fix ListHelperTest failure caused by immutable list being used
2022-07-22 16:09:43 +02:00
37275e8fe3
Fix wrong thumbnail used as placeholder for channel
2022-07-22 15:13:47 +02:00
f1dab11f1f
Remove deprecated method calls in FocusAwareCoordinator.
2022-07-21 09:01:19 +05:30
6d1c61407d
Remove unnecessary method in ChannelFragment.
2022-07-21 08:02:23 +05:30
8b400b48f7
Refactor notifying method in PlayQueue.
2022-07-21 08:02:23 +05:30
b845645b80
Use IO extensions.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-07-21 05:15:39 +05:30
cacce6d2d0
Merge pull request #8651 from Isira-Seneviratne/Use_limiting_methods
...
Use range-limiting methods.
2022-07-20 15:06:45 +02:00
373ee53143
Improve code style
2022-07-20 15:05:25 +02:00
344c33d9a1
Merge pull request #8631 from Isira-Seneviratne/Use_collection_factories
...
Use Java 9 collection factories.
2022-07-20 14:52:18 +02:00
c5b970cca3
Improve code style in List.of()
2022-07-20 14:50:23 +02:00
15947161e6
Merge pull request #8635 from Isira-Seneviratne/Use_stream_sort
...
Use stream sorting.
2022-07-20 11:06:56 +02:00
394eb92e71
Use coerceIn().
2022-07-20 05:36:01 +05:30
d62cdc659f
Use MathUtils.clamp().
...
Co-authored-by: Stypox <stypox@pm.me>
2022-07-20 05:36:01 +05:30
a6cc13845a
Use Map.of().
2022-07-20 04:39:11 +05:30
55a995c4cd
Replace LinkedHashMap with List.of().
2022-07-20 04:39:11 +05:30
ca26fcb0eb
Use List.of().
2022-07-20 04:39:11 +05:30
4eddd2c3d1
Fix random NullPointerException when adding video player view
2022-07-19 20:01:46 +02:00
c53143ef4f
Use Set.of().
2022-07-19 08:53:15 +05:30
e772244440
Update app/src/main/java/org/schabi/newpipe/fragments/detail/DescriptionFragment.java
...
Co-authored-by: Stypox <stypox@pm.me>
2022-07-19 05:13:38 +05:30
ae369ec9ba
Merge pull request #8475 from TacoTheDank/bumpMiscLibraries
...
Update some misc libraries
2022-07-18 23:56:41 +02:00
e8669d4ab5
Deduplicate SQL queries to get feed streams
2022-07-18 23:39:57 +02:00
cd14096dbe
Merge pull request #8633 from Isira-Seneviratne/Use_ViewCompat_setBackgroundTintList
...
Use ViewCompat.setBackgroundTintList().
2022-07-18 23:31:56 +02:00
Stypox
Isira Seneviratne
AudricV
TacoTheDank
litetex
Isira Seneviratne