8345f348f6
Merge pull request #10091 from TeamNewPipe/feat/playlist_description
...
Add playlist description to playlist fragment
2023-12-29 10:58:13 +01:00
845e72bf4a
Merge branch 'master' into dev
2023-12-29 10:48:37 +01:00
0fa2e76c3e
Fix NPE when ChannelTabLHFactory not implemented for a service
...
Fixes #10698
2023-12-26 16:55:52 +01:00
65eb631711
Ellipsize playlist description if it is longer than 5 lines
...
The description can be expanded / collapsed via a "show more" / "show less" button.
2023-12-23 12:33:52 +01:00
6c99557553
Add playlist description to PlaylistFragment
2023-12-23 12:13:34 +01:00
aa84d6fc8f
Add @NonNull annotations
2023-12-22 18:52:42 +01:00
d76e9b0bd8
Fix scrolling to correct comment after closing replies
2023-12-22 18:52:42 +01:00
b4016c91c1
scroll last comment into view
2023-12-22 11:57:55 +01:00
5f32d001cc
Expand DetailFragment again when exiting the CommentRepliesFragment
2023-12-22 11:57:55 +01:00
8c9287d0c8
Revert relying on source ListInfo, use commentsInfoItem.getUrl() instead
...
This reverts commit bb01da3691ff1d5c3dccd41b7ca1a5deb1b5676f. This commit was not needed
2023-12-22 11:57:55 +01:00
3f37e27852
Add some documentation and javadocs
...
Also further simplify CommentRepliesInfo and RelatedItemsInfo
2023-12-22 11:57:55 +01:00
f41ab8b086
Add comment replies fragment header
2023-12-22 11:57:55 +01:00
4b6392df54
Set comment replies fragment title
2023-12-22 11:48:07 +01:00
94ea329b50
Always show comment replies in list mode
2023-12-22 11:48:07 +01:00
591ed2e01f
Fix some code smells
2023-12-22 11:48:07 +01:00
78cf9aaa7d
Save and restore state in CommentRepliesFragment
2023-12-22 11:48:07 +01:00
f9494a294f
Implement CommentRepliesFragment
2023-12-22 11:48:07 +01:00
0dd4553700
Load more items even if initial related items are empty
2023-12-22 11:48:07 +01:00
4f7b36cd70
Keep source list info in InfoItemBuilder
...
Also remove some unused code
2023-12-22 11:48:07 +01:00
5d350aec87
Move RelatedItemInfo next to fragment using it
2023-12-22 11:48:07 +01:00
495c9850b4
Fix transaction too large for channel tab fragments
2023-12-20 23:57:43 +01:00
87dca0f7ec
Separate imageListToDbUrl from choosePreferredImage
...
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
2023-09-22 10:14:44 +02:00
4f7d206736
Display all thumbnails in description tab
2023-09-22 10:14:44 +02:00
35073c780d
Implement better image selection strategy
2023-09-22 10:14:44 +02:00
0a8f28b1c6
Add image quality preference
2023-09-22 10:14:43 +02:00
af2375948d
Support obtaining multiple images from the extractor
2023-09-22 09:57:33 +02:00
748c2babe9
Add comments and annotations
2023-09-20 15:41:21 +02:00
64da7a06c0
Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment
2023-09-18 23:22:32 +02:00
57eaa1bbe1
Apply review
...
Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>
2023-09-18 23:22:32 +02:00
109d06b4bb
Deduplicate code to initialize ClickListeners on playlist controls
...
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.
The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
2023-09-18 23:22:32 +02:00
f2ee3859ab
Hide the upload date element on the About tab
...
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
2023-09-18 23:22:32 +02:00
89dc44be61
Always show the About tab and support having no description
2023-09-18 23:22:32 +02:00
5c7c382323
Add missing `@Override` annotations to setupMetadata() implementations
2023-09-18 23:22:32 +02:00
78b4b9441e
Update NewPipeExtractor and adapt imports
2023-09-18 23:22:32 +02:00
c48e702a50
Improve placeholder channel banner handling
...
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
1061bce4f3
Add avatar and bannner URLs to channel About tab
2023-09-18 23:22:32 +02:00
013d513450
Add space above channel description (About tab)
2023-09-18 23:22:32 +02:00
753a92055c
feat: add playlist controls to channel tab
2023-09-18 23:22:32 +02:00
371f986773
Fix some code smells
2023-09-18 23:22:32 +02:00
a1e8b9be4e
Fix channel tabs in main page setting title themselves
2023-09-18 23:22:32 +02:00
c076a0f771
Channels are now an Info
...
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
2023-09-18 23:22:32 +02:00
b5893f3fa3
fix: notification menu option disappears when switching tabs
2023-09-18 23:22:32 +02:00
e3614cb932
Move channel header to collapsible app bar
2023-09-18 23:22:32 +02:00
193c3e5b3d
fix: NPE in ChannelFragment::onSaveInstanceState
2023-09-18 23:22:32 +02:00
c03c344f49
refactor: rename ChannelInfo to ChannelAbout
...
fix: localize about tab name
2023-09-18 23:22:32 +02:00
25e3031830
cleanup: remove empty constructor from ChannelFragment
2023-09-18 23:22:31 +02:00
39b4ed082c
refactor: common code from ChannelInfo/Description -> BaseInfoFragment
2023-09-18 23:22:31 +02:00
be548dcb52
fix: channel tab title not being set
2023-09-18 23:22:31 +02:00
4357a34339
fix: ChannelFragment: save last tab
2023-09-18 23:22:31 +02:00
2c03ba204e
refactor: adjustments to updated tab extractor API
2023-09-18 23:22:31 +02:00
Stypox
TobiGr
AudricV
ThetaDev