0085ca6416
Fix loading images from db even if disabled
2023-09-22 10:14:44 +02:00
87dca0f7ec
Separate imageListToDbUrl from choosePreferredImage
...
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
2023-09-22 10:14:44 +02:00
37af2c87e8
Fix possible NPE in PlayQueueNavigator
2023-09-22 10:14:44 +02:00
bf908f0b7d
Add documentation and fix SonarCloud issue
2023-09-22 10:14:44 +02:00
8d463b9577
Further improve image resolution strategy
...
Now using multiple comparison steps instead of magic values
2023-09-22 10:14:44 +02:00
4f7d206736
Display all thumbnails in description tab
2023-09-22 10:14:44 +02:00
35073c780d
Implement better image selection strategy
2023-09-22 10:14:44 +02:00
0a8f28b1c6
Add image quality preference
2023-09-22 10:14:43 +02:00
af2375948d
Support obtaining multiple images from the extractor
2023-09-22 09:57:33 +02:00
e2de83188a
Merge pull request #10199 from TeamNewPipe/feat/player/accessibility
...
Improved accessibility of player interfaces
2023-09-21 15:57:38 +02:00
2a1b506d98
Improved accessibility of player interfaces
2023-09-21 12:20:00 +02:00
b798ff5c92
Merge pull request #10435 from TeamNewPipe/imp/codequality
...
Improve codequality
2023-09-20 21:24:44 +02:00
673aa0a87b
Merge pull request #10428 from Isira-Seneviratne/AGP_8.1
...
Bump AGP to 8.1.1
2023-09-20 20:20:36 +02:00
779ea19222
Fix doc formatting
2023-09-20 19:44:23 +02:00
a1f2b7f8e8
Switch to Files.createDirectories()
2023-09-20 19:44:23 +02:00
fcb855cea9
Bump AGP to 8.1.1
2023-09-20 19:44:23 +02:00
50fb48f66d
Merge pull request #10244 from TacoTheDank/bumpMaterial
...
Update Google Material library
2023-09-20 18:19:53 +02:00
0acc3532c9
Remove useless override
2023-09-20 15:42:09 +02:00
8bf2d996ea
Reorder the modifiers to comply with the Java Language Specification.
2023-09-20 15:41:57 +02:00
748c2babe9
Add comments and annotations
2023-09-20 15:41:21 +02:00
6859f73c54
Merge pull request #10224 from TacoTheDank/moreKotlinMath
...
Replace MathUtils.clamp with Kotlin coerceIn
2023-09-20 11:04:54 +02:00
b1faed586d
Replace MathUtils.clamp with Kotlin coerceIn
2023-09-19 16:32:37 -04:00
6c848b4766
Update Google Material library
2023-09-19 16:30:09 -04:00
725c18eada
Merge pull request #10165 from TeamNewPipe/fix/media-format
...
Fix downloads of streams with missing MediaFormat
2023-09-19 15:54:12 +02:00
992bb5d7be
Simplify retrieveMediaFormatFromContentTypeHeader
...
Also check for nullity
2023-09-19 15:33:49 +02:00
9e353f1cdc
Merge pull request #10394 from TeamNewPipe/fix/memory-leaks
...
Fix memory leaks and add documentation
2023-09-19 14:17:23 +02:00
8f83e39970
Fix three memory leaks
...
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
2023-09-19 00:13:16 +02:00
0eae9e7cdc
Merge pull request #9182 from Theta-Dev/channel-tabs
...
Add support for channel tabs
2023-09-18 23:46:13 +02:00
031b893196
Remove unused content not supported TextView
2023-09-18 23:22:32 +02:00
64da7a06c0
Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment
2023-09-18 23:22:32 +02:00
57eaa1bbe1
Apply review
...
Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>
2023-09-18 23:22:32 +02:00
109d06b4bb
Deduplicate code to initialize ClickListeners on playlist controls
...
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.
The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
2023-09-18 23:22:32 +02:00
0d9910cbbe
Fix SubscriptionManagerTest tests
...
The breakage of these tests is related to the channel tabs changes.
The testRememberRecentStreams test method has been removed, as it doesn't seem
to be relevant anymore to managing subscriptions.
2023-09-18 23:22:32 +02:00
8fbc8ffc7c
Remove unneeded German translation
2023-09-18 23:22:32 +02:00
f2ee3859ab
Hide the upload date element on the About tab
...
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
2023-09-18 23:22:32 +02:00
89dc44be61
Always show the About tab and support having no description
2023-09-18 23:22:32 +02:00
6ab8716e69
Extract actual feed loading code into separate method
...
Increase readability
2023-09-18 23:22:32 +02:00
5c7c382323
Add missing `@Override` annotations to setupMetadata() implementations
2023-09-18 23:22:32 +02:00
78b4b9441e
Update NewPipeExtractor and adapt imports
2023-09-18 23:22:32 +02:00
9e55014a13
Fix wrongly themed channel header
...
Since it is embedded in the app bar and has red as background color, it should be themed in the same way as the toolbar.
2023-09-18 23:22:32 +02:00
6f23b56b06
Use consistent name for livestreams tab in settings keys
2023-09-18 23:22:32 +02:00
1519527356
Fix loading feed when a channel tab is empty
2023-09-18 23:22:32 +02:00
6b3a178f2a
Show snackbar with feed loading errors
2023-09-18 23:22:32 +02:00
604419dd1f
Make channel banner placeholder match YouTube's size
...
YouTube's "Desktop Max" thumbnails are 2560x423, while our previous placeholder banner was 2550x427. The extractor actually returns a lower resolution "Desktop Max" banner at 1060x175, but the ratio wrt 2560x423 is off by ~0.1%
The PNG was optimized with OptiPNG
2023-09-18 23:22:32 +02:00
c48e702a50
Improve placeholder channel banner handling
...
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
1061bce4f3
Add avatar and bannner URLs to channel About tab
2023-09-18 23:22:32 +02:00
013d513450
Add space above channel description (About tab)
2023-09-18 23:22:32 +02:00
dca32efadf
add channel banner placeholder
2023-09-18 23:22:32 +02:00
28d952a643
feat: filter fetched channel tabs
2023-09-18 23:22:32 +02:00
a2a717bd49
update NPE
2023-09-18 23:22:32 +02:00
Stypox
Tobi
Isira Seneviratne
TacoTheDank
AudricV
ThetaDev