Stypox
9ff1b5230f
Improve TextEllipsizer class
2023-12-23 18:04:05 +01:00
TobiGr
65eb631711
Ellipsize playlist description if it is longer than 5 lines
...
The description can be expanded / collapsed via a "show more" / "show less" button.
2023-12-23 12:33:52 +01:00
Stypox
ee3455e1e5
Merge pull request #10086 from TacoTheDank/bumpAndroidX
...
Update some AndroidX libraries and compileSdk to 34
2023-12-23 11:46:28 +01:00
TacoTheDank
76f1e588f7
Utilize BundleCompat and IntentCompat methods
2023-12-23 11:38:40 +01:00
Stypox
aa84d6fc8f
Add @NonNull annotations
2023-12-22 18:52:42 +01:00
TobiGr
b4016c91c1
scroll last comment into view
2023-12-22 11:57:55 +01:00
TobiGr
5f32d001cc
Expand DetailFragment again when exiting the CommentRepliesFragment
2023-12-22 11:57:55 +01:00
Stypox
8c9287d0c8
Revert relying on source ListInfo, use commentsInfoItem.getUrl() instead
...
This reverts commit bb01da3691ff1d5c3dccd41b7ca1a5deb1b5676f. This commit was not needed
2023-12-22 11:57:55 +01:00
Stypox
3f37e27852
Add some documentation and javadocs
...
Also further simplify CommentRepliesInfo and RelatedItemsInfo
2023-12-22 11:57:55 +01:00
Stypox
ad68f784ae
Extract some utility methods from CommentInfoItemHolder
2023-12-22 11:48:07 +01:00
Stypox
5d350aec87
Move RelatedItemInfo next to fragment using it
2023-12-22 11:48:07 +01:00
Stypox
059db6fb31
Add replies button to comments
2023-12-22 11:48:05 +01:00
Stypox
e784af3e2d
Merge pull request #10446 from AudricV/dl_improve_video_audio_stream_selection
...
Improve audio stream selection for video-only streams in the downloader
2023-12-07 16:48:57 +01:00
Stypox
ce30108efc
Improve javadoc for `getAudioStreamFor`
2023-12-07 16:40:32 +01:00
Stypox
545f9ae5f3
Merge pull request #10489 from sqproman/missing_quotation_replace_char_crash
...
Quote filename replacement characters to fix crashes when downloading streams with special characters
2023-11-16 20:19:01 +01:00
AudricV
e5fda35c51
Remove OPUS HLS streams from playable streams
...
This format is not supported by ExoPlayer when returned as HLS streams, so we
can't play streams using this format and this delivery method.
Also improve the Javadoc of ListHelper.getPlayableStreams.
2023-11-15 23:37:22 +01:00
akko
6d0bb02544
adds quotation to create filename util replacement char
2023-10-13 11:28:09 +07:00
AudricV
77bbbc88f8
Use ListHelper to get secondary audio streams for video-only streams
...
Instead of searching for the first audio stream matching a compatible media
format, this change makes SecondaryStreamHelper.getAudioStreamFor use methods
isLimitingDataUsage, getAudioFormatComparator and getAudioIndexByHighestRank of
ListHelper to get an audio stream which can be muxed into a video-only stream,
if available.
This allows users to download videos with the highest audio quality available
if no resolution limit on mobile data usage has been set.
The order of formats used to search a compatible audio stream has been kept.
2023-09-24 18:23:45 +02:00
AudricV
cdb79ef78a
Make isLimitingDataUsage method of ListHelper package-private and fix some typos in the class
2023-09-24 18:23:44 +02:00
Tobi
1630e309fb
Merge pull request #9987 from Edwardsoen/add_high_resolution_to_default_option
...
Include a high-resolution option in the default resolution settings.
2023-09-24 17:54:18 +02:00
Stypox
027b829c38
Use @DrawableRes in PicassoHelper
2023-09-22 10:14:45 +02:00
Stypox
0085ca6416
Fix loading images from db even if disabled
2023-09-22 10:14:44 +02:00
Stypox
87dca0f7ec
Separate imageListToDbUrl from choosePreferredImage
...
imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
2023-09-22 10:14:44 +02:00
Stypox
bf908f0b7d
Add documentation and fix SonarCloud issue
2023-09-22 10:14:44 +02:00
Stypox
8d463b9577
Further improve image resolution strategy
...
Now using multiple comparison steps instead of magic values
2023-09-22 10:14:44 +02:00
Stypox
35073c780d
Implement better image selection strategy
2023-09-22 10:14:44 +02:00
Stypox
0a8f28b1c6
Add image quality preference
2023-09-22 10:14:43 +02:00
Stypox
af2375948d
Support obtaining multiple images from the extractor
2023-09-22 09:57:33 +02:00
Stypox
725c18eada
Merge pull request #10165 from TeamNewPipe/fix/media-format
...
Fix downloads of streams with missing MediaFormat
2023-09-19 15:54:12 +02:00
Stypox
992bb5d7be
Simplify retrieveMediaFormatFromContentTypeHeader
...
Also check for nullity
2023-09-19 15:33:49 +02:00
TobiGr
57eaa1bbe1
Apply review
...
Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>
2023-09-18 23:22:32 +02:00
TobiGr
109d06b4bb
Deduplicate code to initialize ClickListeners on playlist controls
...
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.
The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
2023-09-18 23:22:32 +02:00
Stypox
78b4b9441e
Update NewPipeExtractor and adapt imports
2023-09-18 23:22:32 +02:00
Stypox
c48e702a50
Improve placeholder channel banner handling
...
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
ThetaDev
28d952a643
feat: filter fetched channel tabs
2023-09-18 23:22:32 +02:00
Stypox
371f986773
Fix some code smells
2023-09-18 23:22:32 +02:00
Stypox
c076a0f771
Channels are now an Info
...
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
2023-09-18 23:22:32 +02:00
Stypox
e3614cb932
Move channel header to collapsible app bar
2023-09-18 23:22:32 +02:00
ThetaDev
2c03ba204e
refactor: adjustments to updated tab extractor API
2023-09-18 23:22:31 +02:00
ThetaDev
2c98d079de
fix: cache channel data
2023-09-18 23:22:31 +02:00
ThetaDev
16cd47fa2e
fix: missing album tab key
2023-09-18 23:22:31 +02:00
ThetaDev
74a8bfba93
feat: add album tab
2023-09-18 23:22:31 +02:00
ThetaDev
c929f00456
fix: remember selected channel tab on screen rotation
2023-09-18 23:22:31 +02:00
ThetaDev
bb062f07f9
feat: add option to hide channel tabs
2023-09-18 23:22:31 +02:00
ThetaDev
6d13cf5e71
feat: add channel tabs
2023-09-18 23:22:31 +02:00
TobiGr
19640d5e7c
Add documentation to increase maintainablilty
...
Rename a variable
2023-09-18 01:45:53 +02:00
Edward
d1a82a85cd
Include a high-resolution option in the default resolution settings.
2023-09-18 01:15:22 +02:00
TobiGr
68957d3880
Fix grammar in JDoc
2023-08-22 16:23:22 +02:00
TobiGr
ba84e7eead
Display "Unknown quality" if quality is unknown and not MediaFormat name
2023-08-14 23:06:32 +02:00
TobiGr
e51067177e
Add tests for new methods retrieving MediaFormats
...
Fix failing tests
2023-08-14 23:06:32 +02:00