f134e2d02a
Merge pull request #6385 from sauravrao637/6371
...
Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST
2021-05-28 14:23:04 +02:00
b564433ff6
Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST
2021-05-28 03:38:53 +05:30
2e161a1f45
Change shuffle() guard to check for size <= 2
...
After testing the app, I realized that shuffling a queue with size 2
does nothing
2021-05-24 12:20:19 -04:00
5ab6e84044
Remove redundant clearing of list
2021-05-24 12:20:19 -04:00
e1a6347c4e
Refactor shuffle and update documentation
...
- Add early return for invalid sizes to shuffle
- Rename variables to be more descriptive
- Refactor moving list element, removing unnecessary operations
- Unwrap if clause for adding to history because the condition is
guaranteed by the guard clause
- Inline the value 0 for the ReorderEvent
- Update documentation to reflect new changes
2021-05-24 12:20:19 -04:00
92a67bb8cb
Rearrange fields
...
Final fields should be arranged first
2021-05-24 12:20:19 -04:00
e8eeac6735
Resolve TODO in indexOf(...)
...
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
2021-05-24 12:20:19 -04:00
775fbc9a75
Rewrite setIndex(int) to pass unit tests
...
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.
There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
2021-05-24 12:20:19 -04:00
8efe2859b8
Refactor assignments to field declaration
...
Assignments that don't require the constructor can be moved out.
2021-05-24 12:20:19 -04:00
441c68ead2
Add hashCode() to match equals(other)
2021-05-24 12:20:19 -04:00
4cd1f201f5
Refactor streams to initialize with values
2021-05-24 12:20:19 -04:00
013c59f904
Refactor ArrayList fields to List
2021-05-24 12:20:19 -04:00
57474e2dab
Refactor and optimize equals
...
- Remove multiple casts of obj
- Simply use object equals on the streams because PlayQueueItem’s
equals already compares urls
2021-05-24 12:20:19 -04:00
87d2f33e55
Add support for PeerTube HLS streams
2021-05-23 11:53:35 +02:00
fc7944d287
Merge pull request #6319 from ATofighi/feat-6039-store-backup-location
...
Save backup import/export location for future import/exports
2021-05-21 21:08:33 +02:00
92ab9cae27
Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability
2021-05-21 20:24:57 +04:30
fa2b11b768
Move ContentSettingsFragment.isValidPath to helpers and add unit test for it.
2021-05-21 20:21:58 +04:30
82f43ac6a6
Save backup import/export location for feature import/exports
2021-05-17 21:57:27 +04:30
847831c195
Merge pull request #6308 from mhmdanas/make-minor-changes
...
Make some minor changes
2021-05-17 12:14:00 +02:00
e0b246431f
Merge pull request #6312 from ATofighi/fix-6298-report-page-back-not-working
...
Fix ErrorActivity actionbar back button not working
2021-05-17 12:12:12 +02:00
c808beec30
Fix ErrorActivity actionbar back button not working
...
The issue is because of R.id.home != android.R.id.home
2021-05-16 02:19:52 +04:30
eb1cefe2fa
Make some minor changes
2021-05-15 18:48:16 +03:00
95f61542b5
TEST: Downgrade ExoPlayer to 2.12
2021-05-14 14:47:53 +02:00
98ccd577d6
Fixed checkstyle
2021-05-14 12:15:48 +02:00
1d43a2362c
Add debug option to disable media tunneling
2021-05-14 12:05:52 +02:00
5b4fbe32b1
Fix trying to delete object not in list ( #6127 )
...
* fix trying to delete object by index -1
* correction in checkstyle-supressions.xml
Co-authored-by: camo0112 <56369484+camo0112@users.noreply.github.com>
2021-05-12 14:33:00 +02:00
31ea44ccf1
Fixed player not automatically playing ( #6266 )
...
* Fixed player not automatically playing
Should also fix https://github.com/TeamNewPipe/NewPipe/issues/6179
* Added comment
2021-05-12 10:20:39 +02:00
38ed07caa7
Downloader: Deleter: Dismiss previous Snackbars
...
Bug:
In Downloader view, while deleting items, Snackbars at the
bottom of the UI keep queuing up. You need to wait for all
of them to dismiss themselves for files to actually be
deleted. If you close NewPipe before all snackbars are
dismissed, your files will not be deleted and show up again
next time you start NewPipe.
Fix:
When running append(), trigger the commit() action
immediately and cancel all delayed callbacks for commit().
This prevents Snackbars from stacking up in reverse order.
Fixes: https://github.com/TeamNewPipe/NewPipe/issues/5660
2021-05-04 19:44:09 +02:00
72ee4be495
Merge pull request #6152 from Isira-Seneviratne/Use_Animator_addListener
...
Use Animator.addListener() extension.
2021-05-04 19:37:03 +02:00
c85b97a484
Fix: fragmentSize is below the minimum ( #6238 )
...
noticed logs " CacheDataSink: fragmentSize is below the minimum recommended value of 2097152. This may cause poor cache performance.
this fixes the issue by using ExoPlayers MIN_RECOMMENDED_FRAGMENT_SIZE. Unfortunately that field is private:
aeb306a164/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSink.java (L123)
2021-05-04 19:08:25 +02:00
c7510c628f
Merge pull request #6189 from mhmdanas/fix-some-warnings
...
Fix some warnings
2021-05-04 18:54:17 +02:00
3ca1e550fe
Merge pull request #5997 from TeamNewPipe/reChaptcha
...
Do not set reCaptcha cookie when there is no cookie stored
2021-05-04 18:53:12 +02:00
2c1df5f875
Actually fix the parentFile warning
2021-04-30 01:02:46 +03:00
e7ae215ab0
Fix some warnings
2021-04-28 00:28:36 +03:00
4a9c790652
Merge branch 'master' into dev
2021-04-26 19:13:17 +02:00
bacb35fb1c
Merge pull request #6151 from TeamNewPipe/share-dialog-color
...
Fix black drawables in night themes in share dialog (RouterActivity)
2021-04-26 11:51:50 +02:00
e70c153cd3
Fix black drawables in night themes in share dialog (RouterActivity)
2021-04-25 11:36:40 +02:00
b54c2b7f57
Fix invisible buffering / loading indicator in player
2021-04-25 11:36:00 +02:00
3fe80ec5ac
Use Animator.addListener() extension.
2021-04-24 07:45:12 +05:30
e775037366
Only show 'download has started' toast when a download has started
2021-04-22 02:45:04 +00:00
0039312a64
Merge pull request #6109 from sauravrao637/codeImrovement
...
Replaced if/else with switch in ErrorActivity, supress false lint warning
2021-04-19 16:45:45 +02:00
fc4dd4524a
Replaced if/else with switch
2021-04-19 10:52:52 +05:30
e5457e5029
[Bandcamp] Add Radio stream segments
...
Display channel / creator / artist name when given
2021-04-11 23:14:23 +02:00
c9e0bf4f02
Merge pull request #5963 from sauravrao637/IssueFix#5959
...
Fix display of channel details when it has no videos
2021-04-09 11:15:51 +02:00
8f9eaa22e6
Fix display of channel details when it has no videos
2021-04-09 12:45:43 +05:30
3fcd580491
Add queue time ( #6023 )
...
* Add queue time
2021-04-08 10:41:41 +02:00
cf3cc2e984
Disable media tunneling on cvt_mt5886_eu_1g ( #6024 )
...
* Disable media tunneling on cvt_mt5886_eu_1g
Follow-up to 4a9d21062a
2021-04-08 05:21:57 +02:00
9e29d8d692
Merge pull request #6001 from TacoTheDank/appcompat-alertdialog
...
Migrate rest of AlertDialogs to AppCompat
2021-04-07 05:07:24 +02:00
5d5f8b4d51
Fix NullPointerException: Attempt to get length of null array in MainActivity ( #5999 )
...
* Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to get length of null array #5996
issue : #5996
changed :
- Checked null
2021-04-06 14:13:13 +02:00
e75d0de135
Migrate rest of AlertDialogs to AppCompat
2021-04-04 10:26:38 -04:00
Tobi
camo0112
Zhiheng Xu
XiangRongLin
Alireza Tofighi
mhmdanas
Robin
Saurav Rao
litetex
ix5
Robin
mhmdanas
Isira Seneviratne
Sub Raizada
Tom
Davide Beatrici
wangear
TacoTheDank