3fb5073feb
Merge pull request #8150 from karyogamy/caption-fix
...
Fix caption auto-selection not reflected in player GUI
2022-04-14 10:10:53 +02:00
9818f179c4
fixed: auto-generated captions to have lower selection priority as manual captions.
2022-04-11 22:06:43 -04:00
74c9a3dc50
Merge pull request #8146 from GGAutomaton/fix-7825
...
Use newInstance in PlaylistDialog
2022-04-10 15:04:12 +02:00
55fc3fc177
added: caption language stem utility to support language variant conversion between videos.
2022-04-08 18:21:30 -04:00
724eac9168
fixed: player caption auto-selection not reflected in gui.
...
fixed: player caption selection skipping on multiple language variants.
2022-04-07 20:02:56 -04:00
a528cee5f4
Merge pull request #8127 from litetex/fix-SparseItemUtil
...
Fix `SparseItemUtil` so we don't enqueue twice
2022-04-07 17:21:18 +02:00
2e771cd65a
Fix crash when rotating device on unsupported channels
2022-04-04 23:58:39 +08:00
638f227b51
Use newInstance in PlaylistDialog
2022-04-04 13:50:27 +08:00
3261855b8f
Fix fetch of video streams (when switching between tracks in a play queue) and subtitles when using a seamless transition between background and video players
...
Make the use of the new method setDisabledTrackTypes in DefaultTrackSelector.ParametersBuilder, which disables selection of tracks type for every TrackGroup instead of the current group, which is the current behavior.
This removes the use of the deprecated of setSelectionOverride method.
Note that for progressive media, the content is still fetched, but only for initialization purposes (so requests are pretty small, most of times with a few kilobytes size).
2022-04-03 14:07:56 +02:00
6b1a6d264b
Better naming
2022-04-02 15:44:06 +02:00
99d62381b9
Fix download dialog selector layout and add some tests
2022-04-02 15:25:08 +02:00
860d28e16c
Merge pull request #8020 from karyogamy/exo-update-v17
...
ExoPlayer 2.17.1 update and MediaSource management rework
2022-04-02 14:53:58 +02:00
b5fa93eda0
Fix `SparseItemUtil` loading
...
* Added a missing `return` statement
* `fetchUploaderUrlIfSparse` now has a similar layout to `fetchItemInfoIfSparse`
2022-03-30 21:11:15 +02:00
a00bc95acc
updated: source loading error for FailedMediaSource to wait for 3 seconds before allowing retry.
...
updated: minor style fixes.
2022-03-27 13:24:37 -04:00
d289dc8a53
updated: onPlayerError to not catch unspecified source errors so notifications are created.
...
updated: Throwable usage to Exceptions.
updated: minor styles and documentations.
2022-03-26 20:17:52 -04:00
102c05e927
FIx breaking changes
2022-03-26 21:21:07 +01:00
1ecb0ca081
Merge pull request #7977 from Stypox/error-notification-kitkat
...
Fix error notification on KitKat
2022-03-25 20:00:48 +01:00
b81eb35f3d
added: documentations on lifecycles for FailedMediaSource and LoadedMediaSource.
...
fixed: onPlaybackSynchronize to rewind when not playing, which was incorrectly removed in previous commit.
fixed: sonar and checkstyle issues.
2022-03-19 22:40:32 -04:00
6e8c9f92cb
Merge branch 'dev' into pr2335
2022-03-19 22:29:10 +01:00
3d9d25df52
Remove backoff criteria: it never kicked in
...
It never kicked in since we are never returning a retry() Result, but always either success() or failure() (see createWork() function). Also, there is already a default (exponential backoff starting from 30 seconds), so no need to override it.
2022-03-19 21:55:00 +01:00
69646e5b5d
added: documentations to MediaItemTags and Player.
...
fixed: checkStyle failures.
2022-03-19 15:56:45 -04:00
4e459b3383
updated: ExoPlayer to 2.17.1.
...
added: MediaItemTag for ManagedMediaSources.
added: silent track for FailedMediaSource.
added: keyframe fast forward at initial playback buffer.
added: error notification on silently skipped streams.
2022-03-19 15:56:45 -04:00
70d9a77e9b
Merge pull request #8073 from Stypox/bump-checkstyle
...
Update checkstyle to 10.0 and fix various related issues
2022-03-19 14:37:52 +01:00
6d2b5d976d
Merge pull request #8068 from TacoTheDank/lintCleaning
...
Some lint cleaning
2022-03-19 14:37:34 +01:00
57231382a6
Merge pull request #8066 from TacoTheDank/simpleSeekbarChange
...
Create stub implementation for OnSeekBarChangeListener
2022-03-19 14:37:10 +01:00
53f8415e9b
Use @SuppressWarnings for checkstyle suppressions & warnings
...
It's better to use @SuppressWarnings instead of the suppressions file, so that the warning suppression is at the place where it acts.
2022-03-18 23:57:11 +01:00
4dafe424cf
De-duplicate showLicense methods
2022-03-18 13:48:07 -04:00
bc4a0a575c
Clean up the about package a bit
2022-03-18 13:18:23 -04:00
cf213affa2
Annotate some NonNulls, some lint cleaning
2022-03-18 13:15:44 -04:00
979a320347
Delete some unused code
2022-03-17 23:26:34 -04:00
20bddd8e47
Use Animator.addListener() KTX extension
2022-03-17 22:01:51 -04:00
86f335b01f
Create stub implementation for OnSeekBarChangeListener
2022-03-17 21:49:04 -04:00
67651354d5
Fixed conflicts
2022-03-16 15:58:46 +01:00
cefb52471f
Better naming
2022-03-16 15:52:30 +01:00
ee5e0e13b7
Made ``onClick`` less (cognitive) complex
2022-03-16 15:52:30 +01:00
30a8f25d52
Refactored code
2022-03-16 15:47:04 +01:00
d348c2099e
stupid checkstyle
2022-03-16 15:47:04 +01:00
6a400dda7b
delete unused methods
2022-03-16 15:47:03 +01:00
080c4ba680
Extract 2 view click listeners from Player
2022-03-16 15:47:03 +01:00
37aca3f1c7
Merge pull request #7981 from Stypox/sparse-items-deduplic
...
Deduplicate code for fetching stream info when sparse
2022-03-16 15:18:10 +01:00
0158f1363b
Merge pull request #7518 from mauriciocolli/remove-icon-duplicates
...
Remove icon duplicates and fix some theming issues
2022-03-15 21:51:04 +01:00
f47f2d13fa
Merge pull request #5878 from SpinHit/spinhit/addingDeleteConfirmation
...
Add a confirmation button when deleting all files in downloader
2022-03-15 21:49:46 +01:00
6fe6f4b3e0
Merge pull request #7978 from TacoTheDank/bumpSomeLibraries
...
Update some AndroidX libraries
2022-03-15 21:48:49 +01:00
00e4631b3b
Merge pull request #7963 from Stypox/android-tv-player
...
Improve player UI and navigability for Android TV
2022-03-15 21:41:48 +01:00
2e7503ff78
Merge branch 'dev' into bumpSomeLibraries
2022-03-15 21:34:41 +01:00
02fa5aa0fa
Implement appending queue to playlist in main player ( #8008 )
...
This also allows saving a remote playlist locally.
- Add an "Add to playlist" button to the queue menu in the Player.
- Move the appendAllToPlaylist functionality from PlayQueueActivity to
Player.
Fixes : #8004
2022-03-15 18:32:39 +01:00
9b4a67276a
Fix comments and rearrange code
2022-03-15 15:20:25 +01:00
b607a09125
Merge pull request #7975 from TacoTheDank/updateCheckerRewrite
...
Migrate app update checker to AndroidX Work
2022-03-15 14:20:40 +01:00
af89f05011
Merge pull request #7341 from ktprograms/external-play-hide-controls
...
Fix player controls not hiding if resumed from media button
2022-03-15 13:43:35 +01:00
b8b97fa6d4
Convert NewVersionWorker to Kotlin
2022-03-03 13:34:35 -05:00
71f141f3f8
Migrate CheckForNewAppVersion to Worker (and rename it)
2022-03-03 13:26:57 -05:00
81fef1be19
Migrate CheckForNewAppVersion to JobIntentService
2022-03-03 13:24:12 -05:00
0f175de599
Kotlin-ize ReleaseVersionUtil, merge with NewVersionManager
2022-03-03 13:21:50 -05:00
1602befc51
Move utility methods out of CheckForNewAppVersion
2022-03-03 13:19:06 -05:00
162a838afc
Deduplicate code for fetching stream info when sparse
...
Fixes #7941
2022-03-03 16:54:40 +01:00
e588abd4e7
Restore handling SPACE as play-pause only in fullscreen
...
When not in fullscreen SPACE should be not handled by the player, and hence result in a scroll down
2022-03-03 10:14:58 +01:00
f85b206bdf
Update some AndroidX libraries
2022-03-02 11:01:01 -05:00
2a9733fbaf
Fix error notification on KitKat
...
It was crashing due to a drawable icon being used; also use NotificationManagerCompat
2022-03-02 14:14:40 +01:00
96185faca6
Remove manual menu creation from some fragments
...
Doing this programmatically is just a no-go when themes are being set
in some other places (the toolbar is using a custom theme, in this
case), so, instead of hunting down the proper theme, just let the
system do its work.
2022-03-02 12:37:44 +01:00
5f16e4ef87
Replace R.string.yes with R.string.ok
...
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
2022-03-02 12:21:25 +01:00
483dc06ecb
Add confirmation button before deleting all files.
...
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
2022-03-02 11:31:52 +01:00
ab45efceab
- added: variable load check interval for progressive stream.
...
- added: preferences to allow user setting of above.
2022-03-01 20:14:53 +01:00
62c0e6605c
Remember adjustment step size for playback controls (speed and pitch)
...
- Add adjustment_step_key to settings_keys.xml to be used when
saving/loading the step size.
- Remove the global stepSize variable and the code that saves it to
outState/loads it from savedInstanceState because it's now saved to
Shared Preferences.
- Move initially setting step size to setupStepSizeSelector to be
consistent with the other view setup methods, using the value loaded
from Shared Preferences.
- Save the step size to Shared Preferences inside setStepSize.
Fixes : #7031
2022-03-01 16:27:20 +08:00
f1c6988552
Merge pull request #7952 from TacoTheDank/bumpKotlin
...
Update Kotlin to 1.6.10
2022-02-28 19:42:38 +01:00
146062d921
Fix player pop-ups not giving feedback on touch/focus
2022-02-27 18:49:16 +01:00
96c4201929
Fix controls shown below queue/segments list when using DPAD
...
Also invert if
2022-02-27 18:49:16 +01:00
a0bbcd2fee
Fix player queue/segments list buttons not focusable with DPAD
...
Now the in-player play queue and the segments list are closeable
2022-02-27 18:49:16 +01:00
3f7ba2e3d1
Merge pull request #7565 from haklc/dev
...
Change pitch by semitones
2022-02-27 09:58:38 +01:00
678edb1846
Update ktlint to 0.44.0
2022-02-26 16:08:10 -05:00
ccc3d38c45
Merge pull request #7910 from avently/equalscheck
...
Better equals check
2022-02-26 16:20:27 +01:00
37517c7dd1
Merge pull request #7570 from TeamNewPipe/improvement/infoItemDialogBuilder
...
Refactor generating InfoItemDialog's
2022-02-26 16:18:39 +01:00
a95318a4f9
Merge pull request #7349 from TiA4f8R/seamless-transition-players
...
Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only)
2022-02-26 16:16:18 +01:00
46fad32837
Merge pull request #7905 from Stypox/fix-room-unused-columns
...
Fix Room warning about unused columns during build
2022-02-26 16:15:01 +01:00
5be40f62f3
Merge pull request #7904 from Stypox/fix-raw-use-of-parameterized-class
...
Solve Java warning "Raw use of parameterized class"
2022-02-26 16:14:23 +01:00
5fea12d8eb
Small code improvements
...
Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization.
Used some Kotlin feature to reduce code.
2022-02-26 10:40:24 +01:00
1a000fecd5
Replace CircleImageView with ShapeableImageView
2022-02-23 15:11:25 -05:00
01e0dd50ad
Added serviceId check while comparing PlayQueues
2022-02-23 00:53:39 +03:00
d3bc184971
Clarify that only StramInfoItems are accepted by the builder
2022-02-21 21:50:30 +01:00
c42f29446d
Merge pull request #7924 from litetex/revert-7451
...
Revert "Respect cutouts when playing in MultiWindow"
2022-02-21 21:36:07 +01:00
1030e09fc1
Merge pull request #7901 from Stypox/player-small-refactor
...
Small refactor in player class
2022-02-21 20:48:03 +01:00
96b930cd07
Revert "Respect cutouts when playing in MultiWindow"
...
This reverts commit c92a90749e
2022-02-21 20:30:56 +01:00
de08edb831
Merge pull request #7898 from Stypox/regression-arc
...
Have fast seek overlay arc go under system ui
2022-02-21 20:19:22 +01:00
ee477b25e5
Move StreamDialogEntry.openChannelFragment to NavigationHelper
2022-02-20 20:26:27 +01:00
277f21d5b2
Move Classes related to InfoItemDIalog into own package
2022-02-20 20:17:04 +01:00
a7d5d9a1d6
Fix rebase
2022-02-20 20:17:04 +01:00
fd0d76e866
Apply feedback
...
Return this in InfoIrtemDialog.Builder methoods.
Move null checks for InfoIrtemDialog.Builder into constructor.
Fix and add some more docs.
2022-02-20 20:17:04 +01:00
646d8f431c
Use identical method names for creating the InfoItemDialog in Fragments
2022-02-20 20:17:04 +01:00
ef0d562702
Use ErrorActivity to notifiy about errors occourred while loading channel details
2022-02-20 20:17:04 +01:00
962fe9c36d
Use Context instead of Activity
...
Improve docs
2022-02-20 20:17:04 +01:00
50e2385e82
Add default entries automatically
2022-02-20 20:17:04 +01:00
1cd3ef5dba
Extract entries into beginning and end category
2022-02-20 20:17:04 +01:00
80157fc1be
Refactor generating InfoItemDialog's
...
This commit refactors the way `InfoItemDialog`s are generated. This is necessary because the old way used the `StreamDialogEntry` enum for most of the dialogs' content generation process. This required static variables and methods to store the entries which are used for the dialog to be build (See e.g.`enabledEntries` and methods like `generateCommands()`). In other words, `StreamDialogEntry` wasn't an enumeration anymore.
To address this issue, a `Builder` is introduced for the `InfoItemDialog`'s genration. The builder also comes with some default entries and and a specific order. Both can be used, but are not enforced.
A second problem that introduced a structure which was atypical for an enumeration was the usage of non-final attributes within `StreamDialogEntry` instances. These were needed, because the default actions needed to overriden in some cases.
To address this problem, the `StreamDialogEntry` enumeration was renamed to `StreamDialogDefaultEntry` and a new `StreamDialogEntry` class is used instead.
2022-02-20 20:17:04 +01:00
c5fc37150d
Update JavaDoc of VideoPlaybackResolver.getStreamSourceType()
2022-02-20 19:40:03 +01:00
8932adbf88
Apply suggested change and add a note about data consumption for HLS streams in background
...
ExoPlayer right now fetches HLS video tracks even if you disable them (with setRendererDisabled or setSelectionOverride).
See issue 9282 of ExoPlayer's issue tracker for more information.
2022-02-20 19:40:03 +01:00
d27d36b76a
Adress requested changes
2022-02-20 19:40:02 +01:00
ba804c7d4a
Use a enum to understand better what source type is used.
...
This commit also allows a seamless transition for livestreams.
2022-02-20 19:40:02 +01:00
3db37166b4
Apply suggestion
2022-02-20 19:40:02 +01:00
bf02a569ee
Fix a NullPointerException when the current metadata is null
...
Reload the play queue manager and set the recovery in this case, like on the current behavior (without this PR).
2022-02-20 19:40:02 +01:00
a1c5c94753
Add some comments and a JavaDoc
2022-02-20 19:40:01 +01:00
7a356412d5
Fixed typo
2022-02-20 19:40:01 +01:00
Robin
karyogamy
litetex
GGAutomaton
TiA4f8R
Mauricio Colli
Stypox
TacoTheDank
XiangRongLin
ktprograms
Spinhit
kt programs
Avently
TobiGr