ddda80a577
Fixed the bug
2023-01-17 22:31:22 +01:00
e9fcad4787
Fix SonarLint
2023-01-16 23:20:50 +01:00
640d4b0280
Fix more NPEs after OnSharedPreferenceChangeListener changes
2023-01-16 23:05:29 +01:00
b9378a7c1f
Fix NPEs after OnSharedPreferenceChangeListener changes
...
Apps targeting {@link android.os.Build.VERSION_CODES#R} on devices running OS versions {@link android.os.Build.VERSION_CODES#R Android R} or later, will receive a {@code null} value when preferences are cleared.
2023-01-16 22:30:28 +01:00
9ecd5dff09
Orientation is locked if there is no sensor for it
2023-01-16 13:56:45 +01:00
abe6dfb99c
Merge pull request #9671 from Stypox/fix-toast-crash-api33
...
Fix popup enablement toast crash on API 33
2023-01-15 21:05:05 +01:00
6e73c489de
Improve ellipsizing comments
2023-01-15 19:28:01 +01:00
489df0ed7d
Update NewPipeExtractor and properly linkify comments
2023-01-15 19:27:56 +01:00
7924bb5b6b
Thumbnails used in NewPipe are small (list/grid) mode. This PR facilitates full width thumbnails and dubbed as card mode.
2023-01-15 22:32:03 +05:30
c47d1af5e3
Merge pull request #9555 from Marius1501/make_the_channel_images_bigger
...
Made the channel-images in the grid list bigger
2023-01-15 15:16:09 +01:00
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
86997794ab
Merge pull request #9678 from Marius1501/change_whats_new_icon
...
Changed the What's New icon
2023-01-15 15:12:26 +01:00
22c201be39
Create text subpackage in util
2023-01-15 11:51:07 +01:00
cdd5e89b86
Add ability to copy hashtags, URLs and timestamps in descriptions on long-press
...
This commit adds the ability to copy to clipboard hashtags, URLs and timestamps
when long-pressing them.
Some changes in our TextView class related to text setting have been required
and metadata items are now using a NewPipeTextView instead of a standard
TextView.
Six new classes have been added:
- a custom LinkMovementMethod class;
- a custom ClickableSpan class, LongPressClickableSpan, in order to set a long
press event;
- a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils;
- three implementations of LongPressClickableSpan used when linkifying text:
- HashtagLongPressClickableSpan for hashtags;
- TimestampLongPressClickableSpan for timestamps;
- UrlLongPressClickableSpan for URLs.
2023-01-15 11:40:27 +01:00
764b6aa2b1
Made the channel-images in the grid list bigger
...
Also improved the handling of additional information (expanded description, video count, subscriber count)
2023-01-15 10:50:20 +01:00
f766ef2033
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
ef4a6238c8
See if playlists already contain a stream from db
2023-01-14 18:01:48 +01:00
b3554a6a49
Added the number of duplicates to the toast text.
2023-01-14 18:01:48 +01:00
5fb7b3266b
Removed the duplicate dialog and added another toast option
2023-01-14 18:01:48 +01:00
8b6e110635
Fixed the functionality, improved performance & general code cleanup
2023-01-14 18:01:47 +01:00
f5a1f915be
Continued working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
ac15339911
Started working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
fdfeac081a
Implemented a warning before adding duplicate to playlist.
2023-01-14 18:01:46 +01:00
31396a632f
Chenged the name of the icon
2023-01-14 09:21:37 +01:00
135fc08212
Implemented the "remove duplicates" feature.
2023-01-13 21:35:22 +01:00
5e3caf68a5
Chenged the What's New icon
2023-01-13 16:33:45 +01:00
262b3a2945
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs
...
Added the "What's New"-section to the default tabs
2023-01-13 13:25:02 +01:00
e44d09208c
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown
...
Fixed a bug that prevented the display of multiple empty playlists
2023-01-13 13:20:42 +01:00
38c4a1ed85
Fixed the "Remove Watched" bug
...
Reverted changes and fixed bug in a different way
2023-01-12 23:44:26 +01:00
fd8e92cf77
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail
...
Allow the user to permanently set a thumbnail
2023-01-12 23:27:50 +01:00
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
9514316be3
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
a15a5adacc
Merge pull request #9619 from Redirion/avoidreflectionifpossible
...
Check availability of Samsung DeX only on Samsung devices
2023-01-12 12:06:19 +01:00
b6e6d39985
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
48ae830262
Merge pull request #9653 from petlyh/fix-popup-crash
...
Ask for permission when enqueuing in a popup
2023-01-12 11:24:21 +01:00
03f5dd71a5
Merge pull request #9499 from pratyaksh1610/branch-9466
...
Added Language suffix for subtitle downloads
2023-01-11 19:46:51 +01:00
2afbe58722
UX improvements: keep user edits & do not reset cursor
2023-01-11 19:45:55 +01:00
0a64eac778
Added the "What's New"-section to the default tabs
2023-01-11 16:06:11 +01:00
ad605e2c5a
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
944e295ae7
Use Optional for simpler code
2023-01-11 15:14:18 +01:00
28109fef38
Improve showing of toast
...
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
2023-01-11 14:53:48 +01:00
40442f3f82
Utilize Lifecycle observer
...
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
2023-01-11 14:53:48 +01:00
61da167b4f
Oops, added back missing return;
2023-01-11 14:53:48 +01:00
c744f6756b
Fix Sonar reported code smell
2023-01-11 14:53:48 +01:00
de7057ac3a
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids
...
probably due to background restrictions on Android 10+
2023-01-11 14:53:48 +01:00
585bfff11d
Utilize a retained fragment to safekeep network requests in flight
...
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
2023-01-11 14:53:48 +01:00
0f9c20c986
Improve (un)registering FragmentLifecycleCallbacks
...
to avoid adding it multiple times and ensure proper cleanup
2023-01-11 14:53:48 +01:00
f860392ae9
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+
2023-01-11 14:53:48 +01:00
391830558e
Ensure our transparent activity doesn't block touch events to underlying windows
...
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
2023-01-11 14:53:48 +01:00
c1f37d8591
Also show toast in openDownloadDialog()
...
and lengthened a bit to inform user to wait...
2023-01-11 14:53:48 +01:00
b175774ad8
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change
...
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
2023-01-11 14:53:48 +01:00
73e32889b6
Don't finish() to allow recreate
...
when orientation change is on foot
2023-01-11 14:53:48 +01:00
400ee808e0
Set up theme/locale before super.create()
...
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
2023-01-11 14:53:48 +01:00
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
eb3363d4dd
Created the first draft.
2023-01-10 20:55:18 +01:00
edff696ecc
Ask for permission when enqueuing in a popup
2023-01-10 14:16:19 +01:00
9c19e9813a
Fixed a bug that caused multiple empty playlists to be not shown.
2023-01-08 11:53:42 +01:00
2679a4bf1e
Removed the "Unset Thumbnail" item if you can't use this feature
2023-01-04 16:21:16 +01:00
e8216b2e80
Apply code review suggestions.
2023-01-04 06:10:14 +05:30
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
f10d591462
Samsung DeX should only be checked on Samsung devices
...
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2023-01-03 15:12:02 +01:00
3e15c77a05
move string to donottranslate.xml and fix nits
2023-01-03 14:07:28 +05:30
1bb166a9e8
Merge pull request #9553 from Redirion/exo182
...
Update ExoPlayer to 2.18.2
2023-01-02 18:21:53 +01:00
8fa949537b
Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods
...
Use new NPE UTF8 Utils methods
2023-01-02 17:59:26 +01:00
7454b31788
Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback
...
Support audio only background for services only supporting video streams
2023-01-02 17:51:10 +01:00
b6488fe342
Merge pull request #8841 from Isira-Seneviratne/Notification_mode_ListAdapter
...
Use ListAdapter in NotificationModeConfigAdapter.
2023-01-02 14:47:25 +01:00
b1d9080a0f
Simplify disposables handling in notification mode settings
2023-01-02 14:45:11 +01:00
50269d0f5e
updated caption file name and clean code
2023-01-02 16:23:45 +05:30
f17155bb3f
Merge branch 'TeamNewPipe:dev' into exo182
2023-01-02 10:35:20 +01:00
7988fe0c5a
Use new NewPipe Extractor Utils methods.
2023-01-02 07:03:18 +05:30
f4a5b3bcbf
set 'playback in background button' visible if there are videostreams
2023-01-01 21:55:03 +01:00
6af2242d5d
Merge pull request #9521 from pratyaksh1610/branch-9518
...
Fixes #9518 : Crash fix when click "Add to playlist" while the current list is still loading
2022-12-31 23:31:58 +01:00
d21fac658b
Remove playlist details toasts
2022-12-31 23:30:17 +01:00
27f6c3b634
Merge pull request #9502 from Jared234/8585_download_in_queue
...
Added option to download items in the queue
2022-12-31 19:34:07 +01:00
b3bfec9505
Use correct fragment manager for download dialog
...
Tapping download on the long-press menu of queue items when the queue is shown inside the player would crash otherwise
2022-12-31 19:31:24 +01:00
367ece8ffa
Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking
...
Seeking no longer pauses the played video
2022-12-31 19:19:21 +01:00
661cd4c182
Merge pull request #9159 from Isira-Seneviratne/Refactor_VideoPlayerUi
...
Refactor VideoPlayerUi.
2022-12-31 19:01:19 +01:00
be856f71c8
Merge pull request #8847 from Isira-Seneviratne/Refactor_VideoDetailFragment
...
Refactor VideoDetailFragment.
2022-12-31 18:41:06 +01:00
97978033dd
Activate on click listeners only when not loading
...
For consistency with long click listeners, in VideoDetailFragment
2022-12-31 17:49:10 +01:00
413a1b504a
Refactor constrolsTouchListener code
2022-12-31 17:47:57 +01:00
69e8e4d63e
Merge pull request #9306 from Stypox/target-api-33
...
Set compileSdk and targetSdk to 33 (Android 13)
2022-12-31 14:49:30 +01:00
fb1360b72a
Use ListAdapter in NotificationModeConfigAdapter.
2022-12-29 06:14:46 +05:30
231e677b16
Merge pull request #8895 from Isira-Seneviratne/SparseArrayCompat
...
Use SparseArrayCompat.
2022-12-28 20:37:05 +01:00
fcac53cdc0
Merge pull request #9488 from Jared234/9353_night_theme_selection
...
Disabling night theme selection if auto theme is not used
2022-12-25 22:19:02 +01:00
dfc46c3b6c
Support audio only background for services only supporting video streams
...
Some services may only have video streams and no separate audio streams available.
This commit will add audio background playback support for those services.
It uses the video source as audio source for background playback.
2022-12-17 21:17:42 +01:00
eea4f0f41c
Update ExoPlayer to 2.18.2
2022-12-16 17:53:56 +01:00
12796920a3
Removed the wasPlaying variable
2022-12-10 21:56:04 +01:00
fedc26e3cb
Added migration to new database
2022-12-09 22:40:54 +01:00
1ac62541a8
Formatting, renaming and small fixes
2022-12-09 12:01:59 +01:00
c537776826
Fixes #9518
...
- Crash fix on clicking on add to playlist.
- Added toast when clicked on share button for better UI.
2022-12-09 14:09:40 +05:30
bf1ebf8733
Fixed some bugs and improved code quality
2022-12-08 23:31:20 +01:00
10a5741f36
Tried to implement the feature
2022-12-07 02:32:53 +01:00
c7d392e77e
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-12-06 20:21:28 +05:30
161007fe92
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-12-06 20:21:08 +05:30
5fc85fa2e0
Implemented suggestions
2022-12-05 21:21:46 +01:00
a6f57a8665
Merge pull request #9173 from Theta-Dev/video-sub-count
...
Show subscriber count on video details page
2022-12-04 20:50:13 +01:00
86ee94eb04
show subscriber count on player page
2022-12-04 20:45:09 +01:00
0923594e51
Added option to download items in the queue
2022-12-04 20:35:06 +01:00
3bb51875bc
Merge pull request #9501 from Stypox/import-subscriptions-hint
...
Add hint to improve discoverability of subscription import
2022-12-04 20:19:19 +01:00
10977eaefa
Show hint about how to import subscriptions when there are none
2022-12-04 19:16:47 +01:00
281ac13eed
Merge pull request #8883 from Douile/dev-enqueue-next-hide
...
Only show "Enqueue next" when in the middle of the queue
2022-12-04 18:43:45 +01:00
e5f30a07bf
Only show "Enqueue next" when in the middle of the queue
...
Add a check that the queue position is not the last in the queue before
showing "Enqueue next".
Previously the "Enqueue next" action would always be shown if the queue
length was greater than one, this meant even if you were at the end of
the queue (when "Enqueue" would have the same effect as "Enqueue next")
the action would still be shown.
2022-12-04 18:20:50 +01:00
9c4d5526f4
Merge pull request #8810 from Isira-Seneviratne/Math_floorDiv
...
Use Math.floorDiv().
2022-12-04 18:08:12 +01:00
1afb9cdba9
added Language suffix for subtitle downloads
2022-12-04 17:59:22 +05:30
6b210e1542
Apply ktlint formatting.
2022-12-04 12:01:57 +01:00
f1b15a95a4
Show toast when no updates are available.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-12-04 12:01:56 +01:00
8fc5fa979d
Added menu with tappable list items
2022-12-03 09:52:04 +01:00
a2f2d562f6
Disabling night theme selection if auto theme is not used
2022-12-01 13:01:58 +01:00
b0516fbf1d
Use BitmapCompat.createScaledBitmap().
2022-11-29 15:56:19 +01:00
9d01d88eed
Request permission to send notifications
2022-11-28 18:49:11 +01:00
6b89b44dcd
Merge pull request #8961 from dhruvpatidar359/Toast-Popup
...
Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+
2022-11-26 21:33:12 +01:00
e5af1c93ae
Seeking no longer pauses the played video
2022-11-26 15:35:13 +01:00
d6617007d4
Use SparseArrayCompat instead of SparseArray in StreamItemAdapter.
...
Make additional small improvements as well.
2022-11-22 18:31:58 +05:30
8db90ba449
Use SparseArrayCompat for thumbnails.
2022-11-22 17:51:54 +05:30
048b0972de
Set compileSdk and targetSdk to 33 (Android 13)
...
android:exported in now required in the manifest on all activities/services/receivers/providers. It was set to true for those that need to interact with outside apps or the OS, while others have exported=false.
This also required updating LeakCanary to the latest version as the older version being used was not using android:exported in AndroidManifest.xml.
2022-11-18 08:33:13 +01:00
a7989795e8
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-11-14 08:59:03 +05:30
a40f035810
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-11-14 08:58:45 +05:30
aad5e26f31
Merge pull request #8870 from Isira-Seneviratne/Locale_forLanguageTag
...
Use Locale.forLanguageTag().
2022-11-10 19:56:34 +05:30
627c6e29a2
Merge pull request #8316 from han-sz/fix_video_mouse_hover_overlay
...
Fix persistent hover overlay when in desktop/DeX mode or using a mouse/non-touch input
2022-11-09 17:10:01 +01:00
ef1e7e5b52
Merge branch 'master' into dev
2022-11-09 16:45:22 +01:00
abf1cc536d
Improve code of DeviceUtils.isDesktopMode
...
- Avoid NullPointerException crashes if there is no UiModeManager or desktop
system service mode
- Use final for every exception
- Suppress missing fields warnings
- Add missing NonNull annotation
2022-11-09 16:22:49 +01:00
c38f150562
Remove now obsolete API check.
2022-11-09 15:50:09 +01:00
d2b6bda7a2
Remove errant return.
2022-11-09 15:50:09 +01:00
9e5c68c575
Add check for input devices with cursor.
2022-11-09 15:50:06 +01:00
88eed6cc23
Add JSDoc comment and a performance note for `isDesktopMode`
2022-11-09 15:48:50 +01:00
a1773d166f
Fix JSDoc checkstyle warning
2022-11-09 15:44:36 +01:00
5e2ef7ff0d
Address review comments
2022-11-09 15:44:36 +01:00
cfda073aa5
Fix DeX mode check
2022-11-09 15:44:36 +01:00
ff774a1870
Fix persistent hover overlay when mouse connected
2022-11-09 15:44:27 +01:00
feb03f7e30
Use Math.floorDiv().
2022-11-09 20:01:40 +05:30
5c1af6d296
Group private Localization methods together.
2022-11-09 08:54:47 +05:30
6d812b86aa
Use Locale.forLanguageTag().
2022-11-09 08:51:12 +05:30
ef35b36eba
Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+
...
Signed-off-by: dhruv <dhruvpatidar35@gmail.com>
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
Co-authored-by: AudricV <74829229+AudricV@users.noreply.github.com>
2022-11-08 20:47:50 +01:00
3dc1adb69e
Add helper methods for adding PendingIntent mutability.
2022-11-07 17:12:22 +05:30
da61c9f915
Merge pull request #9298 from Stypox/fix-inconsistent-channel-groups
...
Fix inconsistent channel group list and items view mode
2022-11-05 21:11:51 +01:00
9472c36cbd
Merge pull request #9109 from TeamNewPipe/fix/overlayPlayQueueButton
...
Hide play queue button in VideoDetailsFragment when queue is empty
2022-11-05 20:28:14 +01:00
49c12a31e9
Fix wrongly calculated channel groups span count
2022-11-05 20:05:59 +01:00
fc061599f8
Fix inconsistent channel group list and item view mode
2022-11-04 18:21:35 +01:00
c8caf48cda
Merge pull request #9230 from Stypox/duplicate-feed-videos
...
Fix duplicate videos in feed group "All"
2022-11-03 17:23:05 +01:00
e4f97465a4
Use lambdas for VideoDetailFragment listeners.
2022-11-03 20:15:17 +05:30
e333197ed5
Use OnClickListener and OnLongClickListener lambdas in the player UIs.
2022-11-03 05:09:35 +05:30
51bdc30ed0
Use TextViewCompat.setCompoundDrawableTintList().
2022-11-01 06:31:35 +05:30
9d2ab61993
Merge pull request #9203 from Callisto404/add-chapter-timestamp-share
...
Added timestamped link sharing from the start of a chapter with a long hold press
2022-10-30 22:31:09 +01:00
8fdd828de4
Merge pull request #8739 from Isira-Seneviratne/Stream_average
...
Calculate search score using streams.
2022-10-30 22:09:55 +01:00
25795c3a96
Merge pull request #8706 from Isira-Seneviratne/Improve_LocalPlaylistFragment
...
Refactor removeWatchedStreams() in LocalPlaylistFragment.
2022-10-30 22:03:39 +01:00
7f3da04fee
Added an "isYouTube" check to start of long click handler
2022-10-30 13:48:03 +11:00
9524c6245d
Merge pull request #8747 from Isira-Seneviratne/Range_limit
...
Use range-limiting methods in more places.
2022-10-28 10:34:04 +02:00
57d2fe113a
Fix duplicate videos in feed "All"
2022-10-27 23:43:39 +02:00
2f6cb87bba
Use GROUP_ALL_ID instead of hardcoded -1
2022-10-27 23:32:19 +02:00
3cef7f3201
Merge pull request #9207 from cern1710/list-view-alt-alt-implementation
...
undefined
2022-10-27 22:48:03 +02:00
f712ea34e0
Merge remote-tracking branch 'origin/list-view-alt-alt-implementation' into list-view-alt-alt-implementation
2022-10-28 04:54:42 +11:00
a44b7c9c9e
Disabled animations for subscription fragment
2022-10-28 04:54:33 +11:00
4b32890b5f
Fix random crash in SubscriptionFragment
2022-10-27 18:45:06 +02:00
a41aa01461
Solve two SonarCloud smells
2022-10-27 17:52:17 +02:00
ea875c59af
Deduplicate isGridLayout calls
2022-10-27 17:25:06 +02:00
a22162ffac
Add an Open in browser button on error panel ( #9180 )
...
* add a open in browser button
* Corrected a few things that needed to be changed
* Remove unneeded changes.
* Remove unneeded changes.
* Add showAndSetOpenInBrowserButtonAction function
* modify some codes
2022-10-27 14:38:08 +02:00
83d16dc656
Fix flickering in channel groups list
2022-10-27 14:01:04 +02:00
8ceefee1e3
Put "New feed group" item at the top
2022-10-27 13:51:56 +02:00
8f157be7e0
Revert changes
2022-10-27 12:15:36 +11:00
0e169951f7
Fix grid/list toggle implementation of feed
2022-10-26 23:20:32 +02:00
f7e10eb094
Fully working card and list view
2022-10-26 21:05:55 +11:00
0d73d193ad
Added Toast Notification "Hold to enqueue" ( #9196 )
...
* Added Toast Notification "Hold to enqueue"
* Check if enqueue tips are enabled
* created function showHoldToAppendTipIfNeeded() for toast message
2022-10-26 11:35:03 +02:00
40815086ad
Fix crash when the user clicks download then quits the history fragment ( #9143 )
...
* Fix crash when the user clicks download then quits the history fragment
* add a nonnull annotation to the context parameter in the DownloadDialog constructor.
* Revert "Merge branch 'TeamNewPipe:dev' into fix/HistoryFragmentDownloadDialogCrash"
This reverts commit 968d7a7603968d7a760352963ba37dfb3ed83d51f9e1835e71
2022-10-26 11:22:32 +02:00
16860603fd
Add Link to FAQ in the app ( #9164 )
...
* Link to FAQ in the app #4447
* remove redundant comments produced by me.
* Update app/src/main/res/values/strings.xml
Update FAQ description
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Format the CodeStyle and readjust the layout.
* Update app/src/main/res/layout/fragment_about.xml
Remove redundant id.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/layout/fragment_about.xml
Remove redundant id.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/values/strings.xml
Keep the uppercase for consistency.
Co-authored-by: Stypox <stypox@pm.me>
* Update app/src/main/res/values/strings.xml
Modify the description of FAQ.
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2022-10-26 09:59:51 +02:00
c607089cbb
Altered grid view similar to Youtube app layout
2022-10-26 00:06:48 +11:00
28464344c1
Finalized design for vertical card view and removed unneeded variables in SubscriptionFragment.kt
2022-10-25 11:43:25 +11:00
ed68e3bd46
Fully working toggle button that change between vertical and horizontal view
2022-10-25 10:54:27 +11:00
082d7a3f18
Added working binding for a "new" button that works in the list layout.
2022-10-25 02:38:31 +11:00
6eddaa0d38
Added boolean to handle feed groups. May need a better solution for this
2022-10-25 02:20:14 +11:00
1aa1a0287e
Could toggle between list view and grid view...once. Requires bug fixing on refreshing
2022-10-25 02:01:57 +11:00
3bfcb16f9a
Bug: SubscriptionViewModel.kt did not map values for FeedGroupCardVerticalItem in line 26
2022-10-25 00:32:21 +11:00
f37d869ea2
Button can be toggled but not all strings have been fed
2022-10-24 23:01:02 +11:00
78547b4fa4
Created a list view for channel group.
2022-10-24 18:55:08 +11:00
29e56b9f2d
Created a button in SubscriptionFragment.kt that reads whether button is clicked
2022-10-24 16:55:12 +11:00
83357ca67e
Added sharing a link with timestamp from a chapter into the long click for each chapter
2022-10-24 14:14:41 +11:00
8482bf9fed
Created a non-functional button in HeaderWithMenuItem.kt
2022-10-23 23:43:52 +11:00
4a278ef102
Hide play queue button in VideoDetailsFragment mini player when the play queue is empty
...
Related PR introducing the button: #8946
2022-10-11 21:27:04 +02:00
7ab8f9f112
Merge pull request #9079 from devlearner/fix-screen-rotate
...
Fix `DownloadDialog` crash on screen rotation
2022-10-10 11:18:50 +02:00
7fca0e0786
Merge pull request #9065 from devlearner/fix-spannable-cast
...
Fix potential cast exception in comments text
2022-10-10 10:51:32 +02:00
ed4eb124e4
Merge pull request #8734 from Stypox/feed-group-factory
...
Improve `FeedGroupDialogViewModel` factory
2022-10-09 19:35:47 +02:00
5b213a19e4
Merge pull request #8934 from Isira-Seneviratne/LinkifyCompat
...
Use LinkifyCompat.
2022-10-09 12:07:50 +02:00
8bc8355b68
Merge pull request #8946 from HybridAU/add_play_queue_button_to_video_details_fragment
...
Add play queue button to video details fragment
2022-10-06 18:55:50 +02:00
ab99c14fd2
Fix crash on screen rotation
2022-10-06 18:15:36 +08:00
1047158a66
Fix potential cast exception
...
when casting to `Spannable` in `CommentTextOnTouchListener`
2022-10-04 17:31:35 +08:00
489f052ef9
Fix feed menu tooltips (silly copy-paste error)
2022-09-19 11:21:42 +02:00
bf55ed262f
Merge pull request #8972 from Stypox/fix-suggestions-listadapter
...
Fix various issues in the search suggestions list
2022-09-19 08:54:55 +02:00
f26bf33ead
Merge pull request #8966 from Stypox/feed-menuitem-tooltip
...
Show correct tooltips for actions in feed
2022-09-19 08:54:06 +02:00
9db0133a5b
Add play queue button to video details fragment
...
* Add play queue button to video details fragment
* Use existing ic_list icon
* Still open play queue even when queue is empty
* Change app:srcCompat to android:src
2022-09-14 21:00:44 +08:00
28b34f3796
Fix scroll issues in suggestion list
...
Before if the list before updating contained item 'test' at position 0 and after updating that value went to the bottom, the list would incorrectly scroll to the bottom to follow that item. Now the scrolling is done after the list is updated.
2022-09-14 14:39:32 +02:00
1f57c87859
Disable suggestion list animations: not meaningful
...
The animations were just in the way and did not help in choosing items, since the suggestion items keep changing too much.
2022-09-14 14:04:22 +02:00
fbf5549182
Fix wrong icons being set on suggestion items
...
The diff util wrongly considered as equal two items with the same text but with different `fromHistory` value
2022-09-14 14:01:59 +02:00
051c572e7f
Show correct tooltips for actions in feed
2022-09-13 15:26:04 +02:00
464a646671
Use LinkifyCompat.
2022-09-06 09:27:50 +05:30
ed87465565
Only update notification large icon when it changes
2022-08-28 23:14:02 +02:00
f9109ebc81
Use player.getThumbnail() instead of field in VideoPlayerUi
2022-08-28 18:35:21 +02:00
4a7af6f9ac
Remove thumbnail before sync, if outdated
...
Also refactor onPlaybackSynchronize and add comments
2022-08-28 18:32:27 +02:00
7fbef35daa
Unify onThumbnailLoaded calls to ensure UIs always updated
2022-08-28 17:24:51 +02:00
f9994abb94
Prevent tapping on thumbnail if video details are not loaded
2022-08-26 18:54:51 +02:00
ca0f56eea8
Avoid setting invalid states to bottom sheet callback
2022-08-26 18:54:51 +02:00
500acce178
Fix regression in screen rotation animation
2022-08-26 18:54:51 +02:00
6805c75c9c
Fix surface view not resizing video correctly
...
Also fix yet another random null pointer exception that could happen when adding the video player view
2022-08-26 18:54:51 +02:00
59d1ded94e
Fixed sonar detected problems
...
+ Automatically fixed code style (imports)
2022-08-25 17:02:53 +02:00
973a966011
Review suggestions
2022-08-25 17:02:53 +02:00
510efaae97
Keep strong reference to Picasso thumbnail loading target
...
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
2022-08-25 17:02:52 +02:00
11bd2369e5
Merge MediaSessionManager into MediaSessionPlayerUi
2022-08-25 17:02:52 +02:00
f80d1dc48d
Let exoplayer decide when to update metadata
...
Though still make sure metadata is updated after the thumbnail is loaded.
This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
2022-08-25 17:02:52 +02:00
8bff445ec3
Remove useless checks before updating metadata
...
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
2022-08-25 17:02:51 +02:00
d73ca41cfe
Even when thumbnails should not be shown, set it to null in notification
...
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
2022-08-25 17:02:51 +02:00
f3a9b81b67
Fix sometimes seeing outdated thumbnail in notification
...
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
2022-08-25 17:02:51 +02:00
3cc43e9fb9
Fix thumbnail sometimes not set to media session metadata
...
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
2022-08-25 17:00:41 +02:00
bc33322d4b
Remove useless MediaSessionCallback
...
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
2022-08-25 17:00:41 +02:00
c054ea0737
Create MediaSessionPlayerUi
2022-08-25 17:00:41 +02:00
52dbfdee00
Keep strong references to Picasso notification icon loading targets
...
Before the Target would sometimes be garbage collected before being called with the loaded channel icon, since Picasso holds weak references to targets. This meant that sometimes a new streams notification would not be shown, because the lambda that should have shown it had already been garbage collected.
2022-08-25 16:41:51 +02:00
5e0788b99c
Use ListAdapter in PreferenceSearchAdapter.
2022-08-18 19:52:51 +05:30
67669c286b
Use ListAdapter in SuggestionListAdapter.
2022-08-18 19:52:51 +05:30
408a71cfdc
Calculate search score using streams.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-08-15 07:26:56 +05:30
6399e39507
Remove from playlist only upon selecting the option and not afterwards.
2022-08-15 07:26:36 +05:30
f9443f7421
Refactor removeWatchedStreams() in LocalPlaylistFragment.
2022-08-15 07:26:36 +05:30
4f6b5b3b89
Use ListAdapter in PeertubeInstanceListFragment.
2022-08-15 07:26:02 +05:30
571bf397c5
Merge pull request #8666 from TacoTheDank/filepicker
...
Update FilePicker to our custom fork and disable Jetifier
2022-08-12 09:15:34 +02:00
e136a6f915
Use range-limiting methods in more places.
2022-08-08 07:10:16 +05:30
74921d3afa
Merge pull request #8740 from Isira-Seneviratne/Cleanup_methods
...
Remove some unused methods.
2022-08-06 22:45:40 +02:00
edd2b110b0
Merge pull request #8738 from Isira-Seneviratne/Collectors_joining
...
Use Collectors.joining().
2022-08-06 22:31:31 +02:00
80fb21e031
Merge pull request #8728 from Isira-Seneviratne/Comparator_factory
...
Use Comparator factory methods.
2022-08-06 11:56:44 +02:00
ebd06bdd24
Improve comment
2022-08-06 11:56:00 +02:00
6f86e21605
Merge pull request #8724 from Isira-Seneviratne/toArray_improvements
...
Use toArray() with zero-length arrays.
2022-08-06 11:33:05 +02:00
816154c7cb
Merge pull request #8737 from Isira-Seneviratne/Fix_coerceIn
...
Replace coerceIn() with MathUtils.clamp().
2022-08-06 11:16:06 +02:00
d9230c0103
Merge pull request #8708 from Isira-Seneviratne/Reduce_View.kt_size
...
Reduce View.kt size.
2022-08-06 10:59:10 +02:00
5c7dfd1d69
Remove unused method.
2022-08-06 06:54:21 +05:30
7aacaf8c38
Use Collectors.joining().
2022-08-06 06:54:21 +05:30
ee6a279596
Remove unused methods in HistoryRecordManager.
2022-08-06 05:09:54 +05:30
a9af1dfdd2
Applied code review changes.
2022-08-05 06:54:03 +05:30
fc46233baf
Use toArray() with zero-length arrays.
2022-08-05 06:50:55 +05:30
2eec2e9128
Replace coerceIn() with MathUtils.clamp().
2022-08-05 06:19:06 +05:30
8024b437e9
Add reusable classes extending AnimatorListenerAdapter.
2022-08-05 06:08:13 +05:30
d1f3f15478
Use Comparator.comparingDouble().
2022-08-05 05:36:39 +05:30
059cfcbad2
Use Comparator factory methods in ListHelper.
2022-08-05 05:36:21 +05:30
1a8f396e77
Merge pull request #8721 from Isira-Seneviratne/OnClickGesture_interface
...
Make OnClickGesture an interface.
2022-08-04 16:15:54 +02:00
5640365fbd
Merge pull request #8682 from Isira-Seneviratne/Refactor_LicenseFragmentHelper
...
Refactor LicenseFragmentHelper.
2022-08-04 11:18:40 +02:00
4b7de86a92
Clean up getLicenseStylesheet().
2022-08-04 11:17:30 +02:00
24ec642181
Merge pull request #8669 from Isira-Seneviratne/Remove_setBottomSheetCallback
...
Remove uses of setBottomSheetCallback().
2022-08-04 11:03:57 +02:00
8dce66d76f
Improve FeedGroupDialogViewModel factory
2022-08-04 10:49:33 +02:00
ffc1d9a212
Merge pull request #8656 from Isira-Seneviratne/Use_WindowMetrics
...
Use WindowMetrics API.
2022-08-04 10:12:32 +02:00
7f018b90db
Merge branch 'dev' into OnClickGesture_interface
2022-08-04 06:10:39 +05:30
368c6c0ccb
Merge pull request #8709 from Isira-Seneviratne/Tags_case_insensitive
...
Sort tags case-insensitively.
2022-08-03 22:43:50 +02:00
5c4874b90f
Merge pull request #8701 from Isira-Seneviratne/Use_stackTraceToString
...
Use Throwable.stackTraceToString().
2022-08-03 21:04:22 +02:00
3420faab08
Merge pull request #8661 from Stypox/player-refactor-npe
...
Fix random NullPointerException when adding video player view
2022-08-02 11:09:50 +02:00
a548b34811
Merge pull request #8692 from TacoTheDank/bumpMaterial
...
Update Google Material to 1.6.1
2022-08-02 11:05:24 +02:00
ad30eb809c
Merge branch 'dev' into bumpFragment
2022-08-02 10:54:39 +02:00
Jared Fantaye
TobiGr
Stypox
Robin
Mahendran
AudricV
ge78fug
Isira Seneviratne
devlearner
petlyh
pratyaksh1610
Robin
evermind
ThetaDev
Douile
Isira Seneviratne
cybersphinx
Hanif Shersy
dhruvpatidar359
Daniel M
Samuel Wu
YonghaoDeng
Jfax510
plasticanu
Yuuu2990
HybridAU
litetex