d5b54c85ed
Made some small adjustments to the database query
2023-02-09 20:41:22 +01:00
75292e099c
Larger channel cards in search results
...
- Thumbnail larger (100dp) than the usual (92dp) throughout the app
- Description lint count is 8 (normally 3)
2023-02-09 06:15:22 +05:30
e0cb2892b8
Merge branch 'master' into dev
2023-02-08 22:48:14 +01:00
4cc653fdf1
Fix opening links on Android 12+
2023-02-07 22:39:12 +01:00
4c5c2a3d79
Merge pull request #9693 from Redirion/accelerometerfix
...
Orientation is locked if there is no sensor for it
2023-02-07 20:07:45 +01:00
26b29ca78d
Made the requested color changes
2023-02-07 18:46:40 +01:00
e947e86eae
Make positions in list depend on watch history, remove confusing animations
...
The following is the list of all commits squashed together:
Regain function for option `Positions in lists`
use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.
fix #8176 by eliminating exit delay
Regain function for option `Positions in lists`
update code with developer's comments
apply static import to methods in util class DependentPreferenceHelper
Regain function for option `Positions in lists`
use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.
fix behavior for displaying progress bar when autoplay off but video resume on
not to retrieve unnecessary states when position in lists disabled
fix mistake in code
simplify conditional logic
update doc comment and remove unused method
Fix not showing duration if position indicators disabled
Positions in lists only depends on watch history
2023-02-07 09:48:18 +01:00
5d3955854e
Fixed the merge conflict
2023-02-05 21:21:02 +01:00
3ff4b713e8
Merge branch 'dev' into 9458_faulty_playlist_thumbnail_update
2023-02-05 20:45:44 +01:00
68097568d5
Fixed the bug by replacing the thumbnail_url with the thumbnail_stream_id
2023-02-05 20:32:34 +01:00
cd8d57040c
Implemented the feature using multiple checkboxes
2023-02-04 18:48:27 +01:00
e0ba872b66
Revert "Update ExoPlayer to 2.18.2"
...
This commit reverts 1bb166a
2023-02-03 18:33:35 +01:00
9c82441c19
Implemented the feature and fixed some small issues
2023-02-01 23:10:31 +01:00
38db0cc713
Changed the color
2023-01-31 16:07:57 +01:00
ee217eb9b7
Merge branch 'TeamNewPipe:dev' into tabs_on_bottom
2023-01-31 13:37:47 +01:00
d2d324f2dd
First draft of the new feature
2023-01-30 22:37:24 +01:00
ca421c28a1
Merge pull request #9538 from Jared234/4186_warning_duplicates_in_playlist
...
Handle duplicate streams in the "Add to playlist" dialog
2023-01-29 10:36:31 +01:00
102975aeb3
Improve handling playlist duplicate indicator
2023-01-29 10:32:32 +01:00
cd12503f99
Merge pull request #9631 from TeamNewPipe/update-npe
...
Update NewPipeExtractor and properly linkify comments
2023-01-28 22:40:19 +01:00
1e724eba6c
Merge pull request #9706 from Jared234/9131_bug_background_player
...
Fixed a bug that caused the background player to stop working
2023-01-28 21:56:00 +01:00
c70ce791db
Added the duplicate indicator explanation & removed some unnecessary functions
2023-01-27 15:37:33 +01:00
0821f6463a
Added bottom main-tabs feature
2023-01-25 19:25:57 +01:00
5b3f8a3d30
Replaced the equals method
2023-01-21 14:56:55 +01:00
e26c038565
Made some small adjustments
2023-01-20 11:55:50 +01:00
ddda80a577
Fixed the bug
2023-01-17 22:31:22 +01:00
e9fcad4787
Fix SonarLint
2023-01-16 23:20:50 +01:00
640d4b0280
Fix more NPEs after OnSharedPreferenceChangeListener changes
2023-01-16 23:05:29 +01:00
b9378a7c1f
Fix NPEs after OnSharedPreferenceChangeListener changes
...
Apps targeting {@link android.os.Build.VERSION_CODES#R} on devices running OS versions {@link android.os.Build.VERSION_CODES#R Android R} or later, will receive a {@code null} value when preferences are cleared.
2023-01-16 22:30:28 +01:00
9ecd5dff09
Orientation is locked if there is no sensor for it
2023-01-16 13:56:45 +01:00
abe6dfb99c
Merge pull request #9671 from Stypox/fix-toast-crash-api33
...
Fix popup enablement toast crash on API 33
2023-01-15 21:05:05 +01:00
6e73c489de
Improve ellipsizing comments
2023-01-15 19:28:01 +01:00
489df0ed7d
Update NewPipeExtractor and properly linkify comments
2023-01-15 19:27:56 +01:00
7924bb5b6b
Thumbnails used in NewPipe are small (list/grid) mode. This PR facilitates full width thumbnails and dubbed as card mode.
2023-01-15 22:32:03 +05:30
c47d1af5e3
Merge pull request #9555 from Marius1501/make_the_channel_images_bigger
...
Made the channel-images in the grid list bigger
2023-01-15 15:16:09 +01:00
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
86997794ab
Merge pull request #9678 from Marius1501/change_whats_new_icon
...
Changed the What's New icon
2023-01-15 15:12:26 +01:00
22c201be39
Create text subpackage in util
2023-01-15 11:51:07 +01:00
cdd5e89b86
Add ability to copy hashtags, URLs and timestamps in descriptions on long-press
...
This commit adds the ability to copy to clipboard hashtags, URLs and timestamps
when long-pressing them.
Some changes in our TextView class related to text setting have been required
and metadata items are now using a NewPipeTextView instead of a standard
TextView.
Six new classes have been added:
- a custom LinkMovementMethod class;
- a custom ClickableSpan class, LongPressClickableSpan, in order to set a long
press event;
- a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils;
- three implementations of LongPressClickableSpan used when linkifying text:
- HashtagLongPressClickableSpan for hashtags;
- TimestampLongPressClickableSpan for timestamps;
- UrlLongPressClickableSpan for URLs.
2023-01-15 11:40:27 +01:00
764b6aa2b1
Made the channel-images in the grid list bigger
...
Also improved the handling of additional information (expanded description, video count, subscriber count)
2023-01-15 10:50:20 +01:00
f766ef2033
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
ef4a6238c8
See if playlists already contain a stream from db
2023-01-14 18:01:48 +01:00
b3554a6a49
Added the number of duplicates to the toast text.
2023-01-14 18:01:48 +01:00
5fb7b3266b
Removed the duplicate dialog and added another toast option
2023-01-14 18:01:48 +01:00
8b6e110635
Fixed the functionality, improved performance & general code cleanup
2023-01-14 18:01:47 +01:00
f5a1f915be
Continued working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
ac15339911
Started working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
fdfeac081a
Implemented a warning before adding duplicate to playlist.
2023-01-14 18:01:46 +01:00
31396a632f
Chenged the name of the icon
2023-01-14 09:21:37 +01:00
135fc08212
Implemented the "remove duplicates" feature.
2023-01-13 21:35:22 +01:00
5e3caf68a5
Chenged the What's New icon
2023-01-13 16:33:45 +01:00
262b3a2945
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs
...
Added the "What's New"-section to the default tabs
2023-01-13 13:25:02 +01:00
e44d09208c
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown
...
Fixed a bug that prevented the display of multiple empty playlists
2023-01-13 13:20:42 +01:00
38c4a1ed85
Fixed the "Remove Watched" bug
...
Reverted changes and fixed bug in a different way
2023-01-12 23:44:26 +01:00
fd8e92cf77
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail
...
Allow the user to permanently set a thumbnail
2023-01-12 23:27:50 +01:00
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
9514316be3
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
a15a5adacc
Merge pull request #9619 from Redirion/avoidreflectionifpossible
...
Check availability of Samsung DeX only on Samsung devices
2023-01-12 12:06:19 +01:00
b6e6d39985
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
48ae830262
Merge pull request #9653 from petlyh/fix-popup-crash
...
Ask for permission when enqueuing in a popup
2023-01-12 11:24:21 +01:00
03f5dd71a5
Merge pull request #9499 from pratyaksh1610/branch-9466
...
Added Language suffix for subtitle downloads
2023-01-11 19:46:51 +01:00
2afbe58722
UX improvements: keep user edits & do not reset cursor
2023-01-11 19:45:55 +01:00
0a64eac778
Added the "What's New"-section to the default tabs
2023-01-11 16:06:11 +01:00
ad605e2c5a
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
944e295ae7
Use Optional for simpler code
2023-01-11 15:14:18 +01:00
28109fef38
Improve showing of toast
...
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
2023-01-11 14:53:48 +01:00
40442f3f82
Utilize Lifecycle observer
...
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
2023-01-11 14:53:48 +01:00
61da167b4f
Oops, added back missing return;
2023-01-11 14:53:48 +01:00
c744f6756b
Fix Sonar reported code smell
2023-01-11 14:53:48 +01:00
de7057ac3a
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids
...
probably due to background restrictions on Android 10+
2023-01-11 14:53:48 +01:00
585bfff11d
Utilize a retained fragment to safekeep network requests in flight
...
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
2023-01-11 14:53:48 +01:00
0f9c20c986
Improve (un)registering FragmentLifecycleCallbacks
...
to avoid adding it multiple times and ensure proper cleanup
2023-01-11 14:53:48 +01:00
f860392ae9
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+
2023-01-11 14:53:48 +01:00
391830558e
Ensure our transparent activity doesn't block touch events to underlying windows
...
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
2023-01-11 14:53:48 +01:00
c1f37d8591
Also show toast in openDownloadDialog()
...
and lengthened a bit to inform user to wait...
2023-01-11 14:53:48 +01:00
b175774ad8
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change
...
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
2023-01-11 14:53:48 +01:00
73e32889b6
Don't finish() to allow recreate
...
when orientation change is on foot
2023-01-11 14:53:48 +01:00
400ee808e0
Set up theme/locale before super.create()
...
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
2023-01-11 14:53:48 +01:00
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
eb3363d4dd
Created the first draft.
2023-01-10 20:55:18 +01:00
edff696ecc
Ask for permission when enqueuing in a popup
2023-01-10 14:16:19 +01:00
9c19e9813a
Fixed a bug that caused multiple empty playlists to be not shown.
2023-01-08 11:53:42 +01:00
2679a4bf1e
Removed the "Unset Thumbnail" item if you can't use this feature
2023-01-04 16:21:16 +01:00
e8216b2e80
Apply code review suggestions.
2023-01-04 06:10:14 +05:30
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
f10d591462
Samsung DeX should only be checked on Samsung devices
...
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2023-01-03 15:12:02 +01:00
3e15c77a05
move string to donottranslate.xml and fix nits
2023-01-03 14:07:28 +05:30
1bb166a9e8
Merge pull request #9553 from Redirion/exo182
...
Update ExoPlayer to 2.18.2
2023-01-02 18:21:53 +01:00
8fa949537b
Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods
...
Use new NPE UTF8 Utils methods
2023-01-02 17:59:26 +01:00
7454b31788
Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback
...
Support audio only background for services only supporting video streams
2023-01-02 17:51:10 +01:00
b6488fe342
Merge pull request #8841 from Isira-Seneviratne/Notification_mode_ListAdapter
...
Use ListAdapter in NotificationModeConfigAdapter.
2023-01-02 14:47:25 +01:00
b1d9080a0f
Simplify disposables handling in notification mode settings
2023-01-02 14:45:11 +01:00
50269d0f5e
updated caption file name and clean code
2023-01-02 16:23:45 +05:30
f17155bb3f
Merge branch 'TeamNewPipe:dev' into exo182
2023-01-02 10:35:20 +01:00
7988fe0c5a
Use new NewPipe Extractor Utils methods.
2023-01-02 07:03:18 +05:30
f4a5b3bcbf
set 'playback in background button' visible if there are videostreams
2023-01-01 21:55:03 +01:00
6af2242d5d
Merge pull request #9521 from pratyaksh1610/branch-9518
...
Fixes #9518 : Crash fix when click "Add to playlist" while the current list is still loading
2022-12-31 23:31:58 +01:00
d21fac658b
Remove playlist details toasts
2022-12-31 23:30:17 +01:00
27f6c3b634
Merge pull request #9502 from Jared234/8585_download_in_queue
...
Added option to download items in the queue
2022-12-31 19:34:07 +01:00
b3bfec9505
Use correct fragment manager for download dialog
...
Tapping download on the long-press menu of queue items when the queue is shown inside the player would crash otherwise
2022-12-31 19:31:24 +01:00
367ece8ffa
Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking
...
Seeking no longer pauses the played video
2022-12-31 19:19:21 +01:00
661cd4c182
Merge pull request #9159 from Isira-Seneviratne/Refactor_VideoPlayerUi
...
Refactor VideoPlayerUi.
2022-12-31 19:01:19 +01:00
be856f71c8
Merge pull request #8847 from Isira-Seneviratne/Refactor_VideoDetailFragment
...
Refactor VideoDetailFragment.
2022-12-31 18:41:06 +01:00
97978033dd
Activate on click listeners only when not loading
...
For consistency with long click listeners, in VideoDetailFragment
2022-12-31 17:49:10 +01:00
413a1b504a
Refactor constrolsTouchListener code
2022-12-31 17:47:57 +01:00
69e8e4d63e
Merge pull request #9306 from Stypox/target-api-33
...
Set compileSdk and targetSdk to 33 (Android 13)
2022-12-31 14:49:30 +01:00
fb1360b72a
Use ListAdapter in NotificationModeConfigAdapter.
2022-12-29 06:14:46 +05:30
231e677b16
Merge pull request #8895 from Isira-Seneviratne/SparseArrayCompat
...
Use SparseArrayCompat.
2022-12-28 20:37:05 +01:00
fcac53cdc0
Merge pull request #9488 from Jared234/9353_night_theme_selection
...
Disabling night theme selection if auto theme is not used
2022-12-25 22:19:02 +01:00
dfc46c3b6c
Support audio only background for services only supporting video streams
...
Some services may only have video streams and no separate audio streams available.
This commit will add audio background playback support for those services.
It uses the video source as audio source for background playback.
2022-12-17 21:17:42 +01:00
eea4f0f41c
Update ExoPlayer to 2.18.2
2022-12-16 17:53:56 +01:00
12796920a3
Removed the wasPlaying variable
2022-12-10 21:56:04 +01:00
fedc26e3cb
Added migration to new database
2022-12-09 22:40:54 +01:00
1ac62541a8
Formatting, renaming and small fixes
2022-12-09 12:01:59 +01:00
c537776826
Fixes #9518
...
- Crash fix on clicking on add to playlist.
- Added toast when clicked on share button for better UI.
2022-12-09 14:09:40 +05:30
bf1ebf8733
Fixed some bugs and improved code quality
2022-12-08 23:31:20 +01:00
10a5741f36
Tried to implement the feature
2022-12-07 02:32:53 +01:00
c7d392e77e
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-12-06 20:21:28 +05:30
161007fe92
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-12-06 20:21:08 +05:30
5fc85fa2e0
Implemented suggestions
2022-12-05 21:21:46 +01:00
a6f57a8665
Merge pull request #9173 from Theta-Dev/video-sub-count
...
Show subscriber count on video details page
2022-12-04 20:50:13 +01:00
86ee94eb04
show subscriber count on player page
2022-12-04 20:45:09 +01:00
0923594e51
Added option to download items in the queue
2022-12-04 20:35:06 +01:00
3bb51875bc
Merge pull request #9501 from Stypox/import-subscriptions-hint
...
Add hint to improve discoverability of subscription import
2022-12-04 20:19:19 +01:00
10977eaefa
Show hint about how to import subscriptions when there are none
2022-12-04 19:16:47 +01:00
281ac13eed
Merge pull request #8883 from Douile/dev-enqueue-next-hide
...
Only show "Enqueue next" when in the middle of the queue
2022-12-04 18:43:45 +01:00
e5f30a07bf
Only show "Enqueue next" when in the middle of the queue
...
Add a check that the queue position is not the last in the queue before
showing "Enqueue next".
Previously the "Enqueue next" action would always be shown if the queue
length was greater than one, this meant even if you were at the end of
the queue (when "Enqueue" would have the same effect as "Enqueue next")
the action would still be shown.
2022-12-04 18:20:50 +01:00
9c4d5526f4
Merge pull request #8810 from Isira-Seneviratne/Math_floorDiv
...
Use Math.floorDiv().
2022-12-04 18:08:12 +01:00
1afb9cdba9
added Language suffix for subtitle downloads
2022-12-04 17:59:22 +05:30
6b210e1542
Apply ktlint formatting.
2022-12-04 12:01:57 +01:00
f1b15a95a4
Show toast when no updates are available.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-12-04 12:01:56 +01:00
8fc5fa979d
Added menu with tappable list items
2022-12-03 09:52:04 +01:00
a2f2d562f6
Disabling night theme selection if auto theme is not used
2022-12-01 13:01:58 +01:00
b0516fbf1d
Use BitmapCompat.createScaledBitmap().
2022-11-29 15:56:19 +01:00
9d01d88eed
Request permission to send notifications
2022-11-28 18:49:11 +01:00
6b89b44dcd
Merge pull request #8961 from dhruvpatidar359/Toast-Popup
...
Remove the redundant/overlapping toast "Copied to clipboard" for Android 13+
2022-11-26 21:33:12 +01:00
e5af1c93ae
Seeking no longer pauses the played video
2022-11-26 15:35:13 +01:00
d6617007d4
Use SparseArrayCompat instead of SparseArray in StreamItemAdapter.
...
Make additional small improvements as well.
2022-11-22 18:31:58 +05:30
8db90ba449
Use SparseArrayCompat for thumbnails.
2022-11-22 17:51:54 +05:30
048b0972de
Set compileSdk and targetSdk to 33 (Android 13)
...
android:exported in now required in the manifest on all activities/services/receivers/providers. It was set to true for those that need to interact with outside apps or the OS, while others have exported=false.
This also required updating LeakCanary to the latest version as the older version being used was not using android:exported in AndroidManifest.xml.
2022-11-18 08:33:13 +01:00
a7989795e8
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-11-14 08:59:03 +05:30
a40f035810
Merge branch 'dev' into Refactor_VideoDetailFragment
2022-11-14 08:58:45 +05:30
aad5e26f31
Merge pull request #8870 from Isira-Seneviratne/Locale_forLanguageTag
...
Use Locale.forLanguageTag().
2022-11-10 19:56:34 +05:30
627c6e29a2
Merge pull request #8316 from han-sz/fix_video_mouse_hover_overlay
...
Fix persistent hover overlay when in desktop/DeX mode or using a mouse/non-touch input
2022-11-09 17:10:01 +01:00
ef1e7e5b52
Merge branch 'master' into dev
2022-11-09 16:45:22 +01:00
abf1cc536d
Improve code of DeviceUtils.isDesktopMode
...
- Avoid NullPointerException crashes if there is no UiModeManager or desktop
system service mode
- Use final for every exception
- Suppress missing fields warnings
- Add missing NonNull annotation
2022-11-09 16:22:49 +01:00
c38f150562
Remove now obsolete API check.
2022-11-09 15:50:09 +01:00
d2b6bda7a2
Remove errant return.
2022-11-09 15:50:09 +01:00
9e5c68c575
Add check for input devices with cursor.
2022-11-09 15:50:06 +01:00
88eed6cc23
Add JSDoc comment and a performance note for `isDesktopMode`
2022-11-09 15:48:50 +01:00
Jared Fantaye
Mahendran
Stypox
ge78fug
Trust_04zh
Tobi
Marius Wagner
Robin
AudricV
Isira Seneviratne
devlearner
petlyh
pratyaksh1610
Robin
evermind
ThetaDev
Douile
Isira Seneviratne
cybersphinx
Hanif Shersy