Isira Seneviratne
a9af1dfdd2
Applied code review changes.
2022-08-05 06:54:03 +05:30
Isira Seneviratne
fc46233baf
Use toArray() with zero-length arrays.
2022-08-05 06:50:55 +05:30
Isira Seneviratne
d1f3f15478
Use Comparator.comparingDouble().
2022-08-05 05:36:39 +05:30
Isira Seneviratne
b845645b80
Use IO extensions.
...
Co-authored-by: Stypox <stypox@pm.me>
2022-07-21 05:15:39 +05:30
Stypox
c5b970cca3
Improve code style in List.of()
2022-07-20 14:50:23 +02:00
Isira Seneviratne
ca26fcb0eb
Use List.of().
2022-07-20 04:39:11 +05:30
litetex
8b209df253
Changed the code accordingly
...
+ Removed some unused code
2022-07-15 19:55:19 +02:00
Stypox
4443c908cb
Fix SonarLint java:S5320, restrict broadcasts to app package
2022-07-13 23:33:18 +02:00
Stypox
a19073ec01
Restore checkstyle and solve its errors
2022-07-13 23:32:27 +02:00
Stypox
90a89f8ca5
Move player-notification files into their package
2022-07-13 23:27:24 +02:00
Stypox
76ced59b62
Refactor player: separate UIs and more
2022-07-13 23:25:26 +02:00
TacoTheDank
189c92affa
More minSdk 21 cleanup
2022-07-13 19:03:47 +02:00
litetex
99104fc11d
Clean up pre-Lollipop checks
2022-07-13 19:02:24 +02:00
litetex
04e8e03d8f
Fix compile errors
2022-06-22 19:47:03 +02:00
litetex
2985258074
Bonus fix: Made ``single_choice_dialog_view`` scrollable + use viewbinding
2022-05-28 00:46:28 +02:00
Isira Seneviratne
a1f64e4774
Merge branch 'dev' into Remove_compat_methods
2022-05-16 12:36:46 +05:30
Isira Seneviratne
23c1fc3544
Remove unnecessary compat method calls.
2022-05-10 07:45:01 +05:30
litetex
70e0085596
Converted placeholders to svg
...
* Required for SubscriptionFragment (otherwise the PopUp-menu uses half of the screen)
* Size reduction
* Fixed/Improved some images:
* Bandcamp: Was facing in the wrong direction and used an incorrect logo
* Media CCC: Update logo
* YT: Added NewPipe logo so that it's not just a rectangle
2022-05-07 15:08:35 +02:00
Stypox
fa58a81852
Fix New streams settings snackbar not being hidden on exiting
2022-04-16 19:01:30 +02:00
Stypox
f2fc2cc24a
Check whether to enable New streams settings in onCreate to prevent flickering
2022-04-16 19:00:51 +02:00
litetex
102c05e927
FIx breaking changes
2022-03-26 21:21:07 +01:00
Stypox
6e8c9f92cb
Merge branch 'dev' into pr2335
2022-03-19 22:29:10 +01:00
TacoTheDank
cf213affa2
Annotate some NonNulls, some lint cleaning
2022-03-18 13:15:44 -04:00
litetex
0158f1363b
Merge pull request #7518 from mauriciocolli/remove-icon-duplicates
...
Remove icon duplicates and fix some theming issues
2022-03-15 21:51:04 +01:00
litetex
2e7503ff78
Merge branch 'dev' into bumpSomeLibraries
2022-03-15 21:34:41 +01:00
Stypox
b607a09125
Merge pull request #7975 from TacoTheDank/updateCheckerRewrite
...
Migrate app update checker to AndroidX Work
2022-03-15 14:20:40 +01:00
TacoTheDank
71f141f3f8
Migrate CheckForNewAppVersion to Worker (and rename it)
2022-03-03 13:26:57 -05:00
TacoTheDank
81fef1be19
Migrate CheckForNewAppVersion to JobIntentService
2022-03-03 13:24:12 -05:00
TacoTheDank
1602befc51
Move utility methods out of CheckForNewAppVersion
2022-03-03 13:19:06 -05:00
TacoTheDank
f85b206bdf
Update some AndroidX libraries
2022-03-02 11:01:01 -05:00
Mauricio Colli
96185faca6
Remove manual menu creation from some fragments
...
Doing this programmatically is just a no-go when themes are being set
in some other places (the toolbar is using a custom theme, in this
case), so, instead of hunting down the proper theme, just let the
system do its work.
2022-03-02 12:37:44 +01:00
Stypox
5f16e4ef87
Replace R.string.yes with R.string.ok
...
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
2022-03-02 12:21:25 +01:00
litetex
5be40f62f3
Merge pull request #7904 from Stypox/fix-raw-use-of-parameterized-class
...
Solve Java warning "Raw use of parameterized class"
2022-02-26 16:14:23 +01:00
Stypox
5fea12d8eb
Small code improvements
...
Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization.
Used some Kotlin feature to reduce code.
2022-02-26 10:40:24 +01:00
TacoTheDank
1a000fecd5
Replace CircleImageView with ShapeableImageView
2022-02-23 15:11:25 -05:00
Stypox
62abfa96b8
Solve Java warning "Raw use of parameterized class"
2022-02-19 17:30:38 +01:00
TobiGr
ff8e44e4f3
Merge branch 'dev' into feature/notifications
2022-02-19 12:34:44 +01:00
litetex
3223ec04e3
Use the correct app language when searching in the settings
2022-02-11 20:58:44 +01:00
litetex
8a069b497f
Code cleanup
...
Co-authored-by: Stypox <stypox@pm.me>
2022-01-25 20:47:53 +01:00
litetex
82de35d724
Use view binding inside ``PreferenceViewHolder``
2022-01-24 21:08:52 +01:00
litetex
f55e8ea3aa
Use ViewBinding
2022-01-24 21:08:52 +01:00
litetex
7067ebdd12
Fixed imports
2022-01-24 21:08:51 +01:00
litetex
03bb2123f2
Removed breadcrumbs customization
2022-01-24 21:08:51 +01:00
litetex
e2f449f0c8
Code improvements
...
* Renamed methods so that they are more understandable
* Removed ``SearchIndexItem``
2022-01-24 21:08:50 +01:00
litetex
b16e972710
Improved doc
2022-01-24 21:08:50 +01:00
litetex
37cd71328c
Moved ``FuzzyScore`` to original Apache package
2022-01-24 21:08:49 +01:00
litetex
9b2c86a37b
Improved documentation
2022-01-24 21:08:48 +01:00
litetex
ce4dd33eab
Fixed problems with Android's lifecycle (restore)
2022-01-24 21:08:48 +01:00
litetex
c5a06243a6
Fixed variable name
2022-01-24 21:08:47 +01:00
litetex
bebd2b449c
Removed unused import
2022-01-24 21:08:46 +01:00
litetex
658168eb8d
Fixed some sonar warnings
2022-01-24 21:08:45 +01:00
litetex
6b23df0659
Made debug settings searchable (debug only)
...
* Consolidated main-setttings into a single file
* Debug settings are only enabled in the DEBUG build
* Moved LeakCanary (debug) specific stuff into a small class that's only shipped with the debug build
* Other minor fixes
2022-01-24 21:08:45 +01:00
litetex
d59314801c
Code rework
2022-01-24 21:08:44 +01:00
litetex
0f45c69388
Code cleanup + indexing improvements
...
* Removed unused method
* Only index all settings once -> Saves performance
* Fixed some SonarLint reported problems
2022-01-24 21:08:44 +01:00
litetex
52542e04e8
Added fuzzy searching + Some minor code refactoring
2022-01-24 21:08:43 +01:00
litetex
7fc0a3841a
Fine tuning
2022-01-24 21:08:42 +01:00
litetex
22db4175f3
Moved reset-reCAPTCHA-cookie to cache tab and made it read-only
...
so that the search works as expected
2022-01-24 21:08:42 +01:00
litetex
07fb319e88
Applied code changes for preference search framework
2022-01-24 21:08:41 +01:00
litetex
12a78a826d
Added preference search "framework"
2022-01-24 21:08:40 +01:00
litetex
4a061f20ed
Code cleanup
2022-01-24 21:08:39 +01:00
litetex
683d9816cb
Removed dead code
2022-01-24 21:08:38 +01:00
litetex
6dcde96f85
Fixed some Sonarlint warnings
2022-01-05 15:31:55 +01:00
Stypox
cd95ec4e12
Merge branch 'dev' into pr2335
2021-12-31 19:20:18 +01:00
TobiGr
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
TobiGr
d71af9a625
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00
litetex
b21d231e3a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
TobiGr
19fd7bc37e
Reduce power consumption
...
Only schedule the chek for new streams if the user enaled the check. Cancel the worker when the user disables the notifications.
2021-12-10 23:52:37 +01:00
TobiGr
3ade2bb6ec
Merge remote-tracking branch 'origin/dev' into notifications
2021-12-07 17:29:37 +01:00
Stypox
81f740d409
Replace ErrorActivity with ErrorUtil
2021-12-04 10:36:36 +01:00
litetex
b2323859e5
Refactoring + deduplicated code
2021-11-28 14:07:45 +01:00
litetex
68e7fcf8ee
Fixed typos
2021-11-27 23:39:17 +01:00
litetex
f78983b16b
Show an alert/dialog when no appropriate file-manager was found
2021-11-27 15:52:54 +01:00
litetex
272be36dd9
Removed ``e.printStacktrace`` and used an proper logger
2021-11-05 18:04:49 +01:00
litetex
7b4e5dd107
Reworked player-notfication
...
* Fixed ``release`` ``main_settings.xml``
* Renamed "Notification" to "Player-Notification" (also reset all translations)
2021-11-05 14:10:53 +01:00
litetex
0f4b6d7d9f
Improved code readablity
2021-11-02 23:22:52 +01:00
TobiGr
1130aba7ca
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-11-02 07:56:09 +01:00
litetex
e5fd24b0d1
Make naming great again
...
When we build APKs in PRs it's also a GITHUB_APK...
2021-10-26 20:47:14 +02:00
litetex
467bd21de2
Cleanup up some code
2021-10-26 20:47:13 +02:00
vhouriet
5c9705d94e
Change check for updates button to trigger a version check
2021-10-26 20:47:12 +02:00
vhouriet
85fb5827aa
Add Check for updates button
2021-10-26 20:47:11 +02:00
TobiGr
77aaa15082
Fix toggling the system's settings for app notification
...
Do not open the setting for a specific notification channel (Settings.ACTION_CHANNEL_NOTIFICATION_SETTINGS), but the settings for all notifications by the app (Settings.ACTION_APP_NOTIFICATION_SETTINGS)
2021-10-25 13:59:55 +02:00
TobiGr
80bf47493e
Fix check wether the app's notifications are disabled via system settings
...
Add comments
Rename a few methods
2021-10-22 21:24:43 +02:00
TacoTheDank
b6b19b474e
Update RecyclerView & Groupie
2021-10-19 17:31:59 -04:00
TobiGr
7d4c7718aa
comments & rename
2021-10-18 13:11:50 +02:00
TobiGr
64a7978c7f
Rename NotificationMode.ENABLED_DEFAULT to NotificationMode.ENABLED
2021-10-15 19:59:06 +02:00
TobiGr
cea14c9d0d
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-10-11 16:37:49 +02:00
Tobi
ce592f4baf
Merge pull request #6980 from bravenewpipe/check-for-update-after-toggle-and-restart
...
resets the expire date for checking for updates
2021-10-02 09:07:05 +02:00
Tobi
2b3edcf2d1
Add a comment
2021-10-02 08:53:03 +02:00
Laksh
f52cb3bbe0
Make requested changes
2021-09-27 01:45:33 +05:30
Laksh
bc3139e5f9
Fix Settings import
2021-09-25 15:37:07 +05:30
Koitharu
9d249904bd
Toggle all subscriptions notification mode
2021-09-07 13:30:26 +03:00
Koitharu
a5b9fe4c35
Refactor FeedLoadService to use it within the notification worker
2021-09-07 13:30:26 +03:00
Koitharu
e0c674bc9e
Move player notification settings into appearance section
2021-09-07 13:30:25 +03:00
Vasiliy
da9bd1d420
Notifications about new streams
2021-09-07 13:30:16 +03:00
evermind
669a35bc78
check immediately for updates if user enables 'check for updates setting'
...
- Convert CheckForNewAppVersion to IntentService
- reset expire date to 0 after user enables check for updates setting
2021-09-02 07:20:35 +02:00
Stypox
cfdcb92fa3
Always use our strings, not android ones
2021-08-30 16:37:01 +02:00
Stypox
039bd5d413
Rename string finish to ok, as its content was "OK"
2021-08-30 16:36:57 +02:00
Tobi
0787d62254
Merge pull request #6820 from Stypox/picker-mime-type
...
Provide mime type to file picker to gray out unselectable files
2021-08-26 21:39:35 +02:00
Stypox
d37ee1e0dc
First run migrations, then setDefaultValues, since the latter requires the correct types
2021-08-24 18:16:17 +02:00
Stypox
1d33e7ab49
Allow choosing which types of search suggestions to show
...
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00