Profpatsch
743e16a8a7
Quality/AudioTrack: ensure correct indices at construction
...
Instead of allowing to pass arbitrary out-of-bounds indexes to these
bean classes, ensure that the index is always valid for the list.
This is always true for our filter functions, except they all return
`-1` if the list was empty. We have to check/assert that beforehand.
This improves the logic somewhat, because fetching the stream always
returns something now.
Ideally, we wouldn’t be filtering stuff and then passing indices
around everywhere, but that’s the current state of things.
~~~
I took the liberty to remove the `.of`-wrappers, because they don’t
really add much compared to just calling the constructor here.
2024-01-06 19:09:44 +01:00
Stypox
af2375948d
Support obtaining multiple images from the extractor
2023-09-22 09:57:33 +02:00
TobiGr
2a1b506d98
Improved accessibility of player interfaces
2023-09-21 12:20:00 +02:00
AudricV
2d16a06bc4
Show play queue button in main player when there is one stream
2023-08-30 19:45:53 +02:00
ThetaDev
b567d428ad
fix: small codestyle fixes
2023-04-21 23:15:37 +02:00
ThetaDev
d010384c88
Merge branch 'dev' of github.com:TeamNewPipe/NewPipe into alang-selector
2023-04-03 22:13:16 +02:00
Stypox
02906e8132
Merge pull request #9812 from TeamNewPipe/revert-8894-WindowCompat
...
Revert "Use WindowCompat."
2023-04-03 14:23:17 +02:00
ThetaDev
87a88e4df7
feat: localized audio track names
2023-03-19 15:45:52 +01:00
ThetaDev
366c39d4c6
feat: add language selector to audio player
2023-03-19 01:15:36 +01:00
ThetaDev
77649d388c
fix: reduce complexity
2023-03-18 16:29:22 +01:00
ThetaDev
dba53d23aa
fix: remove todo
2023-03-18 16:14:07 +01:00
ThetaDev
de7872d8f2
feat: add audio language selector
2023-03-17 21:51:40 +01:00
Stypox
600ebdae18
Correctly open urls in browser on Android 11+
...
- Fix misconfiguration in manifest ('http|https|market' is not valid)
- Split ShareUtils functions taking a boolean parameter into pairs of functions with better names and less runtime checks
- Move all Kore-related functions to KoreUtils
- Remove the toast_no_player string
2023-02-25 09:13:59 +01:00
Stypox
39c500f33c
Revert "Use WindowCompat."
2023-02-14 08:27:04 +01:00
Stypox
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
Isira Seneviratne
f766ef2033
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
Stypox
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
Isira Seneviratne
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
Isira Seneviratne
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
Stypox
367ece8ffa
Merge pull request #9496 from Jared234/9437_continue_playing_while_seeking
...
Seeking no longer pauses the played video
2022-12-31 19:19:21 +01:00
Jared Fantaye
12796920a3
Removed the wasPlaying variable
2022-12-10 21:56:04 +01:00
Isira Seneviratne
161007fe92
Merge branch 'dev' into Refactor_VideoPlayerUi
2022-12-06 20:21:08 +05:30
Isira Seneviratne
b0516fbf1d
Use BitmapCompat.createScaledBitmap().
2022-11-29 15:56:19 +01:00
Jared Fantaye
e5af1c93ae
Seeking no longer pauses the played video
2022-11-26 15:35:13 +01:00
Isira Seneviratne
e333197ed5
Use OnClickListener and OnLongClickListener lambdas in the player UIs.
2022-11-03 05:09:35 +05:30
Stypox
9d2ab61993
Merge pull request #9203 from Callisto404/add-chapter-timestamp-share
...
Added timestamped link sharing from the start of a chapter with a long hold press
2022-10-30 22:31:09 +01:00
Daniel M
7f3da04fee
Added an "isYouTube" check to start of long click handler
2022-10-30 13:48:03 +11:00
Stypox
9524c6245d
Merge pull request #8747 from Isira-Seneviratne/Range_limit
...
Use range-limiting methods in more places.
2022-10-28 10:34:04 +02:00
Daniel M
83357ca67e
Added sharing a link with timestamp from a chapter into the long click for each chapter
2022-10-24 14:14:41 +11:00
Stypox
f9109ebc81
Use player.getThumbnail() instead of field in VideoPlayerUi
2022-08-28 18:35:21 +02:00
Stypox
c054ea0737
Create MediaSessionPlayerUi
2022-08-25 17:00:41 +02:00
Isira Seneviratne
e136a6f915
Use range-limiting methods in more places.
2022-08-08 07:10:16 +05:30
Isira Seneviratne
4d7a6fb6de
Use WindowMetrics API in VideoDetailFragment and PopupPlayerUi.
2022-07-30 19:22:39 +05:30
Isira Seneviratne
d62cdc659f
Use MathUtils.clamp().
...
Co-authored-by: Stypox <stypox@pm.me>
2022-07-20 05:36:01 +05:30
litetex
3ba04f179f
Fixed conflicts/build
2022-07-15 20:00:08 +02:00
Stypox
4443c908cb
Fix SonarLint java:S5320, restrict broadcasts to app package
2022-07-13 23:33:18 +02:00
Stypox
c03eac1dc9
Some SonarLint refactors
2022-07-13 23:33:18 +02:00
Stypox
61c1da144e
Some refactorings after review comments
2022-07-13 23:33:18 +02:00
Stypox
3692858a3d
Move popup layout param to PopupPlayerUi
2022-07-13 23:33:18 +02:00
Stypox
1cf746f721
Fix volume gestures not working anymore
2022-07-13 23:33:18 +02:00
Stypox
4979f84e41
Solve some Sonarlint warnings
2022-07-13 23:33:16 +02:00
Stypox
a19073ec01
Restore checkstyle and solve its errors
2022-07-13 23:32:27 +02:00
Stypox
1b39b5376f
Add some javadocs; move preparing player uis to PlayerUiList
2022-07-13 23:31:59 +02:00
Stypox
6559416bd8
Improve //region comments in player UIs
2022-07-13 23:30:30 +02:00
Stypox
fa25ecf521
Add comment about broadcast receiver
2022-07-13 23:27:24 +02:00
Stypox
90a89f8ca5
Move player-notification files into their package
2022-07-13 23:27:24 +02:00
Stypox
0bba1d95de
Move all notification-related calls to NotificationPlayerUi
2022-07-13 23:27:24 +02:00
Stypox
b3f99645a3
Fix some crashes / issues after player refactor
2022-07-13 23:27:23 +02:00
Stypox
76ced59b62
Refactor player: separate UIs and more
2022-07-13 23:25:26 +02:00