Commit Graph

755 Commits

Author SHA1 Message Date
Stypox 99379ede8a
Remove useless title&channel text view focusability 2022-02-23 10:13:03 +01:00
Stypox 4871095a3e
Automatically rearrange code in player.xml 2022-02-23 09:16:25 +01:00
Stypox 21dc988e45
Restore focus handling for TVs in player.xml 2022-02-23 09:15:11 +01:00
TobiGr ff8e44e4f3 Merge branch 'dev' into feature/notifications 2022-02-19 12:34:44 +01:00
martin ed2967ec7d Addressing layout comments 2022-02-17 10:28:50 +01:00
martin 4049abf2c0 Addressed comment in PR 2022-02-04 16:15:55 +01:00
martin 47798febed fetch and merge 2022-02-04 15:34:00 +01:00
litetex dfa606ef49
Merge pull request #7586 from litetex/add-preference-search
Made preferences searchable
2022-01-30 17:08:04 +01:00
litetex f55e8ea3aa Use ViewBinding 2022-01-24 21:08:52 +01:00
litetex 8fc935b09d Added resource files
Forgot to commit them before...
2022-01-24 21:08:41 +01:00
litetex 4a061f20ed Code cleanup 2022-01-24 21:08:39 +01:00
Stypox d5cfcb28fc
Merge branch 'dev' into pr2335 2022-01-24 10:25:07 +01:00
litetex fe42206e94 Code cleanup and minimization
* Deduplicated and simplified a lot of code
* Fixed ``invalidSeekConditions`` so that it's possible to seek while the player is loading (like currently the case)
2022-01-21 22:49:23 +01:00
Stypox 83a3d11f38 Small improvements to player 2022-01-21 22:49:22 +01:00
Stypox 03d5372525 Fix buttons' selectable item background not working in player 2022-01-21 22:49:22 +01:00
Stypox ee827407aa Fix seek triangles not visible on API 19 2022-01-21 22:49:22 +01:00
vkay94 3aebfa22e9 SeekOverlay: Switch to merge for SecondsView and other adjustments 2022-01-21 22:49:21 +01:00
vkay94 72eb3b4415 SeekOverlay: Add seek overlay logic to player 2022-01-21 22:49:21 +01:00
vkay94 3a40759cd2 SeekOverlay: Add Views 2022-01-21 22:49:21 +01:00
litetex 0f457127df Removed "list_thumbnail_view_description"
due to accessibility problems
2022-01-04 16:00:01 +01:00
Stypox cd95ec4e12
Merge branch 'dev' into pr2335 2021-12-31 19:20:18 +01:00
David Kramer 07015973d2 Added ability to see pinned comment 2021-12-24 11:29:34 -06:00
martin 5514616372 Change pitch by semitones 2021-12-21 18:17:48 +01:00
TobiGr 3ade2bb6ec Merge remote-tracking branch 'origin/dev' into notifications 2021-12-07 17:29:37 +01:00
litetex 769791af7a Added a "Crash the player" debug option 2021-11-23 20:12:09 +01:00
TobiGr 892a1df280 Merge remote-tracking branch 'origin/dev' into notifications-1 2021-11-21 22:15:09 +01:00
litetex 4eb02f584e Fixed default visibility of "new feed items" button
Fixed/Avoid NPEs
2021-11-15 20:22:22 +01:00
litetex 700c1b4b25 Removed unnecessary layout
Moved the feed button up a bit
2021-11-15 20:22:21 +01:00
litetex 02789122a0 Implemented UI highlighting and "new feed items"-notification
Fixed format
2021-11-15 20:22:17 +01:00
litetex 62efb588ef Removed obvious title from the "Playback Speed Controls" 2021-11-07 13:51:43 +01:00
litetex f933db8117 Added a custom title
to also save some margin/padding/etc
2021-11-04 19:47:08 +01:00
litetex cddb9bccb9 Reworked ``dialog_playback_parameter``
* Removed dependency to @dimen/video_item_search_padding as it's unrelated
* Made the margins/paddings a bit smaller
* Put the checkboxes inside a layout
* Removed some useless attributes (maxLine)
2021-11-04 19:46:22 +01:00
TiA4f8R acaf92d671
Unrevert PR 6824
PR 7061 reverted by mistake PR 6824 (it was a rebase issue). This commit unreverts this change and uses custom TextViews correctly in the file changed by PR 6824.
2021-11-02 17:53:27 +01:00
TobiGr 1130aba7ca Merge remote-tracking branch 'origin/dev' into notifications-1 2021-11-02 07:56:09 +01:00
TiA4f8R 411b3129f9
Use a custom EditText everywhere to be able to share with ShareUtils the selected text
This EditText class extends the AppCompatEditText class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
TiA4f8R a55acd38df
Use a custom TextView everywhere to be able to share with ShareUtils the selected text
This TextView class extends the AppCompatTextView class from androidx.

These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
TobiGr 16d4a034e2 Merge remote-tracking branch 'origin/dev' into notifications 2021-10-14 21:15:43 +02:00
TobiGr cea14c9d0d Merge remote-tracking branch 'origin/dev' into notifications-1 2021-10-11 16:37:49 +02:00
Kalle Struik 87c958b2e7 Rename the "append_playlist" string to "add_to_playlist" 2021-10-03 13:27:24 +02:00
Tobi 5b3137093f
Merge pull request #6824 from phigjm/player_queue_control_rearrangement
Swap seekbar position with player buttons in Queue screen
2021-10-02 09:47:25 +02:00
Kostas Giapis a70c51b71c Remove margins from minimized player buttons 2021-09-26 18:26:40 +03:00
Kostas Giapis 02d417476e Increase minimized player buttons clickable area 2021-09-26 18:23:11 +03:00
Koitharu fb0473da39
Merge branch 'dev' of https://github.com/TeamNewPipe/NewPipe into feature/notifications 2021-09-20 07:26:01 +03:00
Stypox 8272b2508b
Make all buttons in player have selectable item background borderless (#7042)
Except buttons with long text or text that changes on click
2021-09-18 11:29:15 +02:00
Vasiliy da9bd1d420
Notifications about new streams 2021-09-07 13:30:16 +03:00
Stypox 3a09039b93
Remove unused resources 2021-09-02 21:13:54 +02:00
Stypox faa7a91764
Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
Stypox a4c9732916
Merge pull request #6965 from ktprograms/indication-content-main-page
Add how to remove tab from main page text
2021-08-31 12:12:33 +02:00
Stypox 039bd5d413
Rename string finish to ok, as its content was "OK" 2021-08-30 16:36:57 +02:00
litetex d931d058d9 Reworked the ErrorPanel
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown
  * Added a method to ensure the above
  * This deduplicates a lot of code
* Fixed format of some LoC
* Added new method: ``showAndSetErrorButtonAction``
* Fixed  ``showTextError``
* Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
2021-08-28 17:05:12 +02:00
ktprograms e95637f7b7 Add help text in fragment_choose_tabs.xml, convert to ConstraintLayout 2021-08-27 09:20:23 +08:00
Stypox bbcfdf2969
Merge pull request #6917 from sherlockbeard/sherlockbeard-notAvailableVector
Change "not available" image from PNG to vector format
2021-08-25 17:12:07 +02:00
ktprograms f7a0b9951e Move Choose Tabs help message to Action Bar subtitle 2021-08-24 17:28:28 +08:00
ktprograms 160f9df64e Add how to remove tab from main page text 2021-08-24 09:39:18 +08:00
sherlockbeard 137d9e6d6e testing 2021-08-13 20:54:22 +05:30
Stypox 4d50a66e40
Un-nest some text views in play queue activity 2021-08-09 20:11:31 +02:00
phigjm e6c56cacc6
Rearrange the play queue control elements
from bottom to top: Playback_controls, progress bar, center, (seek display)
2021-08-09 20:11:18 +02:00
Stypox f8caed139a
Use custom cancel string everywhere
to fix missing somali translation for android.R.string.cancel
2021-08-04 18:58:35 +02:00
Stypox d42a534fc3
Merge pull request #6741 from KalleStruik/comment-hearts
Show hearts in comments
2021-08-01 11:12:58 +02:00
Kalle Struik bfac73b992 Make heart visible in android studio and move logic to the right file. 2021-07-27 22:34:59 +02:00
Stypox 5924edb289
Merge pull request #6782 from TacoTheDank/fix-fill-parent
Fix deprecated fill_parent attributes
2021-07-27 19:45:51 +02:00
TacoTheDank e2791cdf0f Fix deprecated fill_parent attributes 2021-07-27 13:38:59 -04:00
TacoTheDank 50f3b08c59 Consolidate edittext alert dialogs into one layout 2021-07-27 13:31:58 -04:00
Kalle Struik 74173317de Change heart color to be red, add else clause for non hearted comments, and apply some code style suggestions. 2021-07-23 19:43:25 +02:00
Kalle Struik 3874e16187 Added support for showing when a comment has received a heart from the creator of a video. 2021-07-23 17:30:47 +02:00
Stypox d57bfde604
Merge pull request #6434 from litetex/playerSeekbarPreview
Player seekbar thumbnail preview
2021-07-19 11:42:10 +02:00
Stypox 6c25ce56a3
Merge pull request #6456 from TeamNewPipe/feature/switch-theme
Apply theme to switches
2021-07-18 13:12:47 +02:00
litetex efd038a536 Increased padding of preview thumbnail 2021-07-17 16:43:04 +02:00
litetex 0b2629e910 Moved time to the top 2021-07-17 16:43:03 +02:00
litetex 2a24532e1d Fine tuned padding
Moved seekbar preview up a bit, so the finger is not obstructing the view
2021-07-17 16:43:02 +02:00
litetex c5f2eb1dd8 Enlarged currentDisplaySeek a bit 2021-07-17 16:43:01 +02:00
litetex 2e2dbaf77f Added seekbar-preview to the player layout 2021-07-17 16:41:54 +02:00
litetex 36c198fc33
One textview is enough for disabled comments
Ref: https://github.com/TeamNewPipe/NewPipe/pull/6483#discussion_r654793920
2021-07-17 13:14:50 +02:00
litetex 81107df53f
Added comments disabled functionallity 2021-07-17 13:10:44 +02:00
Tobi 96f5cd9f17
Merge pull request #6463 from Stypox/metadata-tags
Improved metadata layout, better tags accessibility
2021-07-12 16:18:11 +02:00
litetex 85e864a01e Made the thumbnail in the minimized player visible again 2021-07-06 21:40:57 +02:00
Stypox fdb6679d2d
Make list stream item ConstraintLayouts and use chain 2021-06-15 14:17:40 +02:00
Stypox 40a2df847b
Move tags layout at the bottom, use multiple lines 2021-06-13 21:56:06 +02:00
Stypox e58feadba9
Remove IN HISTORY label on stream info items 2021-06-09 15:53:51 +02:00
Mauricio Colli e846f69e38
Add ability to hide played items in a feed
- Use components from the new Groupie list library for displaying the
feed list.
2021-06-09 15:53:51 +02:00
Stypox fa1d7ffac3
Const text width for metadata; scrollable tags layout 2021-06-09 15:32:07 +02:00
Stypox 272d589518
Convert related_items_header to ConstraintLayout 2021-06-09 13:10:26 +02:00
Stypox 6ab4787e97
Use SwitchCompat to make switch uniform across versions
Also just use colorControlActivated in the base V19 theme, instead of using the prefix android: in each V21 service theme
2021-06-09 13:04:21 +02:00
TobiGr ccc46971b4 Show detailed error message when an account has been terminated by the service 2021-06-08 10:12:36 +02:00
Tobi 761e01c3b9
Merge pull request #6443 from Stypox/invalid-attr
Use constraint layout for play queue item
2021-06-08 10:05:38 +02:00
Stypox a102fc9cad
Use constraint layout for play queue item
Also remove invalid ic_selected attribute
2021-06-07 08:07:27 +02:00
TobiGr 49b12ea4f8 Increase space for metadata typeview
Some translations come with longer words causing them to wrap at strange positions
2021-06-06 11:57:14 +02:00
Stypox 9e94c81ef2
Always show scrollbars for metadata tags 2021-06-02 21:23:48 +02:00
Stypox 14256137e8
Use chips to show tags in metadata section
Clicking on chips opens the search fragment
Long clicking copies to clipboard
2021-06-02 16:15:02 +02:00
Stypox bc3e43ac58
Add button to allow selecting text in the description
Since now selection is disabled by default, this fixes #5453
2021-06-02 14:36:34 +02:00
Stypox d0d5373be9
Allow copying metadata to clipboard 2021-06-02 14:19:25 +02:00
Stypox 997267bad1
Show video metadata below the decription 2021-06-02 14:19:25 +02:00
Tobi fdee7c3d06
Merge pull request #6410 from sauravrao637/6409
Fixed channel description textView
2021-06-01 11:02:47 +02:00
camo0112 142cde975f fixed channel description textView 2021-06-01 10:43:57 +05:30
TobiGr 6ec72ef945 Fix empty fragment text not centered when text longer than one line 2021-05-28 12:43:21 +02:00
TobiGr e5457e5029 [Bandcamp] Add Radio stream segments
Display channel / creator / artist name when given
2021-04-11 23:14:23 +02:00
Tom 3fcd580491
Add queue time (#6023)
* Add queue time
2021-04-08 10:41:41 +02:00
krlvm 425a312151
Fix list stream item details overflow when there's free space 2021-04-04 21:07:43 +03:00
krlvm ea294e8e5d
Add ellipsis to list stream item uploader 2021-04-04 20:52:44 +03:00
krlvm e484339cca
Merge branch 'dev' into daynight 2021-04-03 00:08:26 +03:00
krlvm 6b5a1d0202
Fix Player controls colors on KitKat
AppCompatImageButton ignores "tint" theme attribute on API 19, therefore, they had to be specified directly, these attributes can be removed after the KitKat support is dropped.
2021-04-02 23:58:10 +03:00
Fynn Godau c9766d25ef Rename related streams to related items 2021-03-31 22:33:22 +02:00
Tobi aaea661b70
Merge pull request #5935 from Stypox/fix-notification-settings
Fix hidden icon to the left of notification actions in settings
2021-03-31 22:18:26 +02:00
krlvm 7061859112
Fix subscription picker colors on API 19 2021-03-31 20:17:58 +03:00
krlvm 4fdc5ea646
Fix player controls colors on large screens 2021-03-31 19:07:27 +03:00
krlvm ad8f3aa6c9
Fix Kiosk Selector colors in Light theme 2021-03-31 16:49:28 +03:00
wangear 73cfa5499d
Fix overlapping fonts and crash on tapping anywhere on video after long-pressing 'Popup' button (#5813)
* Overlapping fonts #5096
issue : #5096

* Overlapping fonts #5096
issue : #5096
changed :
- If additional textView is overlapped, only title view shows.

* Overlapping fonts #5096
issue : #5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.

* Overlapping fonts #5096
issue : #5096
changed :
- remove unusable variable

* Crash on tapping anywhere on video after long-pressing 'Popup' button #5804
issue : #5804
changed :
- checked null
- fixed NullPointerException.
2021-03-31 10:10:14 +02:00
Stypox 84e3f6ca18
Merge pull request #5881 from TacoTheDank/about_revamp
About package internal revamp
2021-03-31 09:56:12 +02:00
TacoTheDank cc72fa4793 Renamed things pertaining to the about package 2021-03-29 19:05:57 -04:00
krlvm 561d5675f7
Fix Downloader colors 2021-03-29 21:35:00 +03:00
krlvm c906cb57ee
Fix colors in setting fragments, cleanup 2021-03-29 21:19:17 +03:00
krlvm 62c3c7ac21
Fix Toolbar Search input pointer and cursor color 2021-03-29 14:47:46 +03:00
krlvm a7d6ad5162
Fix Subscription Picker's Toolbar colors 2021-03-29 14:44:29 +03:00
krlvm 80d1c5b9f5
Fix Repeat Button color in Player 2021-03-28 22:04:54 +03:00
krlvm d6f9aace8c
Fix White text in Play Queue in Light Theme, remove shade 2021-03-28 21:38:15 +03:00
krlvm aeccb5b472
Fix Toolbar colors in Play Queue 2021-03-28 20:44:20 +03:00
krlvm 09a7b7718a
Fix text color in playlist overlay 2021-03-28 20:43:52 +03:00
krlvm 69793049c3
Fix subscription selector V overlay color, add ripples 2021-03-28 19:50:45 +03:00
krlvm 67942a906a
Fix colors in PeerTube Settings Fragment 2021-03-28 19:36:07 +03:00
krlvm 0afdac5683
Fix Light Player Popups in Dark Theme, make Player Controls Overlay always Dark 2021-03-28 18:48:51 +03:00
krlvm 01e8654fbd
Fix Search colors on KitKat 2021-03-28 14:55:54 +03:00
krlvm e4f2c58933
Set Search text cursor using accent color instead of drawable 2021-03-28 12:24:29 +03:00
Stypox dd00152485
Fix hidden icon to the left of notification actions in settings 2021-03-28 10:36:47 +02:00
krlvm 7d5197e6fd
Fix Dark elements in Dark Theme 2021-03-27 19:15:53 +03:00
krlvm 81e08d0cc4
Show ripples on tab bar with the same color as the toolbar 2021-03-27 18:33:28 +03:00
krlvm fd14c8cdce
Fix Dark elements in Light Theme 2021-03-27 17:46:05 +03:00
krlvm 1d51002173
Fix Dark toolbar text in Light theme 2021-03-27 01:28:28 +03:00
krlvm b3e2418b93
Migrate to DayNight Theme 2021-03-26 23:08:25 +03:00
TacoTheDank 6a9d5fd4cc Replace FrameLayout with FragmentContainerView where applicable 2021-03-22 17:46:06 -04:00
Tobi bfff500915
Merge pull request #5818 from TeamNewPipe/thumbnail_size
[background player] Fix very small thumbnails
2021-03-14 21:12:52 +01:00
Tobi 404a6c12a6
Merge pull request #5148 from Stypox/error-panel
Show improved error panel instead of annoying snackbar or crashing
2021-03-14 17:41:27 +01:00
Tobi 8271409afe
Merge pull request #5562 from mbarashkov/hardware_keyboard_space_shortcut_v2
Implement "pause/play" toggle on hardware keyboard space button.
2021-03-14 13:08:44 +01:00
TobiGr 7c36cbffd0 [background player] Fix very small thumbnails 2021-03-13 18:17:30 +01:00
Stypox aee0478235
FeedFragment: fix view binding and show loading indicator correctly 2021-03-12 23:21:54 +01:00
Stypox c3cf1d81c2
Fix error panel and search fragment state saving 2021-03-12 23:21:54 +01:00
Stypox b265cabc22
Fix views not scrollable when showing error panel 2021-03-12 23:21:54 +01:00
Stypox c43bca6007
Add report/solve-recaptcha button in error panel
It will be shown even when nothing could be loaded not due to a network error, and the user can choose to ignore or report it.

Also improve error reporting arguments
Also completely refactor error activity
Also improve some code here and there
2021-03-12 23:21:49 +01:00
Stypox 553b80164b
Move all error-related classes into error package 2021-03-07 17:49:28 +01:00
Mikhail Barashkov aea912f499 Implement "pause/play" toggle on hardware keyboard space button. 2021-02-12 11:58:15 +03:00
karol 156d7139fa removed resizig text from popup player, as requested in #5514 2021-02-11 11:20:27 +01:00
Stypox 3868243c2a
Animate secondary controls toggle 2021-01-17 15:59:29 +01:00
Stypox d043a4f410
Always show tab layout at the bottom of the screen 2021-01-17 15:36:42 +01:00
Stypox 4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility 2021-01-17 15:34:24 +01:00
Stypox a314f55a17
Move description to a tab alongside related streams and comments 2021-01-17 15:26:25 +01:00
Stypox 78a9811fe3
Add a secondary control panel to video detail fragment
It is shown when the user expands the description
It contains share, open in browser and play in kodi
2021-01-17 15:12:29 +01:00
Isira Seneviratne fe92abde0e Use view binding in VideoDetailFragment. 2021-01-17 09:57:40 +05:30
vkay94 37aa41afae Add stream segments to player 2021-01-14 21:58:19 +01:00
Stypox 94b086de20
Merge pull request #4814 from Isira-Seneviratne/Use_view_binding_in_fragments
Use view binding in fragments.
2021-01-14 14:40:19 +01:00
Stypox 8378789f6a
Fix view binding types 2021-01-14 10:25:48 +01:00
Stypox 059bb7622d
Merge and rename into PlayQueueActivity 2021-01-14 10:25:48 +01:00