489f052ef9
Fix feed menu tooltips (silly copy-paste error)
2022-09-19 11:21:42 +02:00
bf55ed262f
Merge pull request #8972 from Stypox/fix-suggestions-listadapter
...
Fix various issues in the search suggestions list
2022-09-19 08:54:55 +02:00
f26bf33ead
Merge pull request #8966 from Stypox/feed-menuitem-tooltip
...
Show correct tooltips for actions in feed
2022-09-19 08:54:06 +02:00
28b34f3796
Fix scroll issues in suggestion list
...
Before if the list before updating contained item 'test' at position 0 and after updating that value went to the bottom, the list would incorrectly scroll to the bottom to follow that item. Now the scrolling is done after the list is updated.
2022-09-14 14:39:32 +02:00
1f57c87859
Disable suggestion list animations: not meaningful
...
The animations were just in the way and did not help in choosing items, since the suggestion items keep changing too much.
2022-09-14 14:04:22 +02:00
fbf5549182
Fix wrong icons being set on suggestion items
...
The diff util wrongly considered as equal two items with the same text but with different `fromHistory` value
2022-09-14 14:01:59 +02:00
051c572e7f
Show correct tooltips for actions in feed
2022-09-13 15:26:04 +02:00
ed87465565
Only update notification large icon when it changes
2022-08-28 23:14:02 +02:00
f9109ebc81
Use player.getThumbnail() instead of field in VideoPlayerUi
2022-08-28 18:35:21 +02:00
4a7af6f9ac
Remove thumbnail before sync, if outdated
...
Also refactor onPlaybackSynchronize and add comments
2022-08-28 18:32:27 +02:00
7fbef35daa
Unify onThumbnailLoaded calls to ensure UIs always updated
2022-08-28 17:24:51 +02:00
f9994abb94
Prevent tapping on thumbnail if video details are not loaded
2022-08-26 18:54:51 +02:00
ca0f56eea8
Avoid setting invalid states to bottom sheet callback
2022-08-26 18:54:51 +02:00
500acce178
Fix regression in screen rotation animation
2022-08-26 18:54:51 +02:00
6805c75c9c
Fix surface view not resizing video correctly
...
Also fix yet another random null pointer exception that could happen when adding the video player view
2022-08-26 18:54:51 +02:00
59d1ded94e
Fixed sonar detected problems
...
+ Automatically fixed code style (imports)
2022-08-25 17:02:53 +02:00
973a966011
Review suggestions
2022-08-25 17:02:53 +02:00
510efaae97
Keep strong reference to Picasso thumbnail loading target
...
Before the Target would sometimes be garbage collected before being called with the loaded thumbnail, since Picasso holds weak references to targets
2022-08-25 17:02:52 +02:00
11bd2369e5
Merge MediaSessionManager into MediaSessionPlayerUi
2022-08-25 17:02:52 +02:00
f80d1dc48d
Let exoplayer decide when to update metadata
...
Though still make sure metadata is updated after the thumbnail is loaded.
This fixes the wrong seekbar properties (duration and current position) being shown in the notification sometimes.
2022-08-25 17:02:52 +02:00
8bff445ec3
Remove useless checks before updating metadata
...
A while ago NewPipe called the metadata update function very often, so checks were needed to ensure not wasting time updating metadata if it were already up to date. Now, instead, the metadata update function is called exactly when needed, i.e. when metadata changes, so such checks are not needed anymore (and were probably also a little resource-heavy).
2022-08-25 17:02:51 +02:00
d73ca41cfe
Even when thumbnails should not be shown, set it to null in notification
...
This makes sure the thumbnail is removed from the notification if the user disables thumbnails
2022-08-25 17:02:51 +02:00
f3a9b81b67
Fix sometimes seeing outdated thumbnail in notification
...
Before the thumbnail finishes loading for the new video the player is now playing, the old thumbnail was being used, leading to wrong thumbnails set in the media session and the notification.
2022-08-25 17:02:51 +02:00
3cc43e9fb9
Fix thumbnail sometimes not set to media session metadata
...
The thumbnail was not being updated in the media session metadata after it was loaded, since there was no metadata update in that case, only a notification update.
2022-08-25 17:00:41 +02:00
bc33322d4b
Remove useless MediaSessionCallback
...
The player is now passed directly, it made no sense to wrap around it in a callback that was not really a callback but rather, actually, a wrapper.
2022-08-25 17:00:41 +02:00
c054ea0737
Create MediaSessionPlayerUi
2022-08-25 17:00:41 +02:00
52dbfdee00
Keep strong references to Picasso notification icon loading targets
...
Before the Target would sometimes be garbage collected before being called with the loaded channel icon, since Picasso holds weak references to targets. This meant that sometimes a new streams notification would not be shown, because the lambda that should have shown it had already been garbage collected.
2022-08-25 16:41:51 +02:00
5e0788b99c
Use ListAdapter in PreferenceSearchAdapter.
2022-08-18 19:52:51 +05:30
67669c286b
Use ListAdapter in SuggestionListAdapter.
2022-08-18 19:52:51 +05:30
4f6b5b3b89
Use ListAdapter in PeertubeInstanceListFragment.
2022-08-15 07:26:02 +05:30
571bf397c5
Merge pull request #8666 from TacoTheDank/filepicker
...
Update FilePicker to our custom fork and disable Jetifier
2022-08-12 09:15:34 +02:00
74921d3afa
Merge pull request #8740 from Isira-Seneviratne/Cleanup_methods
...
Remove some unused methods.
2022-08-06 22:45:40 +02:00
edd2b110b0
Merge pull request #8738 from Isira-Seneviratne/Collectors_joining
...
Use Collectors.joining().
2022-08-06 22:31:31 +02:00
80fb21e031
Merge pull request #8728 from Isira-Seneviratne/Comparator_factory
...
Use Comparator factory methods.
2022-08-06 11:56:44 +02:00
ebd06bdd24
Improve comment
2022-08-06 11:56:00 +02:00
6f86e21605
Merge pull request #8724 from Isira-Seneviratne/toArray_improvements
...
Use toArray() with zero-length arrays.
2022-08-06 11:33:05 +02:00
816154c7cb
Merge pull request #8737 from Isira-Seneviratne/Fix_coerceIn
...
Replace coerceIn() with MathUtils.clamp().
2022-08-06 11:16:06 +02:00
d9230c0103
Merge pull request #8708 from Isira-Seneviratne/Reduce_View.kt_size
...
Reduce View.kt size.
2022-08-06 10:59:10 +02:00
5c7dfd1d69
Remove unused method.
2022-08-06 06:54:21 +05:30
7aacaf8c38
Use Collectors.joining().
2022-08-06 06:54:21 +05:30
ee6a279596
Remove unused methods in HistoryRecordManager.
2022-08-06 05:09:54 +05:30
a9af1dfdd2
Applied code review changes.
2022-08-05 06:54:03 +05:30
fc46233baf
Use toArray() with zero-length arrays.
2022-08-05 06:50:55 +05:30
2eec2e9128
Replace coerceIn() with MathUtils.clamp().
2022-08-05 06:19:06 +05:30
8024b437e9
Add reusable classes extending AnimatorListenerAdapter.
2022-08-05 06:08:13 +05:30
d1f3f15478
Use Comparator.comparingDouble().
2022-08-05 05:36:39 +05:30
059cfcbad2
Use Comparator factory methods in ListHelper.
2022-08-05 05:36:21 +05:30
1a8f396e77
Merge pull request #8721 from Isira-Seneviratne/OnClickGesture_interface
...
Make OnClickGesture an interface.
2022-08-04 16:15:54 +02:00
5640365fbd
Merge pull request #8682 from Isira-Seneviratne/Refactor_LicenseFragmentHelper
...
Refactor LicenseFragmentHelper.
2022-08-04 11:18:40 +02:00
4b7de86a92
Clean up getLicenseStylesheet().
2022-08-04 11:17:30 +02:00
Stypox
litetex
Isira Seneviratne