c06d61a83c
Made audio-focus calls respect mute state.
2023-08-02 23:44:23 -04:00
bc4f0c699f
Ignore false positive inspection
2023-08-02 20:44:30 +02:00
d6a1170ddb
Replace settings migration with automatic check for device blacklist version
2023-07-31 23:00:54 +02:00
40d102fcb5
Disable media tunneling by default on new devices
...
Sony BRAVIA_VH1, BRAVIA_VH2, BRAVIA_ATV2, BRAVIA_ATV3_4K
Phillips 4K (O)LED TV (PH7M_EU_5596)
Panasonic 4KTV-JUP (TX_50JXW834)
Bouygtel4K (HMB9213NW)
2023-07-29 22:08:51 +02:00
1db73370a7
Ensure that imports handle disabling media tunneling correctly
...
Store in preferences whether media tunneling was disabled automatically.
Show info in ExoPlayer settings if media tunneling was disabled autmatically.
2023-07-29 22:08:51 +02:00
8b63b437d8
Disable media tunneling if the device is known for not supporting it
...
Revert removing the Utils related to media tunneling.
2023-07-29 14:13:03 +02:00
78e577d260
Make some constants private and annotate params
2023-07-29 14:13:03 +02:00
3edd4c012d
Merge pull request #10195 from AudricV/player_refactor-renderers-activation-or-deactivation
...
Refactor Player.useVideoSource logic and improve its comments
2023-07-22 14:12:35 +02:00
c658f28b02
Merge pull request #10078 from Isira-Seneviratne/Improve_feed_notifications
...
Improve new stream notifications
2023-07-20 06:39:19 +05:30
5ab3a4a9e0
Refactor Player.useVideoSource logic and improve its comments
...
- don't check for isAudioOnly == !videoEnabled, as this prevents enabling again
video and text tracks renderers in some cases;
- when reloading play queue manager if that's needed, disable or enable video
and text tracks renderers, as they may need to be enabled again in some cases
like starting a video in main player, opening play queue, switching to
background player on it and switching back to main player;
- disable or enable video renderers also for streams with AUDIO_STREAM
StreamType, as doing so doesn't raise any issue and simplifies code;
- reword and move some comments to make them easier to understand.
2023-07-19 22:52:18 +02:00
cb00c57009
Set channel icon for stream notifications
2023-07-19 05:52:59 +05:30
cd2884d412
Merge pull request #10235 from TacoTheDank/bumpRoom
...
Update AndroidX Room library
2023-07-18 22:35:30 +02:00
471137093a
Merge pull request #9719 from Marius1501/tabs_on_bottom
...
Added bottom main-tabs feature
2023-07-18 22:03:47 +02:00
a01e59e9db
Update AndroidX Room library
2023-07-17 21:09:44 -04:00
43ef852117
Merge pull request #10230 from TeamNewPipe/fix/offline-stream-chooser
...
[Download] Fix audio stream selection
2023-07-17 23:47:21 +02:00
eeec6fd002
Replace null check with use of NotificationManagerCompat.from
2023-07-17 01:28:55 +02:00
795bc82c7f
Show number of new streams in the collapsed summary notification.
2023-07-17 01:28:55 +02:00
7742c40ac0
Create individual stream notifications for convenience on Android 7.0 and later.
2023-07-17 01:28:55 +02:00
5d6158ea76
No need to manually mark fragment as destroyed for LeakCanary
...
It already does so automatically.
2023-07-14 20:48:05 +02:00
00257e969e
Fix PlayerService leakead by Binder instance
...
Also see https://stackoverflow.com/q/63787707
2023-07-14 18:34:20 +02:00
6b7ffbba4c
[Download] Fix audio stream selection
...
Closes #10180
2023-07-14 17:06:12 +02:00
01b46edf1a
Fix crash after feed update
2023-07-14 11:41:52 +03:00
f8599d17c2
Merge pull request #10085 from TacoTheDank/bumpLeakCanary
...
Update LeakCanary library
2023-07-12 19:05:38 +02:00
c1f0a945c0
Clean up AlertDialogs
2023-07-11 21:54:10 -04:00
db7de05f2b
Update LeakCanary library
2023-07-11 20:32:29 -04:00
10c42de2f1
Fix uploader and subchannel avatars swapped
2023-05-03 10:35:28 +02:00
2315b082ff
Merge pull request #9937 from Theta-Dev/alang-selector
...
Add support for multiple audio tracks
2023-05-02 10:07:21 +02:00
023f6166ab
Add Open in browser button to audio external players dialog
...
This change makes the dialog consistent with the video one.
2023-05-02 00:18:46 +02:00
d89a3c6c4d
Remove "default" from audio track already present message
...
We don't know if, on muxed video streams we get for all services which support
multiple audio languages, that the audio language returned is the original one
or not, even if it should be the case.
In order to avoid saying potential false information, this word has been
removed from the string resource (ID and value) and the corresponding layout ID
in the download dialog.
2023-05-02 00:11:09 +02:00
fb00ee8cf9
[YouTube] Improve download speed ( #9948 )
2023-05-01 19:26:42 +02:00
22671ca16c
fix: audio stream cache key, code fmt
2023-05-01 00:04:04 +02:00
4e837e838d
fix docs in app/src/main/java/org/schabi/newpipe/util/Localization.java
...
Co-authored-by: Audric V. <74829229+AudricV@users.noreply.github.com>
2023-05-01 00:02:37 +02:00
c377ffbce8
Merge branch 'dev' of github.com:TeamNewPipe/NewPipe into alang-selector
2023-04-21 23:32:33 +02:00
b567d428ad
fix: small codestyle fixes
2023-04-21 23:15:37 +02:00
2edc223e77
Merge branch 'dev' into alang-selector
2023-04-17 23:01:07 +02:00
e18a6b09f8
Apply new itag filter only to YouTube streams
2023-04-17 13:10:29 +02:00
f8c3ec4be7
Use a whitelist to filter all streams retrieved by the extractor.
...
NewPipe Extractor now extracts all YouTube Itags and therefore only those which can be handled by the player need to be retrieved from the list of all available streams.
2023-04-17 13:00:11 +02:00
ba3afd1e35
Merge pull request #10021 from Isira-Seneviratne/PendingIntentCompat
...
Switch to AndroidX's PendingIntentCompat.
2023-04-14 14:20:47 +02:00
acebabd028
Use AndroidX's PendingIntentCompat class.
2023-04-13 10:53:46 +05:30
787758a436
[Android 6+] Add ability to always use ExoPlayer's MediaVideoCodecRenderer setOutputSurface workaround
...
As some devices not present in ExoPlayer's list may not implement
MediaCodec.setOutputSurface(Surface) properly, this workaround could be useful
on these devices.
It forces ExoPlayer to fall back on releasing and re-instantiating video codec
instances, which is always used on Android 5 and lower due to addition of this
method in Android 6.
To do so, a CustomMediaCodecVideoRenderer, based on ExoPlayer's
MediaVideoCodecRenderer which always return true for the
codecNeedsSetOutputSurfaceWorkaround method has been added, which is used in
CustomRenderersFactory, a class based on DefaultRenderersFactory which always
returns our CustomMediaCodecVideoRenderer as the video renderers.
CustomRenderersFactory replaces DefaultRenderersFactory in the player, in the
case this setting is enabled.
2023-04-10 17:39:27 +02:00
a6ff85a208
Move media tunneling setting to ExoPlayer settings and make this setting available on release builds
...
Media tunneling may be not supported by more devices than the ones we
whitelisted before.
As a matter of fact, the list of devices on which media tunneling is disabled
could be not maintainable in the future, especially if the list of devices
grows more and more.
A preferable solution is to allow users to configure this setting themselves,
allowing them to not wait for their device(s) to be whitelisted in a future
NewPipe update.
This solution has been applied in this commit and works on every build type.
The corresponding preference in the debug settings has been of course removed
and the code used to prevent media tunneling activation on specific devices has
been removed.
2023-04-10 17:37:30 +02:00
41da8fc05f
Add ability to use ExoPlayer's decoder fallback option
...
This option could help to avoid decoder initialization issues, which falls back
to lower-priority decoders if decoder initialization fails. This may result in
poor playback performance than when using primary decoders.
It is disabled by default, but can be enabled in ExoPlayer settings.
2023-04-10 17:37:30 +02:00
a4a9957a15
Add ExoPlayerSettingsFragment and move playback load interval size setting into it
...
This fragment has been added into SettingsResourceRegistry, to allow searches
in its options.
It has been placed at the place of the previous playback load interval size
setting (so in Video and Audio settings).
2023-04-10 17:37:30 +02:00
365bb2d0e4
Merge branch 'dev' of github.com:TeamNewPipe/NewPipe into alang-selector
2023-04-05 14:06:14 +02:00
4bb45c001d
Fix settings migration
2023-04-04 11:06:20 +02:00
704e9bd7b6
Fix checkstyle
2023-04-04 10:02:01 +02:00
d2735607b8
Changed the default of the switches
2023-04-04 09:57:06 +02:00
3c72992c39
Update app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
...
Co-authored-by: Stypox <stypox@pm.me>
2023-04-04 09:57:06 +02:00
7689d1d15c
Added the migration
2023-04-04 09:57:06 +02:00
32cec6c9a7
Changed the naming
2023-04-04 09:57:06 +02:00
72ca52a29b
Made the requested changes
2023-04-04 09:57:06 +02:00
2ded8c7cc1
Made two list options
2023-04-04 09:57:06 +02:00
759a9080a8
Fixed a bug
2023-04-04 09:57:06 +02:00
2ba649949f
Updated the gesture-switch-toggle
2023-04-04 09:57:06 +02:00
c8d54ec6c7
Changed to val
2023-04-04 09:57:06 +02:00
96e9242431
Update app/src/main/java/org/schabi/newpipe/player/gesture/MainPlayerGestureListener.kt
...
Co-authored-by: Stypox <stypox@pm.me>
2023-04-04 09:57:06 +02:00
3c74cb3439
Created a setting to switch the sides of volume and brightness
2023-04-04 09:57:06 +02:00
d010384c88
Merge branch 'dev' of github.com:TeamNewPipe/NewPipe into alang-selector
2023-04-03 22:13:16 +02:00
02906e8132
Merge pull request #9812 from TeamNewPipe/revert-8894-WindowCompat
...
Revert "Use WindowCompat."
2023-04-03 14:23:17 +02:00
39a5c8bdfb
fix: reset video stream sizes on audio track selection
2023-03-29 13:39:29 +02:00
fb1b1c5be1
Merge pull request #9968 from AudricV/fix-open-in-browser-without-browser
...
Use a system chooser when opening links in browser in the case there is no browser available
2023-03-26 12:41:42 +02:00
1a8aa8b17e
Use a system chooser when opening links in browser in the case there is no browser available
...
This change makes the app using the behavior when there is no default browser
on Android 11 and lower, by opening a system chooser when there is no browser
available (on all Android versions).
Also catch any exception when the system chooser cannot be opened and show the
"No app on your device can open this" toast in this case, as an
`ActivityNotFoundException` could be thrown if no app is available to open a
given web link.
2023-03-26 00:04:38 +01:00
694418d30d
fix: update stream sizes when audio track changed
2023-03-21 16:58:36 +01:00
ed06f559ae
feat: add track selection to downloader
2023-03-20 21:41:28 +01:00
fdd3b03fe5
fix: audio stream format selection
2023-03-19 23:47:33 +01:00
dbd6e4d11f
fix: sonarcloud lint
2023-03-19 22:55:37 +01:00
61a14765f3
fix: ListHelper tests
2023-03-19 22:31:31 +01:00
9b8ffdd2aa
fix: improve track name localization
2023-03-19 21:20:21 +01:00
ef0a4cf8b2
feat: add external audio playback language selector
2023-03-19 21:05:48 +01:00
7aed2eed8a
feat: add prefer original option, improve audio stream ordering
2023-03-19 20:40:27 +01:00
87a88e4df7
feat: localized audio track names
2023-03-19 15:45:52 +01:00
366c39d4c6
feat: add language selector to audio player
2023-03-19 01:15:36 +01:00
77649d388c
fix: reduce complexity
2023-03-18 16:29:22 +01:00
dba53d23aa
fix: remove todo
2023-03-18 16:14:07 +01:00
208887d538
feat: improve audio track sorting, add prefer_descriptive_audio option
2023-03-18 14:50:19 +01:00
de7872d8f2
feat: add audio language selector
2023-03-17 21:51:40 +01:00
d06cc862c8
Remove wrong annotation
2023-03-03 11:58:44 +01:00
23a20712da
Merge pull request #9707 from Jared234/1473_remove_duplicates_from_playlist
...
Remove duplicates from playlist feature
2023-02-28 22:14:01 +01:00
43f46e29ad
Update app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
2023-02-28 21:40:11 +01:00
7617f8cdc7
Update app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
2023-02-28 21:35:57 +01:00
2e3490bce2
Merge pull request #9747 from Jared234/9126_remove_partially_watched_from_feed
...
Added option to remove partially watched videos from the 'Whats new' feed
2023-02-28 19:10:11 +01:00
1dd0930b83
Fixed some small issues
2023-02-28 17:30:17 +01:00
265de55a07
Merge remote-tracking branch 'origin/1473_remove_duplicates_from_playlist' into 1473_remove_duplicates_from_playlist
2023-02-28 16:44:13 +01:00
d8ed2c8503
Refactoring removeDuplicates function and preventing concurrent calls.
2023-02-28 16:43:58 +01:00
73aebc1110
Merge pull request #9847 from Redirion/exo183
...
Update to ExoPlayer 2.18.3
2023-02-26 19:16:25 +01:00
65680b2ccf
Only update main tabs position when it changes
2023-02-26 15:58:09 +01:00
c8ffe65acf
Simplify code to set tab layout position
2023-02-26 15:42:49 +01:00
a4767fc48a
Listen to ignore hardware buttons pref changes
2023-02-26 14:28:57 +01:00
42d861688e
Implement Ignore hardware media button events option
2023-02-26 14:02:50 +01:00
2ee4c6e289
Merge pull request #9728 from mahendranv/channel_card
...
Larger channel cards in search results
2023-02-26 13:43:09 +01:00
097c2368f4
Merge pull request #8180 from Trust04zh/fix-4053-8176
...
Make UI behavior for playback information display more consistent
2023-02-26 13:22:13 +01:00
80e0c6ab0e
Merge pull request #9755 from Jared234/9458_faulty_playlist_thumbnail_update
...
Fixed a bug that caused erroneous updates of the playlist thumbnails
2023-02-26 13:13:12 +01:00
9067c770a7
Made some small code improvements
2023-02-25 22:14:49 +01:00
4b050c0dd8
Merge pull request #9850 from Stypox/fix-api33-links-again3
...
[Android 11+] Correctly open URLs in browser and fix opening downloads and external players
2023-02-25 14:33:41 +01:00
be4f3d9d62
Improve javadocs in ShareUtils
2023-02-25 13:14:31 +01:00
24ff6a4313
Rename videoURL to streamUrl
2023-02-25 13:14:31 +01:00
c2968a3ff2
Use non-deprecated resolveActivity method on API 33+
...
But such method is not available before API 33
2023-02-25 13:14:31 +01:00
600ebdae18
Correctly open urls in browser on Android 11+
...
- Fix misconfiguration in manifest ('http|https|market' is not valid)
- Split ShareUtils functions taking a boolean parameter into pairs of functions with better names and less runtime checks
- Move all Kore-related functions to KoreUtils
- Remove the toast_no_player string
2023-02-25 09:13:59 +01:00
5560cea470
Update to ExoPlayer 2.18.3
2023-02-23 12:46:05 +01:00
39c500f33c
Revert "Use WindowCompat."
2023-02-14 08:27:04 +01:00
624ad6a47c
Prevent NPEs when comment text is null
2023-02-14 08:18:13 +01:00
68ea99d6e6
Made some small code improvements
2023-02-09 23:17:36 +01:00
bc29f40d69
Implemented the suggested changes
2023-02-09 21:18:21 +01:00
42fb13f17a
Merge branch 'dev' into 1473_remove_duplicates_from_playlist
2023-02-09 20:47:10 +01:00
d5b54c85ed
Made some small adjustments to the database query
2023-02-09 20:41:22 +01:00
75292e099c
Larger channel cards in search results
...
- Thumbnail larger (100dp) than the usual (92dp) throughout the app
- Description lint count is 8 (normally 3)
2023-02-09 06:15:22 +05:30
e0cb2892b8
Merge branch 'master' into dev
2023-02-08 22:48:14 +01:00
4cc653fdf1
Fix opening links on Android 12+
2023-02-07 22:39:12 +01:00
4c5c2a3d79
Merge pull request #9693 from Redirion/accelerometerfix
...
Orientation is locked if there is no sensor for it
2023-02-07 20:07:45 +01:00
26b29ca78d
Made the requested color changes
2023-02-07 18:46:40 +01:00
e947e86eae
Make positions in list depend on watch history, remove confusing animations
...
The following is the list of all commits squashed together:
Regain function for option `Positions in lists`
use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.
fix #8176 by eliminating exit delay
Regain function for option `Positions in lists`
update code with developer's comments
apply static import to methods in util class DependentPreferenceHelper
Regain function for option `Positions in lists`
use option `Resume playback` to control display of progress info in VideoDetailFragment, remove this (extra) function from option `Positions in lists`.
remove extra check for live streams, live streams updates just as non-live streams.
fix behavior for displaying progress bar when autoplay off but video resume on
not to retrieve unnecessary states when position in lists disabled
fix mistake in code
simplify conditional logic
update doc comment and remove unused method
Fix not showing duration if position indicators disabled
Positions in lists only depends on watch history
2023-02-07 09:48:18 +01:00
5d3955854e
Fixed the merge conflict
2023-02-05 21:21:02 +01:00
3ff4b713e8
Merge branch 'dev' into 9458_faulty_playlist_thumbnail_update
2023-02-05 20:45:44 +01:00
68097568d5
Fixed the bug by replacing the thumbnail_url with the thumbnail_stream_id
2023-02-05 20:32:34 +01:00
cd8d57040c
Implemented the feature using multiple checkboxes
2023-02-04 18:48:27 +01:00
e0ba872b66
Revert "Update ExoPlayer to 2.18.2"
...
This commit reverts 1bb166a
2023-02-03 18:33:35 +01:00
9c82441c19
Implemented the feature and fixed some small issues
2023-02-01 23:10:31 +01:00
38db0cc713
Changed the color
2023-01-31 16:07:57 +01:00
ee217eb9b7
Merge branch 'TeamNewPipe:dev' into tabs_on_bottom
2023-01-31 13:37:47 +01:00
d2d324f2dd
First draft of the new feature
2023-01-30 22:37:24 +01:00
ca421c28a1
Merge pull request #9538 from Jared234/4186_warning_duplicates_in_playlist
...
Handle duplicate streams in the "Add to playlist" dialog
2023-01-29 10:36:31 +01:00
102975aeb3
Improve handling playlist duplicate indicator
2023-01-29 10:32:32 +01:00
cd12503f99
Merge pull request #9631 from TeamNewPipe/update-npe
...
Update NewPipeExtractor and properly linkify comments
2023-01-28 22:40:19 +01:00
1e724eba6c
Merge pull request #9706 from Jared234/9131_bug_background_player
...
Fixed a bug that caused the background player to stop working
2023-01-28 21:56:00 +01:00
c70ce791db
Added the duplicate indicator explanation & removed some unnecessary functions
2023-01-27 15:37:33 +01:00
0821f6463a
Added bottom main-tabs feature
2023-01-25 19:25:57 +01:00
5b3f8a3d30
Replaced the equals method
2023-01-21 14:56:55 +01:00
e26c038565
Made some small adjustments
2023-01-20 11:55:50 +01:00
ddda80a577
Fixed the bug
2023-01-17 22:31:22 +01:00
e9fcad4787
Fix SonarLint
2023-01-16 23:20:50 +01:00
640d4b0280
Fix more NPEs after OnSharedPreferenceChangeListener changes
2023-01-16 23:05:29 +01:00
b9378a7c1f
Fix NPEs after OnSharedPreferenceChangeListener changes
...
Apps targeting {@link android.os.Build.VERSION_CODES#R} on devices running OS versions {@link android.os.Build.VERSION_CODES#R Android R} or later, will receive a {@code null} value when preferences are cleared.
2023-01-16 22:30:28 +01:00
9ecd5dff09
Orientation is locked if there is no sensor for it
2023-01-16 13:56:45 +01:00
abe6dfb99c
Merge pull request #9671 from Stypox/fix-toast-crash-api33
...
Fix popup enablement toast crash on API 33
2023-01-15 21:05:05 +01:00
6e73c489de
Improve ellipsizing comments
2023-01-15 19:28:01 +01:00
489df0ed7d
Update NewPipeExtractor and properly linkify comments
2023-01-15 19:27:56 +01:00
7924bb5b6b
Thumbnails used in NewPipe are small (list/grid) mode. This PR facilitates full width thumbnails and dubbed as card mode.
2023-01-15 22:32:03 +05:30
c47d1af5e3
Merge pull request #9555 from Marius1501/make_the_channel_images_bigger
...
Made the channel-images in the grid list bigger
2023-01-15 15:16:09 +01:00
51af961e0d
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
86997794ab
Merge pull request #9678 from Marius1501/change_whats_new_icon
...
Changed the What's New icon
2023-01-15 15:12:26 +01:00
22c201be39
Create text subpackage in util
2023-01-15 11:51:07 +01:00
cdd5e89b86
Add ability to copy hashtags, URLs and timestamps in descriptions on long-press
...
This commit adds the ability to copy to clipboard hashtags, URLs and timestamps
when long-pressing them.
Some changes in our TextView class related to text setting have been required
and metadata items are now using a NewPipeTextView instead of a standard
TextView.
Six new classes have been added:
- a custom LinkMovementMethod class;
- a custom ClickableSpan class, LongPressClickableSpan, in order to set a long
press event;
- a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils;
- three implementations of LongPressClickableSpan used when linkifying text:
- HashtagLongPressClickableSpan for hashtags;
- TimestampLongPressClickableSpan for timestamps;
- UrlLongPressClickableSpan for URLs.
2023-01-15 11:40:27 +01:00
764b6aa2b1
Made the channel-images in the grid list bigger
...
Also improved the handling of additional information (expanded description, video count, subscriber count)
2023-01-15 10:50:20 +01:00
f766ef2033
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
ef4a6238c8
See if playlists already contain a stream from db
2023-01-14 18:01:48 +01:00
b3554a6a49
Added the number of duplicates to the toast text.
2023-01-14 18:01:48 +01:00
5fb7b3266b
Removed the duplicate dialog and added another toast option
2023-01-14 18:01:48 +01:00
8b6e110635
Fixed the functionality, improved performance & general code cleanup
2023-01-14 18:01:47 +01:00
f5a1f915be
Continued working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
ac15339911
Started working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
fdfeac081a
Implemented a warning before adding duplicate to playlist.
2023-01-14 18:01:46 +01:00
31396a632f
Chenged the name of the icon
2023-01-14 09:21:37 +01:00
135fc08212
Implemented the "remove duplicates" feature.
2023-01-13 21:35:22 +01:00
5e3caf68a5
Chenged the What's New icon
2023-01-13 16:33:45 +01:00
262b3a2945
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs
...
Added the "What's New"-section to the default tabs
2023-01-13 13:25:02 +01:00
e44d09208c
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown
...
Fixed a bug that prevented the display of multiple empty playlists
2023-01-13 13:20:42 +01:00
38c4a1ed85
Fixed the "Remove Watched" bug
...
Reverted changes and fixed bug in a different way
2023-01-12 23:44:26 +01:00
fd8e92cf77
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail
...
Allow the user to permanently set a thumbnail
2023-01-12 23:27:50 +01:00
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
9514316be3
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
a15a5adacc
Merge pull request #9619 from Redirion/avoidreflectionifpossible
...
Check availability of Samsung DeX only on Samsung devices
2023-01-12 12:06:19 +01:00
b6e6d39985
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
48ae830262
Merge pull request #9653 from petlyh/fix-popup-crash
...
Ask for permission when enqueuing in a popup
2023-01-12 11:24:21 +01:00
03f5dd71a5
Merge pull request #9499 from pratyaksh1610/branch-9466
...
Added Language suffix for subtitle downloads
2023-01-11 19:46:51 +01:00
2afbe58722
UX improvements: keep user edits & do not reset cursor
2023-01-11 19:45:55 +01:00
0a64eac778
Added the "What's New"-section to the default tabs
2023-01-11 16:06:11 +01:00
ad605e2c5a
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
944e295ae7
Use Optional for simpler code
2023-01-11 15:14:18 +01:00
28109fef38
Improve showing of toast
...
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
2023-01-11 14:53:48 +01:00
40442f3f82
Utilize Lifecycle observer
...
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
2023-01-11 14:53:48 +01:00
61da167b4f
Oops, added back missing return;
2023-01-11 14:53:48 +01:00
c744f6756b
Fix Sonar reported code smell
2023-01-11 14:53:48 +01:00
de7057ac3a
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids
...
probably due to background restrictions on Android 10+
2023-01-11 14:53:48 +01:00
585bfff11d
Utilize a retained fragment to safekeep network requests in flight
...
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
2023-01-11 14:53:48 +01:00
0f9c20c986
Improve (un)registering FragmentLifecycleCallbacks
...
to avoid adding it multiple times and ensure proper cleanup
2023-01-11 14:53:48 +01:00
f860392ae9
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+
2023-01-11 14:53:48 +01:00
391830558e
Ensure our transparent activity doesn't block touch events to underlying windows
...
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
2023-01-11 14:53:48 +01:00
c1f37d8591
Also show toast in openDownloadDialog()
...
and lengthened a bit to inform user to wait...
2023-01-11 14:53:48 +01:00
b175774ad8
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change
...
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
2023-01-11 14:53:48 +01:00
73e32889b6
Don't finish() to allow recreate
...
when orientation change is on foot
2023-01-11 14:53:48 +01:00
400ee808e0
Set up theme/locale before super.create()
...
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
2023-01-11 14:53:48 +01:00
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
eb3363d4dd
Created the first draft.
2023-01-10 20:55:18 +01:00
edff696ecc
Ask for permission when enqueuing in a popup
2023-01-10 14:16:19 +01:00
9c19e9813a
Fixed a bug that caused multiple empty playlists to be not shown.
2023-01-08 11:53:42 +01:00
2679a4bf1e
Removed the "Unset Thumbnail" item if you can't use this feature
2023-01-04 16:21:16 +01:00
e8216b2e80
Apply code review suggestions.
2023-01-04 06:10:14 +05:30
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
f10d591462
Samsung DeX should only be checked on Samsung devices
...
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2023-01-03 15:12:02 +01:00
3e15c77a05
move string to donottranslate.xml and fix nits
2023-01-03 14:07:28 +05:30
1bb166a9e8
Merge pull request #9553 from Redirion/exo182
...
Update ExoPlayer to 2.18.2
2023-01-02 18:21:53 +01:00
8fa949537b
Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods
...
Use new NPE UTF8 Utils methods
2023-01-02 17:59:26 +01:00
7454b31788
Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback
...
Support audio only background for services only supporting video streams
2023-01-02 17:51:10 +01:00
b6488fe342
Merge pull request #8841 from Isira-Seneviratne/Notification_mode_ListAdapter
...
Use ListAdapter in NotificationModeConfigAdapter.
2023-01-02 14:47:25 +01:00
b1d9080a0f
Simplify disposables handling in notification mode settings
2023-01-02 14:45:11 +01:00
50269d0f5e
updated caption file name and clean code
2023-01-02 16:23:45 +05:30
f17155bb3f
Merge branch 'TeamNewPipe:dev' into exo182
2023-01-02 10:35:20 +01:00
7988fe0c5a
Use new NewPipe Extractor Utils methods.
2023-01-02 07:03:18 +05:30
f4a5b3bcbf
set 'playback in background button' visible if there are videostreams
2023-01-01 21:55:03 +01:00
J-Stutzmann
TobiGr
Isira Seneviratne
AudricV
Isira Seneviratne
TacoTheDank
Stypox
Koitharu
ThetaDev
ge78fug
Marius Wagner
Jared Fantaye
Nyan Cat
Robin
pratyaksh1610
Mahendran
Trust_04zh
devlearner
petlyh
Robin
evermind