From fd4c37e9b38c1f75f6e91d6e9cc1137890223c6c Mon Sep 17 00:00:00 2001 From: TobiGr Date: Sun, 22 Nov 2020 11:46:19 +0100 Subject: [PATCH] Fix crash on startup caused by no implementation of onError() method --- .../schabi/newpipe/CheckForNewAppVersion.java | 46 ++++++++++++------- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java b/app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java index f9b18d463..b18445ab5 100644 --- a/app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java +++ b/app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java @@ -198,24 +198,36 @@ public final class CheckForNewAppVersion { }) .subscribeOn(Schedulers.io()) .observeOn(AndroidSchedulers.mainThread()) - .subscribe(response -> { - // Parse the json from the response. - try { - final JsonObject githubStableObject = JsonParser.object().from(response) - .getObject("flavors").getObject("github").getObject("stable"); + .subscribe( + response -> { + // Parse the json from the response. + try { + final JsonObject githubStableObject = JsonParser.object() + .from(response).getObject("flavors").getObject("github") + .getObject("stable"); - final String versionName = githubStableObject.getString("version"); - final int versionCode = githubStableObject.getInt("version_code"); - final String apkLocationUrl = githubStableObject.getString("apk"); + final String versionName = githubStableObject + .getString("version"); + final int versionCode = githubStableObject + .getInt("version_code"); + final String apkLocationUrl = githubStableObject + .getString("apk"); - compareAppVersionAndShowNotification(app, versionName, apkLocationUrl, - versionCode); - } catch (final JsonParserException e) { - // connectivity problems, do not alarm user and fail silently - if (DEBUG) { - Log.w(TAG, Log.getStackTraceString(e)); - } - } - }); + compareAppVersionAndShowNotification(app, versionName, + apkLocationUrl, versionCode); + } catch (final JsonParserException e) { + // connectivity problems, do not alarm user and fail silently + if (DEBUG) { + Log.w(TAG, Log.getStackTraceString(e)); + } + } + }, + throwable -> { + // connectivity problems, do not alarm user and fail silently + if (DEBUG) { + Log.i(TAG, "Could not get NewPipe API: network problem"); + Log.i(TAG, Log.getStackTraceString(throwable)); + } + }); } }