Peertube
/
NewPipe-app-android
mirror of https://github.com/TeamNewPipe/NewPipe/
1
0
Fork 0
Code Issues Releases Wiki Activity

Prevent tapping on thumbnail if video details are not loaded

This commit is contained in:
Stypox 2022-08-24 17:48:02 +02:00
parent ca0f56eea8
commit f9994abb94
No known key found for this signature in database
GPG Key ID: 4BDF1B40A49FDD23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
View File

@ -505,12 +505,18 @@ public final class VideoDetailFragment
} }
break; break;
case R.id.detail_thumbnail_root_layout: case R.id.detail_thumbnail_root_layout:
// make sure not to open any player if there is nothing currently loaded!
// FIXME removing this `if` causes the player service to start correctly, then stop,
// then restart badly without calling `startForeground()`, causing a crash when
// later closing the detail fragment
if (currentInfo != null) {
autoPlayEnabled = true; // forcefully start playing autoPlayEnabled = true; // forcefully start playing
// FIXME Workaround #7427 // FIXME Workaround #7427
if (isPlayerAvailable()) { if (isPlayerAvailable()) {
player.setRecovery(); player.setRecovery();
} }
openVideoPlayerAutoFullscreen(); openVideoPlayerAutoFullscreen();
}
break; break;
case R.id.detail_title_root_layout: case R.id.detail_title_root_layout:
toggleTitleAndSecondaryControls(); toggleTitleAndSecondaryControls();