From b31490c4e34e7256bf270cb255ec2ffc51f5701a Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Fri, 1 Jan 2016 22:23:00 +0100
Subject: [PATCH] make all strings translatable

---
 app/src/main/AndroidManifest.xml            | 6 ++----
 app/src/main/res/layout/paginate_footer.xml | 2 +-
 app/src/main/res/values/strings.xml         | 2 ++
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index ae3f5f056..8f562698d 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -74,12 +74,10 @@
             android:parentActivityName=".VideoItemDetailActivity"
             tools:ignore="UnusedAttribute">
         </activity>
-        <!--TODO: make label a translatable string -->
         <service
             android:name=".BackgroundPlayer"
-            android:label="NewPipe Background Player"
-            android:exported="false" >
-        </service>
+            android:label="@string/background_player_name"
+            android:exported="false" />
         <activity
             android:name=".SettingsActivity"
             android:label="@string/title_activity_settings" >
diff --git a/app/src/main/res/layout/paginate_footer.xml b/app/src/main/res/layout/paginate_footer.xml
index 8e5d7571d..b3757c1af 100644
--- a/app/src/main/res/layout/paginate_footer.xml
+++ b/app/src/main/res/layout/paginate_footer.xml
@@ -8,7 +8,7 @@
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Loading"
+        android:text="@string/loading"
         android:textAppearance="?android:attr/textAppearanceMedium" />
 
     <ProgressBar
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 177280277..725bf920e 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1,6 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <resources>
     <string name="app_name" translatable="false">NewPipe</string>
+    <string name="background_player_name">NewPipe Background Player</string>
     <string name="title_videoitem_detail" translatable="false">NewPipe</string>
     <string name="viewCountText">%1$s views</string>
     <string name="uploadDateText">Uploaded on %1$s</string>
@@ -10,6 +11,7 @@
     <string name="fdroidVLCurl" translatable="false">https://f-droid.org/repository/browse/?fdfilter=vlc&amp;fdid=org.videolan.vlc</string>
     <string name="open_in_browser">Open in browser</string>
     <string name="share">Share</string>
+    <string name="loading">Loading</string>
     <string name="download">Download</string>
     <string name="search">Search</string>
     <string name="settings">Settings</string>