diff --git a/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt b/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt index 2345fb96a..e4d10fb61 100644 --- a/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt +++ b/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt @@ -30,6 +30,7 @@ import android.view.View import android.view.ViewGroup import androidx.appcompat.app.AlertDialog import androidx.core.os.bundleOf +import androidx.core.view.isVisible import androidx.lifecycle.Observer import androidx.lifecycle.ViewModelProvider import androidx.preference.PreferenceManager @@ -254,11 +255,9 @@ class FeedFragment : BaseListFragment() { oldestSubscriptionUpdate = loadedState.oldestUpdate + refresh_subtitle_text.isVisible = loadedState.notLoadedCount > 0 if (loadedState.notLoadedCount > 0) { - refresh_subtitle_text.visibility = View.VISIBLE refresh_subtitle_text.text = getString(R.string.feed_subscription_not_loaded_count, loadedState.notLoadedCount) - } else { - refresh_subtitle_text.visibility = View.GONE } if (loadedState.itemsErrors.isNotEmpty()) { diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt b/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt index e661a8b3b..dfec50ad2 100644 --- a/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt +++ b/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt @@ -13,6 +13,8 @@ import android.view.inputmethod.InputMethodManager import android.widget.Toast import androidx.core.content.getSystemService import androidx.core.os.bundleOf +import androidx.core.view.isGone +import androidx.core.view.isVisible import androidx.fragment.app.DialogFragment import androidx.lifecycle.Observer import androidx.lifecycle.ViewModelProvider @@ -415,21 +417,14 @@ class FeedGroupDialog : DialogFragment(), BackPressable { else -> android.R.string.ok }) - delete_button.visibility = when { - currentScreen != InitialScreen -> View.GONE - groupId == NO_GROUP_SELECTED -> View.GONE - else -> View.VISIBLE - } + delete_button.isGone = currentScreen != InitialScreen || groupId == NO_GROUP_SELECTED hideKeyboard() hideSearch() } private fun View.onlyVisibleIn(vararg screens: ScreenState) { - visibility = when (currentScreen) { - in screens -> View.VISIBLE - else -> View.GONE - } + isVisible = currentScreen in screens } /*/​////////////////////////////////////////////////////////////////////////// diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/item/HeaderWithMenuItem.kt b/app/src/main/java/org/schabi/newpipe/local/subscription/item/HeaderWithMenuItem.kt index 324932256..142bba433 100644 --- a/app/src/main/java/org/schabi/newpipe/local/subscription/item/HeaderWithMenuItem.kt +++ b/app/src/main/java/org/schabi/newpipe/local/subscription/item/HeaderWithMenuItem.kt @@ -1,9 +1,8 @@ package org.schabi.newpipe.local.subscription.item -import android.view.View.GONE import android.view.View.OnClickListener -import android.view.View.VISIBLE import androidx.annotation.DrawableRes +import androidx.core.view.isVisible import com.xwray.groupie.kotlinandroidextensions.GroupieViewHolder import com.xwray.groupie.kotlinandroidextensions.Item import kotlinx.android.synthetic.main.header_with_menu_item.header_menu_item @@ -47,6 +46,6 @@ class HeaderWithMenuItem( } private fun updateMenuItemVisibility(viewHolder: GroupieViewHolder) { - viewHolder.header_menu_item.visibility = if (showMenuItem) VISIBLE else GONE + viewHolder.header_menu_item.isVisible = showMenuItem } } diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/item/PickerSubscriptionItem.kt b/app/src/main/java/org/schabi/newpipe/local/subscription/item/PickerSubscriptionItem.kt index 7d33da71f..df84c115a 100644 --- a/app/src/main/java/org/schabi/newpipe/local/subscription/item/PickerSubscriptionItem.kt +++ b/app/src/main/java/org/schabi/newpipe/local/subscription/item/PickerSubscriptionItem.kt @@ -1,6 +1,7 @@ package org.schabi.newpipe.local.subscription.item import android.view.View +import androidx.core.view.isVisible import com.nostra13.universalimageloader.core.ImageLoader import com.xwray.groupie.kotlinandroidextensions.GroupieViewHolder import com.xwray.groupie.kotlinandroidextensions.Item @@ -25,7 +26,7 @@ data class PickerSubscriptionItem( viewHolder.thumbnail_view, ImageDisplayConstants.DISPLAY_AVATAR_OPTIONS) viewHolder.title_view.text = subscriptionEntity.name - viewHolder.selected_highlight.visibility = if (isSelected) View.VISIBLE else View.GONE + viewHolder.selected_highlight.isVisible = isSelected } override fun unbind(viewHolder: GroupieViewHolder) {