From cf377c2591f06d834ee7bbfe54252ec7bf985d32 Mon Sep 17 00:00:00 2001
From: Xiang Rong Lin <41164160+XiangRongLin@users.noreply.github.com>
Date: Mon, 3 Feb 2020 10:35:50 +0100
Subject: [PATCH] Fix bug causing crashes when sharing a downloaded file.

---
 .../giga/ui/adapter/MissionAdapter.java       | 33 ++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java b/app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
index 852c29835..c2d3a9b9e 100644
--- a/app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
+++ b/app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
@@ -341,17 +341,7 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
         if (BuildConfig.DEBUG)
             Log.v(TAG, "Mime: " + mimeType + " package: " + BuildConfig.APPLICATION_ID + ".provider");
 
-        Uri uri;
-
-        if (mission.storage.isDirect()) {
-            uri = FileProvider.getUriForFile(
-                    mContext,
-                    BuildConfig.APPLICATION_ID + ".provider",
-                    new File(URI.create(mission.storage.getUri().toString()))
-            );
-        } else {
-            uri = mission.storage.getUri();
-        }
+        Uri uri = resolveShareableUri(mission);
 
         Intent intent = new Intent();
         intent.setAction(Intent.ACTION_VIEW);
@@ -379,11 +369,30 @@ public class MissionAdapter extends Adapter<ViewHolder> implements Handler.Callb
 
         Intent intent = new Intent(Intent.ACTION_SEND);
         intent.setType(resolveMimeType(mission));
-        intent.putExtra(Intent.EXTRA_STREAM, mission.storage.getUri());
+        intent.putExtra(Intent.EXTRA_STREAM, resolveShareableUri(mission));
+        intent.addFlags(FLAG_GRANT_READ_URI_PERMISSION);
 
         mContext.startActivity(Intent.createChooser(intent, null));
     }
 
+    /**
+     * Returns an Uri which can be shared to other applications.
+     *
+     * @see <a href="https://stackoverflow.com/questions/38200282/android-os-fileuriexposedexception-file-storage-emulated-0-test-txt-exposed">
+     * https://stackoverflow.com/questions/38200282/android-os-fileuriexposedexception-file-storage-emulated-0-test-txt-exposed</a>
+     */
+    private Uri resolveShareableUri(Mission mission) {
+        if (mission.storage.isDirect()) {
+            return FileProvider.getUriForFile(
+                mContext,
+                BuildConfig.APPLICATION_ID + ".provider",
+                new File(URI.create(mission.storage.getUri().toString()))
+            );
+        } else {
+            return mission.storage.getUri();
+        }
+    }
+
     private static String resolveMimeType(@NonNull Mission mission) {
         String mimeType;