From 74522103a2d4811e9eb6aa14c7b06ef2a83e9f3d Mon Sep 17 00:00:00 2001 From: Daniel Waxweiler Date: Mon, 3 May 2021 21:39:23 +0200 Subject: [PATCH] remove use of global in test --- source/connector-mobilizon/front/events-loader.js | 2 +- source/connector-mobilizon/front/html-creator-test.js | 8 +++++--- source/connector-mobilizon/front/html-creator.js | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/source/connector-mobilizon/front/events-loader.js b/source/connector-mobilizon/front/events-loader.js index d2cf881..8269780 100644 --- a/source/connector-mobilizon/front/events-loader.js +++ b/source/connector-mobilizon/front/events-loader.js @@ -11,7 +11,7 @@ function displayEvents(data, list) { for (let i = 0; i < eventsCount; i++) { const li = document.createElement('li') - const a = createAnchorElement({ text: events[i].title, url: events[i].url }) + const a = createAnchorElement({ document, text: events[i].title, url: events[i].url }) li.appendChild(a) const br = document.createElement('br') diff --git a/source/connector-mobilizon/front/html-creator-test.js b/source/connector-mobilizon/front/html-creator-test.js index d92bbdc..4d778df 100644 --- a/source/connector-mobilizon/front/html-creator-test.js +++ b/source/connector-mobilizon/front/html-creator-test.js @@ -1,14 +1,16 @@ import test from 'ava' import { JSDOM } from 'jsdom' -import * as HtmlCreator from './html-creator' +import { createAnchorElement } from './html-creator' + +let document test.beforeEach(() => { - global.document = new JSDOM().window.document + document = new JSDOM().window.document }) test('#createAnchorElement usual parameters', t => { - const a = HtmlCreator.createAnchorElement({ text: 'a', url: 'b' }) + const a = createAnchorElement({ document, text: 'a', url: 'b' }) t.is(a.tagName, 'A') t.is(a.innerHTML, 'a') t.is(a.getAttribute('href'), 'b') diff --git a/source/connector-mobilizon/front/html-creator.js b/source/connector-mobilizon/front/html-creator.js index b0a9ce0..d64503b 100644 --- a/source/connector-mobilizon/front/html-creator.js +++ b/source/connector-mobilizon/front/html-creator.js @@ -1,4 +1,4 @@ -export function createAnchorElement({ text, url }) { +export function createAnchorElement({ document, text, url }) { const a = document.createElement('a') a.setAttribute('href', url) a.setAttribute('target', '_blank')