From 6c0c2d23fe4d3ec6f0c960b54b5396d8c01bdc66 Mon Sep 17 00:00:00 2001 From: akaessens <24660231+akaessens@users.noreply.github.com> Date: Fri, 28 Aug 2020 16:19:08 +0200 Subject: [PATCH] make fbevent properties immutable --- .../com/akdev/nofbeventscraper/FbEvent.java | 21 +++++++++---------- .../com/akdev/nofbeventscraper/FbScraper.java | 17 ++++++++------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/app/src/main/java/com/akdev/nofbeventscraper/FbEvent.java b/app/src/main/java/com/akdev/nofbeventscraper/FbEvent.java index 32fd8a7..717b12c 100644 --- a/app/src/main/java/com/akdev/nofbeventscraper/FbEvent.java +++ b/app/src/main/java/com/akdev/nofbeventscraper/FbEvent.java @@ -6,19 +6,18 @@ import java.time.format.FormatStyle; public class FbEvent { - public String url; - public String name; - public ZonedDateTime start_date; - public ZonedDateTime end_date; - public String description; - public String location; - public String image_url; + public final String url; + public final String name; + public final ZonedDateTime start_date; + public final ZonedDateTime end_date; + public final String description; + public final String location; + public final String image_url; - public FbEvent() { - } - - public FbEvent(String name, ZonedDateTime start_date, ZonedDateTime end_date, String description, String location, String image_url) { + public FbEvent(String url, String name, ZonedDateTime start_date, ZonedDateTime end_date, + String description, String location, String image_url) { + this.url = url; this.name = name; this.start_date = start_date; this.end_date = end_date; diff --git a/app/src/main/java/com/akdev/nofbeventscraper/FbScraper.java b/app/src/main/java/com/akdev/nofbeventscraper/FbScraper.java index da3d0f1..a4f0dfc 100644 --- a/app/src/main/java/com/akdev/nofbeventscraper/FbScraper.java +++ b/app/src/main/java/com/akdev/nofbeventscraper/FbScraper.java @@ -135,14 +135,15 @@ public class FbScraper extends AsyncTask { JSONObject reader = new JSONObject(json); - event = new FbEvent(); - event.url = url; - event.name = readFromJson(reader, "name"); - event.start_date = toZonedDateTime(readFromJson(reader, "startDate")); - event.end_date = toZonedDateTime(readFromJson(reader, "endDate")); - event.description = fixDescriptionLinks(readFromJson(reader, "description")); - event.location = fixLocation(readFromJson(reader, "location")); - event.image_url = readFromJson(reader, "image"); + event = new FbEvent( + url, + readFromJson(reader, "name"), + toZonedDateTime(readFromJson(reader, "startDate")), + toZonedDateTime(readFromJson(reader, "endDate")), + fixDescriptionLinks(readFromJson(reader, "description")), + fixLocation(readFromJson(reader, "location")), + readFromJson(reader, "image") + ); } catch (URISyntaxException | MalformedURLException e) { e.printStackTrace();