From 404b8e10869ce5c8afacbaf9d58aa33034bd621d Mon Sep 17 00:00:00 2001
From: akaessens <24660231+akaessens@users.noreply.github.com>
Date: Sun, 4 Oct 2020 11:36:54 +0200
Subject: [PATCH] fix OOB creating incorrect error message, closes #26

---
 .../main/java/com/akdev/nofbeventscraper/FbPageScraper.java  | 5 ++++-
 app/src/main/res/values-de/strings.xml                       | 1 +
 app/src/main/res/values/strings.xml                          | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/com/akdev/nofbeventscraper/FbPageScraper.java b/app/src/main/java/com/akdev/nofbeventscraper/FbPageScraper.java
index c2b46b7..d3e2f33 100644
--- a/app/src/main/java/com/akdev/nofbeventscraper/FbPageScraper.java
+++ b/app/src/main/java/com/akdev/nofbeventscraper/FbPageScraper.java
@@ -89,7 +89,6 @@ public class FbPageScraper extends AsyncTask<Void, Void, Void> {
                         this.url = "https://mbasic.facebook.com" + next_url;
                     } catch (NullPointerException e) {
                         url = null;
-                        event_links = event_links.subList(0, max);
                     }
 
 
@@ -107,6 +106,10 @@ public class FbPageScraper extends AsyncTask<Void, Void, Void> {
             }
         } while (url != null);
 
+        if (this.event_links.size() == 0) {
+            this.error = R.string.error_no_events;
+        }
+
         return null;
     }
 
diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
index 5c8eae0..c14b7d8 100644
--- a/app/src/main/res/values-de/strings.xml
+++ b/app/src/main/res/values-de/strings.xml
@@ -22,4 +22,5 @@
     <string name="undo">Rückgängig</string>
     <string name="preferences_page_event_max_summary">Maximale Anzahl Events, die von einer einzelnen Seite geladen werden sollen.</string>
     <string name="preferences_page_event_max">Veranstaltungslimit für Seiten</string>
+    <string name="error_no_events">Fehler: keine bevorstehenden Veranstaltungen</string>
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index cc0a3f5..9282da1 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -37,6 +37,7 @@
     <string name="event_placeholder" translatable="false">Placeholder</string>
     <string name="done">Done</string>
     <string name="undo">Undo</string>
+    <string name="error_no_events">Error: No upcoming events</string>
 
 
 </resources>