Mobilizon/Facebook-Events-iCal-Converter
1
0
Fork 0
mirror of https://github.com/comatory/fb2iCal synced 2025-06-05 22:09:25 +02:00
Code Issues Releases Wiki Activity

fix: do not attempt to parse non-existent FB pages

Browse Source 
When user enters something invalid (like number 123), it wuold still hit
FB webpage and return HTML. I do simple detection by looking at title
when it attempts to parse the DOM directly. When it contains "Content
Not Found", it is skipped.

Non-existent web pages cannot be parsed by using LDJSON parser and
looking at null data.
This commit is contained in:
Ondřej Synáček
2020-12-26 21:03:03 +01:00
parent 0683ef9666
commit ae700330b9
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/services/dom-parser.spec.js
View File

@@ -258,6 +258,20 @@ describe(parseUsingDOM, () => {
})
it('should return null if title was blacklisted', () => {
const html = `
<html>
<head>
<title>Content Not Found</title>
</head>
</html>
`
const eventData = parseUsingDOM(html, { logger })
expect(eventData).to.be.null
})
it('should NOT return start time without title', () => {
const html = `
<html>