diff --git a/lib/public/service-worker.js b/lib/public/service-worker.js index 439007a..4664d77 100644 --- a/lib/public/service-worker.js +++ b/lib/public/service-worker.js @@ -1,4 +1,4 @@ -// Worker v4 +// Worker v5 self.addEventListener('install', (event) => { event.waitUntil( @@ -7,8 +7,8 @@ self.addEventListener('install', (event) => { '/', '/favicon.ico', '/scripts.js?3', - '/style.css?3', - '/about?1', + '/style.css?4', + '/about?2', ]) }) ) diff --git a/lib/public/style.css b/lib/public/style.css index b7533b6..c3865c2 100644 --- a/lib/public/style.css +++ b/lib/public/style.css @@ -18,11 +18,9 @@ body { min-height: 100vh; font-size: 16px; margin: 0px; - max-width: 800px; -} - -header, footer, article { padding: 5px; + max-width: 600px; + box-sizing: border-box; } footer { diff --git a/lib/views/about.ejs b/lib/views/about.ejs index d85eaf7..46dff2d 100644 --- a/lib/views/about.ejs +++ b/lib/views/about.ejs @@ -4,7 +4,6 @@ - Facebook Events to iCal Converter | about @@ -16,7 +15,10 @@ Not too long ago I deactivated my Facebook account. While I do not miss the social network very much, plenty of local events are only announced on Facebook.

- To my surprise, I found out that the company discontinued the ability to expor events to iCal files. This app aims at enabling you to do just that. It only works with public events. Unfortunately I haven't had the time to enable you to export your own events (but it's definitely possible). + To my surprise, I found out that the company discontinued the ability to export events to iCal files. This app aims at enabling you to do just that. It only works with public events. Unfortunately I haven't had the time to enable you to export your own events (but it's definitely possible). +

+

+ I tried to keep the code and build as simple as I could. It does not have fancy build pipeline, code coverage or typing system, not even design (yeah you probably noticed that, right?)

How it works?

@@ -49,6 +51,6 @@ If you want to let me know about any problems or improvements, you can contact me via my website, or even better create an issue on Github (link are on the main page in the footer).

- Go back + Close diff --git a/lib/views/index.ejs b/lib/views/index.ejs index 7297584..01227d8 100644 --- a/lib/views/index.ejs +++ b/lib/views/index.ejs @@ -73,8 +73,8 @@ diff --git a/readme.MD b/readme.MD index 46ee8a5..e74bcd6 100644 --- a/readme.MD +++ b/readme.MD @@ -14,6 +14,12 @@ Run development server: `npm run start:dev`. Run development server with debugger `npm run start:dev:inspect`. +### Static assets + +There is no clever way to invalidate static assets (HTML, CSS, JS), so if you make any changes, just increment query parameters in view template(s) and service worker. Changing service worker should trigger new _update_ event that should also re-fetch new assets. + +Sorry I wanted to keep the app simple so this is done manually. No big deal for me though. + ## Deployment The command `npm run start` will start the server in production mode.