mirror of
https://github.com/pachli/pachli-android.git
synced 2025-02-01 01:46:54 +01:00
abfd3240bd
Previous code would remove image attachments from the compose editor if there was a problem uploading or updating them. This caused a particular problem with image captions. You could attach a valid image, then write a caption that was too long for the server. The server would reject the status, and the status was saved to drafts. Then you open the draft, which tries to upload the image again with a too-long caption. The upload is rejected, and the image, along with the caption, is removed. Fix this. - Change `QueuedMedia` to track the upload state as a `Result<_,_>`, so any error messages are preserved and available to the UI. - The different `Ok` types for the upload state contain the upload progress percentage (if appropriate) or the server's ID for the uploaded media. - Change `ProgressImageView` to accept the upload state `Result`. If the result is an error the image is drawn with a red overlay and white "error" icon. - If an upload is in an error state allow the user to click on it. That shows a dialog explaining the error, and provides options to edit the image, change the caption, etc. - When changing the caption make the API call to change it on the server (if the attachment has been uploaded). This makes the user aware of any errors sooner in the process, so they can correct them. Fixes #879