a65e2bd937
fix(deps): update dependency com.apollographql.apollo3 to v3.8.3 ( #558 )
2024-03-21 17:10:55 +01:00
8ef227fd20
fix: Improve accessibility of ComposeActivity bottomsheets and buttons ( #548 )
...
The previous bottomsheets did set a minimum height for the menu items,
so they were less than the recommended 48dp minimum. Fix that to improve
the overall accessibility.
Always highlight the "visibilty" icon, to make it clear that it's
something that is set (even if to the default).
Show the visibility icon on the "Toot" button as an additional reminder
to the user.
Other changes:
- Use the "filled" style for all icons (the visibility icons had the
"outlined" style)
- Use the `makeIcon` helper function.
- Use the `Status.Visibility` extension functions to determine the icon
for each visibility type, reducing code duplication.
2024-03-21 16:24:31 +01:00
0ad25bd617
chore: Create SECURITY.md ( #556 )
2024-03-21 16:03:07 +01:00
23faa8531f
chore(deps): pin dependencies ( #549 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout ) | action |
pinDigest | -> `b4ffde6` |
| [actions/github-script](https://togithub.com/actions/github-script ) |
action | pinDigest | -> `60a0d83` |
| [actions/setup-java](https://togithub.com/actions/setup-java ) | action
| pinDigest | -> `99b8673` |
|
[actions/upload-artifact](https://togithub.com/actions/upload-artifact )
| action | pinDigest | -> `5d5d22a` |
| [gradle/actions](https://togithub.com/gradle/actions ) | action |
pinDigest | -> `417ae3c` |
|
[gradle/wrapper-validation-action](https://togithub.com/gradle/wrapper-validation-action )
| action | pinDigest | -> `699bb18` |
|
[myrotvorets/set-commit-status-action](https://togithub.com/myrotvorets/set-commit-status-action )
| action | pinDigest | -> `3730c0a` |
|
[r0adkll/sign-android-release](https://togithub.com/r0adkll/sign-android-release )
| action | pinDigest | -> `dbeba6b` |
|
[r0adkll/upload-google-play](https://togithub.com/r0adkll/upload-google-play )
| action | pinDigest | -> `935ef9c` |
|
[reviewdog/action-suggester](https://togithub.com/reviewdog/action-suggester )
| action | pinDigest | -> `3d7fde6` |
|
[xt0rted/pull-request-comment-branch](https://togithub.com/xt0rted/pull-request-comment-branch )
| action | pinDigest | -> `d97294d` |
|
[ytanikin/PRConventionalCommits](https://togithub.com/ytanikin/PRConventionalCommits )
| action | pinDigest | -> `b7be921` |
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-21 13:10:59 +01:00
4409c736a5
chore: Adopt Renovate's "best-practices" configuration defaults ( #547 )
2024-03-21 12:49:39 +01:00
778017475d
revert: Allow "Vote" button to expand to contain text ( #545 )
...
Expanded too far...
2024-03-19 19:02:15 +01:00
ae811d7126
refactor: Allow "Vote" button to expand to contain text ( #545 )
2024-03-19 18:00:42 +01:00
bcceaaa434
feat: Show the post's language tag in the detailed view ( #546 )
2024-03-19 18:00:33 +01:00
4f9b283432
refactor: Simplify and optimize viewBinding delegate ( #544 )
...
Based on Christophe Beyl's technique described in
https://bladecoder.medium.com/viewlifecyclelazy-and-other-ways-to-avoid-view-memory-leaks-in-android-fragments-4aa982e6e579
2024-03-19 16:42:08 +01:00
c2fc3d1f08
feat: Allow user to see poll results before voting ( #543 )
...
Show a labelled checkbox to the bottom-right of polls that the user has
not voted in and that have votes. If checked the current vote tally (as
percentages) will be shown, along with a bar showing the relative value
of each option.
2024-03-19 13:23:21 +01:00
b478f38e19
fix(l10n): Update Kabyle translations
...
Currently translated at 72.7% (8 of 11 strings)
Translation: Pachli/Core/Ui : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/coreui-main/kab/
2024-03-18 19:31:42 +01:00
76984763af
fix(l10n): Update Kabyle translations
...
Currently translated at 9.8% (6 of 61 strings)
Translation: Pachli/Feature/About : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/featureabout-main/kab/
2024-03-18 19:31:42 +01:00
4ca43e1c2e
fix(l10n): Update Finnish translations
...
Currently translated at 100.0% (593 of 593 strings)
Translation: Pachli/App : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/app-main/fi/
2024-03-18 19:31:42 +01:00
fd6b6d0c07
fix(l10n): Update Kabyle translations
...
Currently translated at 41.1% (7 of 17 strings)
Translation: Pachli/Feature/Login
Translate-URL: https://hosted.weblate.org/projects/pachli/featurelogin/kab/
2024-03-18 19:31:42 +01:00
f64f9f03ae
fix(l10n): Translations update from Hosted Weblate ( #541 )
...
Translations update from [Hosted Weblate](https://hosted.weblate.org )
for [Pachli/Fastlane
Metadata](https://hosted.weblate.org/projects/pachli/fastlane-metadata/ ).
It also includes following components:
* [Pachli/Core/Network :
Main](https://hosted.weblate.org/projects/pachli/corenetwork-main/ )
* [Pachli/App :
Main](https://hosted.weblate.org/projects/pachli/app-main/ )
* [Pachli/Feature/About :
Main](https://hosted.weblate.org/projects/pachli/featureabout-main/ )
* [Pachli/Feature/Lists :
Main](https://hosted.weblate.org/projects/pachli/featurelists-main/ )
* [Pachli/Core/Ui :
Main](https://hosted.weblate.org/projects/pachli/coreui-main/ )
* [Pachli/App :
Google](https://hosted.weblate.org/projects/pachli/app-google/ )
*
[Pachli/Feature/Login](https://hosted.weblate.org/projects/pachli/featurelogin/ )
* [Pachli/Core/Designsystem :
Main](https://hosted.weblate.org/projects/pachli/coredesignsystem-main/ )
* [Pachli/Core/Activity :
Orange](https://hosted.weblate.org/projects/pachli/coreactivity-orange/ )
* [Pachli/Core/Activity :
Main](https://hosted.weblate.org/projects/pachli/coreactivity-main/ )
* [Pachli/App :
Fdroid](https://hosted.weblate.org/projects/pachli/app-fdroid/ )
Current translation status:
---------
Co-authored-by: Languages add-on <noreply-addon-languages@weblate.org>
2024-03-17 00:24:12 +01:00
9e0a1f4015
refactor: Simplify use of BackgroundMessageView ( #539 )
...
Previous code expected callers to typically provide the drawable and the
error message string resource, resulting in duplicate code at many
callsites.
Replace with three canned messages for empty containers, generic errors,
and network errors respectively. The images for these are fixed, the
caller may choose a different string resource for the error if there is
a more specific option.
Update and simplify the call sites.
2024-03-16 22:12:54 +01:00
e41722e16f
refactor: Extract user list functionality to `feature:lists` ( #537 )
...
Move `ListsActivity`, along with fragments and viewmodels, to a new
`feature:lists` module.
Previous code used the `item_follow_request` layout, which was not
ideal, so update it to use a dedicated layout, `item_account_in_list`.
The UI uses strings and views originally defined in the main app, so
move them elsewhere so they can be re-used.
- `BackgroundMessageView` moves to `core.ui`.
- `Lazy` moves to `core.common`.
- `ThrowableExtensions` split; the extensions specific to throwables
from network activity move to `core.network`, others move to `core.ui`.
- `BindingHolder` moves to `core.ui`
- Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
9535506596
fix: Catch and swallow snackbar exception ( #536 )
...
For reasons not fully understood the root of a fragment's view might not
have relevant view from the activity set as its parent. This causes
`Snackbar.make()` to throw an exception, and crash.
See https://issuetracker.google.com/issues/228215869 .
For now, "fix" this by swallowing the exception. Not showing the error
is better than crashing.
2024-03-16 14:34:21 +01:00
bdbe2f85c2
feat: Allow the user to set a list's replies policy ( #534 )
...
The replies policy controls whether replies from members of the list
also appear in the list.
Display the replies policy as three radio buttons when a list is created
or updated, and send the chosen replies policy via the API.
Default value if not specified is always "list", for consistency with
the Mastodon API defaults.
While I'm here:
- Ensure the list dialog layout is inflated using the dialog's themed
context
- Use a `TextInputLayout` wrapper around the list name in the list
dialog for better UX
- Simplify the dialog layout, use LinearLayout, and standard padding and
margins
2024-03-14 23:56:16 +01:00
6c970a9742
fix: Keep TabDataJsonAdapter so Moshi can deserialize in release builds ( #535 )
2024-03-14 20:10:34 +01:00
256c6139ac
feat: Show network activity in ListsActivity ( #533 )
...
Modify `ListsViewModel` to keep track of the number of active network
operations and export as a flow. Collect this in `ListsActivity` and
show a `LinearProgressIndicator` while it is non-zero.
2024-03-14 18:18:34 +01:00
1deaa2c1ff
chore(deps): update kotlin ( #509 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.devtools.ksp](https://goo.gle/ksp )
([source](https://togithub.com/google/ksp )) | `1.9.22-1.0.18` ->
`1.9.23-1.0.19` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin](https://goo.gle/ksp )
([source](https://togithub.com/google/ksp )) | `1.9.22-1.0.18` ->
`1.9.23-1.0.19` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| org.jetbrains.kotlin.plugin.parcelize | `1.9.22` -> `1.9.23` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| org.jetbrains.kotlin.jvm | `1.9.22` -> `1.9.23` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| org.jetbrains.kotlin.android | `1.9.22` -> `1.9.23` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [org.jetbrains.kotlin:kotlin-gradle-plugin](https://kotlinlang.org/ )
([source](https://togithub.com/JetBrains/kotlin )) | `1.9.22` -> `1.9.23`
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [org.jetbrains.kotlin:kotlin-stdlib](https://kotlinlang.org/ )
([source](https://togithub.com/JetBrains/kotlin )) | `1.9.22` -> `1.9.23`
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>google/ksp (com.google.devtools.ksp)</summary>
###
[`v1.9.23-1.0.19`](https://togithub.com/google/ksp/releases/tag/1.9.23-1.0.19 )
##### New APIs
- [#​1708](https://togithub.com/google/ksp/issues/1708 )
`SymbolProcessorEnvironment.kspVersion`
- [#​1707](https://togithub.com/google/ksp/issues/1707 )
`CodeGenerator.associateWithFunctions` and
`CodeGenerator.associateWithProperties`
##### Issues fixed in KSP2
- [#​1691](https://togithub.com/google/ksp/issues/1691 )
IllegalStateException: Value type not found for value
- [#​1719](https://togithub.com/google/ksp/issues/1719 ) The order
of symbols returned from Resolver.getSymbolsWithAnnotation() is
different
- [#​1718](https://togithub.com/google/ksp/issues/1718 ) Getting
packageName of Kotlin types returns empty String
- [#​1721](https://togithub.com/google/ksp/issues/1721 )
KSAnnotation packageName is an empty String for a type from a different
module
- [#​1722](https://togithub.com/google/ksp/issues/1722 )
Resolver.getDeclarationsFromPackage() returns declarations from the
default package when passing in an unknown package
- [#​1717](https://togithub.com/google/ksp/issues/1717 )
Resolver.getJvmName() returns different results for annotation args
- [#​1725](https://togithub.com/google/ksp/issues/1725 )
asMemberOf() throws exception with a generic type without arguments
- [#​1728](https://togithub.com/google/ksp/issues/1728 )
ClassCastException when calling KSType.replace() with empty list
- [#​1713](https://togithub.com/google/ksp/issues/1713 )
NoClassDefFoundError for LZ4Factory when trying KSP2
- [#​1665](https://togithub.com/google/ksp/issues/1665 )
NoClassDefFound in ksp.useKSP2=true mode
- [#​1733](https://togithub.com/google/ksp/issues/1733 ) ABI
incompatibility with kotlin-compiler-embeddable in 2.0.0-Beta4
- [#​1714](https://togithub.com/google/ksp/issues/1714 ) Generated
resources are not added to KotlinCompilation inputs
- [#​1747](https://togithub.com/google/ksp/issues/1747 )
isCompanionObject is false for companion objects from KOTLIN_LIB
- [#​1743](https://togithub.com/google/ksp/issues/1743 ) Incorrect
type parameter variances
- [#​1759](https://togithub.com/google/ksp/issues/1759 )
IllegalStateException when getting the modifiers from properties in a
Java annotation declaration
##### Issues fixed in KSP Gradle Plugin
- [#​1712](https://togithub.com/google/ksp/issues/1712 ) Analysis
API artifacts have the wrong common-deps dependency
- [#​1775](https://togithub.com/google/ksp/issues/1775 ) 1.0.18
creates circular dependencies with kapt tasks
- [#​1772](https://togithub.com/google/ksp/issues/1772 ) Update
plugin com.google.devtools.ksp to v1.9.22-1.0.18 BUILD FAILED
##### Known issues
- [#​1776](https://togithub.com/google/ksp/issues/1776 ) KSP2 has
higher memory usage when the compile classpath is very large.
</details>
<details>
<summary>JetBrains/kotlin
(org.jetbrains.kotlin:kotlin-gradle-plugin)</summary>
###
[`v1.9.23`](https://togithub.com/JetBrains/kotlin/releases/tag/v1.9.23 ):
Kotlin 1.9.23
##### 1.9.23
##### Apple Ecosystem
- [`KT-65542`](https://youtrack.jetbrains.com/issue/KT-65542 ) Cinterop
tasks fails if Xcode 15.3 is used
##### Backend. Wasm
- [`KT-64486`](https://youtrack.jetbrains.com/issue/KT-64486 )
Kotlin/Wasm/WASI exported function callback for coroutines support
##### Compiler
- [`KT-53478`](https://youtrack.jetbrains.com/issue/KT-53478 ) Could not
load module <Error module>
- [`KT-66044`](https://youtrack.jetbrains.com/issue/KT-66044 ) JDK's new
API is used over Kotlin's SDK functions
- [`KT-64640`](https://youtrack.jetbrains.com/issue/KT-64640 ) Prevent
mutating SequenceCollection methods from JDK 21 be available on
read-only collections
- [`KT-65441`](https://youtrack.jetbrains.com/issue/KT-65441 ) K1: Remove
JDK 21 getFirst()/getLast() in (Mutable)List interfaces
- [`KT-65634`](https://youtrack.jetbrains.com/issue/KT-65634 ) K/N: data
race during monolithic cache creation
- [`KT-53109`](https://youtrack.jetbrains.com/issue/KT-53109 )
CompilationErrorException generateUnboundSymbolsAsDependencies with
builder inference and lambdas
- [`KT-52757`](https://youtrack.jetbrains.com/issue/KT-52757 ) Type
inference for builders fails if inferred from a function
##### Tools. Gradle
- [`KT-65792`](https://youtrack.jetbrains.com/issue/KT-65792 ) Add JSON
build report
- [`KT-65091`](https://youtrack.jetbrains.com/issue/KT-65091 ) Update
compiler metrics in build reports
- [`KT-62490`](https://youtrack.jetbrains.com/issue/KT-62490 ) KGP
dropping resource directories
##### Tools. Gradle. JS
- [`KT-64119`](https://youtrack.jetbrains.com/issue/KT-64119 ) K/JS:
Migrate package manager from Yarn onto NPM
- [`KT-64561`](https://youtrack.jetbrains.com/issue/KT-64561 ) K/JS tests
are not executed after upgrade to 1.9.22
##### Tools. Gradle. Multiplatform
- [`KT-65954`](https://youtrack.jetbrains.com/issue/KT-65954 ) commonTest
dependencies affect commoMainMetadata compilation
##### Tools. Gradle. Native
- [`KT-64573`](https://youtrack.jetbrains.com/issue/KT-64573 ) Default
value for `produceUnpackedKlib` was not provided
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-14 15:58:54 +01:00
1305b39341
chore: Only look for Google produced artifacts in Google repositories ( #530 )
...
Optimise the `repositories` declaration with a Gradle content filter
that limits the `google()` repository to just Google artifacts. Results
in a slight speedup when checking repositories, as the `google()`
repository can be skipped when looking for non-Google artifacts.
2024-03-14 13:31:28 +01:00
d66d9d32a4
refactor: Prune cached media using a worker ( #529 )
...
Previous code would prune any cached media every time `MainActivity` was
created, causing extra IO just as the user is trying to use the app.
Re-implement as a WorkManager worker so it can run when the device is
idle, without interfering with the responsiveness of the device.
2024-03-14 13:31:18 +01:00
6f8a3f20a9
chore: Add TODO for more specific error message in the future ( #528 )
2024-03-14 12:32:23 +01:00
faee20dee4
chore: Ignore any files in app/*/release ( #527 )
...
Ensures release build files are ignored irrespective of the build type.
2024-03-14 12:32:13 +01:00
5be93acf6b
feat: Improve Image Viewer toolbar auto-hide ( #521 )
...
Cancel the auto-hide behavior in case the toolbar menu items are
interacted with.
Improves https://github.com/pachli/pachli-android/issues/505 ,
https://github.com/pachli/pachli-android/issues/507
---------
Co-authored-by: Nik Clayton <nik@ngo.org.uk>
2024-03-13 20:19:46 +01:00
d9fc664a63
refactor: Remove obsolete emoji-related resources ( #526 )
2024-03-13 11:29:45 +01:00
cfc15c8f64
refactor: Use LinearProgressIndicator with delayed show/hide ( #525 )
...
Previous code used a normal ProgressBar and a coroutine to delay
hiding/showing the bar for a snappier UI perception.
This is built-in functionality in LinearProgressIndicator, so switch to
that.
While I'm here, implement the "Select list" dialog's layout as a layout
resource.
2024-03-13 10:03:10 +01:00
006c358053
fix: Sort lists by title wherever they occur
2024-03-12 19:52:45 +01:00
7da4bc090b
fix: Update tabs when lists are renamed or deleted
...
If the user has tabs containing one or more lists, and any of those
lists are renamed or deleted then the change should be reflected in the
tabs.
To do that:
`MainActivity`:
- Re-create tabs whenever lists are loaded and there's a list in a tab
- Compare lists-in-tabs by the ID of the list when restoring the user's
tab, so that a list rename doesn't lose their position.
`NetworkListsRepository`:
- Update the user's tab preferences whenever lists are loaded, removing
tabs that contain lists that have been deleted, and updating the
list's title for lists that have been renamed.
Fixes #192
2024-03-12 19:52:45 +01:00
a973f67ac8
refactor: Store tab preferences as polymorphic JSON
2024-03-12 19:52:45 +01:00
e93e4ffb53
feat: Support client filters in GoToSocial 0.15.0 ( #523 )
2024-03-11 23:14:57 +01:00
805a2a9b1d
feat: Show "Followed hashtags" menu item in left-nav
2024-03-11 21:31:34 +01:00
65a0fb19d9
feat: Tapping followed hashtag names in lists opens relevant timeline
2024-03-11 21:31:34 +01:00
4762411147
refactor: Replace custom worker factory with HiltWorkerFactory ( #517 )
...
Removes the need for a separate `WorkerModule` and factory methods in
each worker.
2024-03-11 10:49:58 +01:00
442f3bc80c
feat: Show user's lists in the left-side navigation menu ( #514 )
...
Previously to view a list the user either had to add it to a tab, or tap
through "Lists" in the navigation menu to their list of lists, and then
tap the list they want.
Fix that, and show all their lists in a dedicated section in the menu,
with a new "Manage lists" entry that's functionality identical to the
old "Lists" entry (i.e., it shows their lists and allows them to create,
delete, and edit list settings).
To do that:
- Implement a proper `ListsRepository` as the single source of truth for
list implementation throughout the app. Expose the current list of lists
as a flow, with methods to perform operations on the lists.
- Collect the `ListsRepository` flow in `MainActivity` and use that to
populate the menu and update it whenever the user's lists change.
- Rewrite the activities and fragments that manipulate lists to use
`ListRepository`.
- Always show error snackbars when list operations fail. In particular,
the HTTP code and error are always shown.
- Delete the custom `Either` implementation, it's no longer used.
- Add types for modelling API responses and errors, `ApiResponse` and
`ApiError` respectively. The response includes the headers as well as
the body, so it can replace the use of `NetworkResult` and `Response`.
The actual result of the operation is expected to be carried in a
`com.github.michaelbull.result.Result` type. Implement a Retrofit call
adapter for these types.
Unit tests for these borrow heavily from
https://github.com/connyduck/networkresult-calladapter
Additional user-visible changes:
- Add an accessible "Refresh" menu item to `ListsActivity`.
- Adding a list to a tab has a dialog with a "Manage lists" option.
Previously that would close the dialog when clicked, so the user had to
re-open it on returning from list management. Now the dialog stays open.
- The soft keyboard automatically opens when creating or editing a list.
2024-03-10 23:14:21 +01:00
a4dc3b85bd
fix: Show sized placeholder for hidden account media ( #516 )
...
Previous code showed a small icon for account media that the user has
hidden.
Now determine the correct size / aspect ratio for the media and use that
to compute the placeholder (either a blurhash, or the link colour for
consistency with the view on a timeline).
Fixes #513
2024-03-10 23:13:58 +01:00
bdf2d9329e
feat: Auto-hide Image Viewer toolbar ( #507 )
...
Previous code showed the toolbar and caption when displaying the image,
and the user has to tap the screen to dismiss it.
New code is consistent with the video viewer; the toolbar and caption
is displayed for two seconds, and then auto-hides.
- Tapping after the hide displays the toolbar and caption, which will
not auto-hide and requires a second tap to dismiss.
- Tapping the caption before it's hidden cancels the auto-hide
Fixes #505
2024-03-10 23:13:40 +01:00
0445e187df
fix: Ensure logging out accounts completes ( #515 )
...
The account logout process could fail due to API exceptions; network
errors for example, or if the user had already revoked the app's token
for that account. This would prevent the rest of the logout process
(cleaning database, etc) from completing.
Fix this by ignoring network errors during the logout process, and
always cleaning up account content in the database.
Fix a related issue where a deleted account might be recreated in a
partial state if the account's visible position was saved after it was
deleted. The recreated account couldn't do anything as it had no tokens,
but is very confusing.
2024-03-10 12:25:12 +01:00
0105a8179c
test: close DB in TimelineDaoTest ( #512 )
...
The previous code forgot to close the DB after TimelineDaoTest was run,
so a warning message was displayed when the test was run locally.
Close the database using the `@After` annotation.
Fixes #511
2024-03-08 11:40:51 +01:00
21b85fce1b
fix(deps): update dependency app.cash.turbine:turbine to v1.1.0 ( #506 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [app.cash.turbine:turbine](https://togithub.com/cashapp/turbine ) |
`1.0.0` -> `1.1.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>cashapp/turbine (app.cash.turbine:turbine)</summary>
###
[`v1.1.0`](https://togithub.com/cashapp/turbine/blob/HEAD/CHANGELOG.md#110---2024-03-06 )
[Compare
Source](https://togithub.com/cashapp/turbine/compare/1.0.0...1.1.0 )
[1.1.0]: https://togithub.com/cashapp/turbine/releases/tag/1.1.0
##### Changed
- Add `wasmJs` target, remove `iosArm32` and `watchosX86` targets.
- Throw unconsumed events if scope is externally canceled.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjcuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-06 21:01:55 +01:00
32a6d3465b
feat: Include "Notifications" in the left-side navigation menu ( #504 )
...
Previously the only way to access notifications was to dedicate a tab to
them. Now notifications are available from the left-side navigation menu
so they're always accessible.
Add them to the top of the list, and swap the order of bookmarks and
favourites, assuming that users are more likely to want to see their
bookmarks than their favourites.
Move "Edit profile" to the bottom with the other settings options,
assuming that editing their profile does not happen very often, so
should not be at the top of the list.
2024-03-05 14:45:28 +01:00
51d2c4cbda
chore(deps): update kotlin ( #447 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.devtools.ksp](https://goo.gle/ksp )
([source](https://togithub.com/google/ksp )) | `1.9.22-1.0.17` ->
`1.9.22-1.0.18` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin](https://goo.gle/ksp )
([source](https://togithub.com/google/ksp )) | `1.9.22-1.0.17` ->
`1.9.22-1.0.18` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[org.jetbrains.kotlinx:kotlinx-coroutines-test](https://togithub.com/Kotlin/kotlinx.coroutines )
| `1.7.3` -> `1.8.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[org.jetbrains.kotlinx:kotlinx-coroutines-android](https://togithub.com/Kotlin/kotlinx.coroutines )
| `1.7.3` -> `1.8.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>Kotlin/kotlinx.coroutines
(org.jetbrains.kotlinx:kotlinx-coroutines-test)</summary>
###
[`v1.8.0`](https://togithub.com/Kotlin/kotlinx.coroutines/blob/HEAD/CHANGES.md#Version-180 )
[Compare
Source](https://togithub.com/Kotlin/kotlinx.coroutines/compare/1.7.3...1.8.0 )
- Implement the library for the Web Assembly (Wasm) for JavaScript
([#​3713](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3713 )).
Thanks [@​igoriakovlev](https://togithub.com/igoriakovlev )!
- Major Kotlin version update: was 1.8.20, became 1.9.21.
- On Android, ensure that `Dispatchers.Main !=
Dispatchers.Main.immediate`
([#​3545](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3545 ),
[#​3963](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3963 )).
- Fixed a bug that caused `Flow` operators that limit cancel the
upstream flow to forget that they were already finished if there is
another such operator upstream
([#​4035](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4035 ),
[#​4038](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4038 ))
- `kotlinx-coroutines-debug` is published with the correct Java 9 module
info
([#​3944](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3944 )).
- `kotlinx-coroutines-debug` no longer requires manually setting
`DebugProbes.enableCoroutineCreationStackTraces` to `false`, it's the
default
([#​3783](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3783 )).
- `kotlinx-coroutines-test`: set the default timeout of `runTest` to 60
seconds, added the ability to configure it on the JVM with the
`kotlinx.coroutines.test.default_timeout=10s`
([#​3800](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3800 )).
- `kotlinx-coroutines-test`: fixed a bug that could lead to not all
uncaught exceptions being reported after some tests failed
([#​3800](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3800 )).
- `delay(Duration)` rounds nanoseconds up to whole milliseconds and not
down
([#​3920](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3920 )).
Thanks [@​kevincianfarini](https://togithub.com/kevincianfarini )!
- `Dispatchers.Default` and the default thread for background work are
guaranteed to use the same context classloader as the object containing
it them
([#​3832](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3832 )).
- It is guaranteed that by the time `SharedFlow.collect` suspends for
the first time, it's registered as a subscriber for that `SharedFlow`
([#​3885](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3885 )).
Before, it was also true, but not documented.
- Atomicfu version is updated to 0.23.1, and Kotlin/Native atomic
transformations are enabled, reducing the footprint of coroutine-heavy
code
([#​3954](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3954 )).
- Added a workaround for miscompilation of `withLock` on JS
([#​3881](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3881 )).
Thanks [@​CLOVIS-AI](https://togithub.com/CLOVIS-AI )!
- Small tweaks and documentation fixes.
##### Changelog relative to version 1.8.0-RC2
- `kotlinx-coroutines-debug` no longer requires manually setting
`DebugProbes.enableCoroutineCreationStackTraces` to `false`, it's the
default
([#​3783](https://togithub.com/Kotlin/kotlinx.coroutines/issues/3783 )).
- Fixed a bug that caused `Flow` operators that limit cancel the
upstream flow to forget that they were already finished if there is
another such operator upstream
([#​4035](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4035 ),
[#​4038](https://togithub.com/Kotlin/kotlinx.coroutines/issues/4038 ))
- Small documentation fixes.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 20:35:05 +01:00
a8dc83a63c
fix(l10n): Update Spanish translations
...
Currently translated at 100.0% (61 of 61 strings)
Translation: Pachli/Feature/About : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/featureabout-main/es/
2024-03-04 20:33:08 +01:00
92eb9f32b7
fix(l10n): Update Spanish translations
...
Currently translated at 100.0% (623 of 623 strings)
Translation: Pachli/App : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/app-main/es/
2024-03-04 20:33:08 +01:00
f9e2c7a47c
fix(l10n): Update Spanish translations
...
Currently translated at 100.0% (4 of 4 strings)
Translation: Pachli/Core/Network : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/corenetwork-main/es/
2024-03-04 20:33:08 +01:00
5ba2dfb091
fix(l10n): Update Spanish translations
...
Currently translated at 40.0% (6 of 15 strings)
Translation: Pachli/Fastlane Metadata
Translate-URL: https://hosted.weblate.org/projects/pachli/fastlane-metadata/es/
2024-03-04 20:33:08 +01:00
f8fed14ba1
fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.3 ( #294 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ch.qos.logback:logback-classic](http://logback.qos.ch )
([source](https://togithub.com/qos-ch/logback ),
[changelog](https://logback.qos.ch/news.html )) | `1.4.11` -> `1.5.3` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuMjIwLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 20:18:13 +01:00
dcfdfb8aec
fix(deps): update androidx.lifecycle to v2.7.0 ( #361 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[androidx.lifecycle:lifecycle-viewmodel-ktx](https://developer.android.com/jetpack/androidx/releases/lifecycle#2.7.0 )
([source](https://cs.android.com/androidx/platform/frameworks/support ))
| `2.6.2` -> `2.7.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[androidx.lifecycle:lifecycle-reactivestreams-ktx](https://developer.android.com/jetpack/androidx/releases/lifecycle#2.7.0 )
([source](https://cs.android.com/androidx/platform/frameworks/support ))
| `2.6.2` -> `2.7.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[androidx.lifecycle:lifecycle-livedata-ktx](https://developer.android.com/jetpack/androidx/releases/lifecycle#2.7.0 )
([source](https://cs.android.com/androidx/platform/frameworks/support ))
| `2.6.2` -> `2.7.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[androidx.lifecycle:lifecycle-common-java8](https://developer.android.com/jetpack/androidx/releases/lifecycle#2.7.0 )
([source](https://cs.android.com/androidx/platform/frameworks/support ))
| `2.6.2` -> `2.7.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 18:09:10 +01:00
Nik Clayton
renovate[bot]
ButterflyOfFire
Kalle Kniivilä
Weblate (bot)
Angelo Suzuki
sanao
Juan M Sevilla
