15df28fef6
Merge branch 'main' into instrument-refresh
2024-03-04 14:55:16 +01:00
4067e63dd4
ci: Don't compress APK files when uploading release artifacts ( #496 )
...
They're already compressed, and it slows down the workflow step.
2024-03-04 14:53:34 +01:00
e5d0147fba
fix(deps): update dependency io.github.oshai:kotlin-logging-jvm to v6.0.3 ( #362 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging )
| `5.1.4` -> `6.0.3` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging )
| `6.0.1` -> `6.0.3` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>
###
[`v6.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.3 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.2...6.0.3 )
#### What's Changed
- Add Kotlin/Wasm (JS browser) support by
[@​AzimMuradov](https://togithub.com/AzimMuradov ) in
[https://github.com/oshai/kotlin-logging/pull/388 ](https://togithub.com/oshai/kotlin-logging/pull/388 )
- Bump com.diffplug.spotless from 6.23.3 to 6.24.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/390 ](https://togithub.com/oshai/kotlin-logging/pull/390 )
- Bump actions/upload-pages-artifact from 2 to 3 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/391 ](https://togithub.com/oshai/kotlin-logging/pull/391 )
- Bump actions/deploy-pages from 3 to 4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/392 ](https://togithub.com/oshai/kotlin-logging/pull/392 )
- Bump actions/cache from 3.3.2 to 3.3.3 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/393 ](https://togithub.com/oshai/kotlin-logging/pull/393 )
- Log marker and stacktrace on Darwin by
[@​Gaming32](https://togithub.com/Gaming32 ) in
[https://github.com/oshai/kotlin-logging/pull/379 ](https://togithub.com/oshai/kotlin-logging/pull/379 )
#### New Contributors
- [@​Gaming32](https://togithub.com/Gaming32 ) made their first
contribution in
[https://github.com/oshai/kotlin-logging/pull/379 ](https://togithub.com/oshai/kotlin-logging/pull/379 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/6.0.2...6.0.3
###
[`v6.0.2`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.2 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.1...6.0.2 )
#### What's Changed
- Bump multiplatform from 1.9.21 to 1.9.22 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/385 ](https://togithub.com/oshai/kotlin-logging/pull/385 )
- Remove detekt by
[@​AzimMuradov](https://togithub.com/AzimMuradov ) in
[https://github.com/oshai/kotlin-logging/pull/387 ](https://togithub.com/oshai/kotlin-logging/pull/387 )
- Add workflow to publish Dokka HTML docs to project site by
[@​EdricChan03](https://togithub.com/EdricChan03 ) in
[https://github.com/oshai/kotlin-logging/pull/383 ](https://togithub.com/oshai/kotlin-logging/pull/383 )
#### New Contributors
- [@​EdricChan03](https://togithub.com/EdricChan03 ) made their
first contribution in
[https://github.com/oshai/kotlin-logging/pull/383 ](https://togithub.com/oshai/kotlin-logging/pull/383 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/6.0.1...6.0.2
###
[`v6.0.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.1 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.0...6.0.1 )
#### What's Changed
- Bump com.diffplug.spotless from 6.22.0 to 6.23.3 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/377 ](https://togithub.com/oshai/kotlin-logging/pull/377 )
- Bump actions/setup-java from 3 to 4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/376 ](https://togithub.com/oshai/kotlin-logging/pull/376 )
- Bump org.jetbrains.dokka from 1.8.20 to 1.9.10 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/366 ](https://togithub.com/oshai/kotlin-logging/pull/366 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/6.0.0...6.0.1
###
[`v6.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.0 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.4...6.0.0 )
#### What's Changed
- Update Kotlin to 1.9.21 by
[@​AzimMuradov](https://togithub.com/AzimMuradov ) in
[https://github.com/oshai/kotlin-logging/pull/380 ](https://togithub.com/oshai/kotlin-logging/pull/380 )
#### New Contributors
- [@​AzimMuradov](https://togithub.com/AzimMuradov ) made their
first contribution in
[https://github.com/oshai/kotlin-logging/pull/380 ](https://togithub.com/oshai/kotlin-logging/pull/380 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/5.1.2...6.0.0
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 14:53:10 +01:00
e6df78adf0
chore(deps): update hilt to v2.51 ( #485 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.dagger.hilt.android](https://togithub.com/google/dagger ) |
`2.50` -> `2.51` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[com.google.dagger:hilt-android-testing](https://togithub.com/google/dagger )
| `2.50` -> `2.51` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [com.google.dagger:hilt-compiler](https://togithub.com/google/dagger )
| `2.50` -> `2.51` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
| [com.google.dagger:hilt-android](https://togithub.com/google/dagger ) |
`2.50` -> `2.51` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 14:50:08 +01:00
0f870d7425
chore(deps): update aboutlibraries to v11 (major) ( #486 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| com.mikepenz.aboutlibraries.plugin | `10.10.0` -> `11.1.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[com.mikepenz:aboutlibraries](https://togithub.com/mikepenz/AboutLibraries )
| `10.10.0` -> `11.1.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[com.mikepenz:aboutlibraries-core](https://togithub.com/mikepenz/AboutLibraries )
| `10.10.0` -> `11.1.0` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>mikepenz/AboutLibraries (com.mikepenz:aboutlibraries)</summary>
###
[`v11.1.0`](https://togithub.com/mikepenz/AboutLibraries/releases/tag/v11.1.0 )
##### 🚀 Features
- Upgrade dependencies | Compose 1.6.0 | Compose Compiler | Lifecycle
- PR:
[#​950](https://togithub.com/mikepenz/AboutLibraries/issues/950 )
- Make Library and Licenses data classes stable with KotlinX Collections
- PR:
[#​947](https://togithub.com/mikepenz/AboutLibraries/issues/947 )
- Compose 1.6 | KotlinX Updates
- PR:
[#​958](https://togithub.com/mikepenz/AboutLibraries/issues/958 )
- Update to compose-multiplatform 1.6.0 / compose-android 1.6.2
- PR:
[#​961](https://togithub.com/mikepenz/AboutLibraries/issues/961 )
##### 🐛 Fixes
- Fix wasm sample app no longer loading
- PR:
[#​951](https://togithub.com/mikepenz/AboutLibraries/issues/951 )
##### 💬 Other
- Update README with warning on configPath
- PR:
[#​948](https://togithub.com/mikepenz/AboutLibraries/issues/948 )
- Module specific names
- PR:
[#​952](https://togithub.com/mikepenz/AboutLibraries/issues/952 )
- Lower noise of log
- PR:
[#​956](https://togithub.com/mikepenz/AboutLibraries/issues/956 )
- Update CI gradle action
- PR:
[#​957](https://togithub.com/mikepenz/AboutLibraries/issues/957 )
- Fix CI for releases on macOS-14 runner
- PR:
[#​960](https://togithub.com/mikepenz/AboutLibraries/issues/960 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 14:16:20 +01:00
5e1ba1e399
fix(deps): update dependency io.github.oshai:kotlin-logging-jvm to v5.1.4 ( #385 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging )
| `5.1.0` -> `5.1.4` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>
###
[`v5.1.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.4 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.1...5.1.4 )
#### What's Changed
- fix - protect from uncontrolled format string by
[@​oshai](https://togithub.com/oshai ) in
[https://github.com/oshai/kotlin-logging/pull/381 ](https://togithub.com/oshai/kotlin-logging/pull/381 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/5.1.1...5.1.4
###
[`v5.1.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.1 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.0...5.1.1 )
#### What's Changed
- Bump actions/checkout from 3 to 4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/357 ](https://togithub.com/oshai/kotlin-logging/pull/357 )
- Bump actions/cache from 3.3.1 to 3.3.2 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/358 ](https://togithub.com/oshai/kotlin-logging/pull/358 )
- Bump com.diffplug.spotless from 6.20.0 to 6.22.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/362 ](https://togithub.com/oshai/kotlin-logging/pull/362 )
- add payload to LocationAwareKLogger by
[@​oshai](https://togithub.com/oshai ) in
[https://github.com/oshai/kotlin-logging/pull/332 ](https://togithub.com/oshai/kotlin-logging/pull/332 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/5.1.0...5.1.1
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 14:07:12 +01:00
05d8d6e9e2
Try the latest alpha release of the paging library
2024-03-04 14:07:12 +01:00
126491aecc
fix(deps): update dependency io.github.oshai:kotlin-logging-jvm to v5.1.4 ( #385 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging )
| `5.1.0` -> `5.1.4` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>
###
[`v5.1.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.4 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.1...5.1.4 )
#### What's Changed
- fix - protect from uncontrolled format string by
[@​oshai](https://togithub.com/oshai ) in
[https://github.com/oshai/kotlin-logging/pull/381 ](https://togithub.com/oshai/kotlin-logging/pull/381 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/5.1.1...5.1.4
###
[`v5.1.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.1 )
[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.0...5.1.1 )
#### What's Changed
- Bump actions/checkout from 3 to 4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/357 ](https://togithub.com/oshai/kotlin-logging/pull/357 )
- Bump actions/cache from 3.3.1 to 3.3.2 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/358 ](https://togithub.com/oshai/kotlin-logging/pull/358 )
- Bump com.diffplug.spotless from 6.20.0 to 6.22.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/oshai/kotlin-logging/pull/362 ](https://togithub.com/oshai/kotlin-logging/pull/362 )
- add payload to LocationAwareKLogger by
[@​oshai](https://togithub.com/oshai ) in
[https://github.com/oshai/kotlin-logging/pull/332 ](https://togithub.com/oshai/kotlin-logging/pull/332 )
**Full Changelog**:
https://github.com/oshai/kotlin-logging/compare/5.1.0...5.1.1
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 13:51:01 +01:00
d1eac3f25a
Merge branch 'main' into instrument-refresh
2024-03-03 20:01:10 +01:00
cecbf39fbc
ci: Update release directory
2024-03-03 20:01:00 +01:00
7f157d56c4
Merge branch 'main' into instrument-refresh
2024-03-03 19:41:37 +01:00
22bb442baa
ci: Use correct release directory for variant ( #495 )
2024-03-03 19:41:21 +01:00
447abfee90
wip: Instrument calls to refresh the cached timeline
...
A user report shows what appears to be spurious / unexpected calls to
refresh the cached timeline occuring while scrolling. Have confirmed
these calls aren't coming from any Pachli code, so adding additional
instrumentation that can be included in a custom APK to debug further.
2024-03-03 18:58:42 +01:00
69c258365b
ci: Add workflow to build APK from PR ( #493 )
...
Debugging sometimes requires shipping APKs that have additional
instrumentation to users.
It's bad practice to encourage users to install APKs that they have been
given by a stranger on the Internet.
This new workflow will build a properly signed APK from a PR when a
specific comment is added to the PR. After building a comment is added
with a link to the workflow run and the URL the user can use to download
the APK. This allows them to be sure that the APK contains only the code
in the PR.
2024-03-03 18:50:44 +01:00
dc23ea23d1
refactor: Remove last vestiges of rxJava ( #492 )
2024-03-03 17:38:32 +01:00
da6e026cc6
refactor: Implement updateShortcut as a suspending function ( #491 )
...
Previously a regular function that created and subscribed to an rxJava
callable, now it's a suspending function that enforces Dispatchers.IO as
the context, launched in its own coroutine.
2024-03-03 17:21:04 +01:00
900b1728bf
refactor: Implement deleteStaleCachedMedia as a suspending function ( #490 )
...
Previously a regular function launched with an rxJava scheduler, now
it's a suspending function that enforces Dispatchers.IO as the context,
launched in its own coroutine.
2024-03-03 17:02:23 +01:00
1026fccc40
refactor: Restructure ViewMediaActivity and related fragments ( #489 )
...
Highlights:
- Implement fragment transitions for video to improve the UX, video
won't start playing until the transition completes
- Remove rxJava
- Move duplicate code in to base classes
Details:
`MediaActionsListener`:
- Move to `ViewMediaFragment` as it's used by both subclasses
- Remove need for separate `VideoActionsListener`
- Rename methods to better reflect their purpose and improve readability
`ViewMediaFragment`:
- Move duplicated code from `ViewImageFragment` and `ViewVideoFragment`
- Rewrite code that handles fragment transitions to use a
`CompleteableDeferred` instead of `BehaviorSubject` (removes rxJava).
- Rename methods and properties to better reflect their purpose and
improve readability
- Add extra comments
`ViewImageFragment`:
- Rewrite code that handles fragment transitions to use a
`CompleteableDeferred` instead of `BehaviorSubject` (removes rxJava).
`ViewVideoFragment`:
- Implement fragment transitions for video to improve the UX, video
won't start playing until the transition completes
- Manage toolbar visibility with a coroutine instead of a handler
- Add extra comments
`ViewMediaActivity`:
- Rename properties to better reflect their purpose and improve
readability
- Add extra comments
`ImagePagerAdapter`:
- Rename properties to better reflect their purpose and improve
readability
- Add extra comments
2024-03-03 16:07:39 +01:00
72ef8cfe4a
fix(deps): update dependency com.google.truth:truth to v1.4.2 ( #484 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.truth:truth](https://togithub.com/google/truth ) | `1.4.1`
-> `1.4.2` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.
---
### Release Notes
<details>
<summary>google/truth (com.google.truth:truth)</summary>
### [`v1.4.2`](https://togithub.com/google/truth/releases/tag/v1.4.2 ):
1.4.2
[Compare
Source](https://togithub.com/google/truth/compare/v1.4.1...v1.4.2 )
This release is the final step of copying all our methods from `Truth8`
to `Truth`. If you have not already migrated your usages from `Truth8`
to `Truth`, you may see build errors:
OptionalSubjectTest.java:39: error: reference to assertThat is ambiguous
assertThat(Optional.of("foo")).isPresent();
^
both method
assertThat(@​org.checkerframework.checker.nullness.qual.Nullable
Optional<?>) in Truth8 and method
assertThat(@​org.checkerframework.checker.nullness.qual.Nullable
Optional<?>) in Truth match
In most cases, you can migrate your whole project mechanically: `git
grep -l Truth8 | xargs perl -pi -e 's/\bTruth8\b/Truth/g;'`. (You can
make that change before upgrading to Truth 1.4.2 or as part of the same
commit.)
If you instead need to migrate your project incrementally (for example,
because it is very large), you may want to upgrade your version of Truth
incrementally, too, following our instructions for
[1.3.0](https://togithub.com/google/truth/releases/tag/v1.3.0 ) and
[1.4.0](https://togithub.com/google/truth/releases/tag/v1.4.0 ).
#### For help
Please feel welcome to [open an
issue](https://togithub.com/google/truth/issues/new ) to report problems
or request help.
#### Changelog
- Removed temporary type parameters from `Truth.assertThat(Stream)` and
`Truth.assertThat(Optional)`. This can create build errors, which you
can fix by replacing all your references to `Truth8` with references to
`Truth`.
([`45782bd`](https://togithub.com/google/truth/commit/45782bd0e ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-01 23:08:02 +01:00
72e5ca887d
fix(deps): update agp to v8.3.0, lint to 31.3.0 ( #483 )
...
New lint rules highlighted a potential crash; the use of named match
groups (used here when extracting server versions) requires API >= 26 or
throws an exception.
Use the group numbers instead of names when extracting the value, but
keep the group names in the regular expressions for readability.
2024-03-01 23:07:14 +01:00
b9512e49b4
fix: Ensure files are fully downloaded before sharing ( #482 )
...
The previous code would share media by either:
a. If it was an image, downloading the image using Glide in to a bitmap,
then recompressing as a PNG, saving, and sharing the resulting file.
b. Otherwise, create a temporary file, enqueue a DownloadManager request
to download the media in to the file, and immediately start sharing,
hoping that the download had completed in time.
Both approaches have problems:
In the "image" case the image was being downloaded (or retrieved from
the Glide cache), decompressed to a bitmap, then recompressed as a PNG.
This uses more memory, and doesn't share the original contents of the
file. E.g., if the original file was a JPEG that's lost (and the PNG
might well be larger than the source image).
In the second case the DownloadManager download is not guaranteed to
have completed (or even started) before the user chooses the share
destination. The destination could receive a partial or even empty file.
Fix both of those cases by always fully downloading the file before
sending the share intent. This guarantees the file is available to
share, and in its original format. Since this uses the same OkHttpClient
as the rest of the app the content is highly likely to be in the OkHttp
cache, so there will no extra network traffic because of this.
2024-03-01 21:54:30 +01:00
fcae44110b
refactor: Remove synchronous search functions ( #481 )
...
The previous code used synchronous (i.e., non-suspending) functions to
call the /api/v2/search and /api/v2/accounts/search endpoints.
This is not necessary as the search was always performed in a separate
thread.
Remove, and replace their usage with the equivalent functions that
suspend.
2024-03-01 18:55:59 +01:00
fb66293713
refactor: Remove duplicate strings from Filter.Action ( #479 )
...
Simplify code that users `Filter.Action` by deserialising directly into
the type instead of storing / using strings throughout the API.
2024-02-29 09:49:17 +01:00
af58de5a8f
refactor: Enable core library desugaring as build convention logic ( #480 )
...
Once desugaring is enabled it needs to be enabled for up/down the
dependency chain, so enable it in the shared configuration defined by
the build convention code.
Highlighted a failing test that wasn't being run, so fix that too.
2024-02-29 09:43:44 +01:00
9a23439d04
refactor: Remove duplicate strings from Filter contexts ( #478 )
...
A filter's context (previously referred to as its `kind`) controls where
the filter is applied.
This was implemented as an enum with a specific property to control how
it would serialise when @FormUrlEncoded, and with a @Json annotation for
Moshi.
In addition, the model objects kept the filter context in its string
form throughout Pachli, requiring periodic conversion to/from the enum
type, making the code more complicated.
Fix this, by:
1. Converting the incoming JSON value to the enum type immediately, so
the rest of the code uses the enum constants exclusively.
2. Implement a Retrofit converter that serialises the enum value when
@FormUrlEncoded to the same string used in JSON serialisation
2024-02-28 19:09:54 +01:00
2aa01fba8c
chore: Prepare release 2.3.0 (versionCode 12) ( #477 )
2024-02-28 09:54:52 +01:00
d943fa1aca
fix: Update InstanceV1/V2 related types based on real-world usage ( #476 )
...
Many servers that claim to be Mastodon-API compatible are not, as
evidenced by the content they include in the responses to
`/api/v1/instance` and `/api/v2/instance` requests.
Work around the worst of the breakage by providing defaults or marking
some fields as nullable (with a default null).
Bugs have been reported against the relevant projects.
2024-02-28 00:02:03 +01:00
db628f5dd6
fix(l10n): Update Finnish translations
...
Currently translated at 52.4% (32 of 61 strings)
Translation: Pachli/Feature/About : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/featureabout-main/fi/
2024-02-27 10:37:41 +01:00
58a6f75728
fix(l10n): Update Finnish translations
...
Currently translated at 100.0% (622 of 622 strings)
Translation: Pachli/App : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/app-main/fi/
2024-02-27 10:37:41 +01:00
bb8d6105d5
fix(l10n): Update Finnish translations
...
Currently translated at 100.0% (17 of 17 strings)
Translation: Pachli/Feature/Login
Translate-URL: https://hosted.weblate.org/projects/pachli/featurelogin/fi/
2024-02-27 10:37:41 +01:00
f5d90081ff
fix: Provide v2/instance configuration defaults ( #474 )
...
Some servers don't include a `urls` or `translation` block, which was
preventing parsing of the block, and falling back to the v1 instance
data.
Fix this by providing sensible defaults.
2024-02-26 17:21:33 +01:00
486acecfe7
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (61 of 61 strings)
Translation: Pachli/Feature/About : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/featureabout-main/nl/
2024-02-25 15:53:32 +01:00
44365f445f
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (2 of 2 strings)
Translation: Pachli/App : Google
Translate-URL: https://hosted.weblate.org/projects/pachli/app-google/nl/
2024-02-25 15:53:32 +01:00
c75c143825
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (622 of 622 strings)
Translation: Pachli/App : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/app-main/nl/
2024-02-25 15:53:32 +01:00
edcf6f13ab
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (2 of 2 strings)
Translation: Pachli/App : Fdroid
Translate-URL: https://hosted.weblate.org/projects/pachli/app-fdroid/nl/
2024-02-25 15:53:32 +01:00
6ca085089e
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (4 of 4 strings)
Translation: Pachli/Core/Activity : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/coreactivity-main/nl/
2024-02-25 15:53:32 +01:00
be245ab2c4
fix(l10n): Update Dutch translations
...
Currently translated at 100.0% (4 of 4 strings)
Translation: Pachli/Core/Network : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/corenetwork-main/nl/
2024-02-25 15:53:32 +01:00
1e5fce04f6
fix(l10n): Update Dutch translations
...
Currently translated at 42.8% (6 of 14 strings)
Translation: Pachli/Fastlane Metadata
Translate-URL: https://hosted.weblate.org/projects/pachli/fastlane-metadata/nl/
2024-02-25 15:53:32 +01:00
51c64a74dc
fix: Parse roles without a `highlighted` property ( #467 )
...
The `highlighted` property on a role may be absent. If it is this breaks
account parsing, including accounts in an /api/v2/instance response.
This, in turn, breaks determining server capabilities, including whether
or not translation is supported.
Set the default to `true`, which matches observed Mastodon behaviour.
2024-02-22 21:17:34 +01:00
415b182405
change: Log the trigger for a refresh/reload ( #466 )
...
A user is reporting that a refresh is happening in the middle of loading
content, borne out by the existing logs.
Those logs don't say what has triggered the refresh attempt, so add
additional logging whenever a refresh can occur to record what triggered
it.
2024-02-22 17:41:56 +01:00
9071a89e48
feat: Display uncropped media on account media pages ( #464 )
...
Previously media on the "Media" tab was displayed scaled and cropped to
a square aspect ratio, effectively forcing the user to tap every image
to see it.
Now, display the images scaled but not cropped, layed out with
`StaggeredGridLayoutManager`. This shows each image in full (still
scaled) providing a better experience when scrolling down.
Scrolling up can occasionally introduce gaps in the grid as images are
re-placed as viewholders are reused. When this happens images animate to
a better position when scrolling stops.
2024-02-22 14:33:44 +01:00
203784d718
fix: Don't crash when displaying update check dialog ( #463 )
...
Previous code injected `ApplicationContext`, which is not themed, and
caused a crash if the "update" dialog was shown.
Fix by passing the necesssary context in explicitly when the check is
performed.
2024-02-22 14:16:05 +01:00
2162e03e1f
fix: Handle JSON enums with unknown values ( #462 )
...
Previous code expected all incoming enums values to map directly to
Kotlin enum constants.
This is a problem for servers with additional features -- e.g.,
"reaction" as a notification type.
Fix this with a new Moshi adapter that will set the incoming value to a
given constant if it's not recognised.
Apply this to the enum constants in core.network to ensure they are
handled.
Clean up enum handling in Converters.kt, ComposeViewModel.kt, and
Status.kt by using the existing `.ordinal` property and some extension
functions for idiomatic code.
Fixes #461
2024-02-21 23:36:24 +01:00
941f4677eb
fix: Show previews for playable audio media from accounts ( #460 )
...
Previous code showed a generic placeholder for audio media on the
account's "Media" tab.
Fix this so the preview image is shown (if it's available).
- Move the "is this attachment previewable?" code to `Attachment` so it
can be reused here.
- Restructure the logic in `AccountMediaGridAdapter` to use the new
`isPreviewable()` method when deciding whether to show a preview.
- Attachments have dedicated placeholder drawables, use those when the
preview is not available.
2024-02-20 16:20:34 +01:00
8293e90b73
feat: Allow the user to trigger update checks ( #458 )
...
Add an additional preference entry that triggers an update when tapped.
It also displays the earliest time of the next automatic update check as
the preference summary.
Move the code that performs the update check (and the logic for whether
to perform the check) out of `MainActivity` and in to `UpdateCheck` so
it's available from `PreferencesFragment`.
2024-02-20 14:50:59 +01:00
13cfa1a15d
fix: Remove filters from Firefish capabilities ( #459 )
...
Firefish doesn't support the filters API, so remove filters from the
list of capabilities.
Fixes #248
2024-02-20 14:41:48 +01:00
8fdb15893a
fix: Improve legibility of stats labels for large font sizes ( #457 )
...
If the user increases the font size the labels for post statistics
(number of replies, etc) can crash in to each other.
To give more space for the text:
- Shrink the label font size
- Move the labels slightly left / tighter to the icon
- Allow the "bookmark" icon to move next to the "more" icon. There's
still 48dp of space for them, and this gives a little more space to the
other icons that have labels
2024-02-19 22:59:04 +01:00
73c947edfa
fix: Prevent crash when Friendica returns a null `voted_on` property ( #456 )
...
Friendica can return a null `voted_on` property, in violation of the API
spec.
Introduce a `BooleanIfNull` annotation that will convert the `null` to
`false` if encountered.
While I'm here update the other adapters as classes on their relevant
annotations instead of standalone classes to keep the code consistent.
Fixes #455
2024-02-19 19:04:29 +01:00
23e3cf1035
feat: Show information about notification fetches on "About" screen ( #454 )
...
Some users report that Pachli is not retrieving/displaying notifications
in a timely fashion.
To assist in diagnosing these errors, provide an additional set of tabs
on the "About" screen that contain information about how Pachli is
fetching notifications, and if not, why not.
Allow the user to save notification related logs and other details to a
file that can be attached to an e-mail or bug report.
Recording data:
- Provide a `NotificationConfig` singleton with properties to record
different aspects of the notification configuration. Update these
properties as different notification actions occur.
- Store logs in a `LogEntryEntity` table. Log events of interest with a
new `Timber` `LogEntryTree` that is planted in all cases.
- Add `PruneLogEntryEntityWorker` to trim saved logs to the last 48
hours.
Display:
- Add a `NotificationFragment` to `AboutActivity`. It hosts two other
fragments in tabs to show details from `NotificationConfig` and the
relevant logs, as well as controls for interacting with them.
Bug fixes:
- Filter out notifications with a null tag when processing active
notifications, prevents an NPE crash
Other changes:
- Log more details when errors occur so the bug reports are more helpful
2024-02-17 15:57:32 +01:00
3fb6994429
Update translation files
...
Updated by "Remove blank strings" hook in Weblate.
Translation: Pachli/App : Main
Translate-URL: https://hosted.weblate.org/projects/pachli/app-main/
2024-02-17 10:01:04 +01:00
Nik Clayton
renovate[bot]
Kalle Kniivilä
Martijn de Boer
Hosted Weblate
