change: Deprecate the "develop" branch (#70)

The separation between the `develop` and `main` branches was inherited
from Tusky and isn't helpful, complicating the release process and
causing CI to repeatedly run the same actions on the same code.

Deprecate the `develop` branch by removing references to it in the
documentation and updating the CI configuration as necessary.

Separately, the GitHub settings will be changed to set `main` as the
default branch, and the `develop` branch will be deleted.
This commit is contained in:
Nik Clayton 2023-09-19 16:40:07 +02:00 committed by GitHub
parent 26482c4b78
commit e0e4235354
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 15 deletions

View File

@ -29,7 +29,7 @@ jobs:
- name: Gradle Build Action - name: Gradle Build Action
uses: gradle/gradle-build-action@v2 uses: gradle/gradle-build-action@v2
with: with:
cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} cache-read-only: ${{ github.ref != 'refs/heads/main' }}
- name: ktlint - name: ktlint
run: ./gradlew clean ktlintCheck run: ./gradlew clean ktlintCheck

View File

@ -25,7 +25,7 @@ jobs:
- uses: gradle/gradle-build-action@v2 - uses: gradle/gradle-build-action@v2
with: with:
cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} cache-read-only: ${{ github.ref != 'refs/heads/main' }}
- run: chmod +x ./gradlew - run: chmod +x ./gradlew

View File

@ -1,4 +1,4 @@
# Build the app on each push to `develop`, populating the build cache to speed # Build the app on each push to `main`, populating the build cache to speed
# up CI on PRs. # up CI on PRs.
name: Populate build cache name: Populate build cache
@ -6,7 +6,7 @@ name: Populate build cache
on: on:
push: push:
branches: branches:
- develop - main
jobs: jobs:
build: build:
@ -28,7 +28,7 @@ jobs:
- uses: gradle/gradle-build-action@v2 - uses: gradle/gradle-build-action@v2
with: with:
cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} cache-read-only: ${{ github.ref != 'refs/heads/main' }}
- name: Run app:buildOrangeDebug - name: Run app:buildOrangeDebug
run: ./gradlew app:buildOrangeDebug run: ./gradlew app:buildOrangeDebug

View File

@ -25,7 +25,7 @@ jobs:
- name: Gradle Build Action - name: Gradle Build Action
uses: gradle/gradle-build-action@v2 uses: gradle/gradle-build-action@v2
with: with:
cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} cache-read-only: ${{ github.ref != 'refs/heads/main' }}
- name: Build APK - name: Build APK
run: ./gradlew assembleBlueRelease --stacktrace run: ./gradlew assembleBlueRelease --stacktrace

View File

@ -93,7 +93,7 @@ Pull requests (PRs) are the primary unit of collaboration for code.
### Work on branches in your own fork of the repository ### Work on branches in your own fork of the repository
Do not clone the `pachli-android` repository. Instead, create a fork, create a branch in your fork from the `develop` branch, and commit your changes to that. Do not clone the `pachli-android` repository. Instead, create a fork, create a branch in your fork from the `main` branch, and commit your changes to that.
See the GitHub [Collaborating with pull requests](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/about-collaborative-development-models) documentation. See the GitHub [Collaborating with pull requests](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/about-collaborative-development-models) documentation.
@ -118,7 +118,7 @@ This is not mandatory, but may make developing easier for you.
A PR is typically made up multiple commits. A PR is typically made up multiple commits.
With very few exceptions this project squash-merges all PRs to maintain a linear commit history on the `develop` branch. With very few exceptions this project squash-merges all PRs to maintain a linear commit history on the `main` branch.
Therefore **we do not care** about the "quality" of the individual commits that make up a single PR. Within the PR a single commit might change multiple things, have a non-obvious commit message, be littered with `TODO` comments, etc. Please do not think that every commit you make as you complete your PR needs to be perfect. Therefore **we do not care** about the "quality" of the individual commits that make up a single PR. Within the PR a single commit might change multiple things, have a non-obvious commit message, be littered with `TODO` comments, etc. Please do not think that every commit you make as you complete your PR needs to be perfect.
@ -240,15 +240,15 @@ As well as conveying more information to me as the reviewer this allows me to pe
- Are there other instances of `@color/white` that this PR missed? - Are there other instances of `@color/white` that this PR missed?
- Does the PR use the correct spelling of `colorControlNormal` everywhere? - Does the PR use the correct spelling of `colorControlNormal` everywhere?
#### Cleanly merge back in to `develop` #### Cleanly merge back in to `main`
While you were working on your PR other changes may have happened on the `develop` branch. While you were working on your PR other changes may have happened on the `main` branch.
Some of those changes may have overlapped with changes you make in your PR, and your PR can not be merged cleanly back in to `develop`. Some of those changes may have overlapped with changes you make in your PR, and your PR can not be merged cleanly back in to `main`.
You should periodically merge changes from the `develop` branch in to your PR branch, and keep your PR up to date with `develop` during the review process. You should periodically merge changes from the `main` branch in to your PR branch, and keep your PR up to date with `main` during the review process.
If your PR can not be cleanly merged in to `develop` it is difficult to review effectively, because merging the changes from `develop` in to your PR will invalidate the review. You've changed the code, so the reviewer needs to look at it again. If your PR can not be cleanly merged in to `main` it is difficult to review effectively, because merging the changes from `main` in to your PR will invalidate the review. You've changed the code, so the reviewer needs to look at it again.
#### `ktlintCheck` and `ktlintFormat` #### `ktlintCheck` and `ktlintFormat`
@ -317,7 +317,7 @@ On the GitHub page for your PR create a new comment, and paste (Ctrl-V / Cmd-V)
This checklist may be helpful when you are creating your first few PRs. The PR: This checklist may be helpful when you are creating your first few PRs. The PR:
- [ ] ... is made from my fork of the Pachli repository - [ ] ... is made from my fork of the Pachli repository
- [ ] ... is branched from `develop` - [ ] ... is branched from `main`
- [ ] ... title follows Conventional Commits: - [ ] ... title follows Conventional Commits:
- [ ] starting with the correct type (`fix:`, `feat:`, etc) - [ ] starting with the correct type (`fix:`, `feat:`, etc)
- [ ] and makes sense prefixed with "If merged, this PR will ..." - [ ] and makes sense prefixed with "If merged, this PR will ..."
@ -326,7 +326,7 @@ This checklist may be helpful when you are creating your first few PRs. The PR:
- [ ] What it does - [ ] What it does
- [ ] If appropriate, a justification for the approach - [ ] If appropriate, a justification for the approach
- [ ] And has a "Fixes ..." footer if it fixes an issue - [ ] And has a "Fixes ..." footer if it fixes an issue
- [ ] ... merges cleanly in to the `develop` branch - [ ] ... merges cleanly in to the `main` branch
- [ ] ... passes `ktlintCheck` - [ ] ... passes `ktlintCheck`
- [ ] ... passes all tests - [ ] ... passes all tests
- [ ] ... and adds new ones if appropriate - [ ] ... and adds new ones if appropriate