Mastodon
/
pachli-android
mirror of https://github.com/pachli/pachli-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Restore video transitions on androidx.media3 1.4.0 and 1.4.1 (#922) 

androidx.media3 1.4.0-rc01 and above (at the time of writing) has a bug
that breaks shared element transitions with a `PlayerView` (see
https://github.com/androidx/media/issues/1594).

This can be worked around by setting `app:surface_type="texture_view"`.
This uses more power, but for the typical length of social media videos
this shouldn't be a problem at the moment.

Fixes #920.
This commit is contained in:
Nik Clayton 2024-09-03 13:05:52 +02:00 committed by GitHub
parent 69b87a3c44
commit b83ecf56d6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/res/layout/fragment_view_video.xml
View File

@ -24,6 +24,11 @@
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"
tools:text="Some media description" /> tools:text="Some media description" />
<!--
app:surface_type="texture_view" is a workaround for
https://github.com/androidx/media/issues/1594 and can be removed when
that issue is fixed.
-->
<androidx.media3.ui.PlayerView <androidx.media3.ui.PlayerView
android:id="@+id/videoView" android:id="@+id/videoView"
android:layout_width="wrap_content" android:layout_width="wrap_content"
@ -32,6 +37,7 @@
app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toRightOf="parent" app:layout_constraintRight_toRightOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"
app:surface_type="texture_view"
app:use_controller="true" app:use_controller="true"
app:show_previous_button="false" app:show_previous_button="false"
app:show_next_button="false" app:show_next_button="false"