Mastodon
/
pachli-android
mirror of https://github.com/pachli/pachli-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Improve legibility of stats labels for large font sizes (#457) 

If the user increases the font size the labels for post statistics
(number of replies, etc) can crash in to each other.

To give more space for the text:

- Shrink the label font size
- Move the labels slightly left / tighter to the icon
- Allow the "bookmark" icon to move next to the "more" icon. There's
still 48dp of space for them, and this gives a little more space to the
other icons that have labels
This commit is contained in:
Nik Clayton 2024-02-19 22:59:04 +01:00 committed by GitHub
parent 73c947edfa
commit 8fdb15893a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/main/res/layout/item_status.xml
View File

@ -248,8 +248,8 @@
android:id="@+id/status_replies" android:id="@+id/status_replies"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="45dp" android:layout_marginStart="40dp"
android:textSize="?attr/status_text_medium" android:textSize="?attr/status_text_small"
app:layout_constraintBottom_toBottomOf="@id/status_reply" app:layout_constraintBottom_toBottomOf="@id/status_reply"
app:layout_constraintStart_toStartOf="@id/status_reply" app:layout_constraintStart_toStartOf="@id/status_reply"
app:layout_constraintTop_toTopOf="@id/status_reply" app:layout_constraintTop_toTopOf="@id/status_reply"
@ -276,8 +276,8 @@
android:id="@+id/status_reblogs_count" android:id="@+id/status_reblogs_count"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="45dp" android:layout_marginStart="40dp"
android:textSize="?attr/status_text_medium" android:textSize="?attr/status_text_small"
app:layout_constraintBottom_toBottomOf="@id/status_inset" app:layout_constraintBottom_toBottomOf="@id/status_inset"
app:layout_constraintStart_toStartOf="@id/status_inset" app:layout_constraintStart_toStartOf="@id/status_inset"
app:layout_constraintTop_toTopOf="@id/status_inset" app:layout_constraintTop_toTopOf="@id/status_inset"
@ -304,12 +304,12 @@
android:id="@+id/status_favourites_count" android:id="@+id/status_favourites_count"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="45dp" android:layout_marginStart="40dp"
android:textSize="?attr/status_text_medium" android:textSize="?attr/status_text_small"
app:layout_constraintBottom_toBottomOf="@id/status_inset" app:layout_constraintBottom_toBottomOf="@id/status_inset"
app:layout_constraintStart_toStartOf="@id/status_favourite" app:layout_constraintStart_toStartOf="@id/status_favourite"
app:layout_constraintTop_toTopOf="@id/status_inset" app:layout_constraintTop_toTopOf="@id/status_inset"
tools:text="" /> tools:text="1+" />
<at.connyduck.sparkbutton.SparkButton <at.connyduck.sparkbutton.SparkButton
android:id="@+id/status_bookmark" android:id="@+id/status_bookmark"
@ -338,7 +338,6 @@
android:importantForAccessibility="no" android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="@id/status_reply" app:layout_constraintBottom_toBottomOf="@id/status_reply"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/status_bookmark"
app:layout_constraintTop_toTopOf="@id/status_reply" app:layout_constraintTop_toTopOf="@id/status_reply"
app:srcCompat="@drawable/ic_more_horiz_24dp" /> app:srcCompat="@drawable/ic_more_horiz_24dp" />